39441 2010-05-20 13:03:39 -0700 saveAndSetNewPortStateForUpdate sometimes sets an incorrect window.height property 2010-05-20 14:49:29 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED P2 Normal --- 1 kdecker kdecker oldest_to_newest 228517 0 kdecker 2010-05-20 13:03:39 -0700 I noticed through code inspection that saveAndSetNewPortStateForUpdate sometimes sets an incorrect window.height property. This will break plug-ins at non 1.0 scale factors. 228518 1 56623 kdecker 2010-05-20 13:06:28 -0700 Created attachment 56623 proposed fix 228576 2 56633 kdecker 2010-05-20 14:38:10 -0700 Created attachment 56633 now with 64-bit OOP fixes 228580 3 56633 andersca 2010-05-20 14:40:13 -0700 Comment on attachment 56633 now with 64-bit OOP fixes r=me 56623 2010-05-20 13:06:28 -0700 2010-05-20 14:38:10 -0700 proposed fix patch.txt text/plain 2520 kdecker SW5kZXg6IG1hYy9QbHVnaW5zL1dlYk5ldHNjYXBlUGx1Z2luVmlldy5tbQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBtYWMvUGx1Z2lucy9XZWJOZXRzY2FwZVBsdWdpblZpZXcubW0JKHJldmlzaW9uIDU5ODU4KQor KysgbWFjL1BsdWdpbnMvV2ViTmV0c2NhcGVQbHVnaW5WaWV3Lm1tCSh3b3JraW5nIGNvcHkpCkBA IC0yNzQsMTIgKzI3NCwxNCBAQAogLSAoUG9ydFN0YXRlKXNhdmVBbmRTZXROZXdQb3J0U3RhdGVG b3JVcGRhdGU6KEJPT0wpZm9yVXBkYXRlCiB7CiAgICAgQVNTRVJUKFtzZWxmIGN1cnJlbnRXaW5k b3ddICE9IG5pbCk7Ci0KLSAgICAvLyBVc2UgQXBwS2l0IHRvIGNvbnZlcnQgdmlldyBjb29yZGlu YXRlcyB0byBOU1dpbmRvdyBjb29yZGluYXRlcy4KLSAgICBOU1JlY3QgYm91bmRzSW5XaW5kb3cg PSBbc2VsZiBjb252ZXJ0UmVjdDpbc2VsZiBib3VuZHNdIHRvVmlldzpuaWxdOwotICAgIE5TUmVj dCB2aXNpYmxlUmVjdEluV2luZG93ID0gW3NlbGYgY29udmVydFJlY3Q6W3NlbGYgdmlzaWJsZVJl Y3RdIHRvVmlldzpuaWxdOwogICAgIAotICAgIC8vIEZsaXAgWSB0byBjb252ZXJ0IE5TV2luZG93 IGNvb3JkaW5hdGVzIHRvIHRvcC1sZWZ0LWJhc2VkIHdpbmRvdyBjb29yZGluYXRlcy4KKyAgICAv LyBUaGUgYmFzZSBjb29yZGluYXRlcyBvZiBhIHdpbmRvdyBhbmQgaXQncyBjb250ZW50VmlldyBo YXBwZW4gdG8gYmUgdGhlIGVxdWFsIGF0IGEgdXNlclNwYWNlU2NhbGVGYWN0b3IKKyAgICAvLyBv ZiAxLiBGb3Igbm9uLTEuMCBzY2FsZSBmYWN0b3JzIHRoaXMgYXNzdW1wdGlvbiBpcyBmYWxzZS4K KyAgICBOU1ZpZXcgKndpbmRvd0NvbnRlbnRWaWV3ID0gW1tzZWxmIHdpbmRvd10gY29udGVudFZp ZXddOworICAgIE5TUmVjdCBib3VuZHNJbldpbmRvdyA9IFtzZWxmIGNvbnZlcnRSZWN0OltzZWxm IGJvdW5kc10gdG9WaWV3OndpbmRvd0NvbnRlbnRWaWV3XTsKKyAgICBOU1JlY3QgdmlzaWJsZVJl Y3RJbldpbmRvdyA9IFtzZWxmIGNvbnZlcnRSZWN0OltzZWxmIHZpc2libGVSZWN0XSB0b1ZpZXc6 d2luZG93Q29udGVudFZpZXddOworICAgIAorICAgIC8vIEZsaXAgWSB0byBjb252ZXJ0IC1bTlNX aW5kb3cgY29udGVudFZpZXddIGNvb3JkaW5hdGVzIHRvIHRvcC1sZWZ0LWJhc2VkIHdpbmRvdyBj b29yZGluYXRlcy4KICAgICBmbG9hdCBib3JkZXJWaWV3SGVpZ2h0ID0gW1tzZWxmIGN1cnJlbnRX aW5kb3ddIGZyYW1lXS5zaXplLmhlaWdodDsKICAgICBib3VuZHNJbldpbmRvdy5vcmlnaW4ueSA9 IGJvcmRlclZpZXdIZWlnaHQgLSBOU01heFkoYm91bmRzSW5XaW5kb3cpOwogICAgIHZpc2libGVS ZWN0SW5XaW5kb3cub3JpZ2luLnkgPSBib3JkZXJWaWV3SGVpZ2h0IC0gTlNNYXhZKHZpc2libGVS ZWN0SW5XaW5kb3cpOwpJbmRleDogbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBtYWMvQ2hh bmdlTG9nCShyZXZpc2lvbiA1OTg1OCkKKysrIG1hYy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkK QEAgLTEsMyArMSwxOCBAQAorMjAxMC0wNS0yMCAgS2V2aW4gRGVja2VyICA8a2RlY2tlckBhcHBs ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5NDQxCisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS83OTg1NzE1PiBGbGFzaCBjb250ZXh0IG1lbnUgaXMgYm90aCBob3Jpem9u dGFsbHkgYW5kIHZlcnRpY2FsbHkgb2Zmc2V0IGZyb20gcG9pbnQgb2YgY2xpY2sKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzc5ODYxMDk+IFlvdXR1YmUgdmlkZW8gY29udHJvbGxlciBVSSBlbnRp cmVseSBtaXNzaW5nCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83OTg2MTU0PiBGbGFzaCBjb250 ZW50IHBhaW50cyBhdCBob3Jpem9udGFsbHkgYW5kIHZlcnRpY2FsbHkgc2hpZnRlZCBsb2NhdGlv bnMgKHdpdGhpbiB0aGUgcGx1Zy1pbiByZWdpb24pCisgICAgICAgIAorICAgICAgICAqIFBsdWdp bnMvV2ViTmV0c2NhcGVQbHVnaW5WaWV3Lm1tOgorICAgICAgICAoLVtXZWJOZXRzY2FwZVBsdWdp blZpZXcgc2F2ZUFuZFNldE5ld1BvcnRTdGF0ZUZvclVwZGF0ZTpdKTogVGhlIGJhc2UgY29vcmRp bmF0ZXMgb2YgYSB3aW5kb3cgYW5kIGl0J3MgY29udGVudFZpZXcgaGFwcGVuCisgICAgICAgICB0 byBiZSB0aGUgZXF1YWwgYXQgYSB1c2VyU3BhY2VTY2FsZUZhY3RvciBvZiAxLiBGb3Igbm9uLTEu MCBzY2FsZSBmYWN0b3JzIHRoaXMgYXNzdW1wdGlvbiBpcyBmYWxzZS4gQWNjb3JkaW5nbHkgd2Ug bm93CisgICAgICAgICBjb252ZXJ0IHRvIHRoZSB3aW5kb3cgY29udGVudFZpZXcgY29vcmRpbmF0 ZSBzeXN0ZW0gd2hlbiBjb21wdXRpbmcgYm91bmRzIGluICJ3aW5kb3ciIGFuZCB0aGUgdmlzaWJs ZSByZWN0LgorCisK 56633 2010-05-20 14:38:10 -0700 2010-05-20 14:40:13 -0700 now with 64-bit OOP fixes patch.txt text/plain 4060 kdecker SW5kZXg6IG1hYy9QbHVnaW5zL1dlYk5ldHNjYXBlUGx1Z2luVmlldy5tbQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBtYWMvUGx1Z2lucy9XZWJOZXRzY2FwZVBsdWdpblZpZXcubW0JKHJldmlzaW9uIDU5ODYyKQor KysgbWFjL1BsdWdpbnMvV2ViTmV0c2NhcGVQbHVnaW5WaWV3Lm1tCSh3b3JraW5nIGNvcHkpCkBA IC0yNzQsMTIgKzI3NCwxNCBAQAogLSAoUG9ydFN0YXRlKXNhdmVBbmRTZXROZXdQb3J0U3RhdGVG b3JVcGRhdGU6KEJPT0wpZm9yVXBkYXRlCiB7CiAgICAgQVNTRVJUKFtzZWxmIGN1cnJlbnRXaW5k b3ddICE9IG5pbCk7Ci0KLSAgICAvLyBVc2UgQXBwS2l0IHRvIGNvbnZlcnQgdmlldyBjb29yZGlu YXRlcyB0byBOU1dpbmRvdyBjb29yZGluYXRlcy4KLSAgICBOU1JlY3QgYm91bmRzSW5XaW5kb3cg PSBbc2VsZiBjb252ZXJ0UmVjdDpbc2VsZiBib3VuZHNdIHRvVmlldzpuaWxdOwotICAgIE5TUmVj dCB2aXNpYmxlUmVjdEluV2luZG93ID0gW3NlbGYgY29udmVydFJlY3Q6W3NlbGYgdmlzaWJsZVJl Y3RdIHRvVmlldzpuaWxdOwogICAgIAotICAgIC8vIEZsaXAgWSB0byBjb252ZXJ0IE5TV2luZG93 IGNvb3JkaW5hdGVzIHRvIHRvcC1sZWZ0LWJhc2VkIHdpbmRvdyBjb29yZGluYXRlcy4KKyAgICAv LyBUaGUgYmFzZSBjb29yZGluYXRlcyBvZiBhIHdpbmRvdyBhbmQgaXQncyBjb250ZW50VmlldyBo YXBwZW4gdG8gYmUgdGhlIGVxdWFsIGF0IGEgdXNlclNwYWNlU2NhbGVGYWN0b3IKKyAgICAvLyBv ZiAxLiBGb3Igbm9uLTEuMCBzY2FsZSBmYWN0b3JzIHRoaXMgYXNzdW1wdGlvbiBpcyBmYWxzZS4K KyAgICBOU1ZpZXcgKndpbmRvd0NvbnRlbnRWaWV3ID0gW1tzZWxmIHdpbmRvd10gY29udGVudFZp ZXddOworICAgIE5TUmVjdCBib3VuZHNJbldpbmRvdyA9IFtzZWxmIGNvbnZlcnRSZWN0OltzZWxm IGJvdW5kc10gdG9WaWV3OndpbmRvd0NvbnRlbnRWaWV3XTsKKyAgICBOU1JlY3QgdmlzaWJsZVJl Y3RJbldpbmRvdyA9IFtzZWxmIGNvbnZlcnRSZWN0OltzZWxmIHZpc2libGVSZWN0XSB0b1ZpZXc6 d2luZG93Q29udGVudFZpZXddOworICAgIAorICAgIC8vIEZsaXAgWSB0byBjb252ZXJ0IC1bTlNX aW5kb3cgY29udGVudFZpZXddIGNvb3JkaW5hdGVzIHRvIHRvcC1sZWZ0LWJhc2VkIHdpbmRvdyBj b29yZGluYXRlcy4KICAgICBmbG9hdCBib3JkZXJWaWV3SGVpZ2h0ID0gW1tzZWxmIGN1cnJlbnRX aW5kb3ddIGZyYW1lXS5zaXplLmhlaWdodDsKICAgICBib3VuZHNJbldpbmRvdy5vcmlnaW4ueSA9 IGJvcmRlclZpZXdIZWlnaHQgLSBOU01heFkoYm91bmRzSW5XaW5kb3cpOwogICAgIHZpc2libGVS ZWN0SW5XaW5kb3cub3JpZ2luLnkgPSBib3JkZXJWaWV3SGVpZ2h0IC0gTlNNYXhZKHZpc2libGVS ZWN0SW5XaW5kb3cpOwpJbmRleDogbWFjL1BsdWdpbnMvSG9zdGVkL1dlYkhvc3RlZE5ldHNjYXBl UGx1Z2luVmlldy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBtYWMvUGx1Z2lucy9Ib3N0ZWQvV2ViSG9zdGVk TmV0c2NhcGVQbHVnaW5WaWV3Lm1tCShyZXZpc2lvbiA1OTg2MikKKysrIG1hYy9QbHVnaW5zL0hv c3RlZC9XZWJIb3N0ZWROZXRzY2FwZVBsdWdpblZpZXcubW0JKHdvcmtpbmcgY29weSkKQEAgLTE4 MCw4ICsxODAsMTEgQEAKICAgICBpZiAoIV9wcm94eSkKICAgICAgICAgcmV0dXJuOwogICAgIAot ICAgIC8vIFVzZSBBcHBLaXQgdG8gY29udmVydCB2aWV3IGNvb3JkaW5hdGVzIHRvIE5TV2luZG93 IGNvb3JkaW5hdGVzLgotICAgIE5TUmVjdCBib3VuZHNJbldpbmRvdyA9IFtzZWxmIGNvbnZlcnRS ZWN0OltzZWxmIGJvdW5kc10gdG9WaWV3Om5pbF07CisgICAgLy8gVGhlIGJhc2UgY29vcmRpbmF0 ZXMgb2YgYSB3aW5kb3cgYW5kIGl0J3MgY29udGVudFZpZXcgaGFwcGVuIHRvIGJlIHRoZSBlcXVh bCBhdCBhIHVzZXJTcGFjZVNjYWxlRmFjdG9yCisgICAgLy8gb2YgMS4gRm9yIG5vbi0xLjAgc2Nh bGUgZmFjdG9ycyB0aGlzIGFzc3VtcHRpb24gaXMgZmFsc2UuCisgICAgTlNWaWV3ICp3aW5kb3dD b250ZW50VmlldyA9IFtbc2VsZiB3aW5kb3ddIGNvbnRlbnRWaWV3XTsKKyAgICBOU1JlY3QgYm91 bmRzSW5XaW5kb3cgPSBbc2VsZiBjb252ZXJ0UmVjdDpbc2VsZiBib3VuZHNdIHRvVmlldzp3aW5k b3dDb250ZW50Vmlld107CisKICAgICBOU1JlY3QgdmlzaWJsZVJlY3RJbldpbmRvdzsKICAgICAK ICAgICAvLyBDb3JlIEFuaW1hdGlvbiBwbHVnLWlucyBuZWVkIHRvIGJlIHVwZGF0ZWQgKHdpdGgg YSAwLDAsMCwwIGNsaXBSZWN0KSB3aGVuCkBAIC0xOTAsNyArMTkzLDcgQEAKICAgICAvLyBjb21w YXRpYmxlIHdpdGggdGhpcyBiZWhhdmlvci4gICAgCiAgICAgQk9PTCBzaG91bGRDbGlwT3V0UGx1 Z2luID0gX3BsdWdpbkxheWVyICYmIFtzZWxmIHNob3VsZENsaXBPdXRQbHVnaW5dOwogICAgIGlm ICghc2hvdWxkQ2xpcE91dFBsdWdpbikKLSAgICAgICAgdmlzaWJsZVJlY3RJbldpbmRvdyA9IFtz ZWxmIGNvbnZlcnRSZWN0OltzZWxmIHZpc2libGVSZWN0XSB0b1ZpZXc6bmlsXTsKKyAgICAgICAg dmlzaWJsZVJlY3RJbldpbmRvdyA9IFtzZWxmIGNvbnZlcnRSZWN0OltzZWxmIHZpc2libGVSZWN0 XSB0b1ZpZXc6d2luZG93Q29udGVudFZpZXddOwogICAgIGVsc2UKICAgICAgICAgdmlzaWJsZVJl Y3RJbldpbmRvdyA9IE5TWmVyb1JlY3Q7CiAgICAgCkluZGV4OiBtYWMvQ2hhbmdlTG9nCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIG1hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDU5ODY0KQorKysgbWFjL0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEwLTA1LTIwICBLZXZpbiBEZWNr ZXIgIDxrZGVja2VyQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 Mzk0NDEKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzc5ODU3MTU+IEZsYXNoIGNvbnRleHQgbWVu dSBpcyBib3RoIGhvcml6b250YWxseSBhbmQgdmVydGljYWxseSBvZmZzZXQgZnJvbSBwb2ludCBv ZiBjbGljaworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNzk4NjEwOT4gWW91dHViZSB2aWRlbyBj b250cm9sbGVyIFVJIGVudGlyZWx5IG1pc3NpbmcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzc5 ODYxNTQ+IEZsYXNoIGNvbnRlbnQgcGFpbnRzIGF0IGhvcml6b250YWxseSBhbmQgdmVydGljYWxs eSBzaGlmdGVkIGxvY2F0aW9ucyAod2l0aGluIHRoZSBwbHVnLWluIHJlZ2lvbikKKworICAgICAg ICAqIFBsdWdpbnMvSG9zdGVkL1dlYkhvc3RlZE5ldHNjYXBlUGx1Z2luVmlldy5tbToKKyAgICAg ICAgKC1bV2ViSG9zdGVkTmV0c2NhcGVQbHVnaW5WaWV3IHVwZGF0ZUFuZFNldFdpbmRvd10pOiBU aGUgYmFzZSBjb29yZGluYXRlcyBvZiBhIHdpbmRvdyBhbmQKKyAgICAgICAgIGl0J3MgY29udGVu dFZpZXcgaGFwcGVuIHRvIGJlIHRoZSBlcXVhbCBhdCBhIHVzZXJTcGFjZVNjYWxlRmFjdG9yIG9m IDEuIEZvciBub24tMS4wIHNjYWxlCisgICAgICAgICBmYWN0b3JzIHRoaXMgYXNzdW1wdGlvbiBp cyBmYWxzZS4gQWNjb3JkaW5nbHkgd2Ugbm93IGNvbnZlcnQgdG8gdGhlIHdpbmRvdyBjb250ZW50 VmlldworICAgICAgICBjb29yZGluYXRlIHN5c3RlbSB3aGVuIGNvbXB1dGluZyBib3VuZHMgaW4g IndpbmRvdyIgYW5kIHRoZSB2aXNpYmxlIHJlY3QuCisgICAgICAgICogUGx1Z2lucy9XZWJOZXRz Y2FwZVBsdWdpblZpZXcubW06CisgICAgICAgICgtW1dlYk5ldHNjYXBlUGx1Z2luVmlldyBzYXZl QW5kU2V0TmV3UG9ydFN0YXRlRm9yVXBkYXRlOl0pOiBEaXR0by4KKwogMjAxMC0wNS0yMCAgU3Rl dmUgQmxvY2sgIDxzdGV2ZWJsb2NrQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg SmVyZW15IE9ybG93Lg==