39433 2010-05-20 10:52:21 -0700 editingBehavior settings needs to be set back to a reasonable default between tests 2010-10-22 07:22:57 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 38603 1 mrobinson webkit-unassigned abarth ap dglazkov eric ojan tonikitoo webkit.review.bot oldest_to_newest 228461 0 mrobinson 2010-05-20 10:52:21 -0700 The actual setting depends on the platform. 228462 1 56608 mrobinson 2010-05-20 10:54:28 -0700 Created attachment 56608 Patch 228477 2 56608 mrobinson 2010-05-20 11:18:14 -0700 Comment on attachment 56608 Patch via IRC: (10:57:24 AM) ojan: mrobinson: i'd rather see a shared method in Settings (10:57:53 AM) ojan: mrobinson: that way, if a port changes which editing behavior they use ona platform, they only change it in one place (11:01:09 AM) ojan: mrobinson: so, i'm thinking...add Settings::resetEditingBehavior and move the logic from the Settings constructor into that method. then call the method instead of setEditingBehavior. (11:05:48 AM) ojan: so, i'm just staying to move those 7 lines of code into Settings::resetEditingBehavior and instead call that method from the constructor 228482 3 56616 mrobinson 2010-05-20 11:24:14 -0700 Created attachment 56616 Patch 228493 4 mrobinson 2010-05-20 12:01:35 -0700 Reverted tests causing failures until this can be sorted out properly: http://trac.webkit.org/changeset/59852 228504 5 mrobinson 2010-05-20 12:32:22 -0700 Committed r59857: <http://trac.webkit.org/changeset/59857> 228508 6 webkit.review.bot 2010-05-20 12:40:05 -0700 http://trac.webkit.org/changeset/59852 might have broken Tiger Intel Release The following changes are on the blame list: http://trac.webkit.org/changeset/59850 http://trac.webkit.org/changeset/59851 http://trac.webkit.org/changeset/59852 http://trac.webkit.org/changeset/59853 http://trac.webkit.org/changeset/59854 228522 7 56624 mrobinson 2010-05-20 13:11:31 -0700 Created attachment 56624 Reset Mac and Windows to platform default between tests 228524 8 56624 eric 2010-05-20 13:16:56 -0700 Comment on attachment 56624 Reset Mac and Windows to platform default between tests LGTM! 228525 9 mrobinson 2010-05-20 13:21:11 -0700 Committed r59861: <http://trac.webkit.org/changeset/59861> 228637 10 ap 2010-05-20 17:08:12 -0700 > Committed r59861: <http://trac.webkit.org/changeset/59861> Sounds like this should be closed. + editingBehavior settings needs to be set back to a reasonable default between tests FWIW, I'd expect "reasonable default" to be the same on all platforms. What's the value in making it different? 228641 11 mrobinson 2010-05-20 17:12:55 -0700 This is required because many tests still exist which expect different behavior on different platforms (detected via user agent). At some point, if they are all rewritten, we can probably set some behavior to be the default in DRT. This still needs to be fixed for Chromium and GTK+. 228645 12 ap 2010-05-20 17:24:33 -0700 How many tests like that are there? What we basically need is make two or three copies of each, and set different behaviors in those. 230040 13 tonikitoo 2010-05-24 19:08:03 -0700 (In reply to comment #12) > How many tests like that are there? What we basically need is make two or three copies of each, and set different behaviors in those. ~14 tests in /editing. $ grep -nHR navigator.userAgent.search LayoutTests/editing/ - LayoutTests/editing/selection/script-tests/click-in-padding-with-multiple-line-boxes.js - LayoutTests/editing/selection/script-tests/click-in-margins-inside-editable-div.js - LayoutTests/editing/selection/script-tests/shift-click.js - LayoutTests/editing/selection/extend-selection-after-double-click.html - LayoutTests/editing/selection/extend-after-mouse-selection.html - LayoutTests/editing/selection/move-begin-end.html - LayoutTests/editing/selection/5195166-1.html - LayoutTests/editing/input/option-page-up-down.html - LayoutTests/editing/undo/undo-deleteWord.html - LayoutTests/editing/deleting/delete-by-word-001.html - LayoutTests/editing/deleting/delete-by-word-002.html 230085 14 56970 tonikitoo 2010-05-24 21:47:39 -0700 Created attachment 56970 (committed with r60158, reviewed by eseidel, tkent) Reset Gtk and Chromium to platform default between tests according to comment 11, it seems needed 230086 15 56970 tkent 2010-05-24 22:01:13 -0700 Comment on attachment 56970 (committed with r60158, reviewed by eseidel, tkent) Reset Gtk and Chromium to platform default between tests Chromium part looks OK. 230087 16 56970 eric 2010-05-24 22:02:27 -0700 Comment on attachment 56970 (committed with r60158, reviewed by eseidel, tkent) Reset Gtk and Chromium to platform default between tests Looks OK to me. Why doesn't this affect tests? Can we write a test this would affect? 230088 17 webkit.review.bot 2010-05-24 22:02:46 -0700 Attachment 56970 did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/2315575 230095 18 tonikitoo 2010-05-24 22:14:41 -0700 (In reply to comment #17) > Attachment 56970 [details] did not build on chromium: > Build output: http://webkit-commit-queue.appspot.com/results/2315575 s/EditingBehaviorWindows/EditingBehaviorWin/g , will fix before land. (In reply to comment #16) > (From update of attachment 56970 [details]) > Looks OK to me. Why doesn't this affect tests? Can we write a test this would affect? @Eric: it will affect tests, for example as soon as https://bugs.webkit.org/attachment.cgi?id=56608 re-lands and all tests cited in comment #12 got changed to use the setEditingBehaviour API of LayoutTestController instead of the user agent string 230240 19 56970 tonikitoo 2010-05-25 06:16:57 -0700 Comment on attachment 56970 (committed with r60158, reviewed by eseidel, tkent) Reset Gtk and Chromium to platform default between tests Clearing flags on attachment: 56970 Committed r59861: <http://trac.webkit.org/changeset/59861> 230241 20 56970 tonikitoo 2010-05-25 06:18:52 -0700 Comment on attachment 56970 (committed with r60158, reviewed by eseidel, tkent) Reset Gtk and Chromium to platform default between tests err: Committed r60158: <http://trac.webkit.org/changeset/60158> 230247 21 webkit.review.bot 2010-05-25 06:51:10 -0700 http://trac.webkit.org/changeset/60158 might have broken GTK Linux 32-bit Release The following changes are on the blame list: http://trac.webkit.org/changeset/60158 http://trac.webkit.org/changeset/60159 230304 22 ojan 2010-05-25 09:12:01 -0700 (In reply to comment #10) > + editingBehavior settings needs to be set back to a reasonable default between tests > > FWIW, I'd expect "reasonable default" to be the same on all platforms. What's the value in making it different? For non-DRT, the code in Settings.cpp currently has a different default for Mac and everyone else. So, DRT should, at reset the value to that default. I wouldn't want DRT always defaulting to EditingMacBehavior because then we lose test coverage. For example, if someone accidentally modifies the EditingWinBehavior behavior, then only the tests that call setEditingBehavior would actually test that. I think it's unfortunate that we have setEditingBehavior calls littered throughout the code though. I'd prefer that we had Settings::resetEditingBehavior or Settings::defaultEditingBehavior so that we have the logic of which editing behavior to use in one place. Eric pushed back on this on #webkit saying that this would be different than all other DRT setters. I don't have enough experience hacking on DRT to say. (In reply to comment #12) > How many tests like that are there? What we basically need is make two or three copies of each, and set different behaviors in those. Now that we've exposed setEditingBehavior, we can modify those tests to test both EditingMacBehavior and EditingWinBehavior. There's no need for them to have platform specific expectations now. 230313 23 ap 2010-05-25 09:33:44 -0700 > I wouldn't want DRT always defaulting to EditingMacBehavior because then we lose test coverage. I disagree with that. We need reproducible results more than we need accidental testing - running tests on Mac should be as close to running them on other platforms as possible. 230407 24 tonikitoo 2010-05-25 12:58:27 -0700 I think now that Gtk, Mac, Win, Chromium and soon Qt (see bug 39680) are in, we can revert back r59852 and r59857, and gradually adjust other call sites (see comment #13) to use the new setEditingBehavior. ... and a some point close this bug as FIXED 230412 25 ojan 2010-05-25 13:10:50 -0700 (In reply to comment #23) > > I wouldn't want DRT always defaulting to EditingMacBehavior because then we lose test coverage. > > I disagree with that. We need reproducible results more than we need accidental testing - running tests on Mac should be as close to running them on other platforms as possible. If a test fails on Windows because of the editing behavior, then one of two things should happen: 1. There's a bug when using EditingWinBehavior and that should be fixed. 2. The test unintentionally is testing platform-specific behavior and the test should be fixed to test both EditingMacBehavior and EditingWinBehavior. As long as the above happens, running tests from a Mac is fairly close to running them on other platforms. A given commit might cause a failure on a non-mac port, but the fix will mean broader test coverage. We have bots specifically to ensure that the port-specific code is tested. I don't see why it makes sense for platform-specific code to not get the same testing. 235483 26 tonikitoo 2010-06-08 13:29:07 -0700 (In reply to comment #24) > I think now that Gtk, Mac, Win, Chromium and soon Qt (see bug 39680) are in, we can revert back r59852 and r59857, and gradually adjust other call sites (see comment #13) to use the new setEditingBehavior. @Martin, plans to re-land these two backed out revisions? they should be safe to go now. 235493 27 tonikitoo 2010-06-08 13:43:54 -0700 (In reply to comment #25) > (In reply to comment #23) > > > I wouldn't want DRT always defaulting to EditingMacBehavior because then we lose test coverage. If all platform specific editing tests are going through all code paths possible then it would make sense to default DRT generally to the same editing behavior type (being it "mac" or not). However the condition is not what happens currentl, and due to that I also agree that as tests are today, having them all sharing the same default would lose coverage. That is indeed something that could change in the future though, and I could have a look at that. For example, if we had at least one layout test for each of the platform specific editing behaviors, and each test were going through all code paths, then we would be safe to default all DRTs to the same value. 235502 28 mrobinson 2010-06-08 13:49:09 -0700 Committed r60865: <http://trac.webkit.org/changeset/60865> 292914 29 tonikitoo 2010-10-12 05:55:29 -0700 Yesterday, I started converting all tests relying on platform specific (for now, Mac x Win) behavior to run with the LayoutTestController::setEditingBehavior machinery. I've fixed the following ones so far: - bug 47468: editing/selection/extend-after-mouse-selection.html - bug 47471: editing/selection/script-tests/click-in-margins-inside-editable-div.js - bug 47472: editing/selection/script-tests/click-in-padding-with-multiple-line-boxes.js It basically means that instead of having mac, win and qt expected results, we now have only one cross platform expected result file, since all platform behaviors are being tested. I will continue this work along the week. As a side note, it would be good to turn tests like editing/deleting/delete-by-word-001.html and editing/deleting/delete-by-word-002.html to not dump the render tree, but dump as text. I will try this as well. > (In reply to comment #12) > > How many tests like that are there? What we basically need is make two or three copies of each, and set different behaviors in those. > > ~14 tests in /editing. > > $ grep -nHR navigator.userAgent.search LayoutTests/editing/ > - LayoutTests/editing/selection/script-tests/click-in-padding-with-multiple-line-boxes.js > - LayoutTests/editing/selection/script-tests/click-in-margins-inside-editable-div.js > - LayoutTests/editing/selection/script-tests/shift-click.js > - LayoutTests/editing/selection/extend-selection-after-double-click.html > - LayoutTests/editing/selection/extend-after-mouse-selection.html > - LayoutTests/editing/selection/move-begin-end.html > - LayoutTests/editing/selection/5195166-1.html > - LayoutTests/editing/input/option-page-up-down.html > - LayoutTests/editing/undo/undo-deleteWord.html > - LayoutTests/editing/deleting/delete-by-word-001.html > - LayoutTests/editing/deleting/delete-by-word-002.html 297968 30 tonikitoo 2010-10-22 07:22:57 -0700 > As a side note, it would be good to turn tests like editing/deleting/delete-by-word-001.html and editing/deleting/delete-by-word-002.html to not dump the render tree, but dump as text. I will try this as well. Filed bug 48130 and bug 48131 about these two. 56608 2010-05-20 10:54:28 -0700 2010-05-20 11:24:11 -0700 Patch bug-39433-20100520105427.patch text/plain 4381 mrobinson ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA3MjM5NWJmMmY2MTZhNTU1NmI1MzM4ZjVlMGJlMmYyYzA1YTBlM2UxLi4wNWFjNjMz MDg0ZDI4MWFkMGI3MGU5N2NkZDUyYmU1OTE5NWFlNDMxIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjUgQEAK IDIwMTAtMDUtMjAgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgogCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGVkaXRpbmdCZWhh dmlvciBzZXR0aW5ncyBuZWVkcyB0byBiZSBzZXQgYmFjayB0byBhIHJlYXNvbmFibGUgZGVmYXVs dCBiZXR3ZWVuIHRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0zOTQzMworCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vTGF5b3V0 VGVzdENvbnRyb2xsZXIuY3BwOgorICAgICAgICAoTGF5b3V0VGVzdENvbnRyb2xsZXI6OnJlc2V0 KToKKyAgICAgICAgUmVzZXQgdGhlIGVkaXRpbmdCZWhhdmlvciBzZXR0aW5nIHRvIFdpbmRvd3Mg ZWRpdGluZyBzdHlsZS4KKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9ndGsvRHVtcFJlbmRlclRy ZWUuY3BwOgorICAgICAgICAocmVzZXREZWZhdWx0c1RvQ29uc2lzdGVudFZhbHVlcyk6CisgICAg ICAgIFJlc2V0IHRoZSBlZGl0aW5nQmVoYXZpb3Igc2V0dGluZyB0byBNYWMgZWRpdGluZyBzdHls ZS4KKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9tYWMvRHVtcFJlbmRlclRyZWUubW06CisgICAg ICAgIChyZXNldERlZmF1bHRzVG9Db25zaXN0ZW50VmFsdWVzKToKKyAgICAgICAgUmVzZXQgdGhl IGVkaXRpbmdCZWhhdmlvciBzZXR0aW5nIHRvIE1hYyBlZGl0aW5nIHN0eWxlLgorICAgICAgICAq IER1bXBSZW5kZXJUcmVlL3dpbi9EdW1wUmVuZGVyVHJlZS5jcHA6CisgICAgICAgIChyZXNldERl ZmF1bHRzVG9Db25zaXN0ZW50VmFsdWVzKToKKyAgICAgICAgUmVzZXQgdGhlIGVkaXRpbmdCZWhh dmlvciBzZXR0aW5nIHRvIFdpbmRvd3MgZWRpdGluZyBzdHlsZS4KKworMjAxMC0wNS0yMCAgTWFy dGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CisKICAgICAgICAgUmV2aWV3ZWQg YnkgT2phbiBWYWZhaS4KIAogICAgICAgICBlZGl0aW5nL3NlbGVjdGlvbi9leHRlbmQtc2VsZWN0 aW9uLWFmdGVyLWRvdWJsZS1jbGljay5odG1sIGNyYXNoZXMgb24gdGhlIExlb3BhcmQgSW50ZWwg cmVsZWFzZSBib3QKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9t aXVtL0xheW91dFRlc3RDb250cm9sbGVyLmNwcCBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVl L2Nocm9taXVtL0xheW91dFRlc3RDb250cm9sbGVyLmNwcAppbmRleCA2YjlhNjE3YzQzYTcwM2Zi ZTkzYzkwMGU0MjFiNTc2MzYzZTlmMTYwLi41ZGQ4ZTk2ZWU5ODM5YzBlNjIzYWJhMWZjZTEwM2E4 OWMyYmI5NDEzIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1 bS9MYXlvdXRUZXN0Q29udHJvbGxlci5jcHAKKysrIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRy ZWUvY2hyb21pdW0vTGF5b3V0VGVzdENvbnRyb2xsZXIuY3BwCkBAIC00NTgsNiArNDU4LDkgQEAg dm9pZCBMYXlvdXRUZXN0Q29udHJvbGxlcjo6cmVzZXQoKQogICAgICAgICBtX3NoZWxsLT53ZWJW aWV3KCktPnNldFNlbGVjdGlvbkNvbG9ycygweGZmMWU5MGZmLCAweGZmMDAwMDAwLCAweGZmYzhj OGM4LCAweGZmMzIzMjMyKTsKICNlbmRpZgogICAgICAgICBtX3NoZWxsLT53ZWJWaWV3KCktPnJl bW92ZUFsbFVzZXJDb250ZW50KCk7CisKKyAgICAgICAgV2ViU2V0dGluZ3MqIHNldHRpbmdzID0g bV9zaGVsbC0+d2ViVmlldygpLT5zZXR0aW5ncygpOworICAgICAgICBzZXR0aW5ncy0+c2V0RWRp dGluZ0JlaGF2aW9yKFdlYlNldHRpbmdzOjpFZGl0aW5nQmVoYXZpb3JXaW4pOwogICAgIH0KICAg ICBtX2R1bXBBc1RleHQgPSBmYWxzZTsKICAgICBtX2R1bXBFZGl0aW5nQ2FsbGJhY2tzID0gZmFs c2U7CmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRHVtcFJlbmRl clRyZWUuY3BwIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0R1bXBSZW5kZXJUcmVl LmNwcAppbmRleCAyNzNiY2RmMWEwM2M5NjFhOTI2MTVhNjJhZTRhOGFjM2E0YThhZmNhLi4wMmMw YWJiOTc2ZWRiYTBiYmE3OGM2ZmUzZThjNmM4YjY5ZDIxNmYyIDEwMDY0NAotLS0gYS9XZWJLaXRU b29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRHVtcFJlbmRlclRyZWUuY3BwCisrKyBiL1dlYktpdFRv b2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9EdW1wUmVuZGVyVHJlZS5jcHAKQEAgLTM0Myw2ICszNDMs NyBAQCBzdGF0aWMgdm9pZCByZXNldERlZmF1bHRzVG9Db25zaXN0ZW50VmFsdWVzKCkKICAgICAg ICAgICAgICAgICAgImF1dG8tcmVzaXplLXdpbmRvdyIsIFRSVUUsCiAgICAgICAgICAgICAgICAg ICJlbmFibGUtamF2YS1hcHBsZXQiLCBGQUxTRSwKICAgICAgICAgICAgICAgICAgImVuYWJsZS1w bHVnaW5zIiwgVFJVRSwKKyAgICAgICAgICAgICAgICAgImVkaXRpbmctYmVoYXZpb3IiLCBXRUJL SVRfRURJVElOR19CRUhBVklPUl9NQUMsCiAgICAgICAgICAgICAgICAgIE5VTEwpOwogCiAgICAg d2Via2l0X3dlYl9mcmFtZV9jbGVhcl9tYWluX2ZyYW1lX25hbWUobWFpbkZyYW1lKTsKZGlmZiAt LWdpdCBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL21hYy9EdW1wUmVuZGVyVHJlZS5tbSBi L1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL21hYy9EdW1wUmVuZGVyVHJlZS5tbQppbmRleCBi ZjEzMzlkZmRhOWQ1MDc2ZWFhYTRmY2NiZDNjYWQ3YjZjOGU4YjIzLi44ZmQ1Mjk4ODk4MDMzMWU3 Yjg4NDM5MDAwYjgzMDFlMjhkZjYzODUzIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9EdW1wUmVu ZGVyVHJlZS9tYWMvRHVtcFJlbmRlclRyZWUubW0KKysrIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRl clRyZWUvbWFjL0R1bXBSZW5kZXJUcmVlLm1tCkBAIC00NDEsNiArNDQxLDcgQEAgc3RhdGljIHZv aWQgcmVzZXREZWZhdWx0c1RvQ29uc2lzdGVudFZhbHVlcygpCiAgICAgW3ByZWZlcmVuY2VzIHNl dERldmVsb3BlckV4dHJhc0VuYWJsZWQ6Tk9dOwogICAgIFtwcmVmZXJlbmNlcyBzZXRMb2Fkc0lt YWdlc0F1dG9tYXRpY2FsbHk6WUVTXTsKICAgICBbcHJlZmVyZW5jZXMgc2V0RnJhbWVGbGF0dGVu aW5nRW5hYmxlZDpOT107CisgICAgW3ByZWZlcmVuY2VzIHNldEVkaXRpbmdCZWhhdmlvcjpXZWJL aXRFZGl0aW5nTWFjQmVoYXZpb3JdOwogICAgIGlmIChwZXJzaXN0ZW50VXNlclN0eWxlU2hlZXRM b2NhdGlvbikgewogICAgICAgICBbcHJlZmVyZW5jZXMgc2V0VXNlclN0eWxlU2hlZXRMb2NhdGlv bjpbTlNVUkwgVVJMV2l0aFN0cmluZzooTlNTdHJpbmcgKikocGVyc2lzdGVudFVzZXJTdHlsZVNo ZWV0TG9jYXRpb24uZ2V0KCkpXV07CiAgICAgICAgIFtwcmVmZXJlbmNlcyBzZXRVc2VyU3R5bGVT aGVldEVuYWJsZWQ6WUVTXTsKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVl L3dpbi9EdW1wUmVuZGVyVHJlZS5jcHAgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS93aW4v RHVtcFJlbmRlclRyZWUuY3BwCmluZGV4IGRmYTRkZTA3MWQ2YjUyYzM3YzExYjA2MDY5MWQzYjZm YmM0MjczYzEuLmIyMmYzNDIxNTVlMjQ5NmVhYTdmM2FiNDU3MmFlMTJhYzg4ZjY4NWIgMTAwNjQ0 Ci0tLSBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3dpbi9EdW1wUmVuZGVyVHJlZS5jcHAK KysrIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvd2luL0R1bXBSZW5kZXJUcmVlLmNwcApA QCAtNzg3LDYgKzc4Nyw3IEBAIHN0YXRpYyB2b2lkIHJlc2V0RGVmYXVsdHNUb0NvbnNpc3RlbnRW YWx1ZXMoSVdlYlByZWZlcmVuY2VzKiBwcmVmZXJlbmNlcykKICAgICBwcmVmZXJlbmNlcy0+c2V0 VGFic1RvTGlua3MoRkFMU0UpOwogICAgIHByZWZlcmVuY2VzLT5zZXRTaG91bGRQcmludEJhY2tn cm91bmRzKFRSVUUpOwogICAgIHByZWZlcmVuY2VzLT5zZXRMb2Fkc0ltYWdlc0F1dG9tYXRpY2Fs bHkoVFJVRSk7CisgICAgcHJlZmVyZW5jZXMtPnNldEVkaXRpbmdCZWhhdmlvcihXZWJLaXRFZGl0 aW5nV2luQmVoYXZpb3IpOwogCiAgICAgaWYgKHBlcnNpc3RlbnRVc2VyU3R5bGVTaGVldExvY2F0 aW9uKSB7CiAgICAgICAgIFZlY3Rvcjx3Y2hhcl90PiB1cmxDaGFyYWN0ZXJzKENGU3RyaW5nR2V0 TGVuZ3RoKHBlcnNpc3RlbnRVc2VyU3R5bGVTaGVldExvY2F0aW9uLmdldCgpKSk7Cg== 56616 2010-05-20 11:24:14 -0700 2010-05-20 13:11:27 -0700 Patch bug-39433-20100520112413.patch text/plain 3327 mrobinson ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAxNzBkNzEwZmQ2OWQ4ZWFiMDQ3M2YyMmY2ZDk0MGZkY2ZhNTc0YTlhLi4yMzc4ODJi MjBhZGM5MjNlZjU3NWY2MmZlNDYzMTIzMjA3MzA0NmI1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTAtMDUtMjAgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGVkaXRpbmdCZWhh dmlvciBzZXR0aW5ncyBuZWVkcyB0byBiZSBzZXQgYmFjayB0byBhIHJlYXNvbmFibGUgZGVmYXVs dCBiZXR3ZWVuIHRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0zOTQzMworCisgICAgICAgIFJldmVydCB0aGUgY2hhbmdlcyBmcm9tIHI1OTg0MCB0 byB0aGlzIHRlc3QgdW50aWwgdGhlcmUgaXMgYSBtZXRob2QKKyAgICAgICAgaW4gdGhlIFdlYktp dCBBUElzIHRvIGNvbnNpc3RlbnRseSByZXNldCB0aGUgZWRpdGluZ0JlaGF2aW9yIHNldHRpbmcK KyAgICAgICAgdG8gYSByZWFzb25hYmxlIGRlZmF1bHQuCisKKyAgICAgICAgKiBlZGl0aW5nL3Nl bGVjdGlvbi9leHRlbmQtc2VsZWN0aW9uLWFmdGVyLWRvdWJsZS1jbGljay5odG1sOiBSZXZlcnQg cHJldmlvdXMgY2hhbmdlcyB0byB0aGlzIHRlc3QuCisKIDIwMTAtMDUtMjAgIE1hcnRpbiBSb2Jp bnNvbiAgPG1yb2JpbnNvbkB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE9qYW4g VmFmYWkuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9leHRlbmQt c2VsZWN0aW9uLWFmdGVyLWRvdWJsZS1jbGljay5odG1sIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9z ZWxlY3Rpb24vZXh0ZW5kLXNlbGVjdGlvbi1hZnRlci1kb3VibGUtY2xpY2suaHRtbAppbmRleCA4 Yjg4Yzg5MmJhNWM0ODE2ODJkMWMzOGJmZTE1YTg0ZjM4ZjIxYTE4Li44OTEwODBiYjQ3MGE5MjNm ZmE2MjkyMWYyMGI4OTkwYmRlZjEwZGY2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9lZGl0aW5n L3NlbGVjdGlvbi9leHRlbmQtc2VsZWN0aW9uLWFmdGVyLWRvdWJsZS1jbGljay5odG1sCisrKyBi L0xheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL2V4dGVuZC1zZWxlY3Rpb24tYWZ0ZXItZG91 YmxlLWNsaWNrLmh0bWwKQEAgLTE4LDI1ICsxOCwxMyBAQAogICAgICAgICBldmVudFNlbmRlci5s ZWFwRm9yd2FyZCgxMDAwKTsKICAgICB9CiAKLSAgICBmdW5jdGlvbiBsb2dSZXN1bHQocmVzdWx0 KQotICAgIHsKLSAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInJlc3VsdCIpLmlubmVy SFRNTCArPSByZXN1bHQgKyAiPGJyLz4iOwotICAgIH0KLQotICAgIGZ1bmN0aW9uIHJ1blRlc3Rz KCkKKyAgICBmdW5jdGlvbiBydW5UZXN0KCkKICAgICB7CiAgICAgICAgIGlmICghd2luZG93LmV2 ZW50U2VuZGVyIHx8ICF3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCiAgICAgICAgICAgICBy ZXR1cm47CiAKICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOwogCi0g ICAgICAgIHJ1blRlc3QoIm1hYyIsICJhIHBhcmFncmFwaCIpOwotICAgICAgICBydW5UZXN0KCJ3 aW4iLCAicGFyYWdyYSIpOwotICAgIH0KLQotICAgIGZ1bmN0aW9uIHJ1blRlc3QoYmVoYXZpb3Is IGV4cGVjdGVkVGV4dCkKLSAgICB7Ci0gICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLnNldEVk aXRpbmdCZWhhdmlvcihiZWhhdmlvcik7CiAgICAgICAgIGRvdWJsZUNsaWNrV29yZCgpOwogICAg ICAgICBnZXRTZWxlY3Rpb24oKS5tb2RpZnkoImV4dGVuZCIsICJiYWNrd2FyZCIsICJjaGFyYWN0 ZXIiKTsKICAgICAgICAgZ2V0U2VsZWN0aW9uKCkubW9kaWZ5KCJleHRlbmQiLCAiYmFja3dhcmQi LCAiY2hhcmFjdGVyIik7CkBAIC00NCwxNSArMzIsMTkgQEAKICAgICAgICAgZ2V0U2VsZWN0aW9u KCkubW9kaWZ5KCJleHRlbmQiLCAiYmFja3dhcmQiLCAiY2hhcmFjdGVyIik7CiAgICAgICAgIGdl dFNlbGVjdGlvbigpLm1vZGlmeSgiZXh0ZW5kIiwgImJhY2t3YXJkIiwgImNoYXJhY3RlciIpOwog CisgICAgICAgIHZhciByZXN1bHQ7CiAgICAgICAgIHZhciBzZWxlY3RlZFRleHQgPSBnZXRTZWxl Y3Rpb24oKS50b1N0cmluZygpOworICAgICAgICB2YXIgb25NYWNQbGF0Zm9ybSA9IG5hdmlnYXRv ci51c2VyQWdlbnQuc2VhcmNoKC9cYk1hYyBPUyBYXGIvKSAhPSAtMTsKKyAgICAgICAgdmFyIGV4 cGVjdGVkVGV4dCA9IG9uTWFjUGxhdGZvcm0gPyAiYSBwYXJhZ3JhcGgiIDogInBhcmFncmEiOwog ICAgICAgICBpZiAoc2VsZWN0ZWRUZXh0ID09IGV4cGVjdGVkVGV4dCkKLSAgICAgICAgICAgIGxv Z1Jlc3VsdCgiU1VDQ0VTUyIpOworICAgICAgICAgICAgcmVzdWx0ID0gIlNVQ0NFU1MiOwogICAg ICAgICBlbHNlCi0gICAgICAgICAgICBsb2dSZXN1bHQoIkZBSUxVUkU6IFRoZSBzZWxlY3RlZCB0 ZXh0IGlzIFwiIiArIHNlbGVjdGVkVGV4dCArICJcIiBhbmQgc2hvdWxkIGJlIFwiIiArIGV4cGVj dGVkVGV4dCArICJcIi4iKTsKKyAgICAgICAgICAgIHJlc3VsdCA9ICJGQUlMVVJFOiBUaGUgc2Vs ZWN0ZWQgdGV4dCBpcyBcIiIgKyBzZWxlY3RlZFRleHQgKyAiXCIgYW5kIHNob3VsZCBiZSBcIiIg KyBleHBlY3RlZFRleHQgKyAiXCIuIjsKKyAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo InJlc3VsdCIpLmZpcnN0Q2hpbGQuZGF0YSA9IHJlc3VsdDsKICAgICB9CiA8L3NjcmlwdD4KIDwv aGVhZD4KLTxib2R5IG9ubG9hZD0icnVuVGVzdHMoKSI+Cis8Ym9keSBvbmxvYWQ9InJ1blRlc3Qo KSI+CiA8cD5UaGlzIHRlc3RzIG1vZGlmeWluZyBhIHNlbGVjdGlvbiBjcmVhdGVkIHdpdGggYSBk b3VibGUgY2xpY2sgd2l0aCBzaGlmdCBhcnJvdyBrZXkuPC9wPgogPHAgc3R5bGU9ImNvbG9yOmdy ZWVuIj4KICAgICBUaGlzIHRlc3QgZG9lcyBub3QgcnVuIGludGVyYWN0aXZlbHkuCkBAIC02Miw1 ICs1NCw1IEBACiAgICAgVGhlIHNlbGVjdGlvbiBzaG91bGQgaW5jbHVkZSB0aGUgd29yZHMgImEg cGFyYWdyYXBoIiBvbiBtYWMgYW5kICJwYXJhZ3JhIiBvbiB3aW4vbGludXguLgogPC9wPgogPHA+ VGhpcyBpcyBhIHBhcmE8c3BhbiBzdHlsZT0iY29sb3I6Ymx1ZSIgaWQ9InN0YXJ0Ij5nPC9zcGFu PnJhcGguPC9wPgotPHAgaWQ9InJlc3VsdCI+PC9wPgorPHAgaWQ9InJlc3VsdCI+VEVTVCBIQVMg Tk9UIFJVTjwvcD4KIDwvYm9keT4K 56624 2010-05-20 13:11:31 -0700 2010-06-08 13:47:45 -0700 Reset Mac and Windows to platform default between tests bug-39433-20100520131130.patch text/plain 2558 mrobinson ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBlYmQxZmEyMWIyNTkzM2ZmNDczYTU0NmI4MDJiNTU1NDg2M2MwODMyLi45YzNiOGZm NzRhOTUyMzY0MmVhYTI4MjZjZTg3NGZlZDQ0MTc0MWIyIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAK KzIwMTAtMDUtMjAgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGVkaXRpbmdCZWhh dmlvciBzZXR0aW5ncyBuZWVkcyB0byBiZSBzZXQgYmFjayB0byBhIHJlYXNvbmFibGUgZGVmYXVs dCBiZXR3ZWVuIHRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0zOTQzMworCisgICAgICAgIEZvciBub3csIGhhcmQgY29kZSB0aGUgZGVmYXVsdCBz ZXR0aW5nIGR1cmluZyByZXNldCwgc28gdGhhdCB0aGUgc2VyaWFsaXplZAorICAgICAgICB2ZXJz aW9uIG9mIHRoZSBzZXR0aW5nIHN0YXlzIGluIHN5bmMgd2l0aCBleHBlY3RhdGlvbnMuCisKKyAg ICAgICAgKiBEdW1wUmVuZGVyVHJlZS9tYWMvRHVtcFJlbmRlclRyZWUubW06CisgICAgICAgIChy ZXNldERlZmF1bHRzVG9Db25zaXN0ZW50VmFsdWVzKTogUmVzZXQgZWRpdGluZyBiZWhhdmlvciB0 byB0aGUgYXBwcm9wcmlhdGUgcGxhdGZvcm0gZGVmYXVsdC4KKyAgICAgICAgKiBEdW1wUmVuZGVy VHJlZS93aW4vRHVtcFJlbmRlclRyZWUuY3BwOgorICAgICAgICAocmVzZXREZWZhdWx0c1RvQ29u c2lzdGVudFZhbHVlcyk6IERpdHRvLgorCiAyMDEwLTA1LTIwICBCcmVudCBGdWxnaGFtICA8YmZ1 bGdoYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBCdWlsZCBmaXguICBObyByZXZpZXcuCmRpZmYg LS1naXQgYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9tYWMvRHVtcFJlbmRlclRyZWUubW0g Yi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9tYWMvRHVtcFJlbmRlclRyZWUubW0KaW5kZXgg YmYxMzM5ZGZkYTlkNTA3NmVhYWE0ZmNjYmQzY2FkN2I2YzhlOGIyMy4uOGZkNTI5ODg5ODAzMzFl N2I4ODQzOTAwMGI4MzAxZTI4ZGY2Mzg1MyAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvRHVtcFJl bmRlclRyZWUvbWFjL0R1bXBSZW5kZXJUcmVlLm1tCisrKyBiL1dlYktpdFRvb2xzL0R1bXBSZW5k ZXJUcmVlL21hYy9EdW1wUmVuZGVyVHJlZS5tbQpAQCAtNDQxLDYgKzQ0MSw3IEBAIHN0YXRpYyB2 b2lkIHJlc2V0RGVmYXVsdHNUb0NvbnNpc3RlbnRWYWx1ZXMoKQogICAgIFtwcmVmZXJlbmNlcyBz ZXREZXZlbG9wZXJFeHRyYXNFbmFibGVkOk5PXTsKICAgICBbcHJlZmVyZW5jZXMgc2V0TG9hZHNJ bWFnZXNBdXRvbWF0aWNhbGx5OllFU107CiAgICAgW3ByZWZlcmVuY2VzIHNldEZyYW1lRmxhdHRl bmluZ0VuYWJsZWQ6Tk9dOworICAgIFtwcmVmZXJlbmNlcyBzZXRFZGl0aW5nQmVoYXZpb3I6V2Vi S2l0RWRpdGluZ01hY0JlaGF2aW9yXTsKICAgICBpZiAocGVyc2lzdGVudFVzZXJTdHlsZVNoZWV0 TG9jYXRpb24pIHsKICAgICAgICAgW3ByZWZlcmVuY2VzIHNldFVzZXJTdHlsZVNoZWV0TG9jYXRp b246W05TVVJMIFVSTFdpdGhTdHJpbmc6KE5TU3RyaW5nICopKHBlcnNpc3RlbnRVc2VyU3R5bGVT aGVldExvY2F0aW9uLmdldCgpKV1dOwogICAgICAgICBbcHJlZmVyZW5jZXMgc2V0VXNlclN0eWxl U2hlZXRFbmFibGVkOllFU107CmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJl ZS93aW4vRHVtcFJlbmRlclRyZWUuY3BwIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvd2lu L0R1bXBSZW5kZXJUcmVlLmNwcAppbmRleCBkZmE0ZGUwNzFkNmI1MmMzN2MxMWIwNjA2OTFkM2I2 ZmJjNDI3M2MxLi5iMjJmMzQyMTU1ZTI0OTZlYWE3ZjNhYjQ1NzJhZTEyYWM4OGY2ODViIDEwMDY0 NAotLS0gYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS93aW4vRHVtcFJlbmRlclRyZWUuY3Bw CisrKyBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3dpbi9EdW1wUmVuZGVyVHJlZS5jcHAK QEAgLTc4Nyw2ICs3ODcsNyBAQCBzdGF0aWMgdm9pZCByZXNldERlZmF1bHRzVG9Db25zaXN0ZW50 VmFsdWVzKElXZWJQcmVmZXJlbmNlcyogcHJlZmVyZW5jZXMpCiAgICAgcHJlZmVyZW5jZXMtPnNl dFRhYnNUb0xpbmtzKEZBTFNFKTsKICAgICBwcmVmZXJlbmNlcy0+c2V0U2hvdWxkUHJpbnRCYWNr Z3JvdW5kcyhUUlVFKTsKICAgICBwcmVmZXJlbmNlcy0+c2V0TG9hZHNJbWFnZXNBdXRvbWF0aWNh bGx5KFRSVUUpOworICAgIHByZWZlcmVuY2VzLT5zZXRFZGl0aW5nQmVoYXZpb3IoV2ViS2l0RWRp dGluZ1dpbkJlaGF2aW9yKTsKIAogICAgIGlmIChwZXJzaXN0ZW50VXNlclN0eWxlU2hlZXRMb2Nh dGlvbikgewogICAgICAgICBWZWN0b3I8d2NoYXJfdD4gdXJsQ2hhcmFjdGVycyhDRlN0cmluZ0dl dExlbmd0aChwZXJzaXN0ZW50VXNlclN0eWxlU2hlZXRMb2NhdGlvbi5nZXQoKSkpOwo= 56970 2010-05-24 21:47:39 -0700 2010-05-25 06:18:52 -0700 (committed with r60158, reviewed by eseidel, tkent) Reset Gtk and Chromium to platform default between tests 0001-editingBehavior-settings-needs-to-be-set-back-to-a-r.patch text/plain 3079 tonikitoo RnJvbSBlMThkNjU1YzI0OThkMGY4MTkzOTk2M2JiN2UzZjZhMTIyN2JhNzM5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4K RGF0ZTogVHVlLCAyNSBNYXkgMjAxMCAwMDo0MzoxMyAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIGVk aXRpbmdCZWhhdmlvciBzZXR0aW5ncyBuZWVkcyB0byBiZSBzZXQgYmFjayB0byBhIHJlYXNvbmFi bGUgZGVmYXVsdCBiZXR3ZWVuIHRlc3RzCiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9Mzk0MzMKClJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgpQYXRjaCBieSBBbnRv bmlvIEdvbWVzIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4KClNpbWlsYXJseSB0byByNTk4NjEsIGhh cmQgY29kZSB0aGUgZGVmYXVsdCBzZXR0aW5nIGR1cmluZyByZXNldCBmb3IgR3RrIGFuZCBDaHJv bWl1bSwKc28gdGhhdCB0aGUgc2VyaWFsaXplZCB2ZXJzaW9uIG9mIHRoZSBzZXR0aW5nIHN0YXlz IGluIHN5bmMgd2l0aCBleHBlY3RhdGlvbnMuCgoqIER1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rl c3RTaGVsbC5jcHA6CihUZXN0U2hlbGw6OnJlc2V0V2ViU2V0dGluZ3MpOgoqIER1bXBSZW5kZXJU cmVlL2d0ay9EdW1wUmVuZGVyVHJlZS5jcHA6CihyZXNldERlZmF1bHRzVG9Db25zaXN0ZW50VmFs dWVzKToKLS0tCiBXZWJLaXRUb29scy9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHwgICAxNSArKysrKysrKysrKysrKysKIFdlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2No cm9taXVtL1Rlc3RTaGVsbC5jcHAgfCAgICA2ICsrKysrKwogV2ViS2l0VG9vbHMvRHVtcFJlbmRl clRyZWUvZ3RrL0R1bXBSZW5kZXJUcmVlLmNwcCB8ICAgIDEgKwogMyBmaWxlcyBjaGFuZ2VkLCAy MiBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xz L0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxvZwppbmRleCBiZWMyMzFmLi5lNjBlMzk0 IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMDUtMjQgIEFudG9uaW8gR29tZXMgIDx0b25p a2l0b29Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBlZGl0aW5nQmVoYXZpb3Igc2V0dGluZ3MgbmVlZHMgdG8gYmUgc2V0IGJhY2sg dG8gYSByZWFzb25hYmxlIGRlZmF1bHQgYmV0d2VlbiB0ZXN0cworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzk0MzMKKworICAgICAgICBTaW1pbGFybHkg dG8gcjU5ODYxLCBoYXJkIGNvZGUgdGhlIGRlZmF1bHQgc2V0dGluZyBkdXJpbmcgcmVzZXQgZm9y IEd0ayBhbmQgQ2hyb21pdW0sCisgICAgICAgIHNvIHRoYXQgdGhlIHNlcmlhbGl6ZWQgdmVyc2lv biBvZiB0aGUgc2V0dGluZyBzdGF5cyBpbiBzeW5jIHdpdGggZXhwZWN0YXRpb25zLgorCisgICAg ICAgICogRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vVGVzdFNoZWxsLmNwcDoKKyAgICAgICAgKFRl c3RTaGVsbDo6cmVzZXRXZWJTZXR0aW5ncyk6CisgICAgICAgICogRHVtcFJlbmRlclRyZWUvZ3Rr L0R1bXBSZW5kZXJUcmVlLmNwcDoKKyAgICAgICAgKHJlc2V0RGVmYXVsdHNUb0NvbnNpc3RlbnRW YWx1ZXMpOgorCiAyMDEwLTA1LTIzICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KIAog ICAgICAgICBSZXZpZXdlZCBieSBEYW5pZWwgQmF0ZXMuCmRpZmYgLS1naXQgYS9XZWJLaXRUb29s cy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0U2hlbGwuY3BwIGIvV2ViS2l0VG9vbHMvRHVt cFJlbmRlclRyZWUvY2hyb21pdW0vVGVzdFNoZWxsLmNwcAppbmRleCAyOWJkNTk2Li5mZDU2Yjgw IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0U2hl bGwuY3BwCisrKyBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RTaGVs bC5jcHAKQEAgLTE3NCw2ICsxNzQsMTIgQEAgdm9pZCBUZXN0U2hlbGw6OnJlc2V0V2ViU2V0dGlu Z3MoV2ViVmlldyYgd2ViVmlldykKIAogICAgIHNldHRpbmdzLT5zZXRMb2Fkc0ltYWdlc0F1dG9t YXRpY2FsbHkodHJ1ZSk7CiAgICAgc2V0dGluZ3MtPnNldEltYWdlc0VuYWJsZWQodHJ1ZSk7CisK KyNpZiBPUyhEQVJXSU4pCisgICAgc2V0dGluZ3MtPnNldEVkaXRpbmdCZWhhdmlvcihXZWJTZXR0 aW5nczo6RWRpdGluZ0JlaGF2aW9yTWFjKTsKKyNlbHNlCisgICAgc2V0dGluZ3MtPnNldEVkaXRp bmdCZWhhdmlvcihXZWJTZXR0aW5nczo6RWRpdGluZ0JlaGF2aW9yV2luZG93cyk7CisjZW5kaWYK IH0KIAogdm9pZCBUZXN0U2hlbGw6OnJ1bkZpbGVUZXN0KGNvbnN0IFRlc3RQYXJhbXMmIHBhcmFt cykKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9EdW1wUmVuZGVy VHJlZS5jcHAgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRHVtcFJlbmRlclRyZWUu Y3BwCmluZGV4IDI3M2JjZGYuLmJlMjkyMDQgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0R1bXBS ZW5kZXJUcmVlL2d0ay9EdW1wUmVuZGVyVHJlZS5jcHAKKysrIGIvV2ViS2l0VG9vbHMvRHVtcFJl bmRlclRyZWUvZ3RrL0R1bXBSZW5kZXJUcmVlLmNwcApAQCAtMzQzLDYgKzM0Myw3IEBAIHN0YXRp YyB2b2lkIHJlc2V0RGVmYXVsdHNUb0NvbnNpc3RlbnRWYWx1ZXMoKQogICAgICAgICAgICAgICAg ICAiYXV0by1yZXNpemUtd2luZG93IiwgVFJVRSwKICAgICAgICAgICAgICAgICAgImVuYWJsZS1q YXZhLWFwcGxldCIsIEZBTFNFLAogICAgICAgICAgICAgICAgICAiZW5hYmxlLXBsdWdpbnMiLCBU UlVFLAorICAgICAgICAgICAgICAgICAiZWRpdGluZy1iZWhhdmlvciIsIFdFQktJVF9FRElUSU5H X0JFSEFWSU9SX1dJTkRPV1MsCiAgICAgICAgICAgICAgICAgIE5VTEwpOwogCiAgICAgd2Via2l0 X3dlYl9mcmFtZV9jbGVhcl9tYWluX2ZyYW1lX25hbWUobWFpbkZyYW1lKTsKLS0gCjEuNy4wLjQK Cg==