39411 2010-05-20 00:59:43 -0700 [BREWMP] Don't include POSIX headers in WebCorePrefix.h 2010-06-12 20:41:34 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 33564 0 skyul webkit-unassigned beergun commit-queue joybro201 oldest_to_newest 228243 0 skyul 2010-05-20 00:59:43 -0700 When building for BREW MP, don't include POSIX headers: <fcntl.h>, <pthread.h> and <sys/types.h>. 228246 1 56571 skyul 2010-05-20 01:03:18 -0700 Created attachment 56571 Patch 229983 2 56571 laszlo.gombos 2010-05-24 16:56:22 -0700 Comment on attachment 56571 Patch > +#if !defined(BUILDING_BREWMP__) > #include <pthread.h> > +#endif Can we use HAVE(PTHREAD_H) as a guard here instead ? 230163 3 skyul 2010-05-25 01:44:57 -0700 (In reply to comment #2) > Can we use HAVE(PTHREAD_H) as a guard here instead ? I will try HAVE(XXX_H) and see if other ports build OK. 230170 4 skyul 2010-05-25 01:54:45 -0700 (In reply to comment #3) > I will try HAVE(XXX_H) and see if other ports build OK. Oops. It seems we can't use HAVE(WTF_FEATURE) macro in WebCorePrefix.h. 237415 5 56571 tkent 2010-06-12 19:04:44 -0700 Comment on attachment 56571 Patch Looks OK. 237452 6 56571 commit-queue 2010-06-12 20:41:29 -0700 Comment on attachment 56571 Patch Clearing flags on attachment: 56571 Committed r61074: <http://trac.webkit.org/changeset/61074> 237453 7 commit-queue 2010-06-12 20:41:34 -0700 All reviewed patches have been landed. Closing bug. 56571 2010-05-20 01:03:18 -0700 2010-06-12 20:41:28 -0700 Patch posix.patch text/plain 1490 skyul SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1OTgyMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDUtMjAgIEt3YW5nIFl1bCBTZW8gIDxza3l1bEBjb21wYW55 MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBbQlJFV01QXSBEb24ndCBpbmNsdWRlIFBPU0lYIGhlYWRlcnMgaW4gV2ViQ29yZVByZWZpeC5o CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zOTQxMQor CisgICAgICAgIFdoZW4gYnVpbGRpbmcgZm9yIEJSRVcgTVAsIGRvbid0IGluY2x1ZGUgUE9TSVgg aGVhZGVyczoKKyAgICAgICAgPGZjbnRsLmg+LCA8cHRocmVhZC5oPiBhbmQgPHN5cy90eXBlcy5o Pi4KKworICAgICAgICAqIFdlYkNvcmVQcmVmaXguaDoKKwogMjAxMC0wNS0xOSAgVmFuZ2VsaXMg S29ra2V2aXMgIDx2YW5nZWxpc0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg RGFyaW4gRmlzaGVyLgpJbmRleDogV2ViQ29yZS9XZWJDb3JlUHJlZml4LmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViQ29yZS9XZWJDb3JlUHJlZml4LmgJKHJldmlzaW9uIDU5ODIzKQorKysgV2ViQ29yZS9X ZWJDb3JlUHJlZml4LmgJKHdvcmtpbmcgY29weSkKQEAgLTU5LDcgKzU5LDkgQEAKICNlbmRpZgog CiAjZWxzZQorI2lmICFkZWZpbmVkKEJVSUxESU5HX0JSRVdNUF9fKQogI2luY2x1ZGUgPHB0aHJl YWQuaD4KKyNlbmRpZgogI2VuZGlmIC8vIGRlZmluZWQoV0lOMzIpIHx8IGRlZmluZWQoX1dJTjMy KQogCiAjaWYgZGVmaW5lZChBTkRST0lEKQpAQCAtNzUsOCArNzcsMTAgQEAKICNpbmNsdWRlIDxK YXZhU2NyaXB0Q29yZS9jb25maWcuaD4KICNlbmRpZgogCisjaWYgIWRlZmluZWQoQlVJTERJTkdf QlJFV01QX18pCiAjaW5jbHVkZSA8c3lzL3R5cGVzLmg+CiAjaW5jbHVkZSA8ZmNudGwuaD4KKyNl bmRpZgogI2lmIGRlZmluZWQoX19BUFBMRV9fKQogI2luY2x1ZGUgPHJlZ2V4Lmg+CiAjZW5kaWYK QEAgLTEwNiwxMSArMTEwLDE1IEBACiAKICNlbmRpZgogCisjaWYgIWRlZmluZWQoQlVJTERJTkdf QlJFV01QX18pCiAjaW5jbHVkZSA8c3lzL3R5cGVzLmg+CisjZW5kaWYKICNpZiBkZWZpbmVkKF9f QVBQTEVfXykKICNpbmNsdWRlIDxzeXMvcGFyYW0uaD4KICNlbmRpZgorI2lmICFkZWZpbmVkKEJV SUxESU5HX0JSRVdNUF9fKQogI2luY2x1ZGUgPHN5cy9zdGF0Lmg+CisjZW5kaWYKICNpZiBkZWZp bmVkKF9fQVBQTEVfXykKICNpbmNsdWRlIDxzeXMvdGltZS5oPgogI2luY2x1ZGUgPHN5cy9yZXNv dXJjZS5oPgo=