39402 2010-05-19 21:31:43 -0700 [chromium] disable spelling suggestions if spellcheck=false 2010-05-19 22:36:16 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 tony webkit-unassigned ojan oldest_to_newest 228178 0 tony 2010-05-19 21:31:43 -0700 [chromium] disable spelling suggestions if spellcheck=false 228179 1 56558 tony 2010-05-19 21:32:58 -0700 Created attachment 56558 Patch 228195 2 56558 tkent 2010-05-19 22:19:41 -0700 Comment on attachment 56558 Patch WebKit/chromium/src/ContextMenuClientImpl.cpp:205 + data.isSpellCheckingEnabled = true; Should we leave this line in a case of no misspelledWord? 228198 3 tony 2010-05-19 22:28:16 -0700 (In reply to comment #2) > (From update of attachment 56558 [details]) > WebKit/chromium/src/ContextMenuClientImpl.cpp:205 > + data.isSpellCheckingEnabled = true; > Should we leave this line in a case of no misspelledWord? I left it in to be consistent with Safari. This means that the context menu will still show a check mark by "Spellchecking in this field". I did it this way in Safari because you can imagine a div with spellchecking enabled, with a single span inside it that has spellchecking disabled. It seems more consistent to treat the whole field as "spellcheck enabled" even if you click in the span. I think it would be confusing if the check mark changed depending on which node you happened to click on within a single content editable node. 228201 4 56558 tkent 2010-05-19 22:31:27 -0700 Comment on attachment 56558 Patch (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 56558 [details] [details]) > > WebKit/chromium/src/ContextMenuClientImpl.cpp:205 > > + data.isSpellCheckingEnabled = true; > > Should we leave this line in a case of no misspelledWord? > > I left it in to be consistent with Safari. This means that the context menu will still show a check mark by "Spellchecking in this field". I did it this way in Safari because you can imagine a div with spellchecking enabled, with a single span inside it that has spellchecking disabled. It seems more consistent to treat the whole field as "spellcheck enabled" even if you click in the span. I think it would be confusing if the check mark changed depending on which node you happened to click on within a single content editable node. Ok, that's reasonable. 228202 5 tony 2010-05-19 22:35:44 -0700 Committed r59819: <http://trac.webkit.org/changeset/59819> 56558 2010-05-19 21:32:58 -0700 2010-05-19 22:36:16 -0700 Patch bug-39402-20100519213257.patch text/plain 1770 tony ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDhjNTYyNTNlODM4MWM4YjNiMzUwOGJhMjk0Njk5MWYxMmFkNzZmZjEu LjBmMTVmZmI0N2ExNjY0OGNjNzM1OThlZGE5ZWFhZGI2M2IyOGY0YTggMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE2IEBACisyMDEwLTA1LTE5ICBUb255IENoYW5nICA8dG9ueUBjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW2No cm9taXVtXSBkaXNhYmxlIHNwZWxsaW5nIHN1Z2dlc3Rpb25zIGlmIHNwZWxsY2hlY2s9ZmFsc2UK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5NDAyCisg ICAgICAgIAorICAgICAgICBUaGlzIGlzIHRoZSBDaHJvbWl1bSBmaXggZm9yIGJ1ZyAyNTYzOSB0 aGF0IHdhcyBmaXhlZCBpbiB0aGUKKyAgICAgICAgb3RoZXIgcG9ydHMgaW4gcjU5NTg1LgorCisg ICAgICAgICogc3JjL0NvbnRleHRNZW51Q2xpZW50SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6 OkNvbnRleHRNZW51Q2xpZW50SW1wbDo6Z2V0Q3VzdG9tTWVudUZyb21EZWZhdWx0SXRlbXMpOgor CiAyMDEwLTA1LTE5ICBEYXJpbiBGaXNoZXIgIDxkYXJpbkBjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgUmV2ZXJ0IHI1OTc5MCBkdWUgdG8gZmFpbGluZyBDaHJvbWl1bSBucHJ1bnRpbWUgdGVzdHMu CmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vc3JjL0NvbnRleHRNZW51Q2xpZW50SW1wbC5j cHAgYi9XZWJLaXQvY2hyb21pdW0vc3JjL0NvbnRleHRNZW51Q2xpZW50SW1wbC5jcHAKaW5kZXgg YjYwMDVmOTM5OWE0NzkyN2YzYmEwZGZjYWYzZTIwYjA3NjNiYWQ5YS4uOGRkMzM5MzNkM2ZiOWU3 MjA1N2ZiMDIzZTNhNjE1NzUxMzJjMWZhNCAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL3Ny Yy9Db250ZXh0TWVudUNsaWVudEltcGwuY3BwCisrKyBiL1dlYktpdC9jaHJvbWl1bS9zcmMvQ29u dGV4dE1lbnVDbGllbnRJbXBsLmNwcApAQCAtMjAzLDcgKzIwMyw5IEBAIFBsYXRmb3JtTWVudURl c2NyaXB0aW9uIENvbnRleHRNZW51Q2xpZW50SW1wbDo6Z2V0Q3VzdG9tTWVudUZyb21EZWZhdWx0 SXRlbXMoCiAgICAgICAgIGRhdGEuaXNFZGl0YWJsZSA9IHRydWU7CiAgICAgICAgIGlmIChtX3dl YlZpZXctPmZvY3VzZWRXZWJDb3JlRnJhbWUoKS0+ZWRpdG9yKCktPmlzQ29udGludW91c1NwZWxs Q2hlY2tpbmdFbmFibGVkKCkpIHsKICAgICAgICAgICAgIGRhdGEuaXNTcGVsbENoZWNraW5nRW5h YmxlZCA9IHRydWU7Ci0gICAgICAgICAgICBkYXRhLm1pc3NwZWxsZWRXb3JkID0gc2VsZWN0TWlz c3BlbGxlZFdvcmQoZGVmYXVsdE1lbnUsIHNlbGVjdGVkRnJhbWUpOworICAgICAgICAgICAgLy8g U3BlbGxjaGVja2luZyBtaWdodCBiZSBlbmFibGVkIGZvciB0aGUgZmllbGQsIGJ1dCBjb3VsZCBi ZSBkaXNhYmxlZCBvbiB0aGUgbm9kZS4KKyAgICAgICAgICAgIGlmIChtX3dlYlZpZXctPmZvY3Vz ZWRXZWJDb3JlRnJhbWUoKS0+ZWRpdG9yKCktPnNwZWxsQ2hlY2tpbmdFbmFibGVkSW5Gb2N1c2Vk Tm9kZSgpKQorICAgICAgICAgICAgICAgIGRhdGEubWlzc3BlbGxlZFdvcmQgPSBzZWxlY3RNaXNz cGVsbGVkV29yZChkZWZhdWx0TWVudSwgc2VsZWN0ZWRGcmFtZSk7CiAgICAgICAgIH0KICAgICB9 CiAK