<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>39397</bug_id>
          
          <creation_ts>2010-05-19 20:38:08 -0700</creation_ts>
          <short_desc>Add COMPILER(MSVC) guard for strnstr</short_desc>
          <delta_ts>2010-05-21 02:40:18 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Template Framework</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Kwang Yul Seo">skyul</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>joybro201</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>228156</commentid>
    <comment_count>0</comment_count>
    <who name="Kwang Yul Seo">skyul</who>
    <bug_when>2010-05-19 20:38:08 -0700</bug_when>
    <thetext>BREWMP uses MSVC for simulator build, but it is not OS(WINDOWS). Add COMPILER(MSVC) guard for strnstr.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>228157</commentid>
    <comment_count>1</comment_count>
      <attachid>56552</attachid>
    <who name="Kwang Yul Seo">skyul</who>
    <bug_when>2010-05-19 20:40:12 -0700</bug_when>
    <thetext>Created attachment 56552
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>228227</commentid>
    <comment_count>2</comment_count>
      <attachid>56552</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-05-20 00:35:23 -0700</bug_when>
    <thetext>Comment on attachment 56552
Patch

Seems reasonable.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>228814</commentid>
    <comment_count>3</comment_count>
      <attachid>56552</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-05-21 02:40:14 -0700</bug_when>
    <thetext>Comment on attachment 56552
Patch

Clearing flags on attachment: 56552

Committed r59921: &lt;http://trac.webkit.org/changeset/59921&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>228815</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-05-21 02:40:18 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>56552</attachid>
            <date>2010-05-19 20:40:12 -0700</date>
            <delta_ts>2010-05-21 02:40:14 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>strnstr.patch</filename>
            <type>text/plain</type>
            <size>1175</size>
            <attacher name="Kwang Yul Seo">skyul</attacher>
            
              <data encoding="base64">SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDU5ODE0KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDUtMTkgIEt3YW5nIFl1
bCBTZW8gIDxza3l1bEBjb21wYW55MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP
RFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgQ09NUElMRVIoTVNWQykgZ3VhcmQgZm9yIHN0cm5z
dHIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5Mzk3
CisKKyAgICAgICAgQlJFV01QIHVzZXMgTVNWQyBmb3Igc2ltdWxhdG9yIGJ1aWxkLCBidXQgaXQg
aXMgbm90IE9TKFdJTkRPV1MpLgorICAgICAgICBBZGQgQ09NUElMRVIoTVNWQykgZ3VhcmQgZm9y
IHN0cm5zdHIuCisKKyAgICAgICAgKiB3dGYvU3RyaW5nRXh0cmFzLmg6CisKIDIwMTAtMDUtMTkg
IEdhdmluIEJhcnJhY2xvdWdoICA8YmFycmFjbG91Z2hAYXBwbGUuY29tPgogCiAgICAgICAgIFJl
dmlld2VkIGJ5IE5PQk9EWSAoYnVpbGQgZml4KS4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL3d0Zi9T
dHJpbmdFeHRyYXMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS93dGYvU3RyaW5nRXh0
cmFzLmgJKHJldmlzaW9uIDU5NzYzKQorKysgSmF2YVNjcmlwdENvcmUvd3RmL1N0cmluZ0V4dHJh
cy5oCSh3b3JraW5nIGNvcHkpCkBAIC04Niw3ICs4Niw3IEBAIGlubGluZSBpbnQgc3RyY2FzZWNt
cChjb25zdCBjaGFyKiBzMSwgY28KIAogI2VuZGlmCiAKLSNpZiBPUyhXSU5ET1dTKSB8fCBPUyhM
SU5VWCkgfHwgT1MoU09MQVJJUykKKyNpZiBDT01QSUxFUihNU1ZDKSB8fCBPUyhXSU5ET1dTKSB8
fCBPUyhMSU5VWCkgfHwgT1MoU09MQVJJUykKIC8vIEZJWE1FOiBzaG91bGQgY2hlY2sgSEFWRV9T
VFJOU1RSCiAKIGlubGluZSBjaGFyKiBzdHJuc3RyKGNvbnN0IGNoYXIqIGJ1ZmZlciwgY29uc3Qg
Y2hhciogdGFyZ2V0LCBzaXplX3QgYnVmZmVyTGVuZ3RoKQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>