39372 2010-05-19 11:57:42 -0700 check-webkit-style complains about use of NULL in GTK function calls that require sentinels 2010-05-27 05:15:39 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 darin webkit-unassigned abarth cjerdonek eric hamaji levin pnormand oldest_to_newest 227928 0 darin 2010-05-19 11:57:42 -0700 Various GTK calls have variable arguments that are pointers, and then have to end with a sentinel. The sentinel must be NULL, not 0. But check-webkit-style complains, saying that the NULL should instead be 0. 227930 1 darin 2010-05-19 11:58:04 -0700 See an example in bug 39368. 231195 2 57212 pnormand 2010-05-27 02:33:05 -0700 Created attachment 57212 proposed patch 231203 3 57212 hamaji 2010-05-27 03:01:18 -0700 Comment on attachment 57212 proposed patch Looks good, but it would be better if we can limit the symbols. How about r'\bg_[a-z]+_[a-z]+\b', r'\bg_[a-z]+(_[a-z]+)+\b', or r'\bg(_[a-z]+)+\b' ? 231236 4 pnormand 2010-05-27 05:10:30 -0700 (In reply to comment #3) > (From update of attachment 57212 [details]) > Looks good, but it would be better if we can limit the symbols. How about r'\bg_[a-z]+_[a-z]+\b', r'\bg_[a-z]+(_[a-z]+)+\b', or r'\bg(_[a-z]+)+\b' ? Yeah, I like option #3. Will update the patch and land it, thanks for the review :) 231240 5 pnormand 2010-05-27 05:15:39 -0700 Landed in r60293 <http://trac.webkit.org/changeset/60293> Thanks! 57212 2010-05-27 02:33:05 -0700 2010-05-27 03:01:18 -0700 proposed patch proposed-patch.patch text/plain 2570 pnormand RnJvbSAxZmViMjdlOWM2YjFiNjVlMzkyODc3MmZlZDc1YzU3ZmQ2ZGRhYzRlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUaHUsIDI3IE1heSAyMDEwIDExOjMyOjA2ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g cHJvcG9zZWQgcGF0Y2gKCi0tLQogV2ViS2l0VG9vbHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgfCAgIDEzICsrKysrKysrKysrKysKIFdlYktpdFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5IHwgICAgNCArKy0tCiAuLi4vd2Via2l0cHkv c3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5ICAgICAgICB8ICAgIDMgKysrCiAzIGZpbGVz IGNoYW5nZWQsIDE4IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEv V2ViS2l0VG9vbHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCmluZGV4IDBhMDZl N2QuLjdmNmVkM2EgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZworKysgYi9XZWJL aXRUb29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wNS0yNyAgUGhpbGlwcGUg Tm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgY2hlY2std2Via2l0LXN0eWxlIGNvbXBsYWlucyBhYm91 dCB1c2Ugb2YgTlVMTCBpbiBHVEsgZnVuY3Rpb24gY2FsbHMgdGhhdCByZXF1aXJlIHNlbnRpbmVs cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzkzNzIK KworICAgICAgICBEb24ndCB3YXJuIGFib3V0IE5VTEwgaW4gZ18qKCkgY2FsbHMuIFplcm8gY2Fu J3QgYmUgdXNlZCBpbnN0ZWFkCisgICAgICAgIGZvciBjYWxscyBsaWtlIGdfYnVpbGRfZmlsZW5h bWUgYW5kIGdfb2JqZWN0X2dldC9zZXQuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0 eWxlL2NoZWNrZXJzL2NwcC5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2No ZWNrZXJzL2NwcF91bml0dGVzdC5weToKKwogMjAxMC0wNS0yNiAgUGhpbGlwcGUgTm9ybWFuZCAg PHBub3JtYW5kQGlnYWxpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgTGV2aW4u CmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJz L2NwcC5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3Bw LnB5CmluZGV4IDE1NzAzMzguLmMzNWU0YmMgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1Njcmlw dHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CisrKyBiL1dlYktpdFRvb2xzL1Njcmlw dHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CkBAIC0xODY4LDggKzE4NjgsOCBAQCBk ZWYgY2hlY2tfZm9yX251bGwoZmlsZV9leHRlbnNpb24sIGNsZWFuX2xpbmVzLCBsaW5lX251bWJl ciwgZXJyb3IpOgogCiAgICAgbGluZSA9IGNsZWFuX2xpbmVzLmVsaWRlZFtsaW5lX251bWJlcl0K IAotICAgICMgRG9uJ3Qgd2FybiBhYm91dCBOVUxMIHVzYWdlIGluIGdfb2JqZWN0X3tnZXQsc2V0 fSgpLiBTZWUgQnVnIDMyODU4Ci0gICAgaWYgc2VhcmNoKHInXGJnX29iamVjdF9bc2ddZXRcYics IGxpbmUpOgorICAgICMgRG9uJ3Qgd2FybiBhYm91dCBOVUxMIHVzYWdlIGluIGdfKigpLiBTZWUg QnVnIDMyODU4IGFuZCAzOTM3Mi4KKyAgICBpZiBzZWFyY2gocidcYmdfXHcrXGInLCBsaW5lKToK ICAgICAgICAgcmV0dXJuCiAKICAgICAjIERvbid0IHdhcm4gYWJvdXQgTlVMTCB1c2FnZSBpbiBn c3RfKl9tYW55KCkuIFNlZSBCdWcgMzk3NDAKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1Njcmlw dHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5IGIvV2ViS2l0VG9vbHMv U2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkKaW5kZXggYWVh MzRjYy4uZDdjYjg3NiAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9z dHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93 ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkKQEAgLTM0MzcsNiArMzQzNyw5 IEBAIGNsYXNzIFdlYktpdFN0eWxlVGVzdChDcHBTdHlsZVRlc3RCYXNlKToKICAgICAgICAgICAg ICdnX29iamVjdF9zZXQoZm9vLCAicHJvcCIsIGJhciwgTlVMTCk7JywKICAgICAgICAgICAgICcn KQogICAgICAgICBzZWxmLmFzc2VydF9saW50KAorICAgICAgICAgICAgJ2dfYnVpbGRfZmlsZW5h bWUoZm9vLCBiYXIsIE5VTEwpOycsCisgICAgICAgICAgICAnJykKKyAgICAgICAgc2VsZi5hc3Nl cnRfbGludCgKICAgICAgICAgICAgICdnc3RfYmluX2FkZF9tYW55KGZvbywgYmFyLCBib28sIE5V TEwpOycsCiAgICAgICAgICAgICAnJykKICAgICAgICAgc2VsZi5hc3NlcnRfbGludCgKLS0gCjEu Ni4zLjM=