39358 2010-05-19 06:58:57 -0700 Extra processesArguments() calls in Document::processViewport 2010-05-21 07:21:52 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 jesus jesus commit-queue oldest_to_newest 227806 0 jesus 2010-05-19 06:58:57 -0700 The viewport arguments are only needed when there is a frame->page(), therefore we don't need to always call processArguments(). 227808 1 56485 jesus 2010-05-19 07:05:26 -0700 Created attachment 56485 patch 228239 2 56485 eric 2010-05-20 00:53:37 -0700 Comment on attachment 56485 patch Assuming proceessArguments has no observable side-effects, sure. 228370 3 56485 jesus 2010-05-20 07:41:26 -0700 Comment on attachment 56485 patch Thanks! Adding to the cq+ . 228894 4 56485 commit-queue 2010-05-21 07:21:47 -0700 Comment on attachment 56485 patch Clearing flags on attachment: 56485 Committed r59931: <http://trac.webkit.org/changeset/59931> 228895 5 commit-queue 2010-05-21 07:21:52 -0700 All reviewed patches have been landed. Closing bug. 56485 2010-05-19 07:05:26 -0700 2010-05-21 07:21:47 -0700 patch 0001-Extra-processesArguments-calls-in-Document-processVi.patch text/plain 2135 jesus RnJvbSBhNGRmZGZjZThiNDBmZjZiODY0M2I2OGFkZmNiNmNiNDQ0ODI3OWFiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKZXN1cyBTYW5jaGV6LVBhbGVuY2lhIDxqZXN1c0B3ZWJraXQu b3JnPgpEYXRlOiBXZWQsIDE5IE1heSAyMDEwIDExOjA2OjI1IC0wMzAwClN1YmplY3Q6IFtQQVRD SF0gRXh0cmEgcHJvY2Vzc2VzQXJndW1lbnRzKCkgY2FsbHMgaW4gRG9jdW1lbnQ6OnByb2Nlc3NW aWV3cG9ydAogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5MzU4CgpS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KClRoZSB2aWV3cG9ydCBhcmd1bWVudHMgYXJlIG9u bHkgbmVlZGVkIHdoZW4gdGhlcmUgaXMgYSBmcmFtZS0+cGFnZSgpLAp0aGVyZWZvcmUgd2UgZG9u J3QgbmVlZCB0byBhbHdheXMgY2FsbCBwcm9jZXNzQXJndW1lbnRzKCkuCgoqIGRvbS9Eb2N1bWVu dC5jcHA6CihXZWJDb3JlOjpEb2N1bWVudDo6cHJvY2Vzc1ZpZXdwb3J0KToKLS0tCiBXZWJDb3Jl L0NoYW5nZUxvZyAgICAgICAgfCAgIDEzICsrKysrKysrKysrKysKIFdlYkNvcmUvZG9tL0RvY3Vt ZW50LmNwcCB8ICAgIDcgKysrKy0tLQogMiBmaWxlcyBjaGFuZ2VkLCAxNyBpbnNlcnRpb25zKCsp LCAzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29y ZS9DaGFuZ2VMb2cKaW5kZXggNzViY2ZjYy4uY2Y1ZDljYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9D aGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0w NS0xOSAgSmVzdXMgU2FuY2hlei1QYWxlbmNpYSAgPGplc3VzQHdlYmtpdC5vcmc+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRXh0cmEgcHJvY2Vzc2Vz QXJndW1lbnRzKCkgY2FsbHMgaW4gRG9jdW1lbnQ6OnByb2Nlc3NWaWV3cG9ydAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzkzNTgKKworICAgICAgICBU aGUgdmlld3BvcnQgYXJndW1lbnRzIGFyZSBvbmx5IG5lZWRlZCB3aGVuIHRoZXJlIGlzIGEgZnJh bWUtPnBhZ2UoKSwKKyAgICAgICAgdGhlcmVmb3JlIHdlIGRvbid0IG5lZWQgdG8gYWx3YXlzIGNh bGwgcHJvY2Vzc0FyZ3VtZW50cygpLgorCisgICAgICAgICogZG9tL0RvY3VtZW50LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkRvY3VtZW50Ojpwcm9jZXNzVmlld3BvcnQpOgorCiAyMDEwLTA1LTE4 ICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkIGJ1 aWxkIGZpeC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcCBiL1dlYkNvcmUv ZG9tL0RvY3VtZW50LmNwcAppbmRleCAwMWQ2MDhlLi4xYjYxOTZkIDEwMDY0NAotLS0gYS9XZWJD b3JlL2RvbS9Eb2N1bWVudC5jcHAKKysrIGIvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCkBAIC0y MzgwLDExICsyMzgwLDEyIEBAIHZvaWQgRG9jdW1lbnQ6OnByb2Nlc3NWaWV3cG9ydChjb25zdCBT dHJpbmcmIGZlYXR1cmVzKQogICAgIGlmICghZnJhbWUpCiAgICAgICAgIHJldHVybjsKIAotICAg IFZpZXdwb3J0QXJndW1lbnRzIGFyZ3VtZW50czsKLSAgICBwcm9jZXNzQXJndW1lbnRzKGZlYXR1 cmVzLCAodm9pZCopJmFyZ3VtZW50cywgJnNldFZpZXdwb3J0RmVhdHVyZSk7CisgICAgaWYgKGZy YW1lLT5wYWdlKCkpIHsKKyAgICAgICAgVmlld3BvcnRBcmd1bWVudHMgYXJndW1lbnRzOworICAg ICAgICBwcm9jZXNzQXJndW1lbnRzKGZlYXR1cmVzLCAodm9pZCopJmFyZ3VtZW50cywgJnNldFZp ZXdwb3J0RmVhdHVyZSk7CiAKLSAgICBpZiAoZnJhbWUtPnBhZ2UoKSkKICAgICAgICAgZnJhbWUt PnBhZ2UoKS0+Y2hyb21lKCktPmNsaWVudCgpLT5kaWRSZWNlaXZlVmlld3BvcnRBcmd1bWVudHMo ZnJhbWUsIGFyZ3VtZW50cyk7CisgICAgfQogfQogCiBNb3VzZUV2ZW50V2l0aEhpdFRlc3RSZXN1 bHRzIERvY3VtZW50OjpwcmVwYXJlTW91c2VFdmVudChjb25zdCBIaXRUZXN0UmVxdWVzdCYgcmVx dWVzdCwgY29uc3QgSW50UG9pbnQmIGRvY3VtZW50UG9pbnQsIGNvbnN0IFBsYXRmb3JtTW91c2VF dmVudCYgZXZlbnQpCi0tIAoxLjcuMC4zCgo=