39357 2010-05-19 06:45:46 -0700 [QT] QT_BEARER flag is not enabled on S60 properly 2011-04-19 05:15:29 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) S60 Hardware Other CLOSED FIXED P2 Normal --- 39724 0 maheshk webkit-unassigned commit-queue hausmann laszlo.gombos webkit.review.bot yael oldest_to_newest 227801 0 maheshk 2010-05-19 06:45:46 -0700 QT_BEARER is right now only enabled for symbian (on 4.6) and enabled for all 4.7 releases. There is though one problem with the way the flag has been defined. symbian: { exists($${EPOCROOT}epoc32/release/winscw/udeb/QtBearer.lib)| \ exists($${EPOCROOT}epoc32/release/armv5/lib/QtBearer.lib) { DEFINES += ENABLE_QT_BEARER=1 } Mobility builds only after Qt is built so the condition above never satisfies. After talking to vihria, ekoppen, tronical and SaMUELnEVALA on IRC, exists($$[QMAKE_MKSPECS]/features/mobility.prf) can be used to check if qtmobility is built. QtMobility 1.0.0 (public release) has bearer by default on all platform so no need to check for library either. PS: I will attach a patch on the same and may be not with symbian flag as well! 227802 1 yael 2010-05-19 06:50:47 -0700 This is the same issue I reported in https://bugs.webkit.org/show_bug.cgi?id=36617. At the time, I was assured that there was a solution outside of webkit. 227814 2 56488 maheshk 2010-05-19 07:32:54 -0700 Created attachment 56488 proposed solution Enable QT_BEARER flag based on qtmobility availability. As qtmobility 1.0.0 includes bearer manager for all platform no need of symbian check. 227818 3 maheshk 2010-05-19 07:36:31 -0700 (In reply to comment #1) > This is the same issue I reported in https://bugs.webkit.org/show_bug.cgi?id=36617. > At the time, I was assured that there was a solution outside of webkit. Yael, On S60, there were two issues, one the flag not being defined (which was enabled outside webkit), second, navigator.onLine is not modified at all on any connection change. I'm working on the second issue right now Another patch I'm working is on enabling geolocation which again uses qtmobility. This patch sets a base for using qtmobility. 227850 4 56488 laszlo.gombos 2010-05-19 09:14:28 -0700 Comment on attachment 56488 proposed solution > !CONFIG(QTDIR_build):!contains(DEFINES, ENABLE_QT_BEARER=.) { > - symbian: { > - exists($${EPOCROOT}epoc32/release/winscw/udeb/QtBearer.lib)| \ > - exists($${EPOCROOT}epoc32/release/armv5/lib/QtBearer.lib) { > - DEFINES += ENABLE_QT_BEARER=1 > - } I find this existing build logic useful to continue building WebKit trunk for Symbian devices with QtNetwork 4.6 and a separate QtBearer module. We can maybe add an extra guard around this logic to state explicitly that this only make sense if Qt version is less than 4.7, but I prefer not to remove this code. > + exists($$[QMAKE_MKSPECS]/features/mobility.prf) { > + DEFINES += ENABLE_QT_BEARER=1 > } This might make sense for other QtMobility modules (like Geolocation), but it does not make sense to me for BearerMgmt as BearerMgmt is being rolled into QtNetwork and it will not be a separate QtMobility module going forward. We should check for Qt version to see if QtNetwork module supports BearerMgmt, but that is already part of the build system. # Bearer management is part of Qt 4.7 !lessThan(QT_MINOR_VERSION, 7):!contains(DEFINES, ENABLE_QT_BEARER=.):DEFINES += ENABLE_QT_BEARER=1 r- for taking this feature discovery approach for BearerMgmt; this will make more sense to mo for other QtMobility modules (e.g. Geolocation). 227859 5 maheshk 2010-05-19 09:47:20 -0700 Thank you for your comments. Marking the bug resolved. 230668 6 hausmann 2010-05-26 04:38:36 -0700 (In reply to comment #4) > (From update of attachment 56488 [details]) > > !CONFIG(QTDIR_build):!contains(DEFINES, ENABLE_QT_BEARER=.) { > > - symbian: { > > - exists($${EPOCROOT}epoc32/release/winscw/udeb/QtBearer.lib)| \ > > - exists($${EPOCROOT}epoc32/release/armv5/lib/QtBearer.lib) { > > - DEFINES += ENABLE_QT_BEARER=1 > > - } > > I find this existing build logic useful to continue building WebKit trunk for Symbian devices with QtNetwork 4.6 and a separate QtBearer module. We can maybe add an extra guard around this logic to state explicitly that this only make sense if Qt version is less than 4.7, but I prefer not to remove this code. The problem with the existing logic is that it breaks the build in this setup: 1) Symbian^3 (coming with Qt and the bearer libs in the above location) 2) You compile Qt yourself (in say \dev\myqt) 3) Then you try to compile WebKit and it thinks that Qt is configured with mobility support, which it actually isn't. I think Mahesh's detection is correct here. > > + exists($$[QMAKE_MKSPECS]/features/mobility.prf) { > > + DEFINES += ENABLE_QT_BEARER=1 > > } > > This might make sense for other QtMobility modules (like Geolocation), but it does not make sense to me for BearerMgmt as BearerMgmt is being rolled into QtNetwork and it will not be a separate QtMobility module going forward. > > We should check for Qt version to see if QtNetwork module supports BearerMgmt, but that is already part of the build system. Right, we do that already below. But shouldn't we keep the existing support for Qt 4.6 + bearer management around, too, for Symbian^3? I'd like to refine the existing check to work better (more reliable and cross-platform) and I think we should use the same check in general for future modules provided by the Qt Mobility project. > # Bearer management is part of Qt 4.7 > !lessThan(QT_MINOR_VERSION, 7):!contains(DEFINES, ENABLE_QT_BEARER=.):DEFINES += ENABLE_QT_BEARER=1 > > r- for taking this feature discovery approach for BearerMgmt; this will make more sense to mo for other QtMobility modules (e.g. Geolocation). 230669 7 hausmann 2010-05-26 04:40:51 -0700 (In reply to comment #2) > Created an attachment (id=56488) [details] > proposed solution > > Enable QT_BEARER flag based on qtmobility availability. As qtmobility 1.0.0 includes bearer manager for all platform no need of symbian check. I think we should take this patch in. At the very least it fixes the build issues I outlined earlier (a not unusual setup for Qt + WebKit development on Symbian^3 IMHO) and it shouldn't break anything either :) 230683 8 laszlo.gombos 2010-05-26 05:47:19 -0700 (In reply to comment #7) > (In reply to comment #2) > > Created an attachment (id=56488) [details] [details] > > proposed solution > > > > Enable QT_BEARER flag based on qtmobility availability. As qtmobility 1.0.0 includes bearer manager for all platform no need of symbian check. > > I think we should take this patch in. At the very least it fixes the build issues I outlined earlier (a not unusual setup for Qt + WebKit development on Symbian^3 IMHO) and it shouldn't break anything either :) But how can we detect BearerMgmt support reliably ? My understanding is that one can have mobility.prf without BearerMgmt support (as that can be turned off at configure time). The reliably way seems to me to actually look inside mobility.prf to see if BearerMgmt was enabled. 230684 9 56488 laszlo.gombos 2010-05-26 05:47:53 -0700 Comment on attachment 56488 proposed solution Putting back the r? as this patch is now being reconsidered. 230712 10 hausmann 2010-05-26 08:02:31 -0700 (In reply to comment #8) > (In reply to comment #7) > > (In reply to comment #2) > > > Created an attachment (id=56488) [details] [details] [details] > > > proposed solution > > > > > > Enable QT_BEARER flag based on qtmobility availability. As qtmobility 1.0.0 includes bearer manager for all platform no need of symbian check. > > > > I think we should take this patch in. At the very least it fixes the build issues I outlined earlier (a not unusual setup for Qt + WebKit development on Symbian^3 IMHO) and it shouldn't break anything either :) > > But how can we detect BearerMgmt support reliably ? My understanding is that one can have mobility.prf without BearerMgmt support (as that can be turned off at configure time). You're right, that's currently not possible. Oops. I'll see if that can be fixed. 234181 11 hausmann 2010-06-04 06:08:22 -0700 Ok, Alex fixed this upstream: http://qt.gitorious.org/qt-mobility/qt-mobility/commit/480959c68fb1071bd77b503988b63f4e80387489 load(mobilityconfig) contains(MOBILITY_CONFIG, bearer) { message(Bearer API available) CONFIG+=mobility MOBILITY+=bearer } else { message(Bearer API NOT available) } 234810 12 maheshk 2010-06-07 05:51:07 -0700 re-opening the bug to use solution Simon suggested 234812 13 58019 maheshk 2010-06-07 06:05:55 -0700 Created attachment 58019 solution as suggest by Simon enable bearer flag based on mobility configuration OR enable for all qt4.7+ Load mobility only for older qt versions as per the current changes. 234813 14 webkit.review.bot 2010-06-07 06:07:04 -0700 Attachment 58019 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 234819 15 58023 maheshk 2010-06-07 06:18:11 -0700 Created attachment 58023 solution as suggest by Simon previous one had a tab in patch as result of log thanks to failure of prepare-changelog script and had to manually edit change log :( 234834 16 58023 hausmann 2010-06-07 07:12:26 -0700 Comment on attachment 58023 solution as suggest by Simon r=me, this certainly improves the situation :) (QtMobility 1.0.1 is required for that to work) A next step would be to always do the load(mobilityconfig) at the top of WebKit.pri and then use it throughout the other places I guess 234842 17 58023 commit-queue 2010-06-07 07:29:22 -0700 Comment on attachment 58023 solution as suggest by Simon Clearing flags on attachment: 58023 Committed r60780: <http://trac.webkit.org/changeset/60780> 234843 18 commit-queue 2010-06-07 07:29:29 -0700 All reviewed patches have been landed. Closing bug. 235262 19 laszlo.gombos 2010-06-08 08:26:26 -0700 This created a warning when QtMobility is not available. Following change would fix it: Index: WebCore/WebCore.pri =================================================================== --- WebCore/WebCore.pri (revision 60842) +++ WebCore/WebCore.pri (working copy) @@ -115,7 +115,7 @@ !lessThan(QT_MINOR_VERSION, 7) { DEFINES += ENABLE_QT_BEARER=1 } else { - load(mobilityconfig) + exists($$[QMAKE_MKSPECS]/features/mobility.prf): load(mobilityconfig) contains(MOBILITY_CONFIG, bearer) { DEFINES += ENABLE_QT_BEARER=1 } 235267 20 58142 laszlo.gombos 2010-06-08 08:40:18 -0700 Created attachment 58142 fix build warning 236284 21 hausmann 2010-06-10 03:33:06 -0700 Revision r60780 cherry-picked into qtwebkit-2.0 with commit f3dc6deef5a85d6c7ae13c6c7b37e7da50e20233 236289 22 hausmann 2010-06-10 03:46:13 -0700 (In reply to comment #19) > This created a warning when QtMobility is not available. Following change would fix it: > > Index: WebCore/WebCore.pri > =================================================================== > --- WebCore/WebCore.pri (revision 60842) > +++ WebCore/WebCore.pri (working copy) > @@ -115,7 +115,7 @@ > !lessThan(QT_MINOR_VERSION, 7) { > DEFINES += ENABLE_QT_BEARER=1 > } else { > - load(mobilityconfig) > + exists($$[QMAKE_MKSPECS]/features/mobility.prf): load(mobilityconfig) > contains(MOBILITY_CONFIG, bearer) { > DEFINES += ENABLE_QT_BEARER=1 > } A better fix is to replace load(mobilityconfig) with load(mobilityconfig,true) where the second argument (true) means: ignore errors when loading 236305 23 maheshk 2010-06-10 04:37:53 -0700 (In reply to comment #22) > (In reply to comment #19) > > This created a warning when QtMobility is not available. Following change would fix it: > > > > Index: WebCore/WebCore.pri > > =================================================================== > > --- WebCore/WebCore.pri (revision 60842) > > +++ WebCore/WebCore.pri (working copy) > > @@ -115,7 +115,7 @@ > > !lessThan(QT_MINOR_VERSION, 7) { > > DEFINES += ENABLE_QT_BEARER=1 > > } else { > > - load(mobilityconfig) > > + exists($$[QMAKE_MKSPECS]/features/mobility.prf): load(mobilityconfig) > > contains(MOBILITY_CONFIG, bearer) { > > DEFINES += ENABLE_QT_BEARER=1 > > } > > A better fix is to replace > > load(mobilityconfig) > > with > > load(mobilityconfig,true) > > where the second argument (true) means: ignore errors when loading Nice! Thanks patch from 39724 covers the change for this case as well as we will be loading mobilityconfig only once. 236389 24 58142 laszlo.gombos 2010-06-10 09:19:29 -0700 Comment on attachment 58142 fix build warning Marking obsolete as a better solution is on its way (see bug 39724) and it is not time critical to resolve this. 56488 2010-05-19 07:32:54 -0700 2010-06-07 06:05:55 -0700 proposed solution bearer_flag.patch text/plain 1199 maheshk SW5kZXg6IFdlYkNvcmUvV2ViQ29yZS5wcmkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9XZWJDb3Jl LnByaQkocmV2aXNpb24gNTk2MDMpCisrKyBXZWJDb3JlL1dlYkNvcmUucHJpCSh3b3JraW5nIGNv cHkpCkBAIC0xMDksMTEgKzEwOSw4IEBACiB9CiAKICFDT05GSUcoUVRESVJfYnVpbGQpOiFjb250 YWlucyhERUZJTkVTLCBFTkFCTEVfUVRfQkVBUkVSPS4pIHsKLSAgICBzeW1iaWFuOiB7Ci0gICAg ICAgIGV4aXN0cygkJHtFUE9DUk9PVH1lcG9jMzIvcmVsZWFzZS93aW5zY3cvdWRlYi9RdEJlYXJl ci5saWIpfCBcCi0gICAgICAgIGV4aXN0cygkJHtFUE9DUk9PVH1lcG9jMzIvcmVsZWFzZS9hcm12 NS9saWIvUXRCZWFyZXIubGliKSB7Ci0gICAgICAgICAgICBERUZJTkVTICs9IEVOQUJMRV9RVF9C RUFSRVI9MQotICAgICAgICB9CisgICAgZXhpc3RzKCQkW1FNQUtFX01LU1BFQ1NdL2ZlYXR1cmVz L21vYmlsaXR5LnByZikgeworICAgICAgIERFRklORVMgKz0gRU5BQkxFX1FUX0JFQVJFUj0xCiAg ICAgfQogfQogCkluZGV4OiBXZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3Jl L0NoYW5nZUxvZwkocmV2aXNpb24gNTk3NjIpCisrKyBXZWJDb3JlL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEwLTA1LTE5ICBNYWhlc2ggS3VsYWtybmkgIDxt YWhlc2gua3Vsa2FybmlAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFtRVF0gUVRfQkVBUkVSIGZsYWcgaXMgbm90IGVuYWJsZWQgb24g UzYwIHByb3Blcmx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0zOTM1NworCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gKE9PUFMhKQorCisgICAgICAgICog V2ViQ29yZS5wcmk6IGVuYWJsZSBRVF9CRUFSRVIgZm9yIGFsbCBwbGF0Zm9ybSBiYXNlZCBvbiBx dG1vYmlsaXR5IGF2YWlsYWJpbGl0eQorCiAyMDEwLTA1LTE5ICBBbGV4YW5kZXIgUGF2bG92ICA8 YXBhdmxvdkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgSmVyZW15IE9ybG93 Lgo= 58019 2010-06-07 06:05:55 -0700 2010-06-07 06:18:11 -0700 solution as suggest by Simon enable_bearer.patch text/plain 1734 maheshk SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MDc3NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMDYtMDcgIE1haGVzaCBLdWxha3JuaSAgPG1haGVzaC5rdWxr YXJuaUBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgW1FUXSBRVF9CRUFSRVIgZmxhZyBpcyBub3QgZW5hYmxlZCBvbiBTNjAgcHJvcGVy bHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5MzU3 CisKKyAgICAgICAgKiBXZWJDb3JlLnByaTogZW5hYmxlIFFUX0JFQVJFUiBmb3IgYWxsIHBsYXRm b3JtIGJhc2VkIG9uIHF0bW9iaWxpdHkgKworCWJlYXJlciBtb2R1bGUgYXZhaWxhYmlsaXR5IG9y IGZvciBxdCA0LjcrCisKIDIwMTAtMDYtMDcgIFBhdmVsIFBvZGl2aWxvdiAgPHBvZGl2aWxvdkBj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgUGF2ZWwgRmVsZG1hbi4KSW5kZXg6 IFdlYkNvcmUvV2ViQ29yZS5wcmkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9XZWJDb3JlLnByaQko cmV2aXNpb24gNjA3NzQpCisrKyBXZWJDb3JlL1dlYkNvcmUucHJpCSh3b3JraW5nIGNvcHkpCkBA IC0xMDksMTggKzEwOSwxOSBAQCBncmVhdGVyVGhhbihRVF9NSU5PUl9WRVJTSU9OLCA1KSB7CiAg ICAgZWxzZTpERUZJTkVTICs9IEVOQUJMRV9YU0xUPTAKIH0KIAotIUNPTkZJRyhRVERJUl9idWls ZCk6IWNvbnRhaW5zKERFRklORVMsIEVOQUJMRV9RVF9CRUFSRVI9LikgewotICAgIHN5bWJpYW46 IHsKLSAgICAgICAgZXhpc3RzKCQke0VQT0NST09UfWVwb2MzMi9yZWxlYXNlL3dpbnNjdy91ZGVi L1F0QmVhcmVyLmxpYil8IFwKLSAgICAgICAgZXhpc3RzKCQke0VQT0NST09UfWVwb2MzMi9yZWxl YXNlL2FybXY1L2xpYi9RdEJlYXJlci5saWIpIHsKKyMgQmVhcmVyIG1hbmFnZW1lbnQgaXMgcGFy dCBvZiBRdCA0LjcKKyMgZm9yIG9sZGVyIHZlcnNpb24sIGNoZWNrIGZvciBtb2JpbGl0eSB3aXRo IGJlYXJlciAKKyFjb250YWlucyhERUZJTkVTLCBFTkFCTEVfUVRfQkVBUkVSPS4pIHsKKyAgICAg IWxlc3NUaGFuKFFUX01JTk9SX1ZFUlNJT04sIDcpIHsKKyAgICAgICAgREVGSU5FUyArPSBFTkFC TEVfUVRfQkVBUkVSPTEKKyAgICAgfSBlbHNlIHsKKyAgICAgICAgbG9hZChtb2JpbGl0eWNvbmZp ZykKKyAgICAgICAgY29udGFpbnMoTU9CSUxJVFlfQ09ORklHLCBiZWFyZXIpIHsKICAgICAgICAg ICAgIERFRklORVMgKz0gRU5BQkxFX1FUX0JFQVJFUj0xCiAgICAgICAgIH0KICAgICB9CiB9CiAK LSMgQmVhcmVyIG1hbmFnZW1lbnQgaXMgcGFydCBvZiBRdCA0LjcKLSFsZXNzVGhhbihRVF9NSU5P Ul9WRVJTSU9OLCA3KTohY29udGFpbnMoREVGSU5FUywgRU5BQkxFX1FUX0JFQVJFUj0uKTpERUZJ TkVTICs9IEVOQUJMRV9RVF9CRUFSRVI9MQotCiAjIEVuYWJsZSB0b3VjaCBldmVudCBzdXBwb3J0 IHdpdGggUXQgNC42CiAhbGVzc1RoYW4oUVRfTUlOT1JfVkVSU0lPTiwgNik6IERFRklORVMgKz0g RU5BQkxFX1RPVUNIX0VWRU5UUz0xCiAK 58023 2010-06-07 06:18:11 -0700 2010-06-07 07:29:22 -0700 solution as suggest by Simon enable_bearer.patch text/plain 1754 maheshk SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MDc3NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDYtMDcgIE1haGVzaCBLdWxha3JuaSAgPG1haGVzaC5rdWxr YXJuaUBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgW1FUXSBRVF9CRUFSRVIgZmxhZyBpcyBub3QgZW5hYmxlZCBvbiBTNjAgcHJvcGVy bHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5MzU3 CisKKyAgICAgICAgZW5hYmxlIFFUX0JFQVJFUiBmb3IgYWxsIHBsYXRmb3JtIGJhc2VkIG9uIHF0 bW9iaWxpdHkgKyAKKyAgICAgICAgYmVhcmVyIG1vZHVsZSBhdmFpbGFiaWxpdHkgb3IgZm9yIHF0 IDQuNysKKworICAgICAgICAqIFdlYkNvcmUucHJpOiAKKwogMjAxMC0wNi0wNyAgUGF2ZWwgUG9k aXZpbG92ICA8cG9kaXZpbG92QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBQ YXZlbCBGZWxkbWFuLgpJbmRleDogV2ViQ29yZS9XZWJDb3JlLnByaQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJDb3JlL1dlYkNvcmUucHJpCShyZXZpc2lvbiA2MDc3NCkKKysrIFdlYkNvcmUvV2ViQ29yZS5w cmkJKHdvcmtpbmcgY29weSkKQEAgLTEwOSwxOCArMTA5LDE5IEBAIGdyZWF0ZXJUaGFuKFFUX01J Tk9SX1ZFUlNJT04sIDUpIHsKICAgICBlbHNlOkRFRklORVMgKz0gRU5BQkxFX1hTTFQ9MAogfQog Ci0hQ09ORklHKFFURElSX2J1aWxkKTohY29udGFpbnMoREVGSU5FUywgRU5BQkxFX1FUX0JFQVJF Uj0uKSB7Ci0gICAgc3ltYmlhbjogewotICAgICAgICBleGlzdHMoJCR7RVBPQ1JPT1R9ZXBvYzMy L3JlbGVhc2Uvd2luc2N3L3VkZWIvUXRCZWFyZXIubGliKXwgXAotICAgICAgICBleGlzdHMoJCR7 RVBPQ1JPT1R9ZXBvYzMyL3JlbGVhc2UvYXJtdjUvbGliL1F0QmVhcmVyLmxpYikgeworIyBCZWFy ZXIgbWFuYWdlbWVudCBpcyBwYXJ0IG9mIFF0IDQuNworIyBmb3Igb2xkZXIgdmVyc2lvbiwgY2hl Y2sgZm9yIG1vYmlsaXR5IHdpdGggYmVhcmVyIAorIWNvbnRhaW5zKERFRklORVMsIEVOQUJMRV9R VF9CRUFSRVI9LikgeworICAgICAhbGVzc1RoYW4oUVRfTUlOT1JfVkVSU0lPTiwgNykgeworICAg ICAgICBERUZJTkVTICs9IEVOQUJMRV9RVF9CRUFSRVI9MQorICAgICB9IGVsc2UgeworICAgICAg ICBsb2FkKG1vYmlsaXR5Y29uZmlnKQorICAgICAgICBjb250YWlucyhNT0JJTElUWV9DT05GSUcs IGJlYXJlcikgewogICAgICAgICAgICAgREVGSU5FUyArPSBFTkFCTEVfUVRfQkVBUkVSPTEKICAg ICAgICAgfQogICAgIH0KIH0KIAotIyBCZWFyZXIgbWFuYWdlbWVudCBpcyBwYXJ0IG9mIFF0IDQu NwotIWxlc3NUaGFuKFFUX01JTk9SX1ZFUlNJT04sIDcpOiFjb250YWlucyhERUZJTkVTLCBFTkFC TEVfUVRfQkVBUkVSPS4pOkRFRklORVMgKz0gRU5BQkxFX1FUX0JFQVJFUj0xCi0KICMgRW5hYmxl IHRvdWNoIGV2ZW50IHN1cHBvcnQgd2l0aCBRdCA0LjYKICFsZXNzVGhhbihRVF9NSU5PUl9WRVJT SU9OLCA2KTogREVGSU5FUyArPSBFTkFCTEVfVE9VQ0hfRVZFTlRTPTEKIAo= 58142 2010-06-08 08:40:18 -0700 2010-06-10 09:19:29 -0700 fix build warning 39357.patch text/plain 1208 laszlo.gombos SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MDg0NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDYtMDggIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21i b3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFtRVF0gUVRfQkVBUkVSIGZsYWcgaXMgbm90IGVuYWJsZWQgb24gUzYwIHByb3Blcmx5 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zOTM1Nwor CisgICAgICAgIE9ubHkgbG9hZCBtb2JpbGl0eWNvbmZpZyBpZiB0aGUgbW9iaWxpdHkucHJmIGZp bGUgZXhpc3RzIHRvCisgICAgICAgIHNpbGVuY2UgYnVpbGQgd2FybmluZy4KKworICAgICAgICBO byBuZXcgdGVzdHMgYXMgdGhlcmUgaXMgbm8gbmV3IGZ1bmN0aW9uYWxpdHkuCisKKyAgICAgICAg KiBXZWJDb3JlLnByaToKKwogMjAxMC0wNi0wOCAgWXVyeSBTZW1pa2hhdHNreSAgPHl1cnlzQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBQYXZlbCBGZWxkbWFuLgpJbmRleDog V2ViQ29yZS9XZWJDb3JlLnByaQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL1dlYkNvcmUucHJpCShy ZXZpc2lvbiA2MDg0MikKKysrIFdlYkNvcmUvV2ViQ29yZS5wcmkJKHdvcmtpbmcgY29weSkKQEAg LTExNSw3ICsxMTUsNyBAQCBncmVhdGVyVGhhbihRVF9NSU5PUl9WRVJTSU9OLCA1KSB7CiAgICAg ICFsZXNzVGhhbihRVF9NSU5PUl9WRVJTSU9OLCA3KSB7CiAgICAgICAgIERFRklORVMgKz0gRU5B QkxFX1FUX0JFQVJFUj0xCiAgICAgIH0gZWxzZSB7Ci0gICAgICAgIGxvYWQobW9iaWxpdHljb25m aWcpCisgICAgICAgIGV4aXN0cygkJFtRTUFLRV9NS1NQRUNTXS9mZWF0dXJlcy9tb2JpbGl0eS5w cmYpOiBsb2FkKG1vYmlsaXR5Y29uZmlnKQogICAgICAgICBjb250YWlucyhNT0JJTElUWV9DT05G SUcsIGJlYXJlcikgewogICAgICAgICAgICAgREVGSU5FUyArPSBFTkFCTEVfUVRfQkVBUkVSPTEK ICAgICAgICAgfQo=