39350 2010-05-19 01:54:02 -0700 Add support for handling basic <script> tags in the HTML5 Parser 2010-05-19 12:02:49 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 39259 1 eric webkit-unassigned abarth webkit-ews oldest_to_newest 227743 0 eric 2010-05-19 01:54:02 -0700 Add support for handling basic <script> tags in the HTML5 Parser 227745 1 56476 eric 2010-05-19 02:00:30 -0700 Created attachment 56476 Patch 227746 2 webkit-ews 2010-05-19 02:04:54 -0700 Attachment 56476 did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/2264310 227748 3 eric 2010-05-19 02:07:14 -0700 Attachment 56476 did not build on mac: Build output: http://webkit-commit-queue.appspot.com/results/2318302 227749 4 56477 eric 2010-05-19 02:10:42 -0700 Created attachment 56477 A patch that actually works 227750 5 56477 eric 2010-05-19 02:31:30 -0700 Comment on attachment 56477 A patch that actually works The attached patch works enough to make: <div>Hello</div> <script> alert(42) </script> <div>Bye</div> work. The rest of the HTML5 parser isn't complete enough to make html5lib/runner.html work yet though. 227830 6 56477 abarth 2010-05-19 08:08:30 -0700 Comment on attachment 56477 A patch that actually works Looks reasonable. We'll probably need to move this somewhere else. I tested this locally and it worked. 227934 7 eric 2010-05-19 12:02:49 -0700 Committed r59778: <http://trac.webkit.org/changeset/59778> 56476 2010-05-19 02:00:30 -0700 2010-05-19 02:10:06 -0700 Patch bug-39350-20100519020029.patch text/plain 3000 eric ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NGRlOTVkOWUyNmM5MDEyNTVmYjgwN2FlZDY3MTYxZWU4OGE1MTViZi4uZWJkZDI1ZDdkNzk5MzI2 NjViNTNiMzkyZjhiMWNiY2Y5MTZhNjE0YSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNSBAQAorMjAxMC0wNS0xOSAgRXJp YyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQWRkIHN1cHBvcnQgZm9yIGhhbmRsaW5nIGJhc2ljIDxzY3Jp cHQ+IHRhZ3MgaW4gdGhlIEhUTUw1IFBhcnNlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzkzNTAKKworICAgICAgICBXZWJLaXQgY3VycmVudGx5IGV4 ZWN1dGVzIHNjcmlwdHMgZnJvbSBIVE1MVG9rZW5pemVyIGluIG9uZSBnaWFnYW50aWMKKyAgICAg ICAgaGFjay4gIEhUTUwgNSByZXF1aXJlcyB0aGF0IHdlIGV4ZWN1dGUgc2NyaXB0cyBmcm9tIHRo ZSB0cmVlLWJ1aWxkZXJzL3BhcnNlci4KKworICAgICAgICBJdCB3aWxsIHRha2UgbWUgYSB3aGls ZSB0byByZS1mYWN0b3IgZW5vdWdoIG9mIEhUTUxUb2tlbml6ZXIgdG8gYmUgYWJsZSB0bworICAg ICAgICBtb3ZlIHRoZSBzY3JpcHQgZXhlY3V0aW9uIGxvZ2ljIHdpdGhvdXQgYnJlYWtpbmcgdGhp bmdzLiAgSW4gdGhlIGludGVyZXN0CisgICAgICAgIG9mIGFsbG93aW5nIEFkYW0gdG8gY29udGlu dWUgaW1wcm92aW5nIHRoZSBIVE1MIDUgbGV4ZXIgSSd2ZSBhZGRlZCB0aGlzCisgICAgICAgIHZl cnkgYmFzaWMgKGFuZCB2ZXJ5IGluY29tcGxldGUpIDxzY3JpcHQ+IHN1cHBvcnQgdG8gdGhlIEhU TUwgNSBwYXJzZXIgY29kZQorICAgICAgICBwYXRoIHNvIHRoZSBoZSBjYW4gcnVuIHRoZSBIVE1M NSBwYXJzZXIgdGVzdCBzdWl0ZS4KKworICAgICAgICA8c2NyaXB0PiBzdXBwb3J0IGlzIHRlc3Rl ZCBieSBtb3N0IG9mIHRoZSBsYXlvdXQgdGVzdHMuCisKKyAgICAgICAgKiBkb20vU2NyaXB0RWxl bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjp1c2VIVE1MNVBhcnNlcik6CisgICAgICAgIChX ZWJDb3JlOjpTY3JpcHRFbGVtZW50OjpmaW5pc2hQYXJzaW5nQ2hpbGRyZW4pOgorCiAyMDEwLTA1 LTE5ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgRGF2aWQgSHlhdHQuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2RvbS9TY3JpcHRFbGVtZW50LmNw cCBiL1dlYkNvcmUvZG9tL1NjcmlwdEVsZW1lbnQuY3BwCmluZGV4IDIyZDY5ODE4OGQ1OTc3Mjk1 MjQ4NzRhMmQzZDBmZjYzYzA2MDY1NjkuLjUxMzc4ODgxNWVhNzNmNmI2NmZhODIwYWU3YzQxZGM2 NjQ4YWZlOGQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvZG9tL1NjcmlwdEVsZW1lbnQuY3BwCisrKyBi L1dlYkNvcmUvZG9tL1NjcmlwdEVsZW1lbnQuY3BwCkBAIC04MiwxMiArODIsMjggQEAgdm9pZCBT Y3JpcHRFbGVtZW50OjpjaGlsZHJlbkNoYW5nZWQoU2NyaXB0RWxlbWVudERhdGEmIGRhdGEpCiAg ICAgICAgIGRhdGEuZXZhbHVhdGVTY3JpcHQoU2NyaXB0U291cmNlQ29kZShkYXRhLnNjcmlwdENv bnRlbnQoKSwgZWxlbWVudC0+ZG9jdW1lbnQoKS0+dXJsKCkpKTsgLy8gRklYTUU6IFByb3ZpZGUg YSByZWFsIHN0YXJ0aW5nIGxpbmUgbnVtYmVyIGhlcmUKIH0KIAorc3RhdGljIGlubGluZSB1c2VI VE1MNVBhcnNlcihEb2N1bWVudCogZG9jdW1lbnQpCit7CisgICAgQVNTRVJUKGRvY3VtZW50KTsK KyAgICBTZXR0aW5ncyogc2V0dGluZ3MgPSBkb2N1bWVudC0+cGFnZSgpID8gZG9jdW1lbnQtPnBh Z2UoKS0+c2V0dGluZ3MoKSA6IDA7CisgICAgcmV0dXJuIHNldHRpbmdzICYmIHNldHRpbmdzLT5o dG1sNVBhcnNlckVuYWJsZWQoKTsKK30KKwogdm9pZCBTY3JpcHRFbGVtZW50OjpmaW5pc2hQYXJz aW5nQ2hpbGRyZW4oU2NyaXB0RWxlbWVudERhdGEmIGRhdGEsIGNvbnN0IFN0cmluZyYgc291cmNl VXJsKQogewogICAgIC8vIFRoZSBwYXJzZXIganVzdCByZWFjaGVkIDwvc2NyaXB0Pi4gSWYgd2Ug aGF2ZSBubyBzcmMgYW5kIG5vIHRleHQsCiAgICAgLy8gYWxsb3cgZHluYW1pYyBsb2FkaW5nIGxh dGVyLgogICAgIGlmIChzb3VyY2VVcmwuaXNFbXB0eSgpICYmIGRhdGEuc2NyaXB0Q29udGVudCgp LmlzRW1wdHkoKSkKICAgICAgICAgZGF0YS5zZXRDcmVhdGVkQnlQYXJzZXIoZmFsc2UpOworICAg IC8vIEhUTUw1IFJlcXVpcmVzIHRoYXQgd2UgZXhlY3V0ZSBzY3JpcHRzIGZyb20gdGhlIHBhcnNl ciwgbm90IGZyb20KKyAgICAvLyBIVE1MVG9rZW5pemVyIGxpa2Ugd2UgY3VycmVudGx5IGRvLgor ICAgIC8vIEZJWE1FOiBJdCBtYXkgbm90IGJlIHNhZmUgdG8gZXhlY3V0ZSBzY3JpcHRzIGZyb20g aGVyZSBpZgorICAgIC8vIEhUTUxQYXJzZXI6OnBvcE9uZUJsb2NrQ29tbW9uIGlzIG5vdCByZWVu dHJhbnQuCisgICAgZWxzZSBpZiAodXNlSFRNTDVQYXJzZXIobV9lbGVtZW50LT5kb2N1bWVudCgp KSkgeworICAgICAgICAvLyBUaGlzIGlzIGN1cnJlbnRseSBhbiBpbmNvbXBsZXRlIGltcGxlbWVu dGF0aW9uLCBzZWU6CisgICAgICAgIC8vIGh0dHA6Ly93d3cud2hhdHdnLm9yZy9zcGVjcy93ZWIt YXBwcy9jdXJyZW50LXdvcmsvbXVsdGlwYWdlL3Rva2VuaXphdGlvbi5odG1sI3BhcnNpbmctbWFp bi1pbmNkYXRhCisgICAgICAgIGRhdGEuZXZhbHVhdGVTY3JpcHQoU2NyaXB0U291cmNlQ29kZShk YXRhLnNjcmlwdENvbnRlbnQoKSwgZWxlbWVudC0+ZG9jdW1lbnQoKS0+dXJsKCkpKTsgLy8gRklY TUU6IFByb3ZpZGUgYSByZWFsIHN0YXJ0aW5nIGxpbmUgbnVtYmVyIGhlcmUKKyAgICB9CiB9CiAK IHZvaWQgU2NyaXB0RWxlbWVudDo6aGFuZGxlU291cmNlQXR0cmlidXRlKFNjcmlwdEVsZW1lbnRE YXRhJiBkYXRhLCBjb25zdCBTdHJpbmcmIHNvdXJjZVVybCkK 56477 2010-05-19 02:10:42 -0700 2010-05-19 08:08:29 -0700 A patch that actually works bug-39350-20100519021040.patch text/plain 3328 eric ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NGRlOTVkOWUyNmM5MDEyNTVmYjgwN2FlZDY3MTYxZWU4OGE1MTViZi4uZWJkZDI1ZDdkNzk5MzI2 NjViNTNiMzkyZjhiMWNiY2Y5MTZhNjE0YSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNSBAQAorMjAxMC0wNS0xOSAgRXJp YyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQWRkIHN1cHBvcnQgZm9yIGhhbmRsaW5nIGJhc2ljIDxzY3Jp cHQ+IHRhZ3MgaW4gdGhlIEhUTUw1IFBhcnNlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzkzNTAKKworICAgICAgICBXZWJLaXQgY3VycmVudGx5IGV4 ZWN1dGVzIHNjcmlwdHMgZnJvbSBIVE1MVG9rZW5pemVyIGluIG9uZSBnaWFnYW50aWMKKyAgICAg ICAgaGFjay4gIEhUTUwgNSByZXF1aXJlcyB0aGF0IHdlIGV4ZWN1dGUgc2NyaXB0cyBmcm9tIHRo ZSB0cmVlLWJ1aWxkZXJzL3BhcnNlci4KKworICAgICAgICBJdCB3aWxsIHRha2UgbWUgYSB3aGls ZSB0byByZS1mYWN0b3IgZW5vdWdoIG9mIEhUTUxUb2tlbml6ZXIgdG8gYmUgYWJsZSB0bworICAg ICAgICBtb3ZlIHRoZSBzY3JpcHQgZXhlY3V0aW9uIGxvZ2ljIHdpdGhvdXQgYnJlYWtpbmcgdGhp bmdzLiAgSW4gdGhlIGludGVyZXN0CisgICAgICAgIG9mIGFsbG93aW5nIEFkYW0gdG8gY29udGlu dWUgaW1wcm92aW5nIHRoZSBIVE1MIDUgbGV4ZXIgSSd2ZSBhZGRlZCB0aGlzCisgICAgICAgIHZl cnkgYmFzaWMgKGFuZCB2ZXJ5IGluY29tcGxldGUpIDxzY3JpcHQ+IHN1cHBvcnQgdG8gdGhlIEhU TUwgNSBwYXJzZXIgY29kZQorICAgICAgICBwYXRoIHNvIHRoZSBoZSBjYW4gcnVuIHRoZSBIVE1M NSBwYXJzZXIgdGVzdCBzdWl0ZS4KKworICAgICAgICA8c2NyaXB0PiBzdXBwb3J0IGlzIHRlc3Rl ZCBieSBtb3N0IG9mIHRoZSBsYXlvdXQgdGVzdHMuCisKKyAgICAgICAgKiBkb20vU2NyaXB0RWxl bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjp1c2VIVE1MNVBhcnNlcik6CisgICAgICAgIChX ZWJDb3JlOjpTY3JpcHRFbGVtZW50OjpmaW5pc2hQYXJzaW5nQ2hpbGRyZW4pOgorCiAyMDEwLTA1 LTE5ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgRGF2aWQgSHlhdHQuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2RvbS9TY3JpcHRFbGVtZW50LmNw cCBiL1dlYkNvcmUvZG9tL1NjcmlwdEVsZW1lbnQuY3BwCmluZGV4IDIyZDY5ODE4OGQ1OTc3Mjk1 MjQ4NzRhMmQzZDBmZjYzYzA2MDY1NjkuLmI0NTdmNWQzOTY5NGVjYmFhZWM0OWE5YmFmZGNiNjk0 MDJlOTBmOGUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvZG9tL1NjcmlwdEVsZW1lbnQuY3BwCisrKyBi L1dlYkNvcmUvZG9tL1NjcmlwdEVsZW1lbnQuY3BwCkBAIC0zMiw5ICszMiwxMSBAQAogI2luY2x1 ZGUgIkhUTUxOYW1lcy5oIgogI2luY2x1ZGUgIkhUTUxTY3JpcHRFbGVtZW50LmgiCiAjaW5jbHVk ZSAiTUlNRVR5cGVSZWdpc3RyeS5oIgorI2luY2x1ZGUgIlBhZ2UuaCIKICNpbmNsdWRlICJTY3Jp cHRDb250cm9sbGVyLmgiCiAjaW5jbHVkZSAiU2NyaXB0U291cmNlQ29kZS5oIgogI2luY2x1ZGUg IlNjcmlwdFZhbHVlLmgiCisjaW5jbHVkZSAiU2V0dGluZ3MuaCIKICNpbmNsdWRlICJTdHJpbmdI YXNoLmgiCiAjaW5jbHVkZSAiVGV4dC5oIgogI2luY2x1ZGUgPHd0Zi9TdGRMaWJFeHRyYXMuaD4K QEAgLTgyLDEyICs4NCwyOCBAQCB2b2lkIFNjcmlwdEVsZW1lbnQ6OmNoaWxkcmVuQ2hhbmdlZChT Y3JpcHRFbGVtZW50RGF0YSYgZGF0YSkKICAgICAgICAgZGF0YS5ldmFsdWF0ZVNjcmlwdChTY3Jp cHRTb3VyY2VDb2RlKGRhdGEuc2NyaXB0Q29udGVudCgpLCBlbGVtZW50LT5kb2N1bWVudCgpLT51 cmwoKSkpOyAvLyBGSVhNRTogUHJvdmlkZSBhIHJlYWwgc3RhcnRpbmcgbGluZSBudW1iZXIgaGVy ZQogfQogCitzdGF0aWMgaW5saW5lIGJvb2wgdXNlSFRNTDVQYXJzZXIoRG9jdW1lbnQqIGRvY3Vt ZW50KQoreworICAgIEFTU0VSVChkb2N1bWVudCk7CisgICAgU2V0dGluZ3MqIHNldHRpbmdzID0g ZG9jdW1lbnQtPnBhZ2UoKSA/IGRvY3VtZW50LT5wYWdlKCktPnNldHRpbmdzKCkgOiAwOworICAg IHJldHVybiBzZXR0aW5ncyAmJiBzZXR0aW5ncy0+aHRtbDVQYXJzZXJFbmFibGVkKCk7Cit9CisK IHZvaWQgU2NyaXB0RWxlbWVudDo6ZmluaXNoUGFyc2luZ0NoaWxkcmVuKFNjcmlwdEVsZW1lbnRE YXRhJiBkYXRhLCBjb25zdCBTdHJpbmcmIHNvdXJjZVVybCkKIHsKICAgICAvLyBUaGUgcGFyc2Vy IGp1c3QgcmVhY2hlZCA8L3NjcmlwdD4uIElmIHdlIGhhdmUgbm8gc3JjIGFuZCBubyB0ZXh0LAog ICAgIC8vIGFsbG93IGR5bmFtaWMgbG9hZGluZyBsYXRlci4KICAgICBpZiAoc291cmNlVXJsLmlz RW1wdHkoKSAmJiBkYXRhLnNjcmlwdENvbnRlbnQoKS5pc0VtcHR5KCkpCiAgICAgICAgIGRhdGEu c2V0Q3JlYXRlZEJ5UGFyc2VyKGZhbHNlKTsKKyAgICAvLyBIVE1MNSBSZXF1aXJlcyB0aGF0IHdl IGV4ZWN1dGUgc2NyaXB0cyBmcm9tIHRoZSBwYXJzZXIsIG5vdCBmcm9tCisgICAgLy8gSFRNTFRv a2VuaXplciBsaWtlIHdlIGN1cnJlbnRseSBkby4KKyAgICAvLyBGSVhNRTogSXQgbWF5IG5vdCBi ZSBzYWZlIHRvIGV4ZWN1dGUgc2NyaXB0cyBmcm9tIGhlcmUgaWYKKyAgICAvLyBIVE1MUGFyc2Vy Ojpwb3BPbmVCbG9ja0NvbW1vbiBpcyBub3QgcmVlbnRyYW50LgorICAgIGVsc2UgaWYgKHVzZUhU TUw1UGFyc2VyKGRhdGEuZWxlbWVudCgpLT5kb2N1bWVudCgpKSkgeworICAgICAgICAvLyBUaGlz IGlzIGN1cnJlbnRseSBhbiBpbmNvbXBsZXRlIGltcGxlbWVudGF0aW9uLCBzZWU6CisgICAgICAg IC8vIGh0dHA6Ly93d3cud2hhdHdnLm9yZy9zcGVjcy93ZWItYXBwcy9jdXJyZW50LXdvcmsvbXVs dGlwYWdlL3Rva2VuaXphdGlvbi5odG1sI3BhcnNpbmctbWFpbi1pbmNkYXRhCisgICAgICAgIGRh dGEuZXZhbHVhdGVTY3JpcHQoU2NyaXB0U291cmNlQ29kZShkYXRhLnNjcmlwdENvbnRlbnQoKSwg ZGF0YS5lbGVtZW50KCktPmRvY3VtZW50KCktPnVybCgpKSk7IC8vIEZJWE1FOiBQcm92aWRlIGEg cmVhbCBzdGFydGluZyBsaW5lIG51bWJlciBoZXJlCisgICAgfQogfQogCiB2b2lkIFNjcmlwdEVs ZW1lbnQ6OmhhbmRsZVNvdXJjZUF0dHJpYnV0ZShTY3JpcHRFbGVtZW50RGF0YSYgZGF0YSwgY29u c3QgU3RyaW5nJiBzb3VyY2VVcmwpCg==