39332 2010-05-18 16:47:04 -0700 [chromium] Remove obsolete ChromiumBridge code that routes FileSystem calls to WebKitClient 2010-05-19 10:59:13 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 jianli jianli fishd oldest_to_newest 227551 0 jianli 2010-05-18 16:47:04 -0700 We do not need to route the FileSystem calls to WebKitClient any more. We need to remove the obsolete codes. 227552 1 56423 jianli 2010-05-18 16:48:31 -0700 Created attachment 56423 Proposed Patch 227892 2 jianli 2010-05-19 10:59:13 -0700 Committed as http://trac.webkit.org/changeset/59774. 56423 2010-05-18 16:48:31 -0700 2010-05-18 23:19:30 -0700 Proposed Patch 39332 text/plain 6720 jianli ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDZlZmM4ZTUuLjkwYTFhNjkgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDI0IEBACisyMDEwLTA1LTE4ICBKaWFuIExpICA8amlhbmxpQGNocm9taXVtLm9yZz4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgb2Jzb2xl dGUgQ2hyb21pdW1CcmlkZ2UgY29kZSB0aGF0IHJvdXRlcyBGaWxlU3lzdGVtIGNhbGxzIHRvIFdl YktpdENsaWVudC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTM5MzMyCisKKyAgICAgICAgKiBwdWJsaWMvV2ViS2l0Q2xpZW50Lmg6CisgICAgICAgICog c3JjL0Nocm9taXVtQnJpZGdlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNocm9taXVtQnJpZGdl OjpmaWxlRXhpc3RzKToKKyAgICAgICAgKFdlYkNvcmU6OkNocm9taXVtQnJpZGdlOjpkZWxldGVG aWxlKToKKyAgICAgICAgKFdlYkNvcmU6OkNocm9taXVtQnJpZGdlOjpkZWxldGVFbXB0eURpcmVj dG9yeSk6CisgICAgICAgIChXZWJDb3JlOjpDaHJvbWl1bUJyaWRnZTo6Z2V0RmlsZVNpemUpOgor ICAgICAgICAoV2ViQ29yZTo6Q2hyb21pdW1CcmlkZ2U6OmdldEZpbGVNb2RpZmljYXRpb25UaW1l KToKKyAgICAgICAgKFdlYkNvcmU6OkNocm9taXVtQnJpZGdlOjpkaXJlY3RvcnlOYW1lKToKKyAg ICAgICAgKFdlYkNvcmU6OkNocm9taXVtQnJpZGdlOjpwYXRoQnlBcHBlbmRpbmdDb21wb25lbnQp OgorICAgICAgICAoV2ViQ29yZTo6Q2hyb21pdW1CcmlkZ2U6Om1ha2VBbGxEaXJlY3Rvcmllcyk6 CisgICAgICAgIChXZWJDb3JlOjpDaHJvbWl1bUJyaWRnZTo6Z2V0QWJzb2x1dGVQYXRoKToKKyAg ICAgICAgKFdlYkNvcmU6OkNocm9taXVtQnJpZGdlOjppc0RpcmVjdG9yeSk6CisgICAgICAgIChX ZWJDb3JlOjpDaHJvbWl1bUJyaWRnZTo6ZmlsZVBhdGhUb1VSTCk6CisKIDIwMTAtMDUtMTYgIE1p a2UgQmVsc2hlICA8bWJlbHNoZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg RGltaXRyaSBHbGF6a292LgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJL aXRDbGllbnQuaCBiL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViS2l0Q2xpZW50LmgKaW5kZXgg NTg0Njc5ZC4uZDFkYTg4MyAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJL aXRDbGllbnQuaAorKysgYi9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYktpdENsaWVudC5oCkBA IC05NSwyMyArOTUsNiBAQCBwdWJsaWM6CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGNvbnN0IFdlYlVSTCYgdXJsLCBib29sIGlzTG9jYWxTdG9yYWdlKSB7IH0KIAogCi0g ICAgLy8gRmlsZSAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tCi0KLSAgICAvLyBWYXJpb3VzIGZpbGUvZGlyZWN0b3J5IHJlbGF0 ZWQgZnVuY3Rpb25zLiAgVGhlc2UgbWFwIDE6MSB3aXRoCi0gICAgLy8gZnVuY3Rpb25zIGluIFdl YkNvcmUncyBGaWxlU3lzdGVtLmguCi0gICAgdmlydHVhbCBib29sIGZpbGVFeGlzdHMoY29uc3Qg V2ViU3RyaW5nJiBwYXRoKSB7IHJldHVybiBmYWxzZTsgfQotICAgIHZpcnR1YWwgYm9vbCBkZWxl dGVGaWxlKGNvbnN0IFdlYlN0cmluZyYgcGF0aCkgeyByZXR1cm4gZmFsc2U7IH0KLSAgICB2aXJ0 dWFsIGJvb2wgZGVsZXRlRW1wdHlEaXJlY3RvcnkoY29uc3QgV2ViU3RyaW5nJiBwYXRoKSB7IHJl dHVybiBmYWxzZTsgfQotICAgIHZpcnR1YWwgYm9vbCBnZXRGaWxlU2l6ZShjb25zdCBXZWJTdHJp bmcmIHBhdGgsIGxvbmcgbG9uZyYgcmVzdWx0KSB7IHJldHVybiBmYWxzZTsgfQotICAgIHZpcnR1 YWwgYm9vbCBnZXRGaWxlTW9kaWZpY2F0aW9uVGltZShjb25zdCBXZWJTdHJpbmcmIHBhdGgsIGRv dWJsZSYgcmVzdWx0KSB7IHJldHVybiBmYWxzZTsgfQotICAgIHZpcnR1YWwgV2ViU3RyaW5nIGRp cmVjdG9yeU5hbWUoY29uc3QgV2ViU3RyaW5nJiBwYXRoKSB7IHJldHVybiBXZWJTdHJpbmcoKTsg fQotICAgIHZpcnR1YWwgV2ViU3RyaW5nIHBhdGhCeUFwcGVuZGluZ0NvbXBvbmVudChjb25zdCBX ZWJTdHJpbmcmIHBhdGgsIGNvbnN0IFdlYlN0cmluZyYgY29tcG9uZW50KSB7IHJldHVybiBXZWJT dHJpbmcoKTsgfQotICAgIHZpcnR1YWwgYm9vbCBtYWtlQWxsRGlyZWN0b3JpZXMoY29uc3QgV2Vi U3RyaW5nJiBwYXRoKSB7IHJldHVybiBmYWxzZTsgfQotICAgIHZpcnR1YWwgV2ViU3RyaW5nIGdl dEFic29sdXRlUGF0aChjb25zdCBXZWJTdHJpbmcmIHBhdGgpIHsgcmV0dXJuIFdlYlN0cmluZygp OyB9Ci0gICAgdmlydHVhbCBib29sIGlzRGlyZWN0b3J5KGNvbnN0IFdlYlN0cmluZyYgcGF0aCkg eyByZXR1cm4gZmFsc2U7IH0KLSAgICB2aXJ0dWFsIFdlYlVSTCBmaWxlUGF0aFRvVVJMKGNvbnN0 IFdlYlN0cmluZyYgcGF0aCkgeyByZXR1cm4gV2ViVVJMKCk7IH0KLQotCiAgICAgLy8gSGlzdG9y eSAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tCiAKICAgICAvLyBSZXR1cm5zIHRoZSBoYXNoIGZvciB0aGUgZ2l2ZW4gY2Fub25pY2Fs aXplZCBVUkwgZm9yIHVzZSBpbiB2aXNpdGVkCmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0v c3JjL0Nocm9taXVtQnJpZGdlLmNwcCBiL1dlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21pdW1Ccmlk Z2UuY3BwCmluZGV4IGQxODgwMTYuLjQwZmNhNDMgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1 bS9zcmMvQ2hyb21pdW1CcmlkZ2UuY3BwCisrKyBiL1dlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21p dW1CcmlkZ2UuY3BwCkBAIC0yNzgsODYgKzI3OCw2MSBAQCB2b2lkIENocm9taXVtQnJpZGdlOjpw cmVmZXRjaEROUyhjb25zdCBTdHJpbmcmIGhvc3RuYW1lKQogCiBib29sIENocm9taXVtQnJpZGdl OjpmaWxlRXhpc3RzKGNvbnN0IFN0cmluZyYgcGF0aCkKIHsKLSAgICBpZiAod2ViS2l0Q2xpZW50 KCktPmZpbGVTeXN0ZW0oKSkKLSAgICAgICAgcmV0dXJuIHdlYktpdENsaWVudCgpLT5maWxlU3lz dGVtKCktPmZpbGVFeGlzdHMocGF0aCk7Ci0gICAgcmV0dXJuIHdlYktpdENsaWVudCgpLT5maWxl RXhpc3RzKHBhdGgpOworICAgIHJldHVybiB3ZWJLaXRDbGllbnQoKS0+ZmlsZVN5c3RlbSgpLT5m aWxlRXhpc3RzKHBhdGgpOwogfQogCiBib29sIENocm9taXVtQnJpZGdlOjpkZWxldGVGaWxlKGNv bnN0IFN0cmluZyYgcGF0aCkKIHsKLSAgICBpZiAod2ViS2l0Q2xpZW50KCktPmZpbGVTeXN0ZW0o KSkKLSAgICAgICAgcmV0dXJuIHdlYktpdENsaWVudCgpLT5maWxlU3lzdGVtKCktPmRlbGV0ZUZp bGUocGF0aCk7Ci0gICAgcmV0dXJuIHdlYktpdENsaWVudCgpLT5kZWxldGVGaWxlKHBhdGgpOwor ICAgIHJldHVybiB3ZWJLaXRDbGllbnQoKS0+ZmlsZVN5c3RlbSgpLT5kZWxldGVGaWxlKHBhdGgp OwogfQogCiBib29sIENocm9taXVtQnJpZGdlOjpkZWxldGVFbXB0eURpcmVjdG9yeShjb25zdCBT dHJpbmcmIHBhdGgpCiB7Ci0gICAgaWYgKHdlYktpdENsaWVudCgpLT5maWxlU3lzdGVtKCkpCi0g ICAgICAgIHJldHVybiB3ZWJLaXRDbGllbnQoKS0+ZmlsZVN5c3RlbSgpLT5kZWxldGVFbXB0eURp cmVjdG9yeShwYXRoKTsKLSAgICByZXR1cm4gd2ViS2l0Q2xpZW50KCktPmRlbGV0ZUVtcHR5RGly ZWN0b3J5KHBhdGgpOworICAgIHJldHVybiB3ZWJLaXRDbGllbnQoKS0+ZmlsZVN5c3RlbSgpLT5k ZWxldGVFbXB0eURpcmVjdG9yeShwYXRoKTsKIH0KIAogYm9vbCBDaHJvbWl1bUJyaWRnZTo6Z2V0 RmlsZVNpemUoY29uc3QgU3RyaW5nJiBwYXRoLCBsb25nIGxvbmcmIHJlc3VsdCkKIHsKLSAgICBp ZiAod2ViS2l0Q2xpZW50KCktPmZpbGVTeXN0ZW0oKSkKLSAgICAgICAgcmV0dXJuIHdlYktpdENs aWVudCgpLT5maWxlU3lzdGVtKCktPmdldEZpbGVTaXplKHBhdGgsIHJlc3VsdCk7Ci0gICAgcmV0 dXJuIHdlYktpdENsaWVudCgpLT5nZXRGaWxlU2l6ZShwYXRoLCByZXN1bHQpOworICAgIHJldHVy biB3ZWJLaXRDbGllbnQoKS0+ZmlsZVN5c3RlbSgpLT5nZXRGaWxlU2l6ZShwYXRoLCByZXN1bHQp OwogfQogCiBib29sIENocm9taXVtQnJpZGdlOjpnZXRGaWxlTW9kaWZpY2F0aW9uVGltZShjb25z dCBTdHJpbmcmIHBhdGgsIHRpbWVfdCYgcmVzdWx0KQogewogICAgIGRvdWJsZSBtb2RpZmljYXRp b25UaW1lOwotICAgIGlmICh3ZWJLaXRDbGllbnQoKS0+ZmlsZVN5c3RlbSgpKSB7Ci0gICAgICAg IGlmICghd2ViS2l0Q2xpZW50KCktPmZpbGVTeXN0ZW0oKS0+Z2V0RmlsZU1vZGlmaWNhdGlvblRp bWUocGF0aCwgbW9kaWZpY2F0aW9uVGltZSkpCi0gICAgICAgICAgICByZXR1cm4gZmFsc2U7Ci0g ICAgfSBlbHNlIHsKLSAgICAgICAgaWYgKCF3ZWJLaXRDbGllbnQoKS0+Z2V0RmlsZU1vZGlmaWNh dGlvblRpbWUocGF0aCwgbW9kaWZpY2F0aW9uVGltZSkpCi0gICAgICAgICAgICByZXR1cm4gZmFs c2U7Ci0gICAgfQorICAgIGlmICghd2ViS2l0Q2xpZW50KCktPmZpbGVTeXN0ZW0oKS0+Z2V0Rmls ZU1vZGlmaWNhdGlvblRpbWUocGF0aCwgbW9kaWZpY2F0aW9uVGltZSkpCisgICAgICAgIHJldHVy biBmYWxzZTsKICAgICByZXN1bHQgPSBzdGF0aWNfY2FzdDx0aW1lX3Q+KG1vZGlmaWNhdGlvblRp bWUpOwogICAgIHJldHVybiB0cnVlOwogfQogCiBTdHJpbmcgQ2hyb21pdW1CcmlkZ2U6OmRpcmVj dG9yeU5hbWUoY29uc3QgU3RyaW5nJiBwYXRoKQogewotICAgIGlmICh3ZWJLaXRDbGllbnQoKS0+ ZmlsZVN5c3RlbSgpKQotICAgICAgICByZXR1cm4gd2ViS2l0Q2xpZW50KCktPmZpbGVTeXN0ZW0o KS0+ZGlyZWN0b3J5TmFtZShwYXRoKTsKLSAgICByZXR1cm4gd2ViS2l0Q2xpZW50KCktPmRpcmVj dG9yeU5hbWUocGF0aCk7CisgICAgcmV0dXJuIHdlYktpdENsaWVudCgpLT5maWxlU3lzdGVtKCkt PmRpcmVjdG9yeU5hbWUocGF0aCk7CiB9CiAKIFN0cmluZyBDaHJvbWl1bUJyaWRnZTo6cGF0aEJ5 QXBwZW5kaW5nQ29tcG9uZW50KGNvbnN0IFN0cmluZyYgcGF0aCwgY29uc3QgU3RyaW5nJiBjb21w b25lbnQpCiB7Ci0gICAgaWYgKHdlYktpdENsaWVudCgpLT5maWxlU3lzdGVtKCkpCi0gICAgICAg IHJldHVybiB3ZWJLaXRDbGllbnQoKS0+ZmlsZVN5c3RlbSgpLT5wYXRoQnlBcHBlbmRpbmdDb21w b25lbnQocGF0aCwgY29tcG9uZW50KTsKLSAgICByZXR1cm4gd2ViS2l0Q2xpZW50KCktPnBhdGhC eUFwcGVuZGluZ0NvbXBvbmVudChwYXRoLCBjb21wb25lbnQpOworICAgIHJldHVybiB3ZWJLaXRD bGllbnQoKS0+ZmlsZVN5c3RlbSgpLT5wYXRoQnlBcHBlbmRpbmdDb21wb25lbnQocGF0aCwgY29t cG9uZW50KTsKIH0KIAogYm9vbCBDaHJvbWl1bUJyaWRnZTo6bWFrZUFsbERpcmVjdG9yaWVzKGNv bnN0IFN0cmluZyYgcGF0aCkKIHsKLSAgICBpZiAod2ViS2l0Q2xpZW50KCktPmZpbGVTeXN0ZW0o KSkKLSAgICAgICAgcmV0dXJuIHdlYktpdENsaWVudCgpLT5maWxlU3lzdGVtKCktPm1ha2VBbGxE aXJlY3RvcmllcyhwYXRoKTsKLSAgICByZXR1cm4gd2ViS2l0Q2xpZW50KCktPm1ha2VBbGxEaXJl Y3RvcmllcyhwYXRoKTsKKyAgICByZXR1cm4gd2ViS2l0Q2xpZW50KCktPmZpbGVTeXN0ZW0oKS0+ bWFrZUFsbERpcmVjdG9yaWVzKHBhdGgpOwogfQogCiBTdHJpbmcgQ2hyb21pdW1CcmlkZ2U6Omdl dEFic29sdXRlUGF0aChjb25zdCBTdHJpbmcmIHBhdGgpCiB7Ci0gICAgaWYgKHdlYktpdENsaWVu dCgpLT5maWxlU3lzdGVtKCkpCi0gICAgICAgIHJldHVybiB3ZWJLaXRDbGllbnQoKS0+ZmlsZVN5 c3RlbSgpLT5nZXRBYnNvbHV0ZVBhdGgocGF0aCk7Ci0gICAgcmV0dXJuIHdlYktpdENsaWVudCgp LT5nZXRBYnNvbHV0ZVBhdGgocGF0aCk7CisgICAgcmV0dXJuIHdlYktpdENsaWVudCgpLT5maWxl U3lzdGVtKCktPmdldEFic29sdXRlUGF0aChwYXRoKTsKIH0KIAogYm9vbCBDaHJvbWl1bUJyaWRn ZTo6aXNEaXJlY3RvcnkoY29uc3QgU3RyaW5nJiBwYXRoKQogewotICAgIGlmICh3ZWJLaXRDbGll bnQoKS0+ZmlsZVN5c3RlbSgpKQotICAgICAgICByZXR1cm4gd2ViS2l0Q2xpZW50KCktPmZpbGVT eXN0ZW0oKS0+aXNEaXJlY3RvcnkocGF0aCk7Ci0gICAgcmV0dXJuIHdlYktpdENsaWVudCgpLT5p c0RpcmVjdG9yeShwYXRoKTsKKyAgICByZXR1cm4gd2ViS2l0Q2xpZW50KCktPmZpbGVTeXN0ZW0o KS0+aXNEaXJlY3RvcnkocGF0aCk7CiB9CiAKIEtVUkwgQ2hyb21pdW1CcmlkZ2U6OmZpbGVQYXRo VG9VUkwoY29uc3QgU3RyaW5nJiBwYXRoKQogewotICAgIGlmICh3ZWJLaXRDbGllbnQoKS0+Zmls ZVN5c3RlbSgpKQotICAgICAgICByZXR1cm4gd2ViS2l0Q2xpZW50KCktPmZpbGVTeXN0ZW0oKS0+ ZmlsZVBhdGhUb1VSTChwYXRoKTsKLSAgICByZXR1cm4gd2ViS2l0Q2xpZW50KCktPmZpbGVQYXRo VG9VUkwocGF0aCk7CisgICAgcmV0dXJuIHdlYktpdENsaWVudCgpLT5maWxlU3lzdGVtKCktPmZp bGVQYXRoVG9VUkwocGF0aCk7CiB9CiAKIFBsYXRmb3JtRmlsZUhhbmRsZSBDaHJvbWl1bUJyaWRn ZTo6b3BlbkZpbGUoY29uc3QgU3RyaW5nJiBwYXRoLCBGaWxlT3Blbk1vZGUgbW9kZSkK