39321 2010-05-18 14:32:45 -0700 Reduce the size of ListHashSets used by Document 2010-05-18 15:51:49 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 sam webkit-unassigned dglazkov gustavo webkit.review.bot xan.lopez oldest_to_newest 227501 0 sam 2010-05-18 14:32:45 -0700 We can reduces the pool size of the ListHashSets used by Document. 227502 1 sam 2010-05-18 14:33:29 -0700 <rdar://problem/7999388> 227503 2 56413 sam 2010-05-18 14:36:06 -0700 Created attachment 56413 patch 227507 3 56413 andersca 2010-05-18 14:40:17 -0700 Comment on attachment 56413 patch r=me 227518 4 webkit.review.bot 2010-05-18 15:22:54 -0700 Attachment 56413 did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/2280274 227524 5 sam 2010-05-18 15:38:46 -0700 Landed in r59716. 227529 6 webkit.review.bot 2010-05-18 15:51:49 -0700 Attachment 56413 did not build on gtk: Build output: http://webkit-commit-queue.appspot.com/results/2268321 56413 2010-05-18 14:36:06 -0700 2010-05-18 14:40:16 -0700 patch patch.diff text/plain 3423 sam SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1OTcxMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMDUtMTggIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzkzMjEKKyAgICAgICAgUmVkdWNlIHRo ZSBzaXplIG9mIExpc3RIYXNoU2V0cyB1c2VkIGJ5IERvY3VtZW50CisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS83OTk5Mzg4PgorCisgICAgICAgIFJlZHVjZSBNZW1idXN0ZXIgcGVhayBtZW1vcnkg dXNhZ2UgYnkgfjQ1MEsgYnkgcmVkdWNpbmcgdGhlIHBvb2wgc2l6ZXMKKyAgICAgICAgb2YgdGhl IExpc3RIYXNoU2V0cyB1c2VkIGJ5IERvY3VtZW50LgorCisgICAgICAgICogZG9tL0RvY3VtZW50 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50OjphZGRTdHlsZVNoZWV0Q2FuZGlkYXRl Tm9kZSk6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6cmVjYWxjU3R5bGVTZWxlY3Rvcik6 CisgICAgICAgICogZG9tL0RvY3VtZW50Lmg6CisKIDIwMTAtMDUtMTggIEp1c3RpbiBTY2h1aCAg PGpzY2h1aEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4K SW5kZXg6IFdlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2Rv bS9Eb2N1bWVudC5jcHAJKHJldmlzaW9uIDU5Njc5KQorKysgV2ViQ29yZS9kb20vRG9jdW1lbnQu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNjIwLDkgKzI2MjAsOSBAQCB2b2lkIERvY3VtZW50Ojph ZGRTdHlsZVNoZWV0Q2FuZGlkYXRlTm9kCiAgICAgfQogCiAgICAgLy8gRGV0ZXJtaW5lIGFuIGFw cHJvcHJpYXRlIGluc2VydGlvbiBwb2ludC4KLSAgICBMaXN0SGFzaFNldDxOb2RlKj46Oml0ZXJh dG9yIGJlZ2luID0gbV9zdHlsZVNoZWV0Q2FuZGlkYXRlTm9kZXMuYmVnaW4oKTsKLSAgICBMaXN0 SGFzaFNldDxOb2RlKj46Oml0ZXJhdG9yIGVuZCA9IG1fc3R5bGVTaGVldENhbmRpZGF0ZU5vZGVz LmVuZCgpOwotICAgIExpc3RIYXNoU2V0PE5vZGUqPjo6aXRlcmF0b3IgaXQgPSBlbmQ7CisgICAg U3R5bGVTaGVldENhbmRpZGF0ZUxpc3RIYXNoU2V0OjppdGVyYXRvciBiZWdpbiA9IG1fc3R5bGVT aGVldENhbmRpZGF0ZU5vZGVzLmJlZ2luKCk7CisgICAgU3R5bGVTaGVldENhbmRpZGF0ZUxpc3RI YXNoU2V0OjppdGVyYXRvciBlbmQgPSBtX3N0eWxlU2hlZXRDYW5kaWRhdGVOb2Rlcy5lbmQoKTsK KyAgICBTdHlsZVNoZWV0Q2FuZGlkYXRlTGlzdEhhc2hTZXQ6Oml0ZXJhdG9yIGl0ID0gZW5kOwog ICAgIE5vZGUqIGZvbGxvd2luZ05vZGUgPSAwOwogICAgIGRvIHsKICAgICAgICAgLS1pdDsKQEAg LTI2NTQsOCArMjY1NCw4IEBAIHZvaWQgRG9jdW1lbnQ6OnJlY2FsY1N0eWxlU2VsZWN0b3IoKQog ICAgIGlmIChTZXR0aW5ncyogc2V0dGluZ3MgPSB0aGlzLT5zZXR0aW5ncygpKQogICAgICAgICBt YXRjaEF1dGhvckFuZFVzZXJTdHlsZXMgPSBzZXR0aW5ncy0+YXV0aG9yQW5kVXNlclN0eWxlc0Vu YWJsZWQoKTsKIAotICAgIExpc3RIYXNoU2V0PE5vZGUqPjo6aXRlcmF0b3IgYmVnaW4gPSBtX3N0 eWxlU2hlZXRDYW5kaWRhdGVOb2Rlcy5iZWdpbigpOwotICAgIExpc3RIYXNoU2V0PE5vZGUqPjo6 aXRlcmF0b3IgZW5kID0gbV9zdHlsZVNoZWV0Q2FuZGlkYXRlTm9kZXMuZW5kKCk7CisgICAgU3R5 bGVTaGVldENhbmRpZGF0ZUxpc3RIYXNoU2V0OjppdGVyYXRvciBiZWdpbiA9IG1fc3R5bGVTaGVl dENhbmRpZGF0ZU5vZGVzLmJlZ2luKCk7CisgICAgU3R5bGVTaGVldENhbmRpZGF0ZUxpc3RIYXNo U2V0OjppdGVyYXRvciBlbmQgPSBtX3N0eWxlU2hlZXRDYW5kaWRhdGVOb2Rlcy5lbmQoKTsKICAg ICBpZiAoIW1hdGNoQXV0aG9yQW5kVXNlclN0eWxlcykKICAgICAgICAgZW5kID0gYmVnaW47CiAg ICAgZm9yIChMaXN0SGFzaFNldDxOb2RlKj46Oml0ZXJhdG9yIGl0ID0gYmVnaW47IGl0ICE9IGVu ZDsgKytpdCkgewpJbmRleDogV2ViQ29yZS9kb20vRG9jdW1lbnQuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJDb3JlL2RvbS9Eb2N1bWVudC5oCShyZXZpc2lvbiA1OTY3OSkKKysrIFdlYkNvcmUvZG9tL0Rv Y3VtZW50LmgJKHdvcmtpbmcgY29weSkKQEAgLTEwOTUsMTAgKzEwOTUsMTQgQEAgcHJpdmF0ZToK ICAgICB1bnNpZ25lZCBzaG9ydCBtX2xpc3RlbmVyVHlwZXM7CiAKICAgICBSZWZQdHI8U3R5bGVT aGVldExpc3Q+IG1fc3R5bGVTaGVldHM7IC8vIEFsbCBvZiB0aGUgc3R5bGVzaGVldHMgdGhhdCBh cmUgY3VycmVudGx5IGluIGVmZmVjdCBmb3Igb3VyIG1lZGlhIHR5cGUgYW5kIHN0eWxlc2hlZXQg c2V0LgotICAgIExpc3RIYXNoU2V0PE5vZGUqPiBtX3N0eWxlU2hlZXRDYW5kaWRhdGVOb2Rlczsg Ly8gQWxsIG9mIHRoZSBub2RlcyB0aGF0IGNvdWxkIHBvdGVudGlhbGx5IHByb3ZpZGUgc3R5bGVz aGVldHMgdG8gdGhlIGRvY3VtZW50ICg8bGluaz4sIDxzdHlsZT4sIDw/eG1sLXN0eWxlc2hlZXQ+ KQorICAgIAorICAgIHR5cGVkZWYgTGlzdEhhc2hTZXQ8Tm9kZSosIDMyPiBTdHlsZVNoZWV0Q2Fu ZGlkYXRlTGlzdEhhc2hTZXQ7CisgICAgU3R5bGVTaGVldENhbmRpZGF0ZUxpc3RIYXNoU2V0IG1f c3R5bGVTaGVldENhbmRpZGF0ZU5vZGVzOyAvLyBBbGwgb2YgdGhlIG5vZGVzIHRoYXQgY291bGQg cG90ZW50aWFsbHkgcHJvdmlkZSBzdHlsZXNoZWV0cyB0byB0aGUgZG9jdW1lbnQgKDxsaW5rPiwg PHN0eWxlPiwgPD94bWwtc3R5bGVzaGVldD4pCisKKyAgICB0eXBlZGVmIExpc3RIYXNoU2V0PEVs ZW1lbnQqLCA2ND4gRm9ybUVsZW1lbnRMaXN0SGFzaFNldDsKKyAgICBGb3JtRWxlbWVudExpc3RI YXNoU2V0IG1fZm9ybUVsZW1lbnRzV2l0aFN0YXRlOwogCiAgICAgdHlwZWRlZiBIYXNoTWFwPEZv cm1FbGVtZW50S2V5LCBWZWN0b3I8U3RyaW5nPiwgRm9ybUVsZW1lbnRLZXlIYXNoLCBGb3JtRWxl bWVudEtleUhhc2hUcmFpdHM+IEZvcm1FbGVtZW50U3RhdGVNYXA7Ci0gICAgTGlzdEhhc2hTZXQ8 RWxlbWVudCo+IG1fZm9ybUVsZW1lbnRzV2l0aFN0YXRlOwogICAgIEZvcm1FbGVtZW50U3RhdGVN YXAgbV9zdGF0ZUZvck5ld0Zvcm1FbGVtZW50czsKICAgICAKICAgICBDb2xvciBtX2xpbmtDb2xv cjsK