39298 2010-05-18 10:17:31 -0700 Implement two more lexer states 2010-05-18 16:55:52 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 39259 1 abarth webkit-unassigned eric webkit.review.bot oldest_to_newest 227365 0 abarth 2010-05-18 10:17:31 -0700 Implement two more lexer states 227366 1 56387 abarth 2010-05-18 10:18:49 -0700 Created attachment 56387 Patch 227367 2 webkit.review.bot 2010-05-18 10:21:13 -0700 Attachment 56387 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/html/HTML5Lexer.cpp:661: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 227390 3 56387 eric 2010-05-18 11:17:58 -0700 Comment on attachment 56387 Patch rs=me. 227555 4 abarth 2010-05-18 16:55:52 -0700 Committed r59720: <http://trac.webkit.org/changeset/59720> 56387 2010-05-18 10:18:49 -0700 2010-05-18 11:17:58 -0700 Patch bug-39298-20100518101848.patch text/plain 3678 abarth ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ODRkNDllYzc4NThhOTRjNTY3MjZiZTE5MDc4NjYwZTc5MzdkZGEwZC4uODZhZWJjYmYzMjM5Zjli MWNkNmQ2Yjc3YmU2ZDRhNDFhM2VkNjY1NiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0wNS0xOCAgQWRh bSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEltcGxlbWVudCB0d28gbW9yZSBsZXhlciBzdGF0ZXMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5Mjk4CisKKyAg ICAgICAgTm8gdGVzdHMgYmVjYXVzZSBFcmljIGlzIHN0aWxsIHdvcmtpbmcgb24gd2lyaW5nIHVw IHRoZSBsZXhlciB0byB0aGUKKyAgICAgICAgdGVzdCBoYXJuZXNzLgorCisgICAgICAgICogaHRt bC9IVE1MNUxleGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUw1TGV4ZXI6Om5leHRUb2tl bik6CisgICAgICAgIChXZWJDb3JlOjpIVE1MNUxleGVyOjplbWl0UGFyc2VFcnJvcik6CisgICAg ICAgIChXZWJDb3JlOjpIVE1MNUxleGVyOjplbWl0Q3VycmVudFRhZ1Rva2VuKToKKyAgICAgICAg KiBodG1sL0hUTUw1TGV4ZXIuaDoKKwogMjAxMC0wNS0xOCAgQ2hyaXMgSmVyZG9uZWsgIDxjamVy ZG9uZWtAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KZGlm ZiAtLWdpdCBhL1dlYkNvcmUvaHRtbC9IVE1MNUxleGVyLmNwcCBiL1dlYkNvcmUvaHRtbC9IVE1M NUxleGVyLmNwcAppbmRleCA4YTdmMDJlZjQ3YmJhN2FjM2UxYjNmNTNjNGYzMDc5OGNjNDk0MDlk Li4zZDRjMjdlNDdlZDZhZWM1NDJjNjkzZmE2MWIzNDY0MDMwYmY5ZDY5IDEwMDY0NAotLS0gYS9X ZWJDb3JlL2h0bWwvSFRNTDVMZXhlci5jcHAKKysrIGIvV2ViQ29yZS9odG1sL0hUTUw1TGV4ZXIu Y3BwCkBAIC02NTcsOCArNjU3LDQ3IEBAIHZvaWQgSFRNTDVMZXhlcjo6bmV4dFRva2VuKFNlZ21l bnRlZFN0cmluZyYgc291cmNlLCBIVE1MNVRva2VuJiB0b2tlbikKICAgICAgICAgICAgIH0KICAg ICAgICAgICAgIGJyZWFrOwogICAgICAgICB9Ci0gICAgICAgIGNhc2UgQmVmb3JlQXR0cmlidXRl TmFtZVN0YXRlOgotICAgICAgICBjYXNlIEF0dHJpYnV0ZU5hbWVTdGF0ZToKKyAgICAgICAgY2Fz ZSBCZWZvcmVBdHRyaWJ1dGVOYW1lU3RhdGU6IHsKKyAgICAgICAgICAgIGlmIChjYyA9PSAnXHgw OScgfHwgY2MgPT0gJ1x4MEEnIHx8IGNjID09ICdceDBDJyB8fCBjYyA9PSAnICcpCisgICAgICAg ICAgICAgICAgYnJlYWs7CisgICAgICAgICAgICBlbHNlIGlmIChjYyA9PSAnLycpCisgICAgICAg ICAgICAgICAgbV9zdGF0ZSA9IFNlbGZDbG9zaW5nU3RhcnRUYWdTdGF0ZTsKKyAgICAgICAgICAg IGVsc2UgaWYgKGNjID09ICc+JykgeworICAgICAgICAgICAgICAgIGVtaXRDdXJyZW50VGFnVG9r ZW4oKTsKKyAgICAgICAgICAgICAgICBtX3N0YXRlID0gRGF0YVN0YXRlOworICAgICAgICAgICAg fSBlbHNlIGlmIChjYyA+PSAnQScgJiYgY2MgPD0gJ1onKSB7CisgICAgICAgICAgICAgICAgbm90 SW1wbGVtZW50ZWQoKTsKKyAgICAgICAgICAgICAgICBtX3N0YXRlID0gQXR0cmlidXRlTmFtZVN0 YXRlOworICAgICAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgICAgICBpZiAoY2MgPT0gJyIn IHx8IGNjID09ICdcJycgfHwgY2MgPT0gJzwnIHx8IGNjID09ICc9JykKKyAgICAgICAgICAgICAg ICAgICAgZW1pdFBhcnNlRXJyb3IoKTsKKyAgICAgICAgICAgICAgICBub3RJbXBsZW1lbnRlZCgp OworICAgICAgICAgICAgICAgIG1fc3RhdGUgPSBBdHRyaWJ1dGVOYW1lU3RhdGU7CisgICAgICAg ICAgICB9CisgICAgICAgICAgICAvLyBGSVhNRTogSGFuZGxlIEVPRiBwcm9wZXJseS4KKyAgICAg ICAgICAgIGJyZWFrOworICAgICAgICB9CisgICAgICAgIGNhc2UgQXR0cmlidXRlTmFtZVN0YXRl OiB7CisgICAgICAgICAgICBpZiAoY2MgPT0gJ1x4MDknIHx8IGNjID09ICdceDBBJyB8fCBjYyA9 PSAnXHgwQycgfHwgY2MgPT0gJyAnKQorICAgICAgICAgICAgICAgIG1fc3RhdGUgPSBBZnRlckF0 dHJpYnV0ZU5hbWVTdGF0ZTsKKyAgICAgICAgICAgIGVsc2UgaWYgKGNjID09ICcvJykKKyAgICAg ICAgICAgICAgICBtX3N0YXRlID0gU2VsZkNsb3NpbmdTdGFydFRhZ1N0YXRlOworICAgICAgICAg ICAgZWxzZSBpZiAoY2MgPT0gJz0nKQorICAgICAgICAgICAgICAgIG1fc3RhdGUgPSBCZWZvcmVB dHRyaWJ1dGVWYWx1ZVN0YXRlOworICAgICAgICAgICAgZWxzZSBpZiAoY2MgPT0gJz4nKSB7Cisg ICAgICAgICAgICAgICAgZW1pdEN1cnJlbnRUYWdUb2tlbigpOworICAgICAgICAgICAgICAgIG1f c3RhdGUgPSBEYXRhU3RhdGU7CisgICAgICAgICAgICB9IGVsc2UgaWYgKGNjID49ICdBJyAmJiBj YyA8PSAnWicpCisgICAgICAgICAgICAgICAgbm90SW1wbGVtZW50ZWQoKTsKKyAgICAgICAgICAg IGVsc2UgeworICAgICAgICAgICAgICAgIGlmIChjYyA9PSAnIicgfHwgY2MgPT0gJ1wnJyB8fCBj YyA9PSAnPCcgfHwgY2MgPT0gJz0nKQorICAgICAgICAgICAgICAgICAgICBlbWl0UGFyc2VFcnJv cigpOworICAgICAgICAgICAgICAgIG5vdEltcGxlbWVudGVkKCk7CisgICAgICAgICAgICAgICAg bV9zdGF0ZSA9IEF0dHJpYnV0ZU5hbWVTdGF0ZTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgICAg IC8vIEZJWE1FOiBIYW5kbGUgRU9GIHByb3Blcmx5LgorICAgICAgICAgICAgYnJlYWs7CisgICAg ICAgIH0KICAgICAgICAgY2FzZSBBZnRlckF0dHJpYnV0ZU5hbWVTdGF0ZToKICAgICAgICAgY2Fz ZSBCZWZvcmVBdHRyaWJ1dGVWYWx1ZVN0YXRlOgogICAgICAgICBjYXNlIEF0dHJpYnV0ZVZhbHVl RG91YmxlUXVvdGVkU3RhdGU6CkBAIC03MTYsNiArNzU1LDEyIEBAIGlubGluZSB2b2lkIEhUTUw1 TGV4ZXI6OmVtaXRDaGFyYWN0ZXIoVUNoYXIgY2hhcmFjdGVyKQogCiBpbmxpbmUgdm9pZCBIVE1M NUxleGVyOjplbWl0UGFyc2VFcnJvcigpCiB7CisgICAgbm90SW1wbGVtZW50ZWQoKTsKK30KKwor aW5saW5lIHZvaWQgSFRNTDVMZXhlcjo6ZW1pdEN1cnJlbnRUYWdUb2tlbigpIAoreworICAgIG5v dEltcGxlbWVudGVkKCk7CiB9CiAKIH0KZGlmZiAtLWdpdCBhL1dlYkNvcmUvaHRtbC9IVE1MNUxl eGVyLmggYi9XZWJDb3JlL2h0bWwvSFRNTDVMZXhlci5oCmluZGV4IGM0NDc1OWU4Mzk1Y2FhMmFl NGY3NmY5MDhkYTUzYjhiMzYyN2I0N2QuLmQxZWExODVjYjJlZDQ5ZDUzNzY2MTlhMWFjYmFjMmVl ODYyNjcyNDIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaHRtbC9IVE1MNUxleGVyLmgKKysrIGIvV2Vi Q29yZS9odG1sL0hUTUw1TGV4ZXIuaApAQCAtNDksNiArNDksNyBAQCBuYW1lc3BhY2UgV2ViQ29y ZSB7CiAgICAgcHJpdmF0ZToKICAgICAgICAgaW5saW5lIHZvaWQgZW1pdENoYXJhY3RlcihVQ2hh cik7CiAgICAgICAgIGlubGluZSB2b2lkIGVtaXRQYXJzZUVycm9yKCk7CisgICAgICAgIGlubGlu ZSB2b2lkIGVtaXRDdXJyZW50VGFnVG9rZW4oKTsKIAogICAgICAgICBpbmxpbmUgYm9vbCB0ZW1w b3JhcnlCdWZmZXJJcyhjb25zdCBjaGFyKik7CiAK