<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>39294</bug_id>
          
          <creation_ts>2010-05-18 08:33:44 -0700</creation_ts>
          <short_desc>[Qt] Move visible rect calculation from QGraphicsWebViewPrivate to PageClientQGraphicsWidget</short_desc>
          <delta_ts>2010-05-24 02:38:14 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Qt</keywords>
          <priority>P3</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Antti Koivisto">koivisto</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>benjamin</cc>
    
    <cc>jesus</cc>
    
    <cc>kenneth</cc>
    
    <cc>tonikitoo</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>227316</commentid>
    <comment_count>0</comment_count>
    <who name="Antti Koivisto">koivisto</who>
    <bug_when>2010-05-18 08:33:44 -0700</bug_when>
    <thetext>Some mismatching changes broke actually tile updates.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>227320</commentid>
    <comment_count>1</comment_count>
      <attachid>56379</attachid>
    <who name="Antti Koivisto">koivisto</who>
    <bug_when>2010-05-18 08:40:11 -0700</bug_when>
    <thetext>Created attachment 56379
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>227790</commentid>
    <comment_count>2</comment_count>
    <who name="Antti Koivisto">koivisto</who>
    <bug_when>2010-05-19 06:25:20 -0700</bug_when>
    <thetext>http://trac.webkit.org/changeset/59760</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>227796</commentid>
    <comment_count>3</comment_count>
    <who name="Jesus Sanchez-Palencia">jesus</who>
    <bug_when>2010-05-19 06:39:25 -0700</bug_when>
    <thetext>The PageClient refactor wasn&apos;t cherry-picked in the release branch, so maybe this bug shouldn&apos;t block the release.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>229670</commentid>
    <comment_count>4</comment_count>
    <who name="Antti Koivisto">koivisto</who>
    <bug_when>2010-05-24 02:38:14 -0700</bug_when>
    <thetext>*** Bug 38090 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>56379</attachid>
            <date>2010-05-18 08:40:11 -0700</date>
            <delta_ts>2010-05-19 06:25:36 -0700</delta_ts>
            <desc>patch</desc>
            <filename>page-visible-rect.patch</filename>
            <type>text/plain</type>
            <size>3472</size>
            <attacher name="Antti Koivisto">koivisto</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n
ZUxvZwkocmV2aXNpb24gNTk2NjkpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv
cHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDUtMTggIEFudHRpIEtvaXZpc3RvICA8a29pdmlz
dG9AaWtpLmZpPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg
ICAgIFtRdF0gTW92ZSB2aXNpYmxlIHJlY3QgY2FsY3VsYXRpb24gZnJvbSBRR3JhcGhpY3NXZWJW
aWV3UHJpdmF0ZSB0byBQYWdlQ2xpZW50UUdyYXBoaWNzV2lkZ2V0CisgICAgICAgIGh0dHBzOi8v
YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zOTI5NAorCisgICAgICAgICogQXBpL3Fn
cmFwaGljc3dlYnZpZXcuY3BwOgorICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L1BhZ2VDbGllbnRR
dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQYWdlQ2xpZW50UUdyYXBoaWNzV2lkZ2V0OjpncmFw
aGljc0l0ZW1WaXNpYmxlUmVjdCk6CisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvUGFnZUNsaWVu
dFF0Lmg6CisKIDIwMTAtMDUtMTggIEplZHJ6ZWogTm93YWNraSAgPGplZHJ6ZWoubm93YWNraUBu
b2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gSGF1c21hbm4uCkluZGV4OiBX
ZWJLaXQvcXQvQXBpL3FncmFwaGljc3dlYnZpZXcuY3BwCj09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9x
dC9BcGkvcWdyYXBoaWNzd2Vidmlldy5jcHAJKHJldmlzaW9uIDU5NjExKQorKysgV2ViS2l0L3F0
L0FwaS9xZ3JhcGhpY3N3ZWJ2aWV3LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjAsOCArNjAsNiBA
QCBwdWJsaWM6CiAgICAgdm9pZCBzeW5jTGF5ZXJzKCk7CiAKICAgICB2b2lkIHVwZGF0ZVJlc2l6
ZXNUb0NvbnRlbnRzRm9yUGFnZSgpOwotICAgIHZpcnR1YWwgUVJlY3RGIGdyYXBoaWNzSXRlbVZp
c2libGVSZWN0KCkgY29uc3Q7Ci0KIAogICAgIHZvaWQgZGV0YWNoQ3VycmVudFBhZ2UoKTsKIApA
QCAtMTU3LDI1ICsxNTUsNiBAQCB2b2lkIFFHcmFwaGljc1dlYlZpZXdQcml2YXRlOjpfcV9zY2Fs
ZUNoCiAjZW5kaWYKIH0KIAotUVJlY3RGIFFHcmFwaGljc1dlYlZpZXdQcml2YXRlOjpncmFwaGlj
c0l0ZW1WaXNpYmxlUmVjdCgpIGNvbnN0Ci17Ci0gICAgaWYgKCFxLT5zY2VuZSgpKQotICAgICAg
ICByZXR1cm4gUVJlY3RGKCk7Ci0gICAgUUxpc3Q8UUdyYXBoaWNzVmlldyo+IHZpZXdzID0gcS0+
c2NlbmUoKS0+dmlld3MoKTsKLSAgICBpZiAodmlld3Muc2l6ZSgpID4gMSkgewotI2lmbmRlZiBR
VF9OT19ERUJVR19TVFJFQU0KLSAgICAgICAgcURlYnVnKCkgPDwgIlFHcmFwaGljc1dlYlZpZXcg
aXMgaW4gbW9yZSB0aGFuIG9uZSBncmFwaGljcyB2aWV3cywgdW5hYmxlIHRvIGNvbXB1dGUgdGhl
IHZpc2libGUgcmVjdCI7Ci0jZW5kaWYKLSAgICAgICAgcmV0dXJuIFFSZWN0RigpOwotICAgIH0K
LSAgICBpZiAodmlld3Muc2l6ZSgpIDwgMSkKLSAgICAgICAgcmV0dXJuIFFSZWN0RigpOwotCi0g
ICAgaW50IHhQb3NpdGlvbiA9IHZpZXdzWzBdLT5ob3Jpem9udGFsU2Nyb2xsQmFyKCktPnZhbHVl
KCk7Ci0gICAgaW50IHlQb3NpdGlvbiA9IHZpZXdzWzBdLT52ZXJ0aWNhbFNjcm9sbEJhcigpLT52
YWx1ZSgpOwotICAgIHJldHVybiBxLT5tYXBSZWN0RnJvbVNjZW5lKFFSZWN0RihRUG9pbnQoeFBv
c2l0aW9uLCB5UG9zaXRpb24pLCB2aWV3c1swXS0+dmlld3BvcnQoKS0+c2l6ZSgpKSk7Ci19Ci0K
IC8qIQogICAgIFxjbGFzcyBRR3JhcGhpY3NXZWJWaWV3CiAgICAgXGJyaWVmIFRoZSBRR3JhcGhp
Y3NXZWJWaWV3IGNsYXNzIGFsbG93cyBXZWIgY29udGVudCB0byBiZSBhZGRlZCB0byBhIEdyYXBo
aWNzVmlldy4KSW5kZXg6IFdlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9QYWdlQ2xpZW50UXQuY3Bw
Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT0KLS0tIFdlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9QYWdlQ2xpZW50UXQuY3Bw
CShyZXZpc2lvbiA1OTYxMCkKKysrIFdlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9QYWdlQ2xpZW50
UXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yODgsNiArMjg4LDIzIEBAIFFSZWN0IFBhZ2VDbGll
bnRRR3JhcGhpY3NXaWRnZXQ6Omdlb21ldHIKICAgICByZXR1cm4gZ3JhcGhpY3NWaWV3LT5tYXBG
cm9tU2NlbmUodmlldy0+Ym91bmRpbmdSZWN0KCkpLmJvdW5kaW5nUmVjdCgpOwogfQogCisjaWYg
RU5BQkxFKFRJTEVEX0JBQ0tJTkdfU1RPUkUpCitRUmVjdEYgUGFnZUNsaWVudFFHcmFwaGljc1dp
ZGdldDo6Z3JhcGhpY3NJdGVtVmlzaWJsZVJlY3QoKSBjb25zdAoreworICAgIGlmICghdmlldy0+
c2NlbmUoKSkKKyAgICAgICAgcmV0dXJuIFFSZWN0RigpOworCisgICAgUUxpc3Q8UUdyYXBoaWNz
Vmlldyo+IHZpZXdzID0gdmlldy0+c2NlbmUoKS0+dmlld3MoKTsKKyAgICBpZiAodmlld3MuaXNF
bXB0eSgpKQorICAgICAgICByZXR1cm4gUVJlY3RGKCk7CisgICAgCisgICAgUUdyYXBoaWNzVmll
dyogZ3JhcGhpY3NWaWV3ID0gdmlld3MuYXQoMCk7CisgICAgaW50IHhPZmZzZXQgPSBncmFwaGlj
c1ZpZXctPmhvcml6b250YWxTY3JvbGxCYXIoKS0+dmFsdWUoKTsKKyAgICBpbnQgeU9mZnNldCA9
IGdyYXBoaWNzVmlldy0+dmVydGljYWxTY3JvbGxCYXIoKS0+dmFsdWUoKTsKKyAgICByZXR1cm4g
dmlldy0+bWFwUmVjdEZyb21TY2VuZShRUmVjdEYoUVBvaW50Rih4T2Zmc2V0LCB5T2Zmc2V0KSwg
Z3JhcGhpY3NWaWV3LT52aWV3cG9ydCgpLT5zaXplKCkpKTsKK30KKyNlbmRpZgorCiBRT2JqZWN0
KiBQYWdlQ2xpZW50UUdyYXBoaWNzV2lkZ2V0OjpwbHVnaW5QYXJlbnQoKSBjb25zdAogewogICAg
IHJldHVybiB2aWV3OwpJbmRleDogV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L1BhZ2VDbGllbnRR
dC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9QYWdlQ2xpZW50UXQu
aAkocmV2aXNpb24gNTk2MTApCisrKyBXZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvUGFnZUNsaWVu
dFF0LmgJKHdvcmtpbmcgY29weSkKQEAgLTE2NSw2ICsxNjUsNyBAQCBwdWJsaWM6CiAKICNpZiBF
TkFCTEUoVElMRURfQkFDS0lOR19TVE9SRSkKICAgICB2b2lkIHVwZGF0ZVRpbGVkQmFja2luZ1N0
b3JlU2NhbGUoKTsKKyAgICB2aXJ0dWFsIFFSZWN0RiBncmFwaGljc0l0ZW1WaXNpYmxlUmVjdCgp
IGNvbnN0OwogI2VuZGlmCiAKICNpZiBVU0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcpCg==
</data>
<flag name="review"
          id="40782"
          type_id="1"
          status="+"
          setter="kenneth"
    />
          </attachment>
      

    </bug>

</bugzilla>