39283 2010-05-18 04:03:46 -0700 Port SharedBuffer to POSIX. 2010-05-20 18:19:55 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 39348 0 joybro201 webkit-unassigned commit-queue skyul oldest_to_newest 227245 0 joybro201 2010-05-18 04:03:46 -0700 Implement SharedBuffer::createWithContentsOfFile with POSIX functions. 227248 1 56356 joybro201 2010-05-18 04:07:01 -0700 Created attachment 56356 patch 227333 2 56356 darin 2010-05-18 09:19:33 -0700 Comment on attachment 56356 patch > + int fd = open(filePath.utf8().data(), O_RDONLY); This is not a portable way to convert a WebCore string to a POSIX filename. See the functions named filenameFromString in the various FileSystem source files to see how it's done on various platforms. We may need to add something to FileSystem.h so we can do this in a way that works across platforms. > + size_t bytesToRead = fileStat.st_size; If the file size is greater than what can fit in size_t, this assignment will truncate the size. The type of st_size is off_t, and there's no guarantee it can fit in a size_t. We should include some sort of check here to make sure the function returns 0 in a case like that instead of reading only part of the file. > + RefPtr<SharedBuffer> result = SharedBuffer::create(); Here in the SharedBuffer class, this function should just be called create(). See examples in other member functions. > + result->m_buffer.resize(bytesToRead); It's slightly better to use the grow function here instead of the resize function, since it won't do unnecessary checks related to shrinking a buffer and here we know we are either growing it or leaving it as-is. > + if (result->m_buffer.size() != bytesToRead) { > + close(fd); > + return 0; > + } This code path contains dead code and thus can't be tested. The resize function can't fail. The size is guaranteed to be equal to bytesToRead. The resize function will call CRASH if it can't allocate memory. If we want a code path that will return 0 if we are out of memory then we need to make use of the tryReserveCapacity function, a function that can fail without calling CRASH. Then check for failure, and then call the grow function. > + ssize_t bytesRead = 0; There's no reason to initialize this to zero. I also suggest defining it after defining totalBytesToRead. review- because at least some of the issues I mention above should be resolved 227729 3 joybro201 2010-05-19 00:39:53 -0700 (In reply to comment #2) > (From update of attachment 56356 [details]) > > + int fd = open(filePath.utf8().data(), O_RDONLY); > > This is not a portable way to convert a WebCore string to a POSIX filename. See the functions named filenameFromString in the various FileSystem source files to see how it's done on various platforms. We may need to add something to FileSystem.h so we can do this in a way that works across platforms. OK. I've done this by new patch (https://bugs.webkit.org/show_bug.cgi?id=39348). So now, this depends on 39348. > > > + size_t bytesToRead = fileStat.st_size; > > If the file size is greater than what can fit in size_t, this assignment will truncate the size. The type of st_size is off_t, and there's no guarantee it can fit in a size_t. We should include some sort of check here to make sure the function returns 0 in a case like that instead of reading only part of the file. > > > + RefPtr<SharedBuffer> result = SharedBuffer::create(); > > Here in the SharedBuffer class, this function should just be called create(). See examples in other member functions. > > > + result->m_buffer.resize(bytesToRead); > > It's slightly better to use the grow function here instead of the resize function, since it won't do unnecessary checks related to shrinking a buffer and here we know we are either growing it or leaving it as-is. I've fixed all above. > > > + if (result->m_buffer.size() != bytesToRead) { > > + close(fd); > > + return 0; > > + } > > This code path contains dead code and thus can't be tested. The resize function can't fail. The size is guaranteed to be equal to bytesToRead. The resize function will call CRASH if it can't allocate memory. If we want a code path that will return 0 if we are out of memory then we need to make use of the tryReserveCapacity function, a function that can fail without calling CRASH. Then check for failure, and then call the grow function. Oops, I've removed this but don't add other out of memory check. It seems overwork. > > > + ssize_t bytesRead = 0; > > There's no reason to initialize this to zero. I also suggest defining it after defining totalBytesToRead. fixed also. > > review- because at least some of the issues I mention above should be resolved Thanks. 227731 4 56471 joybro201 2010-05-19 00:41:47 -0700 Created attachment 56471 patch 227847 5 56471 darin 2010-05-19 09:10:49 -0700 Comment on attachment 56471 patch > +#include "FileSystem.h" > + > +#include <fcntl.h> > +#include <sys/stat.h> > +#include <unistd.h> > +#include <wtf/text/CString.h> We put includes in a single paragraph. Not one for "" and a separate one for <>. > + char* filename = filenameFromString(filePath); Can this function ever fail? If so, then I think we need code to handle that case. > + size_t totalBytesRead = 0; > + ssize_t bytesRead; > + while ((bytesRead = read(fd, result->m_buffer.data() + totalBytesRead, bytesToRead - totalBytesRead)) > 0) > + totalBytesRead += bytesRead; If the length of the file increases due to another process writing to it while this function is running, then this will end up calling read with a size of 0. I suppose that's OK and how you're supposed to use the read call. 228669 6 56471 commit-queue 2010-05-20 18:19:50 -0700 Comment on attachment 56471 patch Clearing flags on attachment: 56471 Committed r59890: <http://trac.webkit.org/changeset/59890> 228670 7 commit-queue 2010-05-20 18:19:55 -0700 All reviewed patches have been landed. Closing bug. 56356 2010-05-18 04:07:01 -0700 2010-05-18 09:19:33 -0700 patch patchFor39283 text/plain 3297 joybro201 SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1OTY2NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMDUtMTggIFlvdW5nIEhhbiBMZWUgIDxqb3licm9AY29tcGFu eTEwMC5uZXQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgUG9ydCBTaGFyZWRCdWZmZXIgdG8gUE9TSVguCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zOTI4MworCisgICAgICAgICogcGxhdGZvcm0vcG9zaXgv U2hhcmVkQnVmZmVyUE9TSVguY3BwOiBBZGRlZC4KKyAgICAgICAgKFdlYkNvcmU6OlNoYXJlZEJ1 ZmZlcjo6Y3JlYXRlV2l0aENvbnRlbnRzT2ZGaWxlKToKKwogMjAxMC0wNS0xOCAgRXJpYyBTZWlk ZWwgIDxlcmljQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCBidWlsZCBmaXguCklu ZGV4OiBXZWJDb3JlL3BsYXRmb3JtL3Bvc2l4L1NoYXJlZEJ1ZmZlclBPU0lYLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL3Bvc2l4L1NoYXJlZEJ1ZmZlclBPU0lYLmNwcAkocmV2 aXNpb24gMCkKKysrIFdlYkNvcmUvcGxhdGZvcm0vcG9zaXgvU2hhcmVkQnVmZmVyUE9TSVguY3Bw CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDY5IEBACisvKgorICogQ29weXJpZ2h0IChDKSAyMDEw IENvbXBhbnkgMTAwLCBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKgorICogUmVkaXN0cmli dXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0 CisgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93 aW5nIGNvbmRpdGlvbnMKKyAqIGFyZSBtZXQ6CisgKiAxLiBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291 cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdodAorICogICAgbm90aWNlLCB0 aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgorICog Mi4gUmVkaXN0cmlidXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92 ZSBjb3B5cmlnaHQKKyAqICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRo ZSBmb2xsb3dpbmcgZGlzY2xhaW1lciBpbiB0aGUKKyAqICAgIGRvY3VtZW50YXRpb24gYW5kL29y IG90aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRoIHRoZSBkaXN0cmlidXRpb24uCisgKgorICog VEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBBUFBMRSBDT01QVVRFUiwgSU5DLiBgYEFTIElT JycgQU5EIEFOWQorICogRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xVRElORywg QlVUIE5PVCBMSU1JVEVEIFRPLCBUSEUKKyAqIElNUExJRUQgV0FSUkFOVElFUyBPRiBNRVJDSEFO VEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUgorICogUFVSUE9TRSBBUkUgRElT Q0xBSU1FRC4gIElOIE5PIEVWRU5UIFNIQUxMIEFQUExFIENPTVBVVEVSLCBJTkMuIE9SCisgKiBD T05UUklCVVRPUlMgQkUgTElBQkxFIEZPUiBBTlkgRElSRUNULCBJTkRJUkVDVCwgSU5DSURFTlRB TCwgU1BFQ0lBTCwKKyAqIEVYRU1QTEFSWSwgT1IgQ09OU0VRVUVOVElBTCBEQU1BR0VTIChJTkNM VURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywKKyAqIFBST0NVUkVNRU5UIE9GIFNVQlNUSVRVVEUg R09PRFMgT1IgU0VSVklDRVM7IExPU1MgT0YgVVNFLCBEQVRBLCBPUgorICogUFJPRklUUzsgT1Ig QlVTSU5FU1MgSU5URVJSVVBUSU9OKSBIT1dFVkVSIENBVVNFRCBBTkQgT04gQU5ZIFRIRU9SWQor ICogT0YgTElBQklMSVRZLCBXSEVUSEVSIElOIENPTlRSQUNULCBTVFJJQ1QgTElBQklMSVRZLCBP UiBUT1JUCisgKiAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklTSU5HIElO IEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UKKyAqIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURW SVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCisgKi8KKworI2luY2x1ZGUg ImNvbmZpZy5oIgorI2luY2x1ZGUgIlNoYXJlZEJ1ZmZlci5oIgorCisjaW5jbHVkZSA8ZmNudGwu aD4KKyNpbmNsdWRlIDxzeXMvc3RhdC5oPgorI2luY2x1ZGUgPHVuaXN0ZC5oPgorI2luY2x1ZGUg PHd0Zi90ZXh0L0NTdHJpbmcuaD4KKworbmFtZXNwYWNlIFdlYkNvcmUgeworCitQYXNzUmVmUHRy PFNoYXJlZEJ1ZmZlcj4gU2hhcmVkQnVmZmVyOjpjcmVhdGVXaXRoQ29udGVudHNPZkZpbGUoY29u c3QgU3RyaW5nJiBmaWxlUGF0aCkKK3sKKyAgICBpZiAoZmlsZVBhdGguaXNFbXB0eSgpKQorICAg ICAgICByZXR1cm4gMDsKKworICAgIGludCBmZCA9IG9wZW4oZmlsZVBhdGgudXRmOCgpLmRhdGEo KSwgT19SRE9OTFkpOworICAgIGlmIChmZCA9PSAtMSkKKyAgICAgICAgcmV0dXJuIDA7CisKKyAg ICBzdHJ1Y3Qgc3RhdCBmaWxlU3RhdDsKKyAgICBpZiAoZnN0YXQoZmQsICZmaWxlU3RhdCkpIHsK KyAgICAgICAgY2xvc2UoZmQpOworICAgICAgICByZXR1cm4gMDsKKyAgICB9CisKKyAgICBzaXpl X3QgYnl0ZXNUb1JlYWQgPSBmaWxlU3RhdC5zdF9zaXplOworICAgIFJlZlB0cjxTaGFyZWRCdWZm ZXI+IHJlc3VsdCA9IFNoYXJlZEJ1ZmZlcjo6Y3JlYXRlKCk7CisgICAgcmVzdWx0LT5tX2J1ZmZl ci5yZXNpemUoYnl0ZXNUb1JlYWQpOworICAgIGlmIChyZXN1bHQtPm1fYnVmZmVyLnNpemUoKSAh PSBieXRlc1RvUmVhZCkgeworICAgICAgICBjbG9zZShmZCk7CisgICAgICAgIHJldHVybiAwOwor ICAgIH0KKworICAgIHNzaXplX3QgYnl0ZXNSZWFkID0gMDsKKyAgICBzaXplX3QgdG90YWxCeXRl c1JlYWQgPSAwOworICAgIHdoaWxlICgoYnl0ZXNSZWFkID0gcmVhZChmZCwgcmVzdWx0LT5tX2J1 ZmZlci5kYXRhKCkgKyB0b3RhbEJ5dGVzUmVhZCwgYnl0ZXNUb1JlYWQgLSB0b3RhbEJ5dGVzUmVh ZCkpID4gMCkKKyAgICAgICAgdG90YWxCeXRlc1JlYWQgKz0gYnl0ZXNSZWFkOworCisgICAgY2xv c2UoZmQpOworCisgICAgcmV0dXJuIHRvdGFsQnl0ZXNSZWFkID09IGJ5dGVzVG9SZWFkID8gcmVz dWx0LnJlbGVhc2UoKSA6IDA7Cit9CisKK30gLy8gbmFtZXNwYWNlIFdlYkNvcmUK 56471 2010-05-19 00:41:47 -0700 2010-05-20 18:19:50 -0700 patch patchFor39283_0 text/plain 3371 joybro201 SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1OTc0OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMDUtMTggIFlvdW5nIEhhbiBMZWUgIDxqb3licm9AY29tcGFu eTEwMC5uZXQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgUG9ydCBTaGFyZWRCdWZmZXIgdG8gUE9TSVguCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zOTI4MworCisgICAgICAgICogcGxhdGZvcm0vcG9zaXgv U2hhcmVkQnVmZmVyUE9TSVguY3BwOiBBZGRlZC4KKyAgICAgICAgKFdlYkNvcmU6OlNoYXJlZEJ1 ZmZlcjo6Y3JlYXRlV2l0aENvbnRlbnRzT2ZGaWxlKToKKwogMjAxMC0wNS0xOCAgRXJpYyBTZWlk ZWwgIDxlcmljQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFjaWVqIFN0YWNo b3dpYWsuCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL3Bvc2l4L1NoYXJlZEJ1ZmZlclBPU0lYLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL3Bvc2l4L1NoYXJlZEJ1ZmZlclBPU0lY LmNwcAkocmV2aXNpb24gMCkKKysrIFdlYkNvcmUvcGxhdGZvcm0vcG9zaXgvU2hhcmVkQnVmZmVy UE9TSVguY3BwCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDc0IEBACisvKgorICogQ29weXJpZ2h0 IChDKSAyMDEwIENvbXBhbnkgMTAwLCBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKgorICog UmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBv ciB3aXRob3V0CisgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0 aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKKyAqIGFyZSBtZXQ6CisgKiAxLiBSZWRpc3RyaWJ1dGlv bnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdodAorICogICAg bm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFp bWVyLgorICogMi4gUmVkaXN0cmlidXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9kdWNl IHRoZSBhYm92ZSBjb3B5cmlnaHQKKyAqICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlv bnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lciBpbiB0aGUKKyAqICAgIGRvY3VtZW50YXRp b24gYW5kL29yIG90aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRoIHRoZSBkaXN0cmlidXRpb24u CisgKgorICogVEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBBUFBMRSBDT01QVVRFUiwgSU5D LiBgYEFTIElTJycgQU5EIEFOWQorICogRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMsIElO Q0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRPLCBUSEUKKyAqIElNUExJRUQgV0FSUkFOVElFUyBP RiBNRVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUgorICogUFVSUE9T RSBBUkUgRElTQ0xBSU1FRC4gIElOIE5PIEVWRU5UIFNIQUxMIEFQUExFIENPTVBVVEVSLCBJTkMu IE9SCisgKiBDT05UUklCVVRPUlMgQkUgTElBQkxFIEZPUiBBTlkgRElSRUNULCBJTkRJUkVDVCwg SU5DSURFTlRBTCwgU1BFQ0lBTCwKKyAqIEVYRU1QTEFSWSwgT1IgQ09OU0VRVUVOVElBTCBEQU1B R0VTIChJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywKKyAqIFBST0NVUkVNRU5UIE9GIFNV QlNUSVRVVEUgR09PRFMgT1IgU0VSVklDRVM7IExPU1MgT0YgVVNFLCBEQVRBLCBPUgorICogUFJP RklUUzsgT1IgQlVTSU5FU1MgSU5URVJSVVBUSU9OKSBIT1dFVkVSIENBVVNFRCBBTkQgT04gQU5Z IFRIRU9SWQorICogT0YgTElBQklMSVRZLCBXSEVUSEVSIElOIENPTlRSQUNULCBTVFJJQ1QgTElB QklMSVRZLCBPUiBUT1JUCisgKiAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBB UklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UKKyAqIE9GIFRISVMgU09GVFdBUkUsIEVW RU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCisgKi8KKwor I2luY2x1ZGUgImNvbmZpZy5oIgorI2luY2x1ZGUgIlNoYXJlZEJ1ZmZlci5oIgorCisjaW5jbHVk ZSAiRmlsZVN5c3RlbS5oIgorCisjaW5jbHVkZSA8ZmNudGwuaD4KKyNpbmNsdWRlIDxzeXMvc3Rh dC5oPgorI2luY2x1ZGUgPHVuaXN0ZC5oPgorI2luY2x1ZGUgPHd0Zi90ZXh0L0NTdHJpbmcuaD4K KworbmFtZXNwYWNlIFdlYkNvcmUgeworCitQYXNzUmVmUHRyPFNoYXJlZEJ1ZmZlcj4gU2hhcmVk QnVmZmVyOjpjcmVhdGVXaXRoQ29udGVudHNPZkZpbGUoY29uc3QgU3RyaW5nJiBmaWxlUGF0aCkK K3sKKyAgICBpZiAoZmlsZVBhdGguaXNFbXB0eSgpKQorICAgICAgICByZXR1cm4gMDsKKworICAg IGNoYXIqIGZpbGVuYW1lID0gZmlsZW5hbWVGcm9tU3RyaW5nKGZpbGVQYXRoKTsKKyAgICBpbnQg ZmQgPSBvcGVuKGZpbGVuYW1lLCBPX1JET05MWSk7CisgICAgZmFzdEZyZWUoZmlsZW5hbWUpOwor ICAgIGlmIChmZCA9PSAtMSkKKyAgICAgICAgcmV0dXJuIDA7CisKKyAgICBzdHJ1Y3Qgc3RhdCBm aWxlU3RhdDsKKyAgICBpZiAoZnN0YXQoZmQsICZmaWxlU3RhdCkpIHsKKyAgICAgICAgY2xvc2Uo ZmQpOworICAgICAgICByZXR1cm4gMDsKKyAgICB9CisKKyAgICBzaXplX3QgYnl0ZXNUb1JlYWQg PSBmaWxlU3RhdC5zdF9zaXplOworICAgIGlmIChieXRlc1RvUmVhZCAhPSBmaWxlU3RhdC5zdF9z aXplKSB7CisgICAgICAgIGNsb3NlKGZkKTsKKyAgICAgICAgcmV0dXJuIDA7CisgICAgfQorCisg ICAgUmVmUHRyPFNoYXJlZEJ1ZmZlcj4gcmVzdWx0ID0gY3JlYXRlKCk7CisgICAgcmVzdWx0LT5t X2J1ZmZlci5ncm93KGJ5dGVzVG9SZWFkKTsKKworICAgIHNpemVfdCB0b3RhbEJ5dGVzUmVhZCA9 IDA7CisgICAgc3NpemVfdCBieXRlc1JlYWQ7CisgICAgd2hpbGUgKChieXRlc1JlYWQgPSByZWFk KGZkLCByZXN1bHQtPm1fYnVmZmVyLmRhdGEoKSArIHRvdGFsQnl0ZXNSZWFkLCBieXRlc1RvUmVh ZCAtIHRvdGFsQnl0ZXNSZWFkKSkgPiAwKQorICAgICAgICB0b3RhbEJ5dGVzUmVhZCArPSBieXRl c1JlYWQ7CisKKyAgICBjbG9zZShmZCk7CisKKyAgICByZXR1cm4gdG90YWxCeXRlc1JlYWQgPT0g Ynl0ZXNUb1JlYWQgPyByZXN1bHQucmVsZWFzZSgpIDogMDsKK30KKworfSAvLyBuYW1lc3BhY2Ug V2ViQ29yZQo=