39282 2010-05-18 03:57:58 -0700 Slave lost shouldn't be recognized as build failed 2010-06-02 13:55:46 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 40055 40056 1 ossy webkit-unassigned abarth eric oldest_to_newest 227242 0 ossy 2010-05-18 03:57:58 -0700 Unfortunately slave lost is recognized as build failed now, and sherrifbot bother innocent folks with false positive alarms on IRC and add comments into bugzilla. I propose sherrifbot should handle "slave lost" as "build successful". 227244 1 56355 ossy 2010-05-18 03:59:38 -0700 Created attachment 56355 proposed patch 227247 2 eric 2010-05-18 04:06:07 -0700 I don't think this is the right fix. But it's an interesting hack. For one, we would need to unit test this. Secondly, I think the right fix would be to crawl back a revision and use that as the current red/green status instead of just assuming "slave-lost" means green. Although maybe we should just treat lost slaves as green? Not sure. 232868 3 56355 eric 2010-06-01 11:30:27 -0700 Comment on attachment 56355 proposed patch Please add a FIXME comment. Something like: # FIXME: We treat slave lost as green even though it is not to work # around the Qts bot being on a broken internet connection. # The real fix is https://bugs.webkit.org/show_bug.cgi?id=37099 But this solution is pragmatic and we should do it. 233211 4 ossy 2010-06-02 05:13:31 -0700 Landed in http://trac.webkit.org/changeset/60559 233222 5 ossy 2010-06-02 05:37:49 -0700 (In reply to comment #4) > Landed in http://trac.webkit.org/changeset/60559 And rolled-out by http://trac.webkit.org/changeset/60560 because I forgot about unit test and broke the whole world. Sorry. Fix is coming soon. 233283 6 57659 ossy 2010-06-02 08:41:55 -0700 Created attachment 57659 Patch 233289 7 ossy 2010-06-02 08:46:28 -0700 (In reply to comment #6) > Created an attachment (id=57659) [details] > Patch Here is the fixed patch with unit test for slave lost. I have to add a "not not", because False or None == None. Or is there any simple way to fix this problem? Error message why I had to roll-out my earlier patch: Traceback (most recent call last): File "/Volumes/Data/WebKit-BuildSlave/snowleopard-intel-leaks/build/WebKitTools/Scripts/webkitpy/common/net/buildbot_unittest.py", line 218, in test_status_parsing self.assertEquals(builder[key], expected_value, ("Builder %d parse failure for key: %s: Actual='%s' Expected='%s'" % (x, key, builder[key], expected_value))) AssertionError: Builder 2 parse failure for key: is_green: Actual='None' Expected='False' 233372 8 57659 eric 2010-06-02 11:44:54 -0700 Comment on attachment 57659 Patch LGTM. This seems like the right fix. 233435 9 ossy 2010-06-02 13:55:46 -0700 (In reply to comment #8) > (From update of attachment 57659 [details]) > LGTM. This seems like the right fix. Landed in http://trac.webkit.org/changeset/60575 . 56355 2010-05-18 03:59:38 -0700 2010-06-02 08:41:48 -0700 proposed patch slavelost.patch text/plain 1523 ossy ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA0NDgyMjIzLi4wNmE3NTZmIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDUt MTggIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTbGF2ZSBsb3N0IHNob3VsZG4ndCBi ZSByZWNvZ25pemVkIGFzIGJ1aWxkIGZhaWxlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTM5MjgyCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5 L2NvbW1vbi9uZXQvYnVpbGRib3QucHk6CisKIDIwMTAtMDUtMTggIEZ1bWl0b3NoaSBVa2FpICA8 dWthaUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRp ZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVpbGRi b3QucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVpbGRib3Qu cHkKaW5kZXggNmM2ZWQ0My4uZDJiMzUzNiAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0 cy93ZWJraXRweS9jb21tb24vbmV0L2J1aWxkYm90LnB5CisrKyBiL1dlYktpdFRvb2xzL1Njcmlw dHMvd2Via2l0cHkvY29tbW9uL25ldC9idWlsZGJvdC5weQpAQCAtMzMzLDcgKzMzMyw5IEBAIGNs YXNzIEJ1aWxkQm90KG9iamVjdCk6CiAgICAgICAgICAgICBidWlsZGVyWydidWlsdF9yZXZpc2lv biddID0gaW50KHJldmlzaW9uX3N0cmluZykgXAogICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGlmIG5vdCByZS5tYXRjaCgnXEQnLCByZXZpc2lvbl9zdHJpbmcpIFwKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBlbHNlIE5vbmUKLSAgICAgICAg ICAgIGJ1aWxkZXJbJ2lzX2dyZWVuJ10gPSBub3QgcmUuc2VhcmNoKCdmYWlsJywgY2VsbC5yZW5k ZXJDb250ZW50cygpKQorICAgICAgICAgICAgIyBUaGUgYnVpbGRlciBpcyBncmVlbiBpZiB0aGUg bGFzdCBidWlsZCBkaWRuJ3QgZmFpbCBvciAic2xhdmUgbG9zdCIgb2NjdXJlZC4KKyAgICAgICAg ICAgIGJ1aWxkZXJbJ2lzX2dyZWVuJ10gPSBub3QgcmUuc2VhcmNoKCdmYWlsJywgY2VsbC5yZW5k ZXJDb250ZW50cygpKSBvciBcCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmUu c2VhcmNoKCdsb3N0JywgY2VsbC5yZW5kZXJDb250ZW50cygpKQogCiAgICAgICAgICAgICBzdGF0 dXNfbGlua19yZWdleHAgPSByImJ1aWxkZXJzLyg/UDxidWlsZGVyX25hbWU+LiopL2J1aWxkcy8o P1A8YnVpbGRfbnVtYmVyPlxkKykiCiAgICAgICAgICAgICBsaW5rX21hdGNoID0gcmUubWF0Y2go c3RhdHVzX2xpbmtfcmVnZXhwLCBzdGF0dXNfbGlua1snaHJlZiddKQo= 57659 2010-06-02 08:41:55 -0700 2010-06-02 11:44:53 -0700 Patch bug-39282-20100602084153.patch text/plain 3413 ossy SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDYwNTY3KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDYtMDIgIENzYWJhIE9zenRyb2dvbsOh YyAgPG9zc3lAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBTbGF2ZSBsb3N0IHNob3VsZG4ndCBiZSByZWNvZ25pemVkIGFzIGJ1aWxk IGZhaWxlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTM5MjgyCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVpbGRib3Qu cHk6IFRyZWF0IHNsYXZlIGxvc3QgYXMgZ3JlZW4uCisgICAgICAgICogU2NyaXB0cy93ZWJraXRw eS9jb21tb24vbmV0L2J1aWxkYm90X3VuaXR0ZXN0LnB5OiBBZGQgdW5pdCB0ZXN0IGZvciBzbGF2 ZSBsb3N0LgorCiAyMDEwLTA2LTAxICBZYWVsIEFoYXJvbiAgPHlhZWwuYWhhcm9uQG5va2lhLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbi4KSW5k ZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9idWlsZGJvdC5weQo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVp bGRib3QucHkJKHJldmlzaW9uIDYwNTYxKQorKysgV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRw eS9jb21tb24vbmV0L2J1aWxkYm90LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0zMzMsNyArMzMzLDEy IEBAIGNsYXNzIEJ1aWxkQm90KG9iamVjdCk6CiAgICAgICAgICAgICBidWlsZGVyWydidWlsdF9y ZXZpc2lvbiddID0gaW50KHJldmlzaW9uX3N0cmluZykgXAogICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIGlmIG5vdCByZS5tYXRjaCgnXEQnLCByZXZpc2lvbl9zdHJpbmcp IFwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBlbHNlIE5vbmUKLSAg ICAgICAgICAgIGJ1aWxkZXJbJ2lzX2dyZWVuJ10gPSBub3QgcmUuc2VhcmNoKCdmYWlsJywgY2Vs bC5yZW5kZXJDb250ZW50cygpKQorCisgICAgICAgICAgICAjIEZJWE1FOiBXZSB0cmVhdCBzbGF2 ZSBsb3N0IGFzIGdyZWVuIGV2ZW4gdGhvdWdoIGl0IGlzIG5vdCB0bworICAgICAgICAgICAgIyB3 b3JrIGFyb3VuZCB0aGUgUXRzIGJvdCBiZWluZyBvbiBhIGJyb2tlbiBpbnRlcm5ldCBjb25uZWN0 aW9uLgorICAgICAgICAgICAgIyBUaGUgcmVhbCBmaXggaXMgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTM3MDk5CisgICAgICAgICAgICBidWlsZGVyWydpc19ncmVlbidd ID0gbm90IHJlLnNlYXJjaCgnZmFpbCcsIGNlbGwucmVuZGVyQ29udGVudHMoKSkgb3IgXAorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG5vdCBub3QgcmUuc2VhcmNoKCdsb3N0Jywg Y2VsbC5yZW5kZXJDb250ZW50cygpKQogCiAgICAgICAgICAgICBzdGF0dXNfbGlua19yZWdleHAg PSByImJ1aWxkZXJzLyg/UDxidWlsZGVyX25hbWU+LiopL2J1aWxkcy8oP1A8YnVpbGRfbnVtYmVy PlxkKykiCiAgICAgICAgICAgICBsaW5rX21hdGNoID0gcmUubWF0Y2goc3RhdHVzX2xpbmtfcmVn ZXhwLCBzdGF0dXNfbGlua1snaHJlZiddKQpJbmRleDogV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJr aXRweS9jb21tb24vbmV0L2J1aWxkYm90X3VuaXR0ZXN0LnB5Cj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktp dFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9idWlsZGJvdF91bml0dGVzdC5weQko cmV2aXNpb24gNjA1NjEpCisrKyBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9u ZXQvYnVpbGRib3RfdW5pdHRlc3QucHkJKHdvcmtpbmcgY29weSkKQEAgLTE2OSw2ICsxNjksMTAg QEAgY2xhc3MgQnVpbGRCb3RUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICA8dGQgY2xhc3M9 ImJveCI+PGEgaHJlZj0iYnVpbGRlcnMvUXQlMjBMaW51eCUyMFJlbGVhc2UiPlF0IExpbnV4IFJl bGVhc2U8L2E+PC90ZD4KICAgICAgIDx0ZCBhbGlnbj0iY2VudGVyIiBjbGFzcz0iTGFzdEJ1aWxk IGJveCBmYWlsdXJlIj48YSBocmVmPSJidWlsZGVycy9RdCUyMExpbnV4JTIwUmVsZWFzZS9idWls ZHMvNjU0Ij40NzM4MzwvYT48YnIgLz5mYWlsZWQ8YnIgLz5jb21waWxlLXdlYmtpdDwvdGQ+CiAg ICAgICA8dGQgYWxpZ249ImNlbnRlciIgY2xhc3M9IkFjdGl2aXR5IGlkbGUiPmlkbGU8YnIgLz4z IHBlbmRpbmc8L3RkPgorICAgIDx0cj4KKyAgICA8dGQgY2xhc3M9ImJveCI+PGEgaHJlZj0iYnVp bGRlcnMvUXQlMjBXaW5kb3dzJTIwMzItYml0JTIwRGVidWciPlF0IFdpbmRvd3MgMzItYml0IERl YnVnPC9hPjwvdGQ+CisgICAgICA8dGQgYWxpZ249ImNlbnRlciIgY2xhc3M9Ikxhc3RCdWlsZCBi b3ggZmFpbHVyZSI+PGEgaHJlZj0iYnVpbGRlcnMvUXQlMjBXaW5kb3dzJTIwMzItYml0JTIwRGVi dWcvYnVpbGRzLzIwOTAiPjYwNTYzPC9hPjxiciAvPmZhaWxlZDxiciAvPmZhaWxlZDxiciAvPnNs YXZlPGJyIC8+bG9zdDwvdGQ+CisgICAgICA8dGQgYWxpZ249ImNlbnRlciIgY2xhc3M9IkFjdGl2 aXR5IGJ1aWxkaW5nIj5idWlsZGluZzxiciAvPkVUQSBpbjxiciAvPn4gNSBtaW5zPGJyIC8+YXQg MDg6MjU8L3RkPgogICAgIDwvdGFibGU+CiAnJycKICAgICBfZXhwZWN0ZWRfZXhhbXBsZV9vbmVf Ym94X3BhcnNpbmdzID0gWwpAQCAtMTk2LDYgKzIwMCwxNCBAQCBjbGFzcyBCdWlsZEJvdFRlc3Qo dW5pdHRlc3QuVGVzdENhc2UpOgogICAgICAgICAgICAgJ2FjdGl2aXR5JzogJ2lkbGUnLAogICAg ICAgICAgICAgJ3BlbmRpbmdfYnVpbGRzJzogMywKICAgICAgICAgfSwKKyAgICAgICAgeworICAg ICAgICAgICAgJ2lzX2dyZWVuJzogVHJ1ZSwKKyAgICAgICAgICAgICdidWlsZF9udW1iZXInIDog MjA5MCwKKyAgICAgICAgICAgICduYW1lJzogdSdRdCBXaW5kb3dzIDMyLWJpdCBEZWJ1ZycsCisg ICAgICAgICAgICAnYnVpbHRfcmV2aXNpb24nOiA2MDU2MywKKyAgICAgICAgICAgICdhY3Rpdml0 eSc6ICdidWlsZGluZycsCisgICAgICAgICAgICAncGVuZGluZ19idWlsZHMnOiAwLAorICAgICAg ICB9LAogICAgIF0KIAogICAgIGRlZiB0ZXN0X3N0YXR1c19wYXJzaW5nKHNlbGYpOgo=