39242 2010-05-17 14:58:38 -0700 WinEWS should build Debug instead of Release 2010-05-19 22:38:30 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 39197 1 eric webkit-unassigned abarth aroben bweinstein cjerdonek commit-queue ojan oldest_to_newest 226908 0 eric 2010-05-17 14:58:38 -0700 WinEWS should build Debug instead of Release 226912 1 56274 eric 2010-05-17 15:00:41 -0700 Created attachment 56274 Patch 226914 2 56274 eric 2010-05-17 15:01:59 -0700 Comment on attachment 56274 Patch The WinEWS automatically restarts itself (and does a clean build) every 50 builds, so it will pick this up automatically once it lands. 226915 3 eric 2010-05-17 15:02:31 -0700 I wonder if I need to make the same change to the cr-win-ews. 226917 4 eric 2010-05-17 15:02:52 -0700 We also could just move the WinEWS to a EC2 machine with 64-bit windows. 226927 5 mrowe 2010-05-17 15:13:26 -0700 Release builds on Windows tend to be substantially slower to link than Debug builds due to link-time code generation, so this is probably a good change even if the builder was running 64-bit Windows. 226953 6 bweinstein 2010-05-17 15:51:22 -0700 (In reply to comment #5) > Release builds on Windows tend to be substantially slower to link than Debug builds due to link-time code generation, so this is probably a good change even if the builder was running 64-bit Windows. I agree with this - look at: http://build.webkit.org/builders/Windows%20Release%20%28Build%29/builds/14330 and compare to http://build.webkit.org/builders/Windows%20Debug%20%28Build%29/builds/15539 They are both builds from the same change, and the release build took 17 minutes (almost all linking), while the debug build took 1.5 minutes. We should definitely be using debug for now. 227281 7 aroben 2010-05-18 06:53:08 -0700 Why does this bug depend on bug 39197? 227282 8 56274 aroben 2010-05-18 06:53:37 -0700 Comment on attachment 56274 Patch r=me 227391 9 eric 2010-05-18 11:18:39 -0700 (In reply to comment #7) > Why does this bug depend on bug 39197? I was just trying to relate the two. I often want a "related bugs" field in bugzilla which doesn't imply dependency. 228204 10 56274 commit-queue 2010-05-19 22:38:23 -0700 Comment on attachment 56274 Patch Clearing flags on attachment: 56274 Committed r59821: <http://trac.webkit.org/changeset/59821> 228205 11 commit-queue 2010-05-19 22:38:30 -0700 All reviewed patches have been landed. Closing bug. 56274 2010-05-17 15:00:41 -0700 2010-05-19 22:38:22 -0700 Patch bug-39242-20100517150040.patch text/plain 1575 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA4OTlkM2NlZjE0NzI2MjdhM2U3MTdlODQyMjY4NDljZDM3MjU2MGQ4Li4wNjBmNDRk MmIyZDQ0NjJjMTk2MGUzOTI4NDUzYzQ2N2M1MDAxYWRhIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAK KzIwMTAtMDUtMTcgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdpbkVXUyBzaG91bGQgYnVpbGQg RGVidWcgaW5zdGVhZCBvZiBSZWxlYXNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0zOTI0MgorCisgICAgICAgIFRoaXMgaXMgYSB3b3JrYXJvdW5kIGZv cgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzkxOTcK KyAgICAgICAgQWRhbSBSb2JlbiBhbmQgQnJpYW4gV2VpbnN0ZWluIGJlbGlldmUgdGhpcyBtYXkK KyAgICAgICAgYWxzbyBtYWtlIGJ1aWxkaW5nIGZhc3RlciBzaW5jZSBEZWJ1ZyBidWlsZHMKKyAg ICAgICAgdGFrZSBsZXNzIHRpbWUgdG8gbGluay4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0 cHkvdG9vbC9jb21tYW5kcy9lYXJseXdhcm5pbmdzeXN0ZW0ucHk6CisKIDIwMTAtMDUtMTcgIFJv YmVydCBIb2dhbiAgPHJvYmVydEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtl bm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0 cy93ZWJraXRweS90b29sL2NvbW1hbmRzL2Vhcmx5d2FybmluZ3N5c3RlbS5weSBiL1dlYktpdFRv b2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9lYXJseXdhcm5pbmdzeXN0ZW0ucHkK aW5kZXggNzUwNWM2MjQ4ZWQxZWJkYmY5MDBiMTA3ZTI5OWQ4NTE5N2MyYjUyYy4uOWZiZmRhNmQ4 YmFjZTFjNTI3YWMxZDBmZDk3ZDkwMWVlNTlmMTFhYiAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMv U2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL2Vhcmx5d2FybmluZ3N5c3RlbS5weQorKysg Yi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvZWFybHl3YXJuaW5n c3lzdGVtLnB5CkBAIC0xMTYsNiArMTE2LDkgQEAgY2xhc3MgUXRFV1MoQWJzdHJhY3RFYXJseVdh cm5pbmdTeXN0ZW0pOgogY2xhc3MgV2luRVdTKEFic3RyYWN0RWFybHlXYXJuaW5nU3lzdGVtKToK ICAgICBuYW1lID0gIndpbi1ld3MiCiAgICAgcG9ydF9uYW1lID0gIndpbiIKKyAgICAjIFVzZSBk ZWJ1ZywgdGhlIEFwcGxlIFdpbiBwb3J0IGZhaWxzIHRvIGxpbmsgUmVsZWFzZSBvbiAzMi1iaXQg V2luZG93cy4KKyAgICAjIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0z OTE5NworICAgIF9idWlsZF9zdHlsZSA9ICJkZWJ1ZyIKIAogCiBjbGFzcyBBYnN0cmFjdENocm9t aXVtRVdTKEFic3RyYWN0RWFybHlXYXJuaW5nU3lzdGVtKToK