39238 2010-05-17 14:39:51 -0700 [chromium] Add methods to chromium WebAccessibilityObject 2010-05-20 19:19:54 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC Windows Vista RESOLVED FIXED P2 Minor --- 1 dmazzoni webkit-unassigned cfleizach commit-queue fishd levin oldest_to_newest 226899 0 dmazzoni 2010-05-17 14:39:51 -0700 Chromium classes such as WebAccessibilityObject are simple wrappers for corresponding WebCore classes like AccessibilityObject. They work fine, but much functionality is not exposed in the wrapper. I'm using this bug to keep track of the progress. Rather than trying to add support for everything at once, for now I'm just adding methods as needed, starting with: headingLevel setFocused 226901 1 56271 dmazzoni 2010-05-17 14:45:58 -0700 Created attachment 56271 Add headingLevel and setFocused methods to WebAccessibilityObject. 227890 2 levin 2010-05-19 10:55:42 -0700 Chromium public api changes, so leaving this for Darin Fisher. 227910 3 cfleizach 2010-05-19 11:30:06 -0700 looks ok to me, but i'm not a reviewer 228702 4 56271 commit-queue 2010-05-20 19:19:48 -0700 Comment on attachment 56271 Add headingLevel and setFocused methods to WebAccessibilityObject. Clearing flags on attachment: 56271 Committed r59898: <http://trac.webkit.org/changeset/59898> 228703 5 commit-queue 2010-05-20 19:19:54 -0700 All reviewed patches have been landed. Closing bug. 56271 2010-05-17 14:45:58 -0700 2010-05-20 19:19:47 -0700 Add headingLevel and setFocused methods to WebAccessibilityObject. heading_level1.patch text/plain 2364 dmazzoni SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTk2MjYpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDUtMTcgIERvbWlu aWMgTWF6em9uaSAgPGRtYXp6b25pQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgaGVhZGluZ0xldmVsIGFuZCBzZXRGb2N1 c2VkIG1ldGhvZHMuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTM5MjM4CisKKyAgICAgICAgKiBwdWJsaWMvV2ViQWNjZXNzaWJpbGl0eU9iamVjdC5o OgorICAgICAgICAqIHNyYy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0LmNwcDoKKyAgICAgICAgKFdl YktpdDo6V2ViQWNjZXNzaWJpbGl0eU9iamVjdDo6aGVhZGluZ0xldmVsKToKKyAgICAgICAgKFdl YktpdDo6V2ViQWNjZXNzaWJpbGl0eU9iamVjdDo6c2V0Rm9jdXNlZCk6CisKIDIwMTAtMDUtMTYg IE1pa2UgQmVsc2hlICA8bWJlbHNoZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgRGltaXRyaSBHbGF6a292LgpJbmRleDogV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJBY2Nl c3NpYmlsaXR5T2JqZWN0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9X ZWJBY2Nlc3NpYmlsaXR5T2JqZWN0LmgJKHJldmlzaW9uIDU5NjE3KQorKysgV2ViS2l0L2Nocm9t aXVtL3B1YmxpYy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0LmgJKHdvcmtpbmcgY29weSkKQEAgLTk0 LDEwICs5NCwxMiBAQCBwdWJsaWM6CiAKICAgICBXZWJSZWN0IGJvdW5kaW5nQm94UmVjdCgpIGNv bnN0OwogICAgIFdlYlN0cmluZyBoZWxwVGV4dCgpIGNvbnN0OworICAgIGludCBoZWFkaW5nTGV2 ZWwoKSBjb25zdDsKICAgICBXZWJBY2Nlc3NpYmlsaXR5T2JqZWN0IGhpdFRlc3QoY29uc3QgV2Vi UG9pbnQmKSBjb25zdDsKICAgICBXZWJTdHJpbmcga2V5Ym9hcmRTaG9ydGN1dCgpIGNvbnN0Owog ICAgIGJvb2wgcGVyZm9ybURlZmF1bHRBY3Rpb24oKSBjb25zdDsKICAgICBXZWJBY2Nlc3NpYmls aXR5Um9sZSByb2xlVmFsdWUoKSBjb25zdDsKKyAgICB2b2lkIHNldEZvY3VzZWQoYm9vbCkgY29u c3Q7CiAgICAgV2ViU3RyaW5nIHN0cmluZ1ZhbHVlKCkgY29uc3Q7CiAgICAgV2ViU3RyaW5nIHRp dGxlKCkgY29uc3Q7CiAKSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViQWNjZXNzaWJpbGl0 eU9iamVjdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJBY2Nlc3Np YmlsaXR5T2JqZWN0LmNwcAkocmV2aXNpb24gNTk2MTcpCisrKyBXZWJLaXQvY2hyb21pdW0vc3Jj L1dlYkFjY2Vzc2liaWxpdHlPYmplY3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMDMsNiArMzAz LDE1IEBAIFdlYlN0cmluZyBXZWJBY2Nlc3NpYmlsaXR5T2JqZWN0OjpoZWxwVGUKICAgICByZXR1 cm4gbV9wcml2YXRlLT5oZWxwVGV4dCgpOwogfQogCitpbnQgV2ViQWNjZXNzaWJpbGl0eU9iamVj dDo6aGVhZGluZ0xldmVsKCkgY29uc3QKK3sKKyAgICBpZiAoIW1fcHJpdmF0ZSkKKyAgICAgICAg cmV0dXJuIDA7CisKKyAgICBtX3ByaXZhdGUtPnVwZGF0ZUJhY2tpbmdTdG9yZSgpOworICAgIHJl dHVybiBtX3ByaXZhdGUtPmhlYWRpbmdMZXZlbCgpOworfQorCiBXZWJBY2Nlc3NpYmlsaXR5T2Jq ZWN0IFdlYkFjY2Vzc2liaWxpdHlPYmplY3Q6OmhpdFRlc3QoY29uc3QgV2ViUG9pbnQmIHBvaW50 KSBjb25zdAogewogICAgIGlmICghbV9wcml2YXRlKQpAQCAtMzY4LDYgKzM3NywxMiBAQCBXZWJB Y2Nlc3NpYmlsaXR5Um9sZSBXZWJBY2Nlc3NpYmlsaXR5T2JqCiAgICAgcmV0dXJuIHN0YXRpY19j YXN0PFdlYkFjY2Vzc2liaWxpdHlSb2xlPihtX3ByaXZhdGUtPnJvbGVWYWx1ZSgpKTsKIH0KIAor dm9pZCBXZWJBY2Nlc3NpYmlsaXR5T2JqZWN0OjpzZXRGb2N1c2VkKGJvb2wgb24pIGNvbnN0Cit7 CisgICAgaWYgKG1fcHJpdmF0ZSkKKyAgICAgICAgbV9wcml2YXRlLT5zZXRGb2N1c2VkKG9uKTsK K30KKwogV2ViU3RyaW5nIFdlYkFjY2Vzc2liaWxpdHlPYmplY3Q6OnN0cmluZ1ZhbHVlKCkgY29u c3QKIHsKICAgICBpZiAoIW1fcHJpdmF0ZSkK