39237 2010-05-17 14:31:43 -0700 Web Inspector: keyboard shortcut screen does not disappear on Esc. 2010-05-19 21:37:20 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman caseq commit-queue joepeck timothy yurys oldest_to_newest 226897 0 pfeldman 2010-05-17 14:31:43 -0700 - Open inspector in docked mode - Press ? to show the screen - Undock inspector - Press Esc Actual: console is being opened. (Observed on Chromium ToT). 227314 1 56377 caseq 2010-05-18 08:23:55 -0700 Created attachment 56377 patch: maintain focus on help screen while it's shown This is obviously because we loose focus. I fixed it, but there are some caveats: - It doesn't work vice-versa (when transitioning for undocked to docked state), as entire inspector window gets out of focus. One would need to click it to get it focused again. This should probably be fixed in the browsers. - Text edit fields commit edited changes upon loosing focus. I hesitated whether we should disable our help when inspector is in editing mode, but then realized we only use shortcuts that would cause browser help to be opened, so we'll loose editor focus and commit changes anyway. 227315 2 56377 timothy 2010-05-18 08:28:27 -0700 Comment on attachment 56377 patch: maintain focus on help screen while it's shown WebCore/inspector/front-end/HelpScreen.js:44 + this.contentElement.addEventListener("blur", this._onBlur.bind(this), false); You should register this in show and _hide so there isn't always a listener, even if help is never used. WebCore/inspector/front-end/HelpScreen.js:87 + if (this._isShown) Then you wouldn't need to check this, since you know it was visible or your wouldn't have been called. Otherwise r+. 227324 3 caseq 2010-05-18 08:46:33 -0700 (In reply to comment #2) > (From update of attachment 56377 [details]) > WebCore/inspector/front-end/HelpScreen.js:44 > + this.contentElement.addEventListener("blur", this._onBlur.bind(this), false); > You should register this in show and _hide so there isn't always a listener, even if help is never used. HelpScreen is created lazily, so if help is never used, to HelpScreen() is never called in the first place, and there won't be a listener. If help has been used, having a listener on the event that's not fired is probably cheaper than removing it? 228184 4 56377 commit-queue 2010-05-19 21:37:15 -0700 Comment on attachment 56377 patch: maintain focus on help screen while it's shown Clearing flags on attachment: 56377 Committed r59816: <http://trac.webkit.org/changeset/59816> 228185 5 commit-queue 2010-05-19 21:37:20 -0700 All reviewed patches have been landed. Closing bug. 56377 2010-05-18 08:23:55 -0700 2010-05-19 21:37:15 -0700 patch: maintain focus on help screen while it's shown help-focus.patch text/plain 2536 caseq SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1OTY2OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDUtMTggIEFuZHJleSBLb3N5YWtvdiAgPGNhc2VxQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBNYWludGFpbiBmb2N1cyBvbiBoZWxwIHNjcmVlbiB3aGlsZSBpdCdzIGFjdGl2ZS4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5MjM3CisKKyAgICAg ICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0hlbHBTY3JlZW4uanM6CisgICAgICAgIChXZWJJbnNw ZWN0b3IuSGVscFNjcmVlbik6CisgICAgICAgIChXZWJJbnNwZWN0b3IuSGVscFNjcmVlbi5wcm90 b3R5cGUuc2hvdyk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuSGVscFNjcmVlbi5wcm90b3R5cGUu X2hpZGUpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkhlbHBTY3JlZW4ucHJvdG90eXBlLl9vbkJs dXIpOgorCiAyMDEwLTA1LTA4ICBSb2JlcnQgSG9nYW4gIDxyb2JlcnRAcm9iZXJ0aG9nYW4ubmV0 PgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEhhdXNtYW5uLgpJbmRleDogV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL0hlbHBTY3JlZW4uanMKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL0hlbHBTY3JlZW4uanMJKHJldmlzaW9uIDU5NjY5KQorKysgV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0hlbHBTY3JlZW4uanMJKHdvcmtpbmcgY29weSkKQEAg LTQxLDYgKzQxLDcgQEAgV2ViSW5zcGVjdG9yLkhlbHBTY3JlZW4gPSBmdW5jdGlvbih0aXRsZQog ICAgIHZhciBjbG9zZUJ1dHRvbiA9IGNhcHRpb25XaW5kb3cuY3JlYXRlQ2hpbGQoImJ1dHRvbiIs ICJoZWxwLWNsb3NlLWJ1dHRvbiIpOwogICAgIHRoaXMuY29udGVudEVsZW1lbnQgPSBtYWluV2lu ZG93LmNyZWF0ZUNoaWxkKCJkaXYiLCAiaGVscC1jb250ZW50Iik7CiAgICAgdGhpcy5jb250ZW50 RWxlbWVudC50YWJJbmRleCA9IDA7CisgICAgdGhpcy5jb250ZW50RWxlbWVudC5hZGRFdmVudExp c3RlbmVyKCJibHVyIiwgdGhpcy5fb25CbHVyLmJpbmQodGhpcyksIGZhbHNlKTsKICAgICBjYXB0 aW9uV2luZG93LmNyZWF0ZUNoaWxkKCJoMSIsICJoZWxwLXdpbmRvdy10aXRsZSIpLmlubmVyVGV4 dCA9IHRpdGxlOwogCiAgICAgY2xvc2VCdXR0b24uaW5uZXJUZXh0ID0gIlx1MjcxNiI7IC8vIENv ZGUgc3RhbmRzIGZvciBIRUFWWSBNVUxUSVBMSUNBVElPTiBYLgpAQCAtNTYsMTUgKzU3LDIwIEBA IFdlYkluc3BlY3Rvci5IZWxwU2NyZWVuID0gZnVuY3Rpb24odGl0bGUKIFdlYkluc3BlY3Rvci5I ZWxwU2NyZWVuLnByb3RvdHlwZSA9IHsKICAgICBzaG93OiBmdW5jdGlvbigpCiAgICAgeworICAg ICAgICBpZiAodGhpcy5faXNTaG93bikKKyAgICAgICAgICAgIHJldHVybjsKKwogICAgICAgICB0 aGlzLl9lbGVtZW50LnN0eWxlLnZpc2liaWxpdHkgPSAidmlzaWJsZSI7CiAgICAgICAgIHRoaXMu X2lzU2hvd24gPSB0cnVlOwotICAgICAgICB0aGlzLmNvbnRlbnRFbGVtZW50LmZvY3VzKCk7Cisg ICAgICAgIHRoaXMuX3ByZXZpb3VzRm9jdXNFbGVtZW50ID0gV2ViSW5zcGVjdG9yLmN1cnJlbnRG b2N1c0VsZW1lbnQ7CisgICAgICAgIFdlYkluc3BlY3Rvci5jdXJyZW50Rm9jdXNFbGVtZW50ID0g dGhpcy5jb250ZW50RWxlbWVudDsKICAgICB9LAogCiAgICAgX2hpZGU6IGZ1bmN0aW9uKCkKICAg ICB7CiAgICAgICAgIHRoaXMuX2lzU2hvd24gPSBmYWxzZTsKICAgICAgICAgdGhpcy5fZWxlbWVu dC5zdHlsZS52aXNpYmlsaXR5ID0gImhpZGRlbiI7CisgICAgICAgIFdlYkluc3BlY3Rvci5jdXJy ZW50Rm9jdXNFbGVtZW50ID0gdGhpcy5fcHJldmlvdXNGb2N1c0VsZW1lbnQ7CiAgICAgfSwKIAog ICAgIF9vbktleURvd246IGZ1bmN0aW9uKGV2ZW50KQpAQCAtNzUsNiArODEsMTMgQEAgV2ViSW5z cGVjdG9yLkhlbHBTY3JlZW4ucHJvdG90eXBlID0gewogICAgICAgICB9CiAgICAgfSwKIAorICAg IF9vbkJsdXI6IGZ1bmN0aW9uKCkKKyAgICB7CisgICAgICAgICAvLyBQcmV0ZW5kIHdlJ3JlIG1v ZGFsLCBncmFiIGZvY3VzIGJhY2sgaWYgd2UncmUgc3RpbGwgc2hvd24uCisgICAgICAgIGlmICh0 aGlzLl9pc1Nob3duKQorICAgICAgICAgICAgV2ViSW5zcGVjdG9yLmN1cnJlbnRGb2N1c0VsZW1l bnQgPSB0aGlzLmNvbnRlbnRFbGVtZW50OworICAgIH0sCisKICAgICBfYWRkU3R5bGVTaGVldElm TmVlZGVkOiBmdW5jdGlvbihocmVmKQogICAgIHsKICAgICAgICAgaWYgKFdlYkluc3BlY3Rvci5I ZWxwU2NyZWVuLl9zdHlsZVNoZWV0QWRkZWQpCg==