39233 2010-05-17 13:34:42 -0700 ThreadedMessageQueue should use with_statement for exception safety 2010-05-20 20:04:43 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned abarth cjerdonek commit-queue ojan oldest_to_newest 226883 0 eric 2010-05-17 13:34:42 -0700 ThreadedMessageQueue should use with_statement for exception safety 226884 1 56267 eric 2010-05-17 13:36:37 -0700 Created attachment 56267 Patch 228133 2 56267 abarth 2010-05-19 18:32:47 -0700 Comment on attachment 56267 Patch Nice. I wish I'd know about that when writing the code originally. 228715 3 56267 commit-queue 2010-05-20 20:04:37 -0700 Comment on attachment 56267 Patch Clearing flags on attachment: 56267 Committed r59902: <http://trac.webkit.org/changeset/59902> 228716 4 commit-queue 2010-05-20 20:04:43 -0700 All reviewed patches have been landed. Closing bug. 56267 2010-05-17 13:36:37 -0700 2010-05-20 20:04:37 -0700 Patch bug-39233-20100517133636.patch text/plain 2083 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA4OTlkM2NlZjE0NzI2MjdhM2U3MTdlODQyMjY4NDljZDM3MjU2MGQ4Li42NjEwYTdm M2ViNjBjMTNiMmE2Nzc5NDM1ZDdhZDI4YjFlOGUwYWRkIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTAtMDUtMTcgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRocmVhZGVkTWVzc2FnZVF1ZXVl IHNob3VsZCB1c2Ugd2l0aF9zdGF0ZW1lbnQgZm9yIGV4Y2VwdGlvbiBzYWZldHkKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5MjMzCisKKyAgICAgICAg KiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi90aHJlYWQvdGhyZWFkZWRtZXNzYWdlcXVldWUucHk6 CisKIDIwMTAtMDUtMTcgIFJvYmVydCBIb2dhbiAgPHJvYmVydEB3ZWJraXQub3JnPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuLgpkaWZmIC0tZ2l0IGEv V2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vdGhyZWFkL3RocmVhZGVkbWVzc2Fn ZXF1ZXVlLnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vdGhyZWFkL3Ro cmVhZGVkbWVzc2FnZXF1ZXVlLnB5CmluZGV4IDZjYjZmOGM3Y2ZmZDI1YTBkMjE5NGUyZjEzYTc1 YmE1NmE3ZTIxYWYuLjE3YjYyNzczY2RiZjM0MTIwNDk3MzdlNGFkYTdlOGIyMzY4Mjk2MWYgMTAw NjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3RocmVhZC90aHJl YWRlZG1lc3NhZ2VxdWV1ZS5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2Nv bW1vbi90aHJlYWQvdGhyZWFkZWRtZXNzYWdlcXVldWUucHkKQEAgLTI2LDYgKzI2LDggQEAKICMg KElOQ0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9V VCBPRiBUSEUgVVNFCiAjIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUg UE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCiAKK2Zyb20gX19mdXR1cmVfXyBpbXBvcnQgd2l0 aF9zdGF0ZW1lbnQKKwogaW1wb3J0IHRocmVhZGluZwogCiAKQEAgLTM2LDIwICszOCwxNyBAQCBj bGFzcyBUaHJlYWRlZE1lc3NhZ2VRdWV1ZShvYmplY3QpOgogICAgICAgICBzZWxmLl9sb2NrID0g dGhyZWFkaW5nLkxvY2soKQogCiAgICAgZGVmIHBvc3Qoc2VsZiwgbWVzc2FnZSk6Ci0gICAgICAg IHNlbGYuX2xvY2suYWNxdWlyZSgpCi0gICAgICAgIHNlbGYuX21lc3NhZ2VzLmFwcGVuZChtZXNz YWdlKQotICAgICAgICBzZWxmLl9sb2NrLnJlbGVhc2UoKQorICAgICAgICB3aXRoIHNlbGYuX2xv Y2s6CisgICAgICAgICAgICBzZWxmLl9tZXNzYWdlcy5hcHBlbmQobWVzc2FnZSkKIAogICAgIGRl ZiBzdG9wKHNlbGYpOgotICAgICAgICBzZWxmLl9sb2NrLmFjcXVpcmUoKQotICAgICAgICBzZWxm Ll9pc19ydW5uaW5nID0gRmFsc2UKLSAgICAgICAgc2VsZi5fbG9jay5yZWxlYXNlKCkKKyAgICAg ICAgd2l0aCBzZWxmLl9sb2NrOgorICAgICAgICAgICAgc2VsZi5faXNfcnVubmluZyA9IEZhbHNl CiAKICAgICBkZWYgdGFrZV9hbGwoc2VsZik6Ci0gICAgICAgIHNlbGYuX2xvY2suYWNxdWlyZSgp Ci0gICAgICAgIG1lc3NhZ2VzID0gc2VsZi5fbWVzc2FnZXMKLSAgICAgICAgaXNfcnVubmluZyA9 IHNlbGYuX2lzX3J1bm5pbmcKLSAgICAgICAgc2VsZi5fbWVzc2FnZXMgPSBbXQotICAgICAgICBz ZWxmLl9sb2NrLnJlbGVhc2UoKQorICAgICAgICB3aXRoIHNlbGYuX2xvY2s6CisgICAgICAgICAg ICBtZXNzYWdlcyA9IHNlbGYuX21lc3NhZ2VzCisgICAgICAgICAgICBpc19ydW5uaW5nID0gc2Vs Zi5faXNfcnVubmluZworICAgICAgICAgICAgc2VsZi5fbWVzc2FnZXMgPSBbXQogICAgICAgICBy ZXR1cm4gKG1lc3NhZ2VzLCBpc19ydW5uaW5nKQogCg==