39231 2010-05-17 13:17:25 -0700 Fix rendering and selection failures in fast/multicol/layers-in-multicol.html 2010-05-17 14:26:26 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 hyatt hyatt abarth eric webkit.review.bot oldest_to_newest 226871 0 hyatt 2010-05-17 13:17:25 -0700 Fix some issues exposed by the test. 226873 1 56261 hyatt 2010-05-17 13:17:45 -0700 Created attachment 56261 Patch 226879 2 hyatt 2010-05-17 13:29:14 -0700 Fixed in r59624. 226896 3 webkit.review.bot 2010-05-17 14:26:26 -0700 http://trac.webkit.org/changeset/59624 might have broken GTK Linux 32-bit Debug 56261 2010-05-17 13:17:45 -0700 2010-05-17 13:20:38 -0700 Patch patch.txt text/plain 6805 hyatt SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1OTYyMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDUtMTcgIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBm YWlsdXJlcyBpbiB0aGUgUlRMIHBvcnRpb24gb2YgZmFzdC9tdWx0aWNvbC9sYXllcnMtaW4tbXVs dGljb2wuaHRtbC4gIE1ha2Ugc3VyZSBibG9jayBjaGlsZHJlbiBvZiBSVEwgYmxvY2tzIGFyZSBw b3NpdGlvbmVkIHVzaW5nCisgICAgICAgIHRoZSByZWR1Y2VkIGNvbHVtbiB3aWR0aCBpbnN0ZWFk IG9mIHRoZSB0b3RhbCBjb250ZW50IHdpZHRoLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRl ckJsb2NrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJsb2NrOjpkZXRlcm1pbmVIb3Jp em9udGFsUG9zaXRpb24pOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQmxvY2s6Om5vZGVBdFBv aW50KToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJsb2NrOjpoaXRUZXN0Q29udGVudHMpOgor ICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQmxvY2s6OmFkanVzdEZvckNvbHVtbnMpOgorCiAyMDEw LTA1LTE3ICBKYWtvYiBQZXRzb3ZpdHMgIDxqcGV0c292aXRzQHJpbS5jb20+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgR2VvcmdlIFN0YWlrb3MuCkluZGV4OiBXZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJCbG9jay5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2su Y3BwCShyZXZpc2lvbiA1OTU5MCkKKysrIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMTE1NSw5ICsxMTU1LDggQEAgaW50IFJlbmRlckJsb2NrOjpl c3RpbWF0ZVZlcnRpY2FsUG9zaXRpbwogCiB2b2lkIFJlbmRlckJsb2NrOjpkZXRlcm1pbmVIb3Jp em9udGFsUG9zaXRpb24oUmVuZGVyQm94KiBjaGlsZCkKIHsKKyAgICBpbnQgeFBvcyA9IGJvcmRl ckxlZnQoKSArIHBhZGRpbmdMZWZ0KCk7CiAgICAgaWYgKHN0eWxlKCktPmRpcmVjdGlvbigpID09 IExUUikgewotICAgICAgICBpbnQgeFBvcyA9IGJvcmRlckxlZnQoKSArIHBhZGRpbmdMZWZ0KCk7 Ci0gICAgICAgIAogICAgICAgICAvLyBBZGQgaW4gb3VyIGxlZnQgbWFyZ2luLgogICAgICAgICBp bnQgY2hQb3MgPSB4UG9zICsgY2hpbGQtPm1hcmdpbkxlZnQoKTsKICAgICAgICAgCkBAIC0xMTgz LDcgKzExODIsNyBAQCB2b2lkIFJlbmRlckJsb2NrOjpkZXRlcm1pbmVIb3Jpem9udGFsUG9zCiAg ICAgICAgIHZpZXcoKS0+YWRkTGF5b3V0RGVsdGEoSW50U2l6ZShjaGlsZC0+eCgpIC0gY2hQb3Ms IDApKTsKICAgICAgICAgY2hpbGQtPnNldExvY2F0aW9uKGNoUG9zLCBjaGlsZC0+eSgpKTsKICAg ICB9IGVsc2UgewotICAgICAgICBpbnQgeFBvcyA9IHdpZHRoKCkgLSBib3JkZXJSaWdodCgpIC0g cGFkZGluZ1JpZ2h0KCkgLSB2ZXJ0aWNhbFNjcm9sbGJhcldpZHRoKCk7CisgICAgICAgIHhQb3Mg Kz0gYXZhaWxhYmxlV2lkdGgoKTsKICAgICAgICAgaW50IGNoUG9zID0geFBvcyAtIChjaGlsZC0+ d2lkdGgoKSArIGNoaWxkLT5tYXJnaW5SaWdodCgpKTsKICAgICAgICAgaWYgKGNoaWxkLT5hdm9p ZHNGbG9hdHMoKSkgewogICAgICAgICAgICAgaW50IHJpZ2h0T2ZmID0gcmlnaHRPZmZzZXQoaGVp Z2h0KCksIGZhbHNlKTsKQEAgLTMzMjMsMTIgKzMzMjIsMTYgQEAgYm9vbCBSZW5kZXJCbG9jazo6 bm9kZUF0UG9pbnQoY29uc3QgSGl0VAogICAgICAgICB9CiAKICAgICAgICAgLy8gSGl0IHRlc3Qg Y29udGVudHMgaWYgd2UgZG9uJ3QgaGF2ZSBjb2x1bW5zLgotICAgICAgICBpZiAoIWhhc0NvbHVt bnMoKSAmJiBoaXRUZXN0Q29udGVudHMocmVxdWVzdCwgcmVzdWx0LCBfeCwgX3ksIHNjcm9sbGVk WCwgc2Nyb2xsZWRZLCBoaXRUZXN0QWN0aW9uKSkKKyAgICAgICAgaWYgKCFoYXNDb2x1bW5zKCkg JiYgaGl0VGVzdENvbnRlbnRzKHJlcXVlc3QsIHJlc3VsdCwgX3gsIF95LCBzY3JvbGxlZFgsIHNj cm9sbGVkWSwgaGl0VGVzdEFjdGlvbikpIHsKKyAgICAgICAgICAgIHVwZGF0ZUhpdFRlc3RSZXN1 bHQocmVzdWx0LCBJbnRQb2ludChfeCAtIHR4LCBfeSAtIHR5KSk7CiAgICAgICAgICAgICByZXR1 cm4gdHJ1ZTsKLSAgICAgICAgICAgIAorICAgICAgICB9CisKICAgICAgICAgLy8gSGl0IHRlc3Qg b3VyIGNvbHVtbnMgaWYgd2UgZG8gaGF2ZSB0aGVtLgotICAgICAgICBpZiAoaGFzQ29sdW1ucygp ICYmIGhpdFRlc3RDb2x1bW5zKHJlcXVlc3QsIHJlc3VsdCwgX3gsIF95LCBzY3JvbGxlZFgsIHNj cm9sbGVkWSwgaGl0VGVzdEFjdGlvbikpCisgICAgICAgIGlmIChoYXNDb2x1bW5zKCkgJiYgaGl0 VGVzdENvbHVtbnMocmVxdWVzdCwgcmVzdWx0LCBfeCwgX3ksIHNjcm9sbGVkWCwgc2Nyb2xsZWRZ LCBoaXRUZXN0QWN0aW9uKSkgeworICAgICAgICAgICAgdXBkYXRlSGl0VGVzdFJlc3VsdChyZXN1 bHQsIEludFBvaW50KF94IC0gdHgsIF95IC0gdHkpKTsKICAgICAgICAgICAgIHJldHVybiB0cnVl OworICAgICAgICB9CiAKICAgICAgICAgLy8gSGl0IHRlc3QgZmxvYXRzLgogICAgICAgICBpZiAo aGl0VGVzdEFjdGlvbiA9PSBIaXRUZXN0RmxvYXQgJiYgbV9mbG9hdGluZ09iamVjdHMpIHsKQEAg LTM0MDUsMjAgKzM0MDgsMTYgQEAgYm9vbCBSZW5kZXJCbG9jazo6aGl0VGVzdENvbnRlbnRzKGNv bnN0IAogewogICAgIGlmIChjaGlsZHJlbklubGluZSgpICYmICFpc1RhYmxlKCkpIHsKICAgICAg ICAgLy8gV2UgaGF2ZSB0byBoaXQtdGVzdCBvdXIgbGluZSBib3hlcy4KLSAgICAgICAgaWYgKG1f bGluZUJveGVzLmhpdFRlc3QodGhpcywgcmVxdWVzdCwgcmVzdWx0LCB4LCB5LCB0eCwgdHksIGhp dFRlc3RBY3Rpb24pKSB7Ci0gICAgICAgICAgICB1cGRhdGVIaXRUZXN0UmVzdWx0KHJlc3VsdCwg SW50UG9pbnQoeCAtIHR4LCB5IC0gdHkpKTsKKyAgICAgICAgaWYgKG1fbGluZUJveGVzLmhpdFRl c3QodGhpcywgcmVxdWVzdCwgcmVzdWx0LCB4LCB5LCB0eCwgdHksIGhpdFRlc3RBY3Rpb24pKQog ICAgICAgICAgICAgcmV0dXJuIHRydWU7Ci0gICAgICAgIH0KICAgICB9IGVsc2UgewogICAgICAg ICAvLyBIaXQgdGVzdCBvdXIgY2hpbGRyZW4uCiAgICAgICAgIEhpdFRlc3RBY3Rpb24gY2hpbGRI aXRUZXN0ID0gaGl0VGVzdEFjdGlvbjsKICAgICAgICAgaWYgKGhpdFRlc3RBY3Rpb24gPT0gSGl0 VGVzdENoaWxkQmxvY2tCYWNrZ3JvdW5kcykKICAgICAgICAgICAgIGNoaWxkSGl0VGVzdCA9IEhp dFRlc3RDaGlsZEJsb2NrQmFja2dyb3VuZDsKICAgICAgICAgZm9yIChSZW5kZXJCb3gqIGNoaWxk ID0gbGFzdENoaWxkQm94KCk7IGNoaWxkOyBjaGlsZCA9IGNoaWxkLT5wcmV2aW91c1NpYmxpbmdC b3goKSkgewotICAgICAgICAgICAgaWYgKCFjaGlsZC0+aGFzU2VsZlBhaW50aW5nTGF5ZXIoKSAm JiAhY2hpbGQtPmlzRmxvYXRpbmcoKSAmJiBjaGlsZC0+bm9kZUF0UG9pbnQocmVxdWVzdCwgcmVz dWx0LCB4LCB5LCB0eCwgdHksIGNoaWxkSGl0VGVzdCkpIHsKLSAgICAgICAgICAgICAgICB1cGRh dGVIaXRUZXN0UmVzdWx0KHJlc3VsdCwgSW50UG9pbnQoeCAtIHR4LCB5IC0gdHkpKTsKKyAgICAg ICAgICAgIGlmICghY2hpbGQtPmhhc1NlbGZQYWludGluZ0xheWVyKCkgJiYgIWNoaWxkLT5pc0Zs b2F0aW5nKCkgJiYgY2hpbGQtPm5vZGVBdFBvaW50KHJlcXVlc3QsIHJlc3VsdCwgeCwgeSwgdHgs IHR5LCBjaGlsZEhpdFRlc3QpKQogICAgICAgICAgICAgICAgIHJldHVybiB0cnVlOwotICAgICAg ICAgICAgfQogICAgICAgICB9CiAgICAgfQogICAgIApAQCAtMzkzOCw3ICszOTM3LDcgQEAgdm9p ZCBSZW5kZXJCbG9jazo6YWRqdXN0Rm9yQ29sdW1ucyhJbnRTaQogCiAgICAgaW50IGdhcFdpZHRo ID0gY29sdW1uR2FwKCk7CiAgICAgCi0gICAgaW50IHhPZmZzZXQgPSAwOworICAgIGludCB4T2Zm c2V0ID0gc3R5bGUoKS0+ZGlyZWN0aW9uKCkgPT0gTFRSID8gMCA6IGNvbnRlbnRXaWR0aCgpIC0g Y29sdW1uUmVjdHNbMF0ud2lkdGgoKTsKICAgICBpbnQgeU9mZnNldCA9IDA7CiAgICAgc2l6ZV90 IGNvbHVtbkNvdW50ID0gY29sdW1uUmVjdHMuc2l6ZSgpOwogICAgIGZvciAoc2l6ZV90IGkgPSAw OyBpIDwgY29sdW1uQ291bnQ7ICsraSkgewpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFj L2Zhc3QvbXVsdGljb2wvbGF5ZXJzLWluLW11bHRpY29sLWV4cGVjdGVkLnR4dAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC9tdWx0aWNvbC9sYXllcnMtaW4tbXVs dGljb2wtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiA1OTU5MCkKKysrIExheW91dFRlc3RzL3BsYXRm b3JtL21hYy9mYXN0L211bHRpY29sL2xheWVycy1pbi1tdWx0aWNvbC1leHBlY3RlZC50eHQJKHdv cmtpbmcgY29weSkKQEAgLTE4MSw3ICsxODEsNyBAQCBsYXllciBhdCAoOCwyNikgc2l6ZSAxMjc5 eDMxMAogICAgICAgUmVuZGVyQlIge0JSfSBhdCAoMTA2LDI0OCkgc2l6ZSAweDAKIGxheWVyIGF0 ICg4LDM1NCkgc2l6ZSA3Njl4MzEwCiAgIFJlbmRlckJsb2NrIHtESVZ9IGF0ICgwLDM0Nikgc2l6 ZSA3Njl4MzEwIFtib3JkZXI6ICg1cHggc29saWQgIzgwMDAwMCldCi0gICAgUmVuZGVyQmxvY2sg KGFub255bW91cykgYXQgKDUyMiw1KSBzaXplIDI0MngyMzQKKyAgICBSZW5kZXJCbG9jayAoYW5v bnltb3VzKSBhdCAoNSw1KSBzaXplIDI0MngyMzQKICAgICAgIFJlbmRlclRleHQgeyN0ZXh0fSBh dCAoMTM2LDApIHNpemUgMTA2eDE4CiAgICAgICAgIHRleHQgcnVuIGF0ICgxMzYsMCkgd2lkdGgg MTA2OiAiVGhpcyBpcyBzb21lIHRleHQiCiAgICAgICBSZW5kZXJCUiB7QlJ9IGF0ICgxMzYsMTQp IHNpemUgMHgwCkBAIC0yMjEsOSArMjIxLDkgQEAgbGF5ZXIgYXQgKDgsMzU0KSBzaXplIDc2OXgz MTAKICAgICAgIFJlbmRlclRleHQgeyN0ZXh0fSBhdCAoMTM2LDIxNikgc2l6ZSAxMDZ4MTgKICAg ICAgICAgdGV4dCBydW4gYXQgKDEzNiwyMTYpIHdpZHRoIDEwNjogIlRoaXMgaXMgc29tZSB0ZXh0 IgogICAgICAgUmVuZGVyQlIge0JSfSBhdCAoMTM2LDIzMCkgc2l6ZSAweDAKLSAgICBSZW5kZXJC bG9jayB7RElWfSBhdCAoNTIyLDIzOSkgc2l6ZSAyNDJ4MjcwCisgICAgUmVuZGVyQmxvY2sge0RJ Vn0gYXQgKDUsMjM5KSBzaXplIDI0MngyNzAKICAgICAgIFJlbmRlclRleHQgeyN0ZXh0fSBhdCAo MCwwKSBzaXplIDB4MAotICAgIFJlbmRlckJsb2NrIChhbm9ueW1vdXMpIGF0ICg1MjIsNTA5KSBz aXplIDI0Mng1MDQKKyAgICBSZW5kZXJCbG9jayAoYW5vbnltb3VzKSBhdCAoNSw1MDkpIHNpemUg MjQyeDUwNAogICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0ICgxMzYsMCkgc2l6ZSAxMDZ4MTgK ICAgICAgICAgdGV4dCBydW4gYXQgKDEzNiwwKSB3aWR0aCAxMDY6ICJUaGlzIGlzIHNvbWUgdGV4 dCIKICAgICAgIFJlbmRlckJSIHtCUn0gYXQgKDEzNiwxNCkgc2l6ZSAweDAKQEAgLTMwNiw3ICsz MDYsNyBAQCBsYXllciBhdCAoOCwzNTQpIHNpemUgNzY5eDMxMAogICAgICAgICB0ZXh0IHJ1biBh dCAoMTM2LDQ2OCkgd2lkdGggMTA2OiAiVGhpcyBpcyBzb21lIHRleHQiCiAgICAgICBSZW5kZXJC UiB7QlJ9IGF0ICgxMzYsNDgyKSBzaXplIDB4MAogICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0 ICgwLDApIHNpemUgMHgwCi0gICAgUmVuZGVyQmxvY2sgKGFub255bW91cykgYXQgKDUyMiwxMDMx KSBzaXplIDI0MngyNTIKKyAgICBSZW5kZXJCbG9jayAoYW5vbnltb3VzKSBhdCAoNSwxMDMxKSBz aXplIDI0MngyNTIKICAgICAgIFJlbmRlclRleHQgeyN0ZXh0fSBhdCAoMTM2LDApIHNpemUgMTA2 eDE4CiAgICAgICAgIHRleHQgcnVuIGF0ICgxMzYsMCkgd2lkdGggMTA2OiAiVGhpcyBpcyBzb21l IHRleHQiCiAgICAgICBSZW5kZXJCUiB7QlJ9IGF0ICgxMzYsMTQpIHNpemUgMHgwCkBAIC0zNjMs NyArMzYzLDcgQEAgbGF5ZXIgYXQgKDc5NywyMjkpIHNpemUgMjQyeDE4CiBsYXllciBhdCAoNDE0 LDM1OSkgc2l6ZSAxMDB4MjcwCiAgIFJlbmRlckJsb2NrIChyZWxhdGl2ZSBwb3NpdGlvbmVkKSB7 RElWfSBhdCAoMTQyLDApIHNpemUgMTAweDI3MCBbYmdjb2xvcj0jMDA4MDAwXQogbGF5ZXIgYXQg KC0yMzQsNTU3KSBzaXplIDI0MngxOCBiYWNrZ3JvdW5kQ2xpcCBhdCAoMCwwKSBzaXplIDEyODd4 NjcyIGNsaXAgYXQgKDAsMCkgc2l6ZSAxMjg3eDY3MiBvdXRsaW5lQ2xpcCBhdCAoMCwwKSBzaXpl IDEyODd4NjcyCi0gIFJlbmRlckJsb2NrIChyZWxhdGl2ZSBwb3NpdGlvbmVkKSB7RElWfSBhdCAo NTIyLDEwMTMpIHNpemUgMjQyeDE4CisgIFJlbmRlckJsb2NrIChyZWxhdGl2ZSBwb3NpdGlvbmVk KSB7RElWfSBhdCAoNSwxMDEzKSBzaXplIDI0MngxOAogICAgIFJlbmRlclRleHQgeyN0ZXh0fSBh dCAoNTAsMCkgc2l6ZSAxOTJ4MTgKICAgICAgIHRleHQgcnVuIGF0ICg1MCwwKSB3aWR0aCA0IFJU TDogIi4iCiAgICAgICB0ZXh0IHJ1biBhdCAoNTQsMCkgd2lkdGggMTg4OiAiVGhpcyBpcyByZWxh dGl2ZSBwb3NpdGlvbmVkIHRleHQiCg==