39227 2010-05-17 11:05:16 -0700 Fix JSC's generation of 'Optional' arguments 2010-05-17 11:42:37 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 yaar webkit-unassigned abarth sam oldest_to_newest 226826 0 yaar 2010-05-17 11:05:16 -0700 Fix JSC's generation of 'Optional' arguments 226835 1 56253 yaar 2010-05-17 11:14:38 -0700 Created attachment 56253 Patch 226840 2 yaar 2010-05-17 11:25:40 -0700 Passes all layout tests. 226841 3 56253 darin 2010-05-17 11:35:40 -0700 Comment on attachment 56253 Patch Looks fine. Once we use this in a binding, lets makes sure it's tested in layout tests. 226842 4 yaar 2010-05-17 11:37:42 -0700 Thank you! 226844 5 yaar 2010-05-17 11:42:37 -0700 Committed r59618: <http://trac.webkit.org/changeset/59618> 56253 2010-05-17 11:14:38 -0700 2010-05-17 11:35:40 -0700 Patch bug-39227-20100517111437.patch text/plain 3111 yaar SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1OTYxNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDUtMTcgIFlhYXIgU2Nobml0bWFuICA8eWFhckBjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Rml4IEpTQydzIGdlbmVyYXRpb24gb2YgJ09wdGlvbmFsJyBhcmd1bWVudHMuIFdoZW4gYSBzaW5n bGUgJ09wdGlvbmFsJyBleHRlbmRlZCBhdHRyaWJ1dGUgcHJlY2VkZXMgbXVsdGlwbGUgbWV0aG9k IGFyZ3VtZW50cywgYWxsIG9mIHRoZXNlIGFyZ3VtZW50cyBhcmUgb3B0aW9uYWwgYXMgYSBncm91 cCAoZWl0aGVyIGFsbCBvciBub24gbXVzdCBiZSBzcGVjaWZpZWQpLiBUaGlzIGZpeCwgd2hpY2gg bWFrZXMgSlNDIGNvbXBsaWFudCB3aXRoIFY4IGFuZCB3aXRoIHRoZSBXZWIgSURMIHNwZWNzLCBp cyBwcmV0dHkgaGFybWxlc3MsIHNpbmNlIE9wdGlvbmFsIGlzIGN1cnJlbnRseSBub3QgYmVpbmcg dXNlZCBhbnl3aGVyZSBpbiBKU0MsIGJ1dCBpdCBibG9ja3MgZnVydGhlciB3b3JrIG9uIG92ZXJs b2Fkcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5 MjI3CisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiAoT09QUyEpCisKKyAgICAgICAgKiBiaW5kaW5n cy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbToKKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRz L3Rlc3QvSlMvSlNUZXN0T2JqLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmpzVGVzdE9ialByb3Rv dHlwZUZ1bmN0aW9uTWV0aG9kV2l0aE5vbk9wdGlvbmFsQXJnQW5kVHdvT3B0aW9uYWxBcmdzKToK KwogMjAxMC0wNS0xNiAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IEFkYW0gQmFydGguCkluZGV4OiBXZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29k ZUdlbmVyYXRvckpTLnBtCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9D b2RlR2VuZXJhdG9ySlMucG0JKHJldmlzaW9uIDU5NjEyKQorKysgV2ViQ29yZS9iaW5kaW5ncy9z Y3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbQkod29ya2luZyBjb3B5KQpAQCAtMTg5NCwxMiArMTg5 NCwxMiBAQCBzdWIgR2VuZXJhdGVJbXBsZW1lbnRhdGlvbgogICAgICAgICAgICAgICAgICAgICB9 CiAKICAgICAgICAgICAgICAgICAgICAgZm9yZWFjaCBteSAkcGFyYW1ldGVyIChAeyRmdW5jdGlv bi0+cGFyYW1ldGVyc30pIHsKLSAgICAgICAgICAgICAgICAgICAgICAgIGlmICghJGhhc09wdGlv bmFsQXJndW1lbnRzICYmICRwYXJhbWV0ZXItPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJPcHRpb25h bCJ9KSB7Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgcHVzaChAaW1wbENvbnRlbnQsICJc biAgICBpbnQgYXJnc0NvdW50ID0gYXJncy5zaXplKCk7XG4iKTsKLSAgICAgICAgICAgICAgICAg ICAgICAgICAgICAkaGFzT3B0aW9uYWxBcmd1bWVudHMgPSAxOwotICAgICAgICAgICAgICAgICAg ICAgICAgfQotCi0gICAgICAgICAgICAgICAgICAgICAgICBpZiAoJGhhc09wdGlvbmFsQXJndW1l bnRzKSB7CisgICAgICAgICAgICAgICAgICAgICAgICBpZiAoJHBhcmFtZXRlci0+ZXh0ZW5kZWRB dHRyaWJ1dGVzLT57Ik9wdGlvbmFsIn0pIHsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAj IEdlbmVyYXRlIGVhcmx5IGNhbGwgaWYgdGhlcmUgYXJlIGVub3VnaCBwYXJhbWV0ZXJzLgorICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGlmICghJGhhc09wdGlvbmFsQXJndW1lbnRzKSB7Cisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHB1c2goQGltcGxDb250ZW50LCAiXG4gICAg aW50IGFyZ3NDb3VudCA9IGFyZ3Muc2l6ZSgpO1xuIik7CisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICRoYXNPcHRpb25hbEFyZ3VtZW50cyA9IDE7CisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgfQogICAgICAgICAgICAgICAgICAgICAgICAgICAgIHB1c2goQGltcGxDb250ZW50 LCAiICAgIGlmIChhcmdzQ291bnQgPCAiIC4gKCRwYXJhbUluZGV4ICsgMSkgLiAiKSB7XG4iKTsK ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBHZW5lcmF0ZUltcGxlbWVudGF0aW9uRnVuY3Rp b25DYWxsKCRmdW5jdGlvbiwgJGZ1bmN0aW9uU3RyaW5nLCAkcGFyYW1JbmRleCwgIiAgICAiIHgg MiwgJHBvZFR5cGUsICRpbXBsQ2xhc3NOYW1lKTsKICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBwdXNoKEBpbXBsQ29udGVudCwgIiAgICB9XG5cbiIpOwpJbmRleDogV2ViQ29yZS9iaW5kaW5n cy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0T2JqLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2Jp bmRpbmdzL3NjcmlwdHMvdGVzdC9KUy9KU1Rlc3RPYmouY3BwCShyZXZpc2lvbiA1OTYxMikKKysr IFdlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0pTL0pTVGVzdE9iai5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTgzNCwxMSArODM0LDYgQEAgSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGpzVGVzdE9i alByb3RvdHlwZQogICAgIH0KIAogICAgIGludCBvcHQxID0gYXJncy5hdCgxKS50b0ludDMyKGV4 ZWMpOwotICAgIGlmIChhcmdzQ291bnQgPCAzKSB7Ci0gICAgICAgIGltcC0+bWV0aG9kV2l0aE5v bk9wdGlvbmFsQXJnQW5kVHdvT3B0aW9uYWxBcmdzKG5vbk9wdCwgb3B0MSk7Ci0gICAgICAgIHJl dHVybiBqc1VuZGVmaW5lZCgpOwotICAgIH0KLQogICAgIGludCBvcHQyID0gYXJncy5hdCgyKS50 b0ludDMyKGV4ZWMpOwogCiAgICAgaW1wLT5tZXRob2RXaXRoTm9uT3B0aW9uYWxBcmdBbmRUd29P cHRpb25hbEFyZ3Mobm9uT3B0LCBvcHQxLCBvcHQyKTsK