39222 2010-05-17 09:31:56 -0700 V8 code generator does not add ENABLE guards around attribute getters and setters 2010-05-19 03:48:54 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 39210 1 steveblock webkit-unassigned commit-queue jianli jorlow steveblock yaar oldest_to_newest 226784 0 steveblock 2010-05-17 09:31:56 -0700 The V8 code generator does not add ENABLE guards around the static functions used to implement generated attribute getters and setters. This means that when a class has methods which are guarded by an enable flag, and that flag is disabled, the generated code will reference these methods without a guard, causing compile errors. For example, if TOUCH_EVENTS are disabled, ontouchstartAttrGetter() in V8DOMWindow.cpp is generated without guards and calls DOMWindow::ontouchstart(), which is guarded by ENABLE(TOUCH_EVENTS) 226866 1 56258 steveblock 2010-05-17 13:01:23 -0700 Created attachment 56258 Patch 226869 2 56258 japhet 2010-05-17 13:10:41 -0700 Comment on attachment 56258 Patch Ok. 227762 3 56258 commit-queue 2010-05-19 03:48:47 -0700 Comment on attachment 56258 Patch Clearing flags on attachment: 56258 Committed r59757: <http://trac.webkit.org/changeset/59757> 227763 4 commit-queue 2010-05-19 03:48:54 -0700 All reviewed patches have been landed. Closing bug. 56258 2010-05-17 13:01:23 -0700 2010-05-19 03:48:47 -0700 Patch bug-39222-20100517210121.patch text/plain 3474 steveblock SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1OTYyMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDUtMTcgIFN0ZXZlIEJsb2NrICA8c3RldmVibG9ja0Bnb29n bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFY4IGNvZGUgZ2VuZXJhdG9yIGRvZXMgbm90IGFkZCBFTkFCTEUgZ3VhcmRzIGFyb3VuZCBhdHRy aWJ1dGUgZ2V0dGVycyBhbmQgc2V0dGVycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MzkyMjIKKworICAgICAgICBObyBuZXcgdGVzdHMsIGJ1aWxkIGZp eCBvbmx5LgorCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG06 CisKIDIwMTAtMDUtMTcgIEpha29iIFBldHNvdml0cyAgPGpwZXRzb3ZpdHNAcmltLmNvbT4KIAog ICAgICAgICBSZXZpZXdlZCBieSBHZW9yZ2UgU3RhaWtvcy4KSW5kZXg6IFdlYkNvcmUvYmluZGlu Z3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5k aW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQkocmV2aXNpb24gNTk2MjMpCisrKyBXZWJD b3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCSh3b3JraW5nIGNvcHkpCkBA IC02MjgsNyArNjI4LDEwIEBAIHN1YiBHZW5lcmF0ZU5vcm1hbEF0dHJHZXR0ZXIKIAogICAgIG15 ICRnZXR0ZXJTdHJpbmdVc2VzSW1wID0gJGltcGxDbGFzc05hbWUgbmUgImZsb2F0IjsKIAotICAj IEdldHRlcgorICAgICMgR2V0dGVyCisgICAgbXkgJGNvbmRpdGlvbmFsU3RyaW5nID0gR2VuZXJh dGVDb25kaXRpb25hbFN0cmluZygkYXR0cmlidXRlLT5zaWduYXR1cmUpOworICAgIHB1c2goQGlt cGxDb250ZW50RGVjbHMsICIjaWYgJHtjb25kaXRpb25hbFN0cmluZ31cblxuIikgaWYgJGNvbmRp dGlvbmFsU3RyaW5nOworCiAgICAgcHVzaChAaW1wbENvbnRlbnREZWNscywgPDxFTkQpOwogc3Rh dGljIHY4OjpIYW5kbGU8djg6OlZhbHVlPiAke2F0dHJOYW1lfUF0dHJHZXR0ZXIodjg6OkxvY2Fs PHY4OjpTdHJpbmc+IG5hbWUsIGNvbnN0IHY4OjpBY2Nlc3NvckluZm8mIGluZm8pCiB7CkBAIC02 NzEsNiArNjc0LDcgQEAgRU5ECiAgICAgICAgICAgICAkaW1wbEluY2x1ZGVzeyIke25hbWVzcGFj ZX0uaCJ9ID0gMTsKICAgICAgICAgICAgIHB1c2goQGltcGxDb250ZW50RGVjbHMsICIgICAgcmV0 dXJuIGdldEVsZW1lbnRTdHJpbmdBdHRyKGluZm8sICR7bmFtZXNwYWNlfTo6JHtjb250ZW50QXR0 cmlidXRlTmFtZX1BdHRyKTtcbiIpOwogICAgICAgICAgICAgcHVzaChAaW1wbENvbnRlbnREZWNs cywgIn1cblxuIik7CisgICAgICAgICAgICBwdXNoKEBpbXBsQ29udGVudERlY2xzLCAiI2VuZGlm IC8vICR7Y29uZGl0aW9uYWxTdHJpbmd9XG5cbiIpIGlmICRjb25kaXRpb25hbFN0cmluZzsKICAg ICAgICAgICAgIHJldHVybjsKICAgICAgICAgICAgICMgU2tpcCB0aGUgcmVzdCBvZiB0aGUgZnVu Y3Rpb24hCiAgICAgICAgIH0KQEAgLTgwMSw2ICs4MDUsNyBAQCBFTkQKICAgICAgICAgICAgIHB1 c2goQGltcGxDb250ZW50RGVjbHMsICIgICAgfVxuIik7CiAgICAgICAgICAgICBwdXNoKEBpbXBs Q29udGVudERlY2xzLCAiICAgIHJldHVybiB3cmFwcGVyO1xuIik7CiAgICAgICAgICAgICBwdXNo KEBpbXBsQ29udGVudERlY2xzLCAifVxuXG4iKTsKKyAgICAgICAgICAgIHB1c2goQGltcGxDb250 ZW50RGVjbHMsICIjZW5kaWYgLy8gJHtjb25kaXRpb25hbFN0cmluZ31cblxuIikgaWYgJGNvbmRp dGlvbmFsU3RyaW5nOwogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9CiAgICAgfQpAQCAt ODI1LDYgKzgzMCw3IEBAIEVORAogICAgIH0KIAogICAgIHB1c2goQGltcGxDb250ZW50RGVjbHMs ICJ9XG5cbiIpOyAgIyBlbmQgb2YgZ2V0dGVyCisgICAgcHVzaChAaW1wbENvbnRlbnREZWNscywg IiNlbmRpZiAvLyAke2NvbmRpdGlvbmFsU3RyaW5nfVxuXG4iKSBpZiAkY29uZGl0aW9uYWxTdHJp bmc7CiB9CiAKIHN1YiBHZW5lcmF0ZU5vcm1hbEF0dHJTZXR0ZXIKQEAgLTgzNiw2ICs4NDIsOSBA QCBzdWIgR2VuZXJhdGVOb3JtYWxBdHRyU2V0dGVyCiAKICAgICBteSAkYXR0ckV4dCA9ICRhdHRy aWJ1dGUtPnNpZ25hdHVyZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzOwogCisgICAgbXkgJGNvbmRpdGlv bmFsU3RyaW5nID0gR2VuZXJhdGVDb25kaXRpb25hbFN0cmluZygkYXR0cmlidXRlLT5zaWduYXR1 cmUpOworICAgIHB1c2goQGltcGxDb250ZW50RGVjbHMsICIjaWYgJHtjb25kaXRpb25hbFN0cmlu Z31cblxuIikgaWYgJGNvbmRpdGlvbmFsU3RyaW5nOworCiAgICAgcHVzaChAaW1wbENvbnRlbnRE ZWNscywgInN0YXRpYyB2b2lkICR7YXR0ck5hbWV9QXR0clNldHRlcih2ODo6TG9jYWw8djg6OlN0 cmluZz4gbmFtZSwgdjg6OkxvY2FsPHY4OjpWYWx1ZT4gdmFsdWUsIGNvbnN0IHY4OjpBY2Nlc3Nv ckluZm8mIGluZm8pXG57XG4iKTsKICAgICBwdXNoKEBpbXBsQ29udGVudERlY2xzLCAiICAgIElO Q19TVEFUUyhcIkRPTS4kaW1wbENsYXNzTmFtZS4kYXR0ck5hbWUuX3NldFwiKTtcbiIpOwogCkBA IC04NzUsNiArODg0LDcgQEAgRU5ECiAgICAgICAgICAgICAkaW1wbEluY2x1ZGVzeyIke25hbWVz cGFjZX0uaCJ9ID0gMTsKICAgICAgICAgICAgIHB1c2goQGltcGxDb250ZW50RGVjbHMsICIgICAg c2V0RWxlbWVudFN0cmluZ0F0dHIoaW5mbywgJHtuYW1lc3BhY2V9Ojoke2NvbnRlbnRBdHRyaWJ1 dGVOYW1lfUF0dHIsIHZhbHVlKTtcbiIpOwogICAgICAgICAgICAgcHVzaChAaW1wbENvbnRlbnRE ZWNscywgIn1cblxuIik7CisgICAgICAgICAgICBwdXNoKEBpbXBsQ29udGVudERlY2xzLCAiI2Vu ZGlmIC8vICR7Y29uZGl0aW9uYWxTdHJpbmd9XG5cbiIpIGlmICRjb25kaXRpb25hbFN0cmluZzsK ICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgICAgICMgU2tpcCB0aGUgcmVzdCBvZiB0aGUg ZnVuY3Rpb24hCiAgICAgICAgIH0KQEAgLTk2Myw2ICs5NzMsNyBAQCBFTkQKIAogICAgIHB1c2go QGltcGxDb250ZW50RGVjbHMsICIgICAgcmV0dXJuO1xuIik7CiAgICAgcHVzaChAaW1wbENvbnRl bnREZWNscywgIn1cblxuIik7ICAjIGVuZCBvZiBzZXR0ZXIKKyAgICBwdXNoKEBpbXBsQ29udGVu dERlY2xzLCAiI2VuZGlmIC8vICR7Y29uZGl0aW9uYWxTdHJpbmd9XG5cbiIpIGlmICRjb25kaXRp b25hbFN0cmluZzsKIH0KIAogc3ViIEdldEZ1bmN0aW9uVGVtcGxhdGVDYWxsYmFja05hbWUK