<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>39206</bug_id>
          
          <creation_ts>2010-05-17 01:36:27 -0700</creation_ts>
          <short_desc>[GStreamer] video painting support on mac port</short_desc>
          <delta_ts>2010-05-21 06:20:40 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Media</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>39202</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Philippe Normand">pnormand</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>atwilson</cc>
    
    <cc>eric.carlson</cc>
    
    <cc>eric</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>226679</commentid>
    <comment_count>0</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2010-05-17 01:36:27 -0700</bug_when>
    <thetext>an ImageGStreamerMac implementation is needed. It would take a GstBuffer as input and create a CG Image object with the buffer data.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>226688</commentid>
    <comment_count>1</comment_count>
      <attachid>56224</attachid>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2010-05-17 01:41:43 -0700</bug_when>
    <thetext>Created attachment 56224
proposed patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>226690</commentid>
    <comment_count>2</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2010-05-17 01:43:06 -0700</bug_when>
    <thetext>Attachment 56224 did not pass style-queue:

Failed to run &quot;[&apos;WebKitTools/Scripts/check-webkit-style&apos;, &apos;--no-squash&apos;]&quot; exit_code: 1
WebCore/platform/graphics/gstreamer/ImageGStreamer.h:58:  Tab found; better to use spaces  [whitespace/tab] [1]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>226706</commentid>
    <comment_count>3</comment_count>
      <attachid>56227</attachid>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2010-05-17 02:27:05 -0700</bug_when>
    <thetext>Created attachment 56227
proposed patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>228424</commentid>
    <comment_count>4</comment_count>
      <attachid>56227</attachid>
    <who name="Eric Carlson">eric.carlson</who>
    <bug_when>2010-05-20 09:45:21 -0700</bug_when>
    <thetext>Comment on attachment 56227
proposed patch

&gt; + *
&gt; + * You should have received a copy of the GNU Library General Public License
&gt; + * aint with this library; see the file COPYING.LIB.  If not, write to
&gt;
This typo is back, &quot;aint&quot; should be &quot;along&quot; (see https://bugs.webkit.org/show_bug.cgi?id=36442).

&gt; +    CGColorSpaceRef colorSpace = CGColorSpaceCreateDeviceRGB();
&gt; +    CGImageRef frameImage = CGImageCreate(size.width(), size.height(), 8, 32, size.width()*4, colorSpace,
&gt; +        kCGBitmapByteOrder32Little | kCGImageAlphaFirst, provider.get(), 0, false, kCGRenderingIntentDefault);
&gt; +    m_image = BitmapImage::create(frameImage);
&gt; +}
&gt; 
You are leaking the CGColorSpaceRef. Since your frames are always in the same color space, you could use a static.

r=me with these changes</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>228428</commentid>
    <comment_count>5</comment_count>
    <who name="Eric Carlson">eric.carlson</who>
    <bug_when>2010-05-20 09:49:19 -0700</bug_when>
    <thetext>Actually, one more thing - I don&apos;t think &quot;ImageGStreamerMac.mm&quot; is the best name for this file because it is really about using CoreGraphics images. The alternate version is &quot;ImageGStreamerCairo&quot;, so how about &quot;ImageGStreamerCG&quot; instead?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>228431</commentid>
    <comment_count>6</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2010-05-20 09:55:29 -0700</bug_when>
    <thetext>(In reply to comment #5)
&gt; Actually, one more thing - I don&apos;t think &quot;ImageGStreamerMac.mm&quot; is the best name for this file because it is really about using CoreGraphics images. The alternate version is &quot;ImageGStreamerCairo&quot;, so how about &quot;ImageGStreamerCG&quot; instead?

Ok I will rename and apply the changes you suggested.
Thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>228881</commentid>
    <comment_count>7</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2010-05-21 06:20:40 -0700</bug_when>
    <thetext>Landed in http://trac.webkit.org/changeset/59929
Thanks!</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>56224</attachid>
            <date>2010-05-17 01:41:43 -0700</date>
            <delta_ts>2010-05-17 02:27:05 -0700</delta_ts>
            <desc>proposed patch</desc>
            <filename>proposed-patch.patch</filename>
            <type>text/plain</type>
            <size>4290</size>
            <attacher name="Philippe Normand">pnormand</attacher>
            
              <data encoding="base64">RnJvbSA1MzVmMmYzM2YyMmRiOTY5ZWVkOWExZGE0ODA4MzYxMzBmODc1MWU1IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t
PgpEYXRlOiBNb24sIDIyIE1hciAyMDEwIDEwOjAxOjQ4ICswMTAwClN1YmplY3Q6IFtQQVRDSF0g
cHJvcG9zZWQgcGF0Y2gKCi0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgfCAgIDE2ICsrKysrKwogLi4uL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJl
YW1lci9JbWFnZUdTdHJlYW1lci5oICAgfCAgICA0ICsrCiAuLi4vZ3JhcGhpY3MvZ3N0cmVhbWVy
L0ltYWdlR1N0cmVhbWVyTWFjLm1tICAgICAgICB8ICAgNTcgKysrKysrKysrKysrKysrKysrKysK
IDMgZmlsZXMgY2hhbmdlZCwgNzcgaW5zZXJ0aW9ucygrKSwgMCBkZWxldGlvbnMoLSkKIGNyZWF0
ZSBtb2RlIDEwMDY0NCBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9JbWFnZUdT
dHJlYW1lck1hYy5tbQoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9D
aGFuZ2VMb2cKaW5kZXggMGY3YTk4MS4uNTM5NThkNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFu
Z2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0wNS0x
NyAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2
aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dTdHJlYW1lcl0gZW5hYmxlIGdz
dCBzdXBwb3J0IGlmIFVTRV9HU1RSRUFNRVIgbWFjcm8gaXMgZGVmaW5lZAorICAgICAgICBodHRw
czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzkyMDUKKworICAgICAgICBJbWFn
ZUdTdHJlYW1lciBzdXBwb3J0IGZvciBtYWMgcG9ydC4gQSBDRyBJbWFnZSBpcyBjcmVhdGVkIHVz
aW5nCisgICAgICAgIHRoZSBHc3RCdWZmZXIgZGF0YS4gSXQgY2FuIHRoZW4gYmUgcGFpbnRlZCBi
eSB0aGUgZ3N0cmVhbWVyIHBsYXllci4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dz
dHJlYW1lci9JbWFnZUdTdHJlYW1lci5oOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dz
dHJlYW1lci9JbWFnZUdTdHJlYW1lck1hYy5tbTogQWRkZWQuCisgICAgICAgIChJbWFnZUdTdHJl
YW1lcjo6Y3JlYXRlSW1hZ2UpOgorICAgICAgICAoSW1hZ2VHU3RyZWFtZXI6OkltYWdlR1N0cmVh
bWVyKToKKyAgICAgICAgKEltYWdlR1N0cmVhbWVyOjp+SW1hZ2VHU3RyZWFtZXIpOgorCiAyMDEw
LTA1LTE2ICBDaHJpcyBKZXJkb25layAgPGNqZXJkb25la0B3ZWJraXQub3JnPgogCiAgICAgICAg
IFJldmlld2VkIGJ5ID1BZGFtIEJhcnRoLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9n
cmFwaGljcy9nc3RyZWFtZXIvSW1hZ2VHU3RyZWFtZXIuaCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh
cGhpY3MvZ3N0cmVhbWVyL0ltYWdlR1N0cmVhbWVyLmgKaW5kZXggMmU5N2I0ZC4uN2ZjODZkYSAx
MDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvSW1hZ2VHU3Ry
ZWFtZXIuaAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9JbWFnZUdT
dHJlYW1lci5oCkBAIC01NCw2ICs1NCwxMCBAQCBjbGFzcyBJbWFnZUdTdHJlYW1lciA6IHB1Ymxp
YyBSZWZDb3VudGVkPEltYWdlR1N0cmVhbWVyPiB7CiAgICAgICAgIGNhaXJvX3N1cmZhY2VfdCog
bV9zdXJmYWNlOwogI2VuZGlmCiAKKyNpZiBQTEFURk9STShNQUMpCisJSW1hZ2VHU3RyZWFtZXIo
R3N0QnVmZmVyKiYsIEludFNpemUpOworI2VuZGlmCisKICAgICB9OwogfQogCmRpZmYgLS1naXQg
YS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9JbWFnZUdTdHJlYW1lck1hYy5t
bSBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0ltYWdlR1N0cmVhbWVyTWFj
Lm1tCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLmY4ZjE5MTkKLS0tIC9kZXYv
bnVsbAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9JbWFnZUdTdHJl
YW1lck1hYy5tbQpAQCAtMCwwICsxLDU3IEBACisvKgorICogQ29weXJpZ2h0IChDKSAyMDEwIEln
YWxpYSBTLkwKKyAqCisgKiBUaGlzIGxpYnJhcnkgaXMgZnJlZSBzb2Z0d2FyZTsgeW91IGNhbiBy
ZWRpc3RyaWJ1dGUgaXQgYW5kL29yCisgKiBtb2RpZnkgaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRo
ZSBHTlUgTGlicmFyeSBHZW5lcmFsIFB1YmxpYworICogTGljZW5zZSBhcyBwdWJsaXNoZWQgYnkg
dGhlIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbjsgZWl0aGVyCisgKiB2ZXJzaW9uIDIgb2YgdGhl
IExpY2Vuc2UsIG9yIChhdCB5b3VyIG9wdGlvbikgYW55IGxhdGVyIHZlcnNpb24uCisgKgorICog
VGhpcyBsaWJyYXJ5IGlzIGRpc3RyaWJ1dGVkIGluIHRoZSBob3BlIHRoYXQgaXQgd2lsbCBiZSB1
c2VmdWwsCisgKiBidXQgV0lUSE9VVCBBTlkgV0FSUkFOVFk7IHdpdGhvdXQgZXZlbiB0aGUgaW1w
bGllZCB3YXJyYW50eSBvZgorICogTUVSQ0hBTlRBQklMSVRZIG9yIEZJVE5FU1MgRk9SIEEgUEFS
VElDVUxBUiBQVVJQT1NFLiAgU2VlIHRoZSBHTlUKKyAqIExpYnJhcnkgR2VuZXJhbCBQdWJsaWMg
TGljZW5zZSBmb3IgbW9yZSBkZXRhaWxzLgorICoKKyAqIFlvdSBzaG91bGQgaGF2ZSByZWNlaXZl
ZCBhIGNvcHkgb2YgdGhlIEdOVSBMaWJyYXJ5IEdlbmVyYWwgUHVibGljIExpY2Vuc2UKKyAqIGFp
bnQgd2l0aCB0aGlzIGxpYnJhcnk7IHNlZSB0aGUgZmlsZSBDT1BZSU5HLkxJQi4gIElmIG5vdCwg
d3JpdGUgdG8KKyAqIHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24sIEluYy4sIDUxIEZyYW5r
bGluIFN0cmVldCwgRmlmdGggRmxvb3IsCisgKiBCb3N0b24sIE1BIDAyMTEwLTEzMDEsIFVTQS4K
KyAqLworCisjaW5jbHVkZSAiY29uZmlnLmgiCisjaW5jbHVkZSAiSW1hZ2VHU3RyZWFtZXIuaCIK
KwordXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CisKK1Bhc3NSZWZQdHI8SW1hZ2VHU3RyZWFtZXI+
IEltYWdlR1N0cmVhbWVyOjpjcmVhdGVJbWFnZShHc3RCdWZmZXIqIGJ1ZmZlcikKK3sKKyAgICBp
bnQgd2lkdGggPSAwLCBoZWlnaHQgPSAwOworICAgIEdzdENhcHMqIGNhcHMgPSBnc3RfYnVmZmVy
X2dldF9jYXBzKGJ1ZmZlcik7CisgICAgR3N0VmlkZW9Gb3JtYXQgZm9ybWF0OworICAgIGlmICgh
Z3N0X3ZpZGVvX2Zvcm1hdF9wYXJzZV9jYXBzKGNhcHMsICZmb3JtYXQsICZ3aWR0aCwgJmhlaWdo
dCkpIHsKKyAgICAgICAgZ3N0X2NhcHNfdW5yZWYoY2Fwcyk7CisgICAgICAgIHJldHVybiBOVUxM
OworICAgIH0KKworICAgIHJldHVybiBhZG9wdFJlZihuZXcgSW1hZ2VHU3RyZWFtZXIoYnVmZmVy
LCBJbnRTaXplKHdpZHRoLCBoZWlnaHQpKSk7Cit9CisKK0ltYWdlR1N0cmVhbWVyOjpJbWFnZUdT
dHJlYW1lcihHc3RCdWZmZXIqJiBidWZmZXIsIEludFNpemUgc2l6ZSkKKyAgICA6IG1faW1hZ2Uo
MCkKK3sKKyAgICBBU1NFUlQoR1NUX0JVRkZFUl9TSVpFKGJ1ZmZlcikpOworCisgICAgUmV0YWlu
UHRyPENGRGF0YVJlZj4gZGF0YShBZG9wdENGLCBDRkRhdGFDcmVhdGVXaXRoQnl0ZXNOb0NvcHko
MCwgc3RhdGljX2Nhc3Q8VUludDgqPihHU1RfQlVGRkVSX0RBVEEoYnVmZmVyKSksIEdTVF9CVUZG
RVJfU0laRShidWZmZXIpLCBrQ0ZBbGxvY2F0b3JOdWxsKSk7CisgICAgUmV0YWluUHRyPENHRGF0
YVByb3ZpZGVyUmVmPiBwcm92aWRlcihBZG9wdENGLCBDR0RhdGFQcm92aWRlckNyZWF0ZVdpdGhD
RkRhdGEoZGF0YS5nZXQoKSkpOworICAgIENHQ29sb3JTcGFjZVJlZiBjb2xvclNwYWNlID0gQ0dD
b2xvclNwYWNlQ3JlYXRlRGV2aWNlUkdCKCk7CisgICAgQ0dJbWFnZVJlZiBmcmFtZUltYWdlID0g
Q0dJbWFnZUNyZWF0ZShzaXplLndpZHRoKCksIHNpemUuaGVpZ2h0KCksIDgsIDMyLCBzaXplLndp
ZHRoKCkqNCwgY29sb3JTcGFjZSwKKyAgICAgICAga0NHQml0bWFwQnl0ZU9yZGVyMzJMaXR0bGUg
fCBrQ0dJbWFnZUFscGhhRmlyc3QsIHByb3ZpZGVyLmdldCgpLCAwLCBmYWxzZSwga0NHUmVuZGVy
aW5nSW50ZW50RGVmYXVsdCk7CisgICAgbV9pbWFnZSA9IEJpdG1hcEltYWdlOjpjcmVhdGUoZnJh
bWVJbWFnZSk7Cit9CisKK0ltYWdlR1N0cmVhbWVyOjp+SW1hZ2VHU3RyZWFtZXIoKQoreworICAg
IGlmIChtX2ltYWdlKQorICAgICAgICBtX2ltYWdlLmNsZWFyKCk7CisKKyAgICBtX2ltYWdlID0g
MDsKK30KLS0gCjEuNy4x
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>56227</attachid>
            <date>2010-05-17 02:27:05 -0700</date>
            <delta_ts>2010-05-20 09:45:21 -0700</delta_ts>
            <desc>proposed patch</desc>
            <filename>proposed-patch.patch</filename>
            <type>text/plain</type>
            <size>4297</size>
            <attacher name="Philippe Normand">pnormand</attacher>
            
              <data encoding="base64">RnJvbSA3YWJlZWY2OGUwMjlhOTYwYzliODQ4ODQzMmU4MjYxNDRkZWQzMDhmIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t
PgpEYXRlOiBNb24sIDIyIE1hciAyMDEwIDEwOjAxOjQ4ICswMTAwClN1YmplY3Q6IFtQQVRDSF0g
cHJvcG9zZWQgcGF0Y2gKCi0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgfCAgIDE2ICsrKysrKwogLi4uL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJl
YW1lci9JbWFnZUdTdHJlYW1lci5oICAgfCAgICA0ICsrCiAuLi4vZ3JhcGhpY3MvZ3N0cmVhbWVy
L0ltYWdlR1N0cmVhbWVyTWFjLm1tICAgICAgICB8ICAgNTcgKysrKysrKysrKysrKysrKysrKysK
IDMgZmlsZXMgY2hhbmdlZCwgNzcgaW5zZXJ0aW9ucygrKSwgMCBkZWxldGlvbnMoLSkKIGNyZWF0
ZSBtb2RlIDEwMDY0NCBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9JbWFnZUdT
dHJlYW1lck1hYy5tbQoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9D
aGFuZ2VMb2cKaW5kZXggMGY3YTk4MS4uNTM5NThkNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFu
Z2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0wNS0x
NyAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2
aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dTdHJlYW1lcl0gZW5hYmxlIGdz
dCBzdXBwb3J0IGlmIFVTRV9HU1RSRUFNRVIgbWFjcm8gaXMgZGVmaW5lZAorICAgICAgICBodHRw
czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzkyMDUKKworICAgICAgICBJbWFn
ZUdTdHJlYW1lciBzdXBwb3J0IGZvciBtYWMgcG9ydC4gQSBDRyBJbWFnZSBpcyBjcmVhdGVkIHVz
aW5nCisgICAgICAgIHRoZSBHc3RCdWZmZXIgZGF0YS4gSXQgY2FuIHRoZW4gYmUgcGFpbnRlZCBi
eSB0aGUgZ3N0cmVhbWVyIHBsYXllci4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dz
dHJlYW1lci9JbWFnZUdTdHJlYW1lci5oOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dz
dHJlYW1lci9JbWFnZUdTdHJlYW1lck1hYy5tbTogQWRkZWQuCisgICAgICAgIChJbWFnZUdTdHJl
YW1lcjo6Y3JlYXRlSW1hZ2UpOgorICAgICAgICAoSW1hZ2VHU3RyZWFtZXI6OkltYWdlR1N0cmVh
bWVyKToKKyAgICAgICAgKEltYWdlR1N0cmVhbWVyOjp+SW1hZ2VHU3RyZWFtZXIpOgorCiAyMDEw
LTA1LTE2ICBDaHJpcyBKZXJkb25layAgPGNqZXJkb25la0B3ZWJraXQub3JnPgogCiAgICAgICAg
IFJldmlld2VkIGJ5ID1BZGFtIEJhcnRoLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9n
cmFwaGljcy9nc3RyZWFtZXIvSW1hZ2VHU3RyZWFtZXIuaCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh
cGhpY3MvZ3N0cmVhbWVyL0ltYWdlR1N0cmVhbWVyLmgKaW5kZXggMmU5N2I0ZC4uM2Q2ZDc0YSAx
MDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvSW1hZ2VHU3Ry
ZWFtZXIuaAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9JbWFnZUdT
dHJlYW1lci5oCkBAIC01NCw2ICs1NCwxMCBAQCBjbGFzcyBJbWFnZUdTdHJlYW1lciA6IHB1Ymxp
YyBSZWZDb3VudGVkPEltYWdlR1N0cmVhbWVyPiB7CiAgICAgICAgIGNhaXJvX3N1cmZhY2VfdCog
bV9zdXJmYWNlOwogI2VuZGlmCiAKKyNpZiBQTEFURk9STShNQUMpCisgICAgICAgIEltYWdlR1N0
cmVhbWVyKEdzdEJ1ZmZlciomLCBJbnRTaXplKTsKKyNlbmRpZgorCiAgICAgfTsKIH0KIApkaWZm
IC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvSW1hZ2VHU3RyZWFt
ZXJNYWMubW0gYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9JbWFnZUdTdHJl
YW1lck1hYy5tbQpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi5mOGYxOTE5Ci0t
LSAvZGV2L251bGwKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvSW1h
Z2VHU3RyZWFtZXJNYWMubW0KQEAgLTAsMCArMSw1NyBAQAorLyoKKyAqIENvcHlyaWdodCAoQykg
MjAxMCBJZ2FsaWEgUy5MCisgKgorICogVGhpcyBsaWJyYXJ5IGlzIGZyZWUgc29mdHdhcmU7IHlv
dSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vcgorICogbW9kaWZ5IGl0IHVuZGVyIHRoZSB0ZXJt
cyBvZiB0aGUgR05VIExpYnJhcnkgR2VuZXJhbCBQdWJsaWMKKyAqIExpY2Vuc2UgYXMgcHVibGlz
aGVkIGJ5IHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb247IGVpdGhlcgorICogdmVyc2lvbiAy
IG9mIHRoZSBMaWNlbnNlLCBvciAoYXQgeW91ciBvcHRpb24pIGFueSBsYXRlciB2ZXJzaW9uLgor
ICoKKyAqIFRoaXMgbGlicmFyeSBpcyBkaXN0cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0IGl0IHdp
bGwgYmUgdXNlZnVsLAorICogYnV0IFdJVEhPVVQgQU5ZIFdBUlJBTlRZOyB3aXRob3V0IGV2ZW4g
dGhlIGltcGxpZWQgd2FycmFudHkgb2YKKyAqIE1FUkNIQU5UQUJJTElUWSBvciBGSVRORVNTIEZP
UiBBIFBBUlRJQ1VMQVIgUFVSUE9TRS4gIFNlZSB0aGUgR05VCisgKiBMaWJyYXJ5IEdlbmVyYWwg
UHVibGljIExpY2Vuc2UgZm9yIG1vcmUgZGV0YWlscy4KKyAqCisgKiBZb3Ugc2hvdWxkIGhhdmUg
cmVjZWl2ZWQgYSBjb3B5IG9mIHRoZSBHTlUgTGlicmFyeSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNl
CisgKiBhaW50IHdpdGggdGhpcyBsaWJyYXJ5OyBzZWUgdGhlIGZpbGUgQ09QWUlORy5MSUIuICBJ
ZiBub3QsIHdyaXRlIHRvCisgKiB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLCBJbmMuLCA1
MSBGcmFua2xpbiBTdHJlZXQsIEZpZnRoIEZsb29yLAorICogQm9zdG9uLCBNQSAwMjExMC0xMzAx
LCBVU0EuCisgKi8KKworI2luY2x1ZGUgImNvbmZpZy5oIgorI2luY2x1ZGUgIkltYWdlR1N0cmVh
bWVyLmgiCisKK3VzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOworCitQYXNzUmVmUHRyPEltYWdlR1N0
cmVhbWVyPiBJbWFnZUdTdHJlYW1lcjo6Y3JlYXRlSW1hZ2UoR3N0QnVmZmVyKiBidWZmZXIpCit7
CisgICAgaW50IHdpZHRoID0gMCwgaGVpZ2h0ID0gMDsKKyAgICBHc3RDYXBzKiBjYXBzID0gZ3N0
X2J1ZmZlcl9nZXRfY2FwcyhidWZmZXIpOworICAgIEdzdFZpZGVvRm9ybWF0IGZvcm1hdDsKKyAg
ICBpZiAoIWdzdF92aWRlb19mb3JtYXRfcGFyc2VfY2FwcyhjYXBzLCAmZm9ybWF0LCAmd2lkdGgs
ICZoZWlnaHQpKSB7CisgICAgICAgIGdzdF9jYXBzX3VucmVmKGNhcHMpOworICAgICAgICByZXR1
cm4gTlVMTDsKKyAgICB9CisKKyAgICByZXR1cm4gYWRvcHRSZWYobmV3IEltYWdlR1N0cmVhbWVy
KGJ1ZmZlciwgSW50U2l6ZSh3aWR0aCwgaGVpZ2h0KSkpOworfQorCitJbWFnZUdTdHJlYW1lcjo6
SW1hZ2VHU3RyZWFtZXIoR3N0QnVmZmVyKiYgYnVmZmVyLCBJbnRTaXplIHNpemUpCisgICAgOiBt
X2ltYWdlKDApCit7CisgICAgQVNTRVJUKEdTVF9CVUZGRVJfU0laRShidWZmZXIpKTsKKworICAg
IFJldGFpblB0cjxDRkRhdGFSZWY+IGRhdGEoQWRvcHRDRiwgQ0ZEYXRhQ3JlYXRlV2l0aEJ5dGVz
Tm9Db3B5KDAsIHN0YXRpY19jYXN0PFVJbnQ4Kj4oR1NUX0JVRkZFUl9EQVRBKGJ1ZmZlcikpLCBH
U1RfQlVGRkVSX1NJWkUoYnVmZmVyKSwga0NGQWxsb2NhdG9yTnVsbCkpOworICAgIFJldGFpblB0
cjxDR0RhdGFQcm92aWRlclJlZj4gcHJvdmlkZXIoQWRvcHRDRiwgQ0dEYXRhUHJvdmlkZXJDcmVh
dGVXaXRoQ0ZEYXRhKGRhdGEuZ2V0KCkpKTsKKyAgICBDR0NvbG9yU3BhY2VSZWYgY29sb3JTcGFj
ZSA9IENHQ29sb3JTcGFjZUNyZWF0ZURldmljZVJHQigpOworICAgIENHSW1hZ2VSZWYgZnJhbWVJ
bWFnZSA9IENHSW1hZ2VDcmVhdGUoc2l6ZS53aWR0aCgpLCBzaXplLmhlaWdodCgpLCA4LCAzMiwg
c2l6ZS53aWR0aCgpKjQsIGNvbG9yU3BhY2UsCisgICAgICAgIGtDR0JpdG1hcEJ5dGVPcmRlcjMy
TGl0dGxlIHwga0NHSW1hZ2VBbHBoYUZpcnN0LCBwcm92aWRlci5nZXQoKSwgMCwgZmFsc2UsIGtD
R1JlbmRlcmluZ0ludGVudERlZmF1bHQpOworICAgIG1faW1hZ2UgPSBCaXRtYXBJbWFnZTo6Y3Jl
YXRlKGZyYW1lSW1hZ2UpOworfQorCitJbWFnZUdTdHJlYW1lcjo6fkltYWdlR1N0cmVhbWVyKCkK
K3sKKyAgICBpZiAobV9pbWFnZSkKKyAgICAgICAgbV9pbWFnZS5jbGVhcigpOworCisgICAgbV9p
bWFnZSA9IDA7Cit9Ci0tIAoxLjcuMQ==
</data>
<flag name="review"
          id="40621"
          type_id="1"
          status="+"
          setter="eric.carlson"
    />
    <flag name="commit-queue"
          id="41060"
          type_id="3"
          status="-"
          setter="eric.carlson"
    />
          </attachment>
      

    </bug>

</bugzilla>