39205 2010-05-17 01:20:22 -0700 [GStreamer] enable gst support if USE_GSTREAMER macro is defined 2010-05-20 01:45:55 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 39202 1 pnormand webkit-unassigned eric.carlson eric levin scherkus oldest_to_newest 226675 0 pnormand 2010-05-17 01:20:22 -0700 Currently MediaPlayer.cpp includes MediaPlayerPrivateGStreamer only for the GTK port. It would be more convenient to enable the player include and creation only if USE_GSTREAMER macro is defined. 226678 1 56221 pnormand 2010-05-17 01:31:09 -0700 Created attachment 56221 proposed patch 228248 2 56221 eric 2010-05-20 01:04:50 -0700 Comment on attachment 56221 proposed patch ok. rs=me. 228249 3 eric 2010-05-20 01:05:27 -0700 You should CC some of the media folks on your bugs so they get to see media changes go by. (at least until they tell you not to CC them). :) 228251 4 levin 2010-05-20 01:08:32 -0700 Removing atwilson and adding scherkus to get the video person :). 228252 5 eric 2010-05-20 01:09:35 -0700 Sorry, I'm remembering my video folks wrong. I added atwilson to a few other media bugs by mistake then too. :( 228273 6 pnormand 2010-05-20 01:45:55 -0700 Landed in http://trac.webkit.org/changeset/59825 Thanks :) 56221 2010-05-17 01:31:09 -0700 2010-05-20 01:04:50 -0700 proposed patch proposed-patch.patch text/plain 2302 pnormand RnJvbSA4NDAxOTg2MjEzMzY3YmFlOTE4ODU0N2FhZTI2N2FjOWM0ZGQzMzY3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUaHUsIDE4IE1hciAyMDEwIDE0OjAzOjQxICswMTAwClN1YmplY3Q6IFtQQVRDSF0g cHJvcG9zZWQgcGF0Y2gKCi0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAg ICAgICAgfCAgIDEzICsrKysrKysrKysrKysKIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvTWVk aWFQbGF5ZXIuY3BwIHwgICAxMSArKysrKysrLS0tLQogMiBmaWxlcyBjaGFuZ2VkLCAyMCBpbnNl cnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9n IGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGY3YTk4MS4uNDM1MWRhMiAxMDA2NDQKLS0tIGEv V2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBA QAorMjAxMC0wNS0xNyAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dTdHJlYW1l cl0gZW5hYmxlIGdzdCBzdXBwb3J0IGlmIFVTRV9HU1RSRUFNRVIgbWFjcm8gaXMgZGVmaW5lZAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzkyMDUKKwor ICAgICAgICBJbmNsdWRlIGdzdHJlYW1lciBwcml2YXRlIHBsYXllciBpbiB0aGUgYnVpbGQgd2hl biB0aGUKKyAgICAgICAgVVNFX0dTVFJFQU1FUiBtYWNybyBpcyBlbmFibGVkLgorCisgICAgICAg ICogcGxhdGZvcm0vZ3JhcGhpY3MvTWVkaWFQbGF5ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 aW5zdGFsbGVkTWVkaWFFbmdpbmVzKToKKwogMjAxMC0wNS0xNiAgQ2hyaXMgSmVyZG9uZWsgIDxj amVyZG9uZWtAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSA9QWRhbSBCYXJ0aC4K ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvTWVkaWFQbGF5ZXIuY3BwIGIv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9NZWRpYVBsYXllci5jcHAKaW5kZXggZWVlNDQ3ZS4u Mzk4ODAyMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9NZWRpYVBsYXll ci5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9NZWRpYVBsYXllci5jcHAKQEAg LTQxLDYgKzQxLDEwIEBACiAjaW5jbHVkZSA8UXRHbG9iYWw+CiAjZW5kaWYKIAorI2lmIFVTRShH U1RSRUFNRVIpCisjaW5jbHVkZSAiTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmgiCisjZW5k aWYKKwogI2lmIFBMQVRGT1JNKE1BQykKICNpbmNsdWRlICJNZWRpYVBsYXllclByaXZhdGVRVEtp dC5oIgogI2VsaWYgT1MoV0lOQ0UpICYmICFQTEFURk9STShRVCkKQEAgLTQ4LDggKzUyLDYgQEAK ICNlbGlmIFBMQVRGT1JNKFdJTikKICNpbmNsdWRlICJNZWRpYVBsYXllclByaXZhdGVRdWlja1Rp bWVWaXN1YWxDb250ZXh0LmgiCiAjaW5jbHVkZSAiTWVkaWFQbGF5ZXJQcml2YXRlUXVpY2t0aW1l V2luLmgiCi0jZWxpZiBQTEFURk9STShHVEspCi0jaW5jbHVkZSAiTWVkaWFQbGF5ZXJQcml2YXRl R1N0cmVhbWVyLmgiCiAjZWxpZiBQTEFURk9STShRVCkKIC8vIFF0TXVsdGltZWRpYSBzdXBwb3J0 IGlzIGRpc2FibGVkIGN1cnJlbnRseS4KICNpZiAxIHx8IChRVF9WRVJTSU9OIDwgMHgwNDA3MDAp CkBAIC0xNjUsMTAgKzE2NywxMSBAQCBzdGF0aWMgVmVjdG9yPE1lZGlhUGxheWVyRmFjdG9yeSo+ JiBpbnN0YWxsZWRNZWRpYUVuZ2luZXMoKQogICAgICAgICBlbmdpbmVzUXVlcmllZCA9IHRydWU7 CiAjaWYgVVNFKEdTVFJFQU1FUikKICAgICAgICAgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVy OjpyZWdpc3Rlck1lZGlhRW5naW5lKGFkZE1lZGlhRW5naW5lKTsKLSNlbHNlCisjZW5kaWYKKwog I2lmIFBMQVRGT1JNKFdJTikKICAgICAgICAgTWVkaWFQbGF5ZXJQcml2YXRlUXVpY2tUaW1lVmlz dWFsQ29udGV4dDo6cmVnaXN0ZXJNZWRpYUVuZ2luZShhZGRNZWRpYUVuZ2luZSk7Ci0jZW5kaWYK KyNlbGlmICFQTEFURk9STShHVEspCiAgICAgICAgIC8vIEZJWE1FOiBjdXJyZW50bHkgYWxsIHRo ZSBNZWRpYUVuZ2luZXMgYXJlIG5hbWVkCiAgICAgICAgIC8vIE1lZGlhUGxheWVyUHJpdmF0ZS4g VGhpcyBjb2RlIHdpbGwgbmVlZCBhbiB1cGRhdGUgd2hlbiBidWcKICAgICAgICAgLy8gMzY2NjMg aXMgYWRyZXNzZWQuCi0tIAoxLjcuMQ==