39180 2010-05-16 10:42:31 -0700 Reduce the size of FunctionExecutable 2010-05-16 18:04:03 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser webkit-unassigned ggaren oliver oldest_to_newest 226500 0 simon.fraser 2010-05-16 10:42:31 -0700 FunctionExecutable could be shrunkerated. m_numVariables can be an int, etc. 226514 1 56191 simon.fraser 2010-05-16 12:13:14 -0700 Created attachment 56191 Patch 226515 2 56191 darin 2010-05-16 12:14:49 -0700 Comment on attachment 56191 Patch > + int variableCount() const { return m_numVariables; } Why int rather than unsigned? > + int m_numVariables : 31; Same question here. r=me 226577 3 simon.fraser 2010-05-16 18:03:10 -0700 http://trac.webkit.org/changeset/59587 226578 4 simon.fraser 2010-05-16 18:04:03 -0700 <rdar://problem/7990529> 56191 2010-05-16 12:13:14 -0700 2010-05-16 12:14:49 -0700 Patch 39180_patch.txt text/plain 3291 simon.fraser ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCAwNGJkOTk3Li43YmFkZWNlIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTAtMDUtMTYgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVkdWNlIHRo ZSBzaXplIG9mIEZ1bmN0aW9uRXhlY3V0YWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzkxODAKKyAgICAgICAgCisgICAgICAgIENoYW5nZSBtX251 bVZhcmlhYmxlcyBmcm9tIGEgc2l6ZV90IHRvIDMxIGJpdHMgaW4gYSBiaXRmaWVsZCwKKyAgICAg ICAgcGFja2VkIHdpdGggYW5vdGhlciBiaXQgZm9yIG1fZm9yY2VVc2VzQXJndW1lbnRzICh3aGlj aCBpbiB0dXJuCisgICAgICAgIGdldCBwYWNrZWQgd2l0aCB0aGUgYmFzZSBjbGFzcykuCisgICAg ICAgIAorICAgICAgICBSZWR1Y2VzIHRoZSBzaXplIG9mIEZ1bmN0aW9uRXhlY3V0YWJsZSBmcm9t IDE2MCB0byAxNTIgYnl0ZXMuCisKKyAgICAgICAgKiBydW50aW1lL0V4ZWN1dGFibGUuaDoKKyAg ICAgICAgKEpTQzo6RnVuY3Rpb25FeGVjdXRhYmxlOjp2YXJpYWJsZUNvdW50KToKKyAgICAgICAg KEpTQzo6RnVuY3Rpb25FeGVjdXRhYmxlOjpGdW5jdGlvbkV4ZWN1dGFibGUpOgorCiAyMDEwLTA1 LTE1ICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgTWFjaWVqIFN0YWNob3dpYWsuCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L0V4ZWN1dGFibGUuaCBiL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvRXhlY3V0YWJsZS5oCmluZGV4 IDc1NDEwM2YuLjdlY2U4NDggMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvRXhl Y3V0YWJsZS5oCisrKyBiL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvRXhlY3V0YWJsZS5oCkBAIC0z MTksNyArMzE5LDcgQEAgbmFtZXNwYWNlIEpTQyB7CiAKICAgICAgICAgY29uc3QgSWRlbnRpZmll ciYgbmFtZSgpIHsgcmV0dXJuIG1fbmFtZTsgfQogICAgICAgICBzaXplX3QgcGFyYW1ldGVyQ291 bnQoKSBjb25zdCB7IHJldHVybiBtX3BhcmFtZXRlcnMtPnNpemUoKTsgfQotICAgICAgICBzaXpl X3QgdmFyaWFibGVDb3VudCgpIGNvbnN0IHsgcmV0dXJuIG1fbnVtVmFyaWFibGVzOyB9CisgICAg ICAgIGludCB2YXJpYWJsZUNvdW50KCkgY29uc3QgeyByZXR1cm4gbV9udW1WYXJpYWJsZXM7IH0K ICAgICAgICAgVVN0cmluZyBwYXJhbVN0cmluZygpIGNvbnN0OwogICAgICAgICBTaGFyZWRTeW1i b2xUYWJsZSogc3ltYm9sVGFibGUoKSBjb25zdCB7IHJldHVybiBtX3N5bWJvbFRhYmxlOyB9CiAK QEAgLTMzMSwxMiArMzMxLDEyIEBAIG5hbWVzcGFjZSBKU0MgewogICAgIHByaXZhdGU6CiAgICAg ICAgIEZ1bmN0aW9uRXhlY3V0YWJsZShKU0dsb2JhbERhdGEqIGdsb2JhbERhdGEsIGNvbnN0IElk ZW50aWZpZXImIG5hbWUsIGNvbnN0IFNvdXJjZUNvZGUmIHNvdXJjZSwgYm9vbCBmb3JjZVVzZXNB cmd1bWVudHMsIEZ1bmN0aW9uUGFyYW1ldGVycyogcGFyYW1ldGVycywgaW50IGZpcnN0TGluZSwg aW50IGxhc3RMaW5lKQogICAgICAgICAgICAgOiBTY3JpcHRFeGVjdXRhYmxlKGdsb2JhbERhdGEs IHNvdXJjZSkKKyAgICAgICAgICAgICwgbV9udW1WYXJpYWJsZXMoMCkKICAgICAgICAgICAgICwg bV9mb3JjZVVzZXNBcmd1bWVudHMoZm9yY2VVc2VzQXJndW1lbnRzKQogICAgICAgICAgICAgLCBt X3BhcmFtZXRlcnMocGFyYW1ldGVycykKICAgICAgICAgICAgICwgbV9jb2RlQmxvY2tGb3JDYWxs KDApCiAgICAgICAgICAgICAsIG1fY29kZUJsb2NrRm9yQ29uc3RydWN0KDApCiAgICAgICAgICAg ICAsIG1fbmFtZShuYW1lKQotICAgICAgICAgICAgLCBtX251bVZhcmlhYmxlcygwKQogICAgICAg ICAgICAgLCBtX3N5bWJvbFRhYmxlKDApCiAgICAgICAgIHsKICAgICAgICAgICAgIG1fZmlyc3RM aW5lID0gZmlyc3RMaW5lOwpAQCAtMzQ1LDEyICszNDUsMTIgQEAgbmFtZXNwYWNlIEpTQyB7CiAK ICAgICAgICAgRnVuY3Rpb25FeGVjdXRhYmxlKEV4ZWNTdGF0ZSogZXhlYywgY29uc3QgSWRlbnRp ZmllciYgbmFtZSwgY29uc3QgU291cmNlQ29kZSYgc291cmNlLCBib29sIGZvcmNlVXNlc0FyZ3Vt ZW50cywgRnVuY3Rpb25QYXJhbWV0ZXJzKiBwYXJhbWV0ZXJzLCBpbnQgZmlyc3RMaW5lLCBpbnQg bGFzdExpbmUpCiAgICAgICAgICAgICA6IFNjcmlwdEV4ZWN1dGFibGUoZXhlYywgc291cmNlKQor ICAgICAgICAgICAgLCBtX251bVZhcmlhYmxlcygwKQogICAgICAgICAgICAgLCBtX2ZvcmNlVXNl c0FyZ3VtZW50cyhmb3JjZVVzZXNBcmd1bWVudHMpCiAgICAgICAgICAgICAsIG1fcGFyYW1ldGVy cyhwYXJhbWV0ZXJzKQogICAgICAgICAgICAgLCBtX2NvZGVCbG9ja0ZvckNhbGwoMCkKICAgICAg ICAgICAgICwgbV9jb2RlQmxvY2tGb3JDb25zdHJ1Y3QoMCkKICAgICAgICAgICAgICwgbV9uYW1l KG5hbWUpCi0gICAgICAgICAgICAsIG1fbnVtVmFyaWFibGVzKDApCiAgICAgICAgICAgICAsIG1f c3ltYm9sVGFibGUoMCkKICAgICAgICAgewogICAgICAgICAgICAgbV9maXJzdExpbmUgPSBmaXJz dExpbmU7CkBAIC0zNjAsMTIgKzM2MCwxMyBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAgdm9p ZCBjb21waWxlRm9yQ2FsbChFeGVjU3RhdGUqLCBTY29wZUNoYWluTm9kZSopOwogICAgICAgICB2 b2lkIGNvbXBpbGVGb3JDb25zdHJ1Y3QoRXhlY1N0YXRlKiwgU2NvcGVDaGFpbk5vZGUqKTsKIAot ICAgICAgICBib29sIG1fZm9yY2VVc2VzQXJndW1lbnRzOworICAgICAgICBpbnQgbV9udW1WYXJp YWJsZXMgOiAzMTsKKyAgICAgICAgYm9vbCBtX2ZvcmNlVXNlc0FyZ3VtZW50cyA6IDE7CisKICAg ICAgICAgUmVmUHRyPEZ1bmN0aW9uUGFyYW1ldGVycz4gbV9wYXJhbWV0ZXJzOwogICAgICAgICBG dW5jdGlvbkNvZGVCbG9jayogbV9jb2RlQmxvY2tGb3JDYWxsOwogICAgICAgICBGdW5jdGlvbkNv ZGVCbG9jayogbV9jb2RlQmxvY2tGb3JDb25zdHJ1Y3Q7CiAgICAgICAgIElkZW50aWZpZXIgbV9u YW1lOwotICAgICAgICBzaXplX3QgbV9udW1WYXJpYWJsZXM7CiAgICAgICAgIFNoYXJlZFN5bWJv bFRhYmxlKiBtX3N5bWJvbFRhYmxlOwogCiAjaWYgRU5BQkxFKEpJVCkK