39179 2010-05-16 09:29:56 -0700 Shrink SimpleFontData 2010-05-16 13:27:21 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED InRadar P2 Blocker --- 1 simon.fraser simon.fraser abarth eric mitz webkit.review.bot xan.lopez oldest_to_newest 226485 0 simon.fraser 2010-05-16 09:29:56 -0700 SimpleFontData is 5632 bytes big, mostly because of the 255 * sizeof(FloatRect) cache, which is only used in the complex code path. We can shrink it by allocating this cache lazily. It's 1536 bytes after this change. 226486 1 56189 simon.fraser 2010-05-16 09:31:52 -0700 Created attachment 56189 Patch 226490 2 56189 andersca 2010-05-16 10:07:00 -0700 Comment on attachment 56189 Patch r=me 226493 3 simon.fraser 2010-05-16 10:18:40 -0700 <rdar://problem/7990089> 226497 4 simon.fraser 2010-05-16 10:25:12 -0700 http://trac.webkit.org/changeset/59577 226512 5 webkit.review.bot 2010-05-16 12:04:39 -0700 http://trac.webkit.org/changeset/59577 might have broken GTK Linux 64-bit Debug 226522 6 eric 2010-05-16 13:09:04 -0700 I'm not sure how this could be possible, but the buildbot says this change caused a Gtk layout test to crash: http://build.webkit.org/results/GTK%20Linux%2064-bit%20Debug/r59577%20(5945)/fast/workers/storage/execute-sql-args-worker-stderr.txt ASSERTION FAILED: !protectedObjectCount() (../../JavaScriptCore/runtime/Collector.cpp:323 void JSC::Heap::freeBlocks()) It's crashed on every build since this was checked in. It's possible this was an earlier regression which was not noticed earlier due to Gtk build system dependency tracking problems. 226523 7 eric 2010-05-16 13:09:43 -0700 Nevermind, looks like this test has been flaky for a while: http://build.webkit.org/results/GTK%20Linux%2064-bit%20Debug/r59574%20(5941)/results.html 226528 8 eric 2010-05-16 13:27:21 -0700 Filed the false positive as bug 39183. 56189 2010-05-16 09:31:52 -0700 2010-05-16 10:07:00 -0700 Patch bug-39179-20100516093151.patch text/plain 2160 simon.fraser ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NjNhYjgyNDc0NmI1YzUwNjVlMTgyMDYzZjAwYTJiZmI0YmVjZjNjMy4uMWM3ZTAxNjMyZGNlYzI1 NGEyNTVlNmE3M2Q4NmVmYWU3ZTAzYzNjNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0wNS0xNiAgU2lt b24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTaHJpbmsgU2ltcGxlRm9udERhdGEKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5MTc5CisKKyAgICAg ICAgQ2hhbmdlIFNpbXBsZUZvbnREYXRhIHRvIGhhdmUgYSBwb2ludGVyIHRvIHRoZSBtX2dseXBo VG9Cb3VuZHNNYXAsIAorICAgICAgICBhbmQgdG8gYWxsb2NhdGUgdGhpcyBsYXppbHkuIFRoaXMg cmVkdWNlcyB0aGUgc2l6ZSBvZiB0aGUgY2xhc3MgZnJvbQorICAgICAgICA1NjMyIHRvIDE1MzYg Ynl0ZXMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9TaW1wbGVGb250RGF0YS5oOgor ICAgICAgICAoV2ViQ29yZTo6U2ltcGxlRm9udERhdGE6OmJvdW5kc0ZvckdseXBoKToKKwogMjAx MC0wNS0xNSAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBNYWNpZWogU3RhY2hvd2lhay4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvU2ltcGxlRm9udERhdGEuaCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvU2ltcGxlRm9udERhdGEuaAppbmRleCA0YzM0ZjJiMjVjMjYyYWNmNjljYjVkYjEyMTk2YWY2 Yzg4ZmVjYmU1Li5iYzg5N2JlMzFkZjhjNGJhNDBlOWE4M2Y3NzgyMzA5YmEzN2M1ZTMwIDEwMDY0 NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1NpbXBsZUZvbnREYXRhLmgKKysrIGIv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9TaW1wbGVGb250RGF0YS5oCkBAIC0xOTEsNyArMTkx LDcgQEAgcHJpdmF0ZToKIAogICAgIEZvbnRQbGF0Zm9ybURhdGEgbV9wbGF0Zm9ybURhdGE7CiAK LSAgICBtdXRhYmxlIEdseXBoTWV0cmljc01hcDxGbG9hdFJlY3Q+IG1fZ2x5cGhUb0JvdW5kc01h cDsKKyAgICBtdXRhYmxlIE93blB0cjxHbHlwaE1ldHJpY3NNYXA8RmxvYXRSZWN0PiA+IG1fZ2x5 cGhUb0JvdW5kc01hcDsKICAgICBtdXRhYmxlIEdseXBoTWV0cmljc01hcDxmbG9hdD4gbV9nbHlw aFRvV2lkdGhNYXA7CiAKICAgICBib29sIG1fdHJlYXRBc0ZpeGVkUGl0Y2g7CkBAIC0yNTUsMTIg KzI1NSwxNyBAQCBBTFdBWVNfSU5MSU5FIEZsb2F0UmVjdCBTaW1wbGVGb250RGF0YTo6Ym91bmRz Rm9yR2x5cGgoR2x5cGggZ2x5cGgpIGNvbnN0CiAgICAgaWYgKGdseXBoID09IG1femVyb1dpZHRo U3BhY2VHbHlwaCAmJiBnbHlwaCkKICAgICAgICAgcmV0dXJuIEZsb2F0UmVjdCgpOwogCi0gICAg RmxvYXRSZWN0IGJvdW5kcyA9IG1fZ2x5cGhUb0JvdW5kc01hcC5tZXRyaWNzRm9yR2x5cGgoZ2x5 cGgpOwotICAgIGlmIChib3VuZHMud2lkdGgoKSAhPSBjR2x5cGhTaXplVW5rbm93bikKLSAgICAg ICAgcmV0dXJuIGJvdW5kczsKKyAgICBGbG9hdFJlY3QgYm91bmRzOworICAgIGlmIChtX2dseXBo VG9Cb3VuZHNNYXApIHsKKyAgICAgICAgYm91bmRzID0gbV9nbHlwaFRvQm91bmRzTWFwLT5tZXRy aWNzRm9yR2x5cGgoZ2x5cGgpOworICAgICAgICBpZiAoYm91bmRzLndpZHRoKCkgIT0gY0dseXBo U2l6ZVVua25vd24pCisgICAgICAgICAgICByZXR1cm4gYm91bmRzOworICAgIH0KIAogICAgIGJv dW5kcyA9IHBsYXRmb3JtQm91bmRzRm9yR2x5cGgoZ2x5cGgpOwotICAgIG1fZ2x5cGhUb0JvdW5k c01hcC5zZXRNZXRyaWNzRm9yR2x5cGgoZ2x5cGgsIGJvdW5kcyk7CisgICAgaWYgKCFtX2dseXBo VG9Cb3VuZHNNYXApCisgICAgICAgIG1fZ2x5cGhUb0JvdW5kc01hcC5zZXQobmV3IEdseXBoTWV0 cmljc01hcDxGbG9hdFJlY3Q+KCkpOworICAgIG1fZ2x5cGhUb0JvdW5kc01hcC0+c2V0TWV0cmlj c0ZvckdseXBoKGdseXBoLCBib3VuZHMpOwogICAgIHJldHVybiBib3VuZHM7CiB9CiAK