39150 2010-05-14 23:22:19 -0700 Canvas's getContext() must return null when called with an invalid/unsupported parameter 2010-05-18 13:52:39 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All CLOSED FIXED P2 Normal --- 35784 1 kling webkit-unassigned commit-queue hausmann kenneth oldest_to_newest 226149 0 kling 2010-05-14 23:22:19 -0700 See HTML5 spec 4.8.11: http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#dom-canvas-getcontext 226152 1 56142 kling 2010-05-14 23:24:21 -0700 Created attachment 56142 Proposed patch 226299 2 56142 kenneth 2010-05-15 12:15:15 -0700 Comment on attachment 56142 Proposed patch LGTM, but please add the spec link to the ChangeLog 226368 3 56142 abarth 2010-05-15 17:59:21 -0700 Comment on attachment 56142 Proposed patch Looks like the spec link is already in the WebCore ChangeLog. Did you mean that it should be in the LayoutTests ChangeLog too? 226373 4 kenneth 2010-05-15 18:21:54 -0700 I overlooked that, my bad. Having it both places makes sense though. Another option would be to link to it from the test itself. 226440 5 56142 commit-queue 2010-05-16 00:58:58 -0700 Comment on attachment 56142 Proposed patch Clearing flags on attachment: 56142 Committed r59569: <http://trac.webkit.org/changeset/59569> 226442 6 commit-queue 2010-05-16 00:59:04 -0700 All reviewed patches have been landed. Closing bug. 227485 7 hausmann 2010-05-18 13:52:26 -0700 Revision r59569 cherry-picked into qtwebkit-2.0 with commit 14cc1d210d6f2b951f74a5906640d0db4778e9b7 56142 2010-05-14 23:24:21 -0700 2010-05-16 00:58:58 -0700 Proposed patch bug-39150.diff text/plain 5464 kling ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA2NTBjYTUyLi5mMmRjNzVkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDUt MTQgIEFuZHJlYXMgS2xpbmcgIDxhbmRyZWFzLmtsaW5nQG5va2lhLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSB0ZXN0IHRvIGNoZWNr IHByb3BlciByZXR1cm4gdmFsdWUgKG51bGwpIGZyb20gaW52YWxpZCBjYW52YXMgZ2V0Q29udGV4 dCgpIGNhbGxzLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0zOTE1MAorCisgICAgICAgICogZmFzdC9jYW52YXMvY2FudmFzLWdldENvbnRleHQtaW52 YWxpZC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvY2FudmFzL2NhbnZhcy1n ZXRDb250ZXh0LWludmFsaWQuaHRtbDogQWRkZWQuCisgICAgICAgICogZmFzdC9jYW52YXMvc2Ny aXB0LXRlc3RzL2NhbnZhcy1nZXRDb250ZXh0LWludmFsaWQuanM6IEFkZGVkLgorCiAyMDEwLTA1 LTE0ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdl ZC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvY2FudmFzL2NhbnZhcy1nZXRDb250ZXh0 LWludmFsaWQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvY2FudmFzLWdl dENvbnRleHQtaW52YWxpZC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXgg MDAwMDAwMC4uMmYyNGU4ZQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY2Fu dmFzL2NhbnZhcy1nZXRDb250ZXh0LWludmFsaWQtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTUg QEAKK1Rlc3QgdGhhdCBpbnZhbGlkIGNhbnZhcyBnZXRDb250ZXh0KCkgcmVxdWVzdHMgcmV0dXJu IG51bGwuCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVz c2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitQQVNTIGNhbnZhcy5nZXRD b250ZXh0KCcnKSBpcyBudWxsCitQQVNTIGNhbnZhcy5nZXRDb250ZXh0KCcyZCMnKSBpcyBudWxs CitQQVNTIGNhbnZhcy5nZXRDb250ZXh0KCdUaGlzIGlzIGNsZWFybHkgbm90IGEgdmFsaWQgY29u dGV4dCBuYW1lLicpIGlzIG51bGwKK1BBU1MgY2FudmFzLmdldENvbnRleHQoJzJkJykgaXMgbnVs bAorUEFTUyBjYW52YXMuZ2V0Q29udGV4dCgnMu+9hCcpIGlzIG51bGwKK1BBU1MgY2FudmFzLmdl dENvbnRleHQoJzJEJykgaXMgbnVsbAorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQor CitURVNUIENPTVBMRVRFCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvY2FudmFzL2Nh bnZhcy1nZXRDb250ZXh0LWludmFsaWQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvY2FudmFzL2Nh bnZhcy1nZXRDb250ZXh0LWludmFsaWQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAw MDAwMDAwLi5hNzZiYzRhCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9jYW52 YXMvY2FudmFzLWdldENvbnRleHQtaW52YWxpZC5odG1sCkBAIC0wLDAgKzEsMTMgQEAKKzwhRE9D VFlQRSBIVE1MIFBVQkxJQyAiLS8vSUVURi8vRFREIEhUTUwvL0VOIj4KKzxodG1sPgorPGhlYWQ+ Cis8bGluayByZWw9InN0eWxlc2hlZXQiIGhyZWY9Ii4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXN0 eWxlLmNzcyI+Cis8c2NyaXB0IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48 L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPHAgaWQ9ImRlc2NyaXB0aW9uIj48L3A+Cis8ZGl2 IGlkPSJjb25zb2xlIj48L2Rpdj4KKzxzY3JpcHQgc3JjPSJzY3JpcHQtdGVzdHMvY2FudmFzLWdl dENvbnRleHQtaW52YWxpZC5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vanMvcmVzb3Vy Y2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy9zY3JpcHQtdGVzdHMvY2FudmFzLWdldENvbnRl eHQtaW52YWxpZC5qcyBiL0xheW91dFRlc3RzL2Zhc3QvY2FudmFzL3NjcmlwdC10ZXN0cy9jYW52 YXMtZ2V0Q29udGV4dC1pbnZhbGlkLmpzCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAw MDAuLmJhZWI2OTMKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy9z Y3JpcHQtdGVzdHMvY2FudmFzLWdldENvbnRleHQtaW52YWxpZC5qcwpAQCAtMCwwICsxLDEyIEBA CitkZXNjcmlwdGlvbigiVGVzdCB0aGF0IGludmFsaWQgY2FudmFzIGdldENvbnRleHQoKSByZXF1 ZXN0cyByZXR1cm4gbnVsbC4iKTsKKworY2FudmFzID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgn Y2FudmFzJyk7CisKK3Nob3VsZEJlKCJjYW52YXMuZ2V0Q29udGV4dCgnJykiLCAibnVsbCIpOwor c2hvdWxkQmUoImNhbnZhcy5nZXRDb250ZXh0KCcyZCMnKSIsICJudWxsIik7CitzaG91bGRCZSgi Y2FudmFzLmdldENvbnRleHQoJ1RoaXMgaXMgY2xlYXJseSBub3QgYSB2YWxpZCBjb250ZXh0IG5h bWUuJykiLCAibnVsbCIpOworc2hvdWxkQmUoImNhbnZhcy5nZXRDb250ZXh0KCcyZFwwJykiLCAi bnVsbCIpOworc2hvdWxkQmUoImNhbnZhcy5nZXRDb250ZXh0KCcyXHVGRjQ0JykiLCAibnVsbCIp Oworc2hvdWxkQmUoImNhbnZhcy5nZXRDb250ZXh0KCcyRCcpIiwgIm51bGwiKTsKKwordmFyIHN1 Y2Nlc3NmdWxseVBhcnNlZCA9IHRydWU7CmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBi L1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDBmY2MyOWQuLmJiYjUyZDcgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAK KzIwMTAtMDUtMTQgIEFuZHJlYXMgS2xpbmcgIDxhbmRyZWFzLmtsaW5nQG5va2lhLmNvbT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDYW52YXMncyBn ZXRDb250ZXh0KCkgbXVzdCByZXR1cm4gbnVsbCB3aGVuIGNhbGxlZCB3aXRoIGFuIGludmFsaWQv dW5zdXBwb3J0ZWQgcGFyYW1ldGVyLgorICAgICAgICAoSFRNTDUgc3BlYyA0LjguMTEpOiBodHRw Oi8vd3d3LndoYXR3Zy5vcmcvc3BlY3Mvd2ViLWFwcHMvY3VycmVudC13b3JrL211bHRpcGFnZS90 aGUtY2FudmFzLWVsZW1lbnQuaHRtbCNkb20tY2FudmFzLWdldGNvbnRleHQKKworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzkxNTAKKworICAgICAgICBU ZXN0OiBmYXN0L2NhbnZhcy9jYW52YXMtZ2V0Q29udGV4dC1pbnZhbGlkLmh0bWwKKworICAgICAg ICAqIGJpbmRpbmdzL2pzL0pTSFRNTENhbnZhc0VsZW1lbnRDdXN0b20uY3BwOgorICAgICAgICAo V2ViQ29yZTo6SlNIVE1MQ2FudmFzRWxlbWVudDo6Z2V0Q29udGV4dCk6CisgICAgICAgICogYmlu ZGluZ3MvdjgvY3VzdG9tL1Y4SFRNTENhbnZhc0VsZW1lbnRDdXN0b20uY3BwOgorICAgICAgICAo V2ViQ29yZTo6VjhIVE1MQ2FudmFzRWxlbWVudDo6Z2V0Q29udGV4dENhbGxiYWNrKToKKwogMjAx MC0wNS0xNCAgQWRlbGUgUGV0ZXJzb24gIDxhZGVsZUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgRGF2ZSBIeWF0dC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvYmluZGluZ3MvanMvSlNI VE1MQ2FudmFzRWxlbWVudEN1c3RvbS5jcHAgYi9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTSFRNTENh bnZhc0VsZW1lbnRDdXN0b20uY3BwCmluZGV4IDg5ZjYyZjguLjQxOWY5ZTkgMTAwNjQ0Ci0tLSBh L1dlYkNvcmUvYmluZGluZ3MvanMvSlNIVE1MQ2FudmFzRWxlbWVudEN1c3RvbS5jcHAKKysrIGIv V2ViQ29yZS9iaW5kaW5ncy9qcy9KU0hUTUxDYW52YXNFbGVtZW50Q3VzdG9tLmNwcApAQCAtNzgs NyArNzgsMTAgQEAgSlNWYWx1ZSBKU0hUTUxDYW52YXNFbGVtZW50OjpnZXRDb250ZXh0KEV4ZWNT dGF0ZSogZXhlYywgY29uc3QgQXJnTGlzdCYgYXJncykKICAgICAgICAgfQogICAgIH0KICNlbmRp ZgotICAgIHJldHVybiB0b0pTKGV4ZWMsIGdsb2JhbE9iamVjdCgpLCBXVEY6OmdldFB0cihjYW52 YXMtPmdldENvbnRleHQodXN0cmluZ1RvU3RyaW5nKGNvbnRleHRJZCksIGF0dHJzLmdldCgpKSkp OworICAgIENhbnZhc1JlbmRlcmluZ0NvbnRleHQqIGNvbnRleHQgPSBjYW52YXMtPmdldENvbnRl eHQodXN0cmluZ1RvU3RyaW5nKGNvbnRleHRJZCksIGF0dHJzLmdldCgpKTsKKyAgICBpZiAoIWNv bnRleHQpCisgICAgICAgIHJldHVybiBqc051bGwoKTsKKyAgICByZXR1cm4gdG9KUyhleGVjLCBn bG9iYWxPYmplY3QoKSwgV1RGOjpnZXRQdHIoY29udGV4dCkpOwogfQogCiB9IC8vIG5hbWVzcGFj ZSBXZWJDb3JlCmRpZmYgLS1naXQgYS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEhUTUxD YW52YXNFbGVtZW50Q3VzdG9tLmNwcCBiL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4SFRN TENhbnZhc0VsZW1lbnRDdXN0b20uY3BwCmluZGV4IDY3YmEzOGIuLjA3MmEyOGYgMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4SFRNTENhbnZhc0VsZW1lbnRDdXN0b20u Y3BwCisrKyBiL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4SFRNTENhbnZhc0VsZW1lbnRD dXN0b20uY3BwCkBAIC03OCw3ICs3OCw3IEBAIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBWOEhUTUxD YW52YXNFbGVtZW50OjpnZXRDb250ZXh0Q2FsbGJhY2soY29uc3Qgdjg6OkFyZ3VtZW50CiAjZW5k aWYKICAgICBDYW52YXNSZW5kZXJpbmdDb250ZXh0KiByZXN1bHQgPSBpbXAtPmdldENvbnRleHQo Y29udGV4dElkLCBhdHRycy5nZXQoKSk7CiAgICAgaWYgKCFyZXN1bHQpCi0gICAgICAgIHJldHVy biB2ODo6VW5kZWZpbmVkKCk7CisgICAgICAgIHJldHVybiB2ODo6TnVsbCgpOwogICAgIGlmIChy ZXN1bHQtPmlzMmQoKSkKICAgICAgICAgcmV0dXJuIHRvVjgoc3RhdGljX2Nhc3Q8Q2FudmFzUmVu ZGVyaW5nQ29udGV4dDJEKj4ocmVzdWx0KSk7CiAjaWYgRU5BQkxFKDNEX0NBTlZBUykKQEAgLTg2 LDcgKzg2LDcgQEAgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IFY4SFRNTENhbnZhc0VsZW1lbnQ6Omdl dENvbnRleHRDYWxsYmFjayhjb25zdCB2ODo6QXJndW1lbnQKICAgICAgICAgcmV0dXJuIHRvVjgo c3RhdGljX2Nhc3Q8V2ViR0xSZW5kZXJpbmdDb250ZXh0Kj4ocmVzdWx0KSk7CiAjZW5kaWYKICAg ICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKLSAgICByZXR1cm4gdjg6OlVuZGVmaW5lZCgpOworICAg IHJldHVybiB2ODo6TnVsbCgpOwogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg==