<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>39141</bug_id>
          
          <creation_ts>2010-05-14 15:10:13 -0700</creation_ts>
          <short_desc>Only use rietveld mode when in-rietveld is set to +</short_desc>
          <delta_ts>2010-05-14 16:13:47 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Julie Parent">jparent</reporter>
          <assigned_to name="Julie Parent">jparent</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>226023</commentid>
    <comment_count>0</comment_count>
    <who name="Julie Parent">jparent</who>
    <bug_when>2010-05-14 15:10:13 -0700</bug_when>
    <thetext>Currently uses presence of flag, not the value of it, so shows the &quot;Rietveld Review&quot; link even if the in-rietveld flag is -.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>226041</commentid>
    <comment_count>1</comment_count>
      <attachid>56117</attachid>
    <who name="Julie Parent">jparent</who>
    <bug_when>2010-05-14 15:58:29 -0700</bug_when>
    <thetext>Created attachment 56117
patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>226044</commentid>
    <comment_count>2</comment_count>
    <who name="Julie Parent">jparent</who>
    <bug_when>2010-05-14 16:13:47 -0700</bug_when>
    <thetext>Committed in http://trac.webkit.org/changeset/59501</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>56117</attachid>
            <date>2010-05-14 15:58:29 -0700</date>
            <delta_ts>2010-05-14 16:09:55 -0700</delta_ts>
            <desc>patch.</desc>
            <filename>useStatus.txt</filename>
            <type>text/plain</type>
            <size>1297</size>
            <attacher name="Julie Parent">jparent</attacher>
            
              <data encoding="base64">SW5kZXg6IEJ1Z3NTaXRlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBCdWdzU2l0ZS9DaGFuZ2VM
b2cJKHJldmlzaW9uIDU5NTAwKQorKysgQnVnc1NpdGUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkp
CkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDUtMTQgIEp1bGllIFBhcmVudCAgPGpwYXJlbnRAY2hy
b21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg
ICAgIEJ1Z3ppbGxhOiBPbmx5IHVzZSByaWV0dmVsZCBtb2RlIHdoZW4gaW4tcmlldHZlbGQgaXMg
c2V0IHRvICsuCisgICAgICAgIAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93
X2J1Zy5jZ2k/aWQ9MzkxNDEKKworICAgICAgICAqIHRlbXBsYXRlL2VuL2N1c3RvbS9hdHRhY2ht
ZW50L2xpc3QuaHRtbC50bXBsOgorCiAyMDEwLTA1LTEzICBKdWxpZSBQYXJlbnQgIDxqcGFyZW50
QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXZpZCBLaWx6ZXIuCkluZGV4
OiBCdWdzU2l0ZS90ZW1wbGF0ZS9lbi9jdXN0b20vYXR0YWNobWVudC9saXN0Lmh0bWwudG1wbAo9
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09Ci0tLSBCdWdzU2l0ZS90ZW1wbGF0ZS9lbi9jdXN0b20vYXR0YWNobWVudC9saXN0
Lmh0bWwudG1wbAkocmV2aXNpb24gNTk0OTUpCisrKyBCdWdzU2l0ZS90ZW1wbGF0ZS9lbi9jdXN0
b20vYXR0YWNobWVudC9saXN0Lmh0bWwudG1wbAkod29ya2luZyBjb3B5KQpAQCAtMTUwLDcgKzE1
MCw3IEBACiBbJSMgaWYgV0VCS0lUX0NIQU5HRVMgJV0KICAgICAgICAgICBbJSBJRiBhdHRhY2ht
ZW50LmlzcGF0Y2ggJV0KICAgICAgICAgICAgIFslIEZPUkVBQ0ggZmxhZyA9IGF0dGFjaG1lbnQu
ZmxhZ3MgJV0KLSAgICAgICAgICAgICAgWyUgSUYgZmxhZy50eXBlLm5hbWUgPT0gJ2luLXJpZXR2
ZWxkJyAgJV0KKyAgICAgICAgICAgICAgWyUgSUYgZmxhZy50eXBlLm5hbWUgPT0gJ2luLXJpZXR2
ZWxkJyAmJiBmbGFnLnN0YXR1cyA9PSAiKyIgICVdCiAgICAgICAgICAgICAgICAgfCA8YSBocmVm
PSJhdHRhY2htZW50LmNnaT9pZD1bJSBhdHRhY2htZW50LmlkICVdJmFtcDthY3Rpb249cmlldHZl
bGRyZXZpZXcmYW1wO0dvQWhlYWRBbmRMb2dJbj0xIj5SaWV0dmVsZCBSZXZpZXc8L2E+CiAgICAg
ICAgICAgICAgIFslIEVORCAlXQogICAgICAgICAgICAgWyUgRU5EICVdCg==
</data>
<flag name="review"
          id="40468"
          type_id="1"
          status="+"
          setter="ojan"
    />
          </attachment>
      

    </bug>

</bugzilla>