39133 2010-05-14 13:40:15 -0700 Clipboard.setData doesn't need to be custom 2010-05-15 06:15:07 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth webkit-unassigned commit-queue oldest_to_newest 225979 0 abarth 2010-05-14 13:40:15 -0700 Clipboard.setData doesn't need to be custom 225980 1 56104 abarth 2010-05-14 13:45:19 -0700 Created attachment 56104 Patch 226000 2 56104 darin 2010-05-14 14:21:07 -0700 Comment on attachment 56104 Patch > + // FIXME: Should setData return void? It used be declared that way... > + // Also, this function used to be declared to throw an > + // exception even though it never did. I don't think this comment is all that helpful. 226002 3 56109 abarth 2010-05-14 14:30:50 -0700 Created attachment 56109 Patch for landing 226233 4 56109 commit-queue 2010-05-15 06:15:01 -0700 Comment on attachment 56109 Patch for landing Clearing flags on attachment: 56109 Committed r59536: <http://trac.webkit.org/changeset/59536> 226234 5 commit-queue 2010-05-15 06:15:07 -0700 All reviewed patches have been landed. Closing bug. 56104 2010-05-14 13:45:19 -0700 2010-05-14 14:30:38 -0700 Patch bug-39133-20100514134516.patch text/plain 3793 abarth SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1OTQ4NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjEgQEAKKzIwMTAtMDUtMTQgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDbGlw Ym9hcmQuc2V0RGF0YSBkb2Vzbid0IG5lZWQgdG8gYmUgY3VzdG9tCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zOTEzMworCisgICAgICAgIFRoZSBpbXBs ZW1lbnRhdGlvbiBvZiB0aGUgY3VzdG9tIGJpbmRpbmcgZm9yIHRoaXMgZnVuY3Rpb24gd2FzIGEg Yml0CisgICAgICAgIGRpZmZlcmVudCB0aGFuIGl0cyBkZWNsYXJhdGlvbiBpbiB0aGUgSURMIGZp bGUuICBJJ3ZlIHVwZGF0ZWQgdGhlIElETAorICAgICAgICB0byBtYXRjaCB0aGUgaW1wbGVtZW50 YXRpb24sIGJ1dCB3ZSBwcm9iYWJseSBzaG91bGQgY2hlY2sgd2hldGhlciBvdXIKKyAgICAgICAg YmVoYXZpb3IgaXMgY29ycmVjdCB3aXRoIHJlc3BlY3QgdG8gdGhlIHNwZWNpZmljYXRpb24uCisK KyAgICAgICAgTm8gdGVzdHMgYmVjYXVzZSBJJ3ZlIG1haW50YWluZWQgb3VyIGN1cnJlbnQgYmVo YXZpb3IuCisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU0NsaXBib2FyZEN1c3RvbS5jcHA6Cisg ICAgICAgICogYmluZGluZ3MvdjgvY3VzdG9tL1Y4Q2xpcGJvYXJkQ3VzdG9tLmNwcDoKKyAgICAg ICAgKiBkb20vQ2xpcGJvYXJkLmlkbDoKKwogMjAxMC0wNS0xNCAgU2VyZ2V5IFVsYW5vdiAgPHNl cmdleXVAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERtaXRyeSBUaXRvdiBh bmQgQnJldHQgV2lsc29uLgpJbmRleDogV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0NsaXBib2FyZEN1 c3RvbS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0NsaXBib2FyZEN1 c3RvbS5jcHAJKHJldmlzaW9uIDU5MzgzKQorKysgV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0NsaXBi b2FyZEN1c3RvbS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTk3LDE3ICs5Nyw2IEBAIEpTVmFsdWUg SlNDbGlwYm9hcmQ6OmdldERhdGEoRXhlY1N0YXRlKiAKICAgICByZXR1cm4ganNTdHJpbmcoZXhl YywgcmVzdWx0KTsKIH0KIAotSlNWYWx1ZSBKU0NsaXBib2FyZDo6c2V0RGF0YShFeGVjU3RhdGUq IGV4ZWMsIGNvbnN0IEFyZ0xpc3QmIGFyZ3MpCi17Ci0gICAgQ2xpcGJvYXJkKiBjbGlwYm9hcmQg PSBpbXBsKCk7Ci0KLSAgICAvLyBGSVhNRTogSXQgZG9lcyBub3QgbWF0Y2ggdGhlIHJlc3Qgb2Yg dGhlIEpTIGJpbmRpbmdzIHRvIHRocm93IG9uIGludmFsaWQgbnVtYmVyIG9mIGFyZ3VtZW50cy4g Ci0gICAgaWYgKGFyZ3Muc2l6ZSgpICE9IDIpCi0gICAgICAgIHJldHVybiB0aHJvd0Vycm9yKGV4 ZWMsIFN5bnRheEVycm9yLCAic2V0RGF0YTogSW52YWxpZCBudW1iZXIgb2YgYXJndW1lbnRzIik7 Ci0KLSAgICByZXR1cm4ganNCb29sZWFuKGNsaXBib2FyZC0+c2V0RGF0YSh1c3RyaW5nVG9TdHJp bmcoYXJncy5hdCgwKS50b1N0cmluZyhleGVjKSksIHVzdHJpbmdUb1N0cmluZyhhcmdzLmF0KDEp LnRvU3RyaW5nKGV4ZWMpKSkpOwotfQotCiBKU1ZhbHVlIEpTQ2xpcGJvYXJkOjpzZXREcmFnSW1h Z2UoRXhlY1N0YXRlKiBleGVjLCBjb25zdCBBcmdMaXN0JiBhcmdzKQogewogICAgIENsaXBib2Fy ZCogY2xpcGJvYXJkID0gaW1wbCgpOwpJbmRleDogV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20v VjhDbGlwYm9hcmRDdXN0b20uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvYmluZGluZ3Mvdjgv Y3VzdG9tL1Y4Q2xpcGJvYXJkQ3VzdG9tLmNwcAkocmV2aXNpb24gNTkzODMpCisrKyBXZWJDb3Jl L2JpbmRpbmdzL3Y4L2N1c3RvbS9WOENsaXBib2FyZEN1c3RvbS5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTk2LDE5ICs5Niw2IEBAIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBWOENsaXBib2FyZDo6Z2V0 RGEKICAgICByZXR1cm4gdjg6OlVuZGVmaW5lZCgpOwogfQogCi12ODo6SGFuZGxlPHY4OjpWYWx1 ZT4gVjhDbGlwYm9hcmQ6OnNldERhdGFDYWxsYmFjayhjb25zdCB2ODo6QXJndW1lbnRzJiBhcmdz KQotewotICAgIElOQ19TVEFUUygiRE9NLkNsaXBib2FyZC5zZXREYXRhKCkiKTsKLSAgICBDbGlw Ym9hcmQqIGNsaXBib2FyZCA9IFY4Q2xpcGJvYXJkOjp0b05hdGl2ZShhcmdzLkhvbGRlcigpKTsK LQotICAgIGlmIChhcmdzLkxlbmd0aCgpICE9IDIpCi0gICAgICAgIHJldHVybiB0aHJvd0Vycm9y KCJzZXREYXRhOiBJbnZhbGlkIG51bWJlciBvZiBhcmd1bWVudHMiLCBWOFByb3h5OjpTeW50YXhF cnJvcik7Ci0KLSAgICBTdHJpbmcgdHlwZSA9IHRvV2ViQ29yZVN0cmluZyhhcmdzWzBdKTsKLSAg ICBTdHJpbmcgZGF0YSA9IHRvV2ViQ29yZVN0cmluZyhhcmdzWzFdKTsKLSAgICByZXR1cm4gdjhC b29sZWFuKGNsaXBib2FyZC0+c2V0RGF0YSh0eXBlLCBkYXRhKSk7Ci19Ci0KIHY4OjpIYW5kbGU8 djg6OlZhbHVlPiBWOENsaXBib2FyZDo6c2V0RHJhZ0ltYWdlQ2FsbGJhY2soY29uc3Qgdjg6OkFy Z3VtZW50cyYgYXJncykKIHsKICAgICBJTkNfU1RBVFMoIkRPTS5DbGlwYm9hcmQuc2V0RHJhZ0lt YWdlKCkiKTsKSW5kZXg6IFdlYkNvcmUvZG9tL0NsaXBib2FyZC5pZGwKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViQ29yZS9kb20vQ2xpcGJvYXJkLmlkbAkocmV2aXNpb24gNTkzODMpCisrKyBXZWJDb3JlL2Rv bS9DbGlwYm9hcmQuaWRsCSh3b3JraW5nIGNvcHkpCkBAIC0zOCw4ICszOCwxMSBAQCBtb2R1bGUg Y29yZSB7CiAgICAgICAgICAgICByYWlzZXMoRE9NRXhjZXB0aW9uKTsKICAgICAgICAgW0N1c3Rv bV0gdm9pZCBnZXREYXRhKGluIERPTVN0cmluZyB0eXBlKQogICAgICAgICAgICAgcmFpc2VzKERP TUV4Y2VwdGlvbik7Ci0gICAgICAgIFtDdXN0b21dIHZvaWQgc2V0RGF0YShpbiBET01TdHJpbmcg dHlwZSwgaW4gRE9NU3RyaW5nIGRhdGEpCi0gICAgICAgICAgICByYWlzZXMoRE9NRXhjZXB0aW9u KTsKKyAgICAgICAgLy8gRklYTUU6IFJlcXVpcmVzQWxsQXJndW1lbnRzIGlzIHByb2JhYmx5IGJv Z3VzIGhlcmUuCisgICAgICAgIC8vIEZJWE1FOiBTaG91bGQgc2V0RGF0YSByZXR1cm4gdm9pZD8g SXQgdXNlZCBiZSBkZWNsYXJlZCB0aGF0IHdheS4uLgorICAgICAgICAvLyAgICAgICAgQWxzbywg dGhpcyBmdW5jdGlvbiB1c2VkIHRvIGJlIGRlY2xhcmVkIHRvIHRocm93IGFuCisgICAgICAgIC8v ICAgICAgICBleGNlcHRpb24gZXZlbiB0aG91Z2ggaXQgbmV2ZXIgZGlkLgorICAgICAgICBbUmVx dWlyZXNBbGxBcmd1bWVudHNdIGJvb2xlYW4gc2V0RGF0YShpbiBET01TdHJpbmcgdHlwZSwgaW4g RE9NU3RyaW5nIGRhdGEpOwogICAgICAgICBbQ3VzdG9tXSB2b2lkIHNldERyYWdJbWFnZShpbiBI VE1MSW1hZ2VFbGVtZW50IGltYWdlLCBpbiBsb25nIHgsIGluIGxvbmcgeSkKICAgICAgICAgICAg IHJhaXNlcyhET01FeGNlcHRpb24pOwogICAgIH07Cg== 56109 2010-05-14 14:30:50 -0700 2010-05-15 06:15:01 -0700 Patch for landing bug-39133-20100514143049.patch text/plain 3566 abarth SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1OTQ5MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjEgQEAKKzIwMTAtMDUtMTQgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KKworICAgICAgICBDbGlwYm9h cmQuc2V0RGF0YSBkb2Vzbid0IG5lZWQgdG8gYmUgY3VzdG9tCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zOTEzMworCisgICAgICAgIFRoZSBpbXBsZW1l bnRhdGlvbiBvZiB0aGUgY3VzdG9tIGJpbmRpbmcgZm9yIHRoaXMgZnVuY3Rpb24gd2FzIGEgYml0 CisgICAgICAgIGRpZmZlcmVudCB0aGFuIGl0cyBkZWNsYXJhdGlvbiBpbiB0aGUgSURMIGZpbGUu ICBJJ3ZlIHVwZGF0ZWQgdGhlIElETAorICAgICAgICB0byBtYXRjaCB0aGUgaW1wbGVtZW50YXRp b24sIGJ1dCB3ZSBwcm9iYWJseSBzaG91bGQgY2hlY2sgd2hldGhlciBvdXIKKyAgICAgICAgYmVo YXZpb3IgaXMgY29ycmVjdCB3aXRoIHJlc3BlY3QgdG8gdGhlIHNwZWNpZmljYXRpb24uCisKKyAg ICAgICAgTm8gdGVzdHMgYmVjYXVzZSBJJ3ZlIG1haW50YWluZWQgb3VyIGN1cnJlbnQgYmVoYXZp b3IuCisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU0NsaXBib2FyZEN1c3RvbS5jcHA6CisgICAg ICAgICogYmluZGluZ3MvdjgvY3VzdG9tL1Y4Q2xpcGJvYXJkQ3VzdG9tLmNwcDoKKyAgICAgICAg KiBkb20vQ2xpcGJvYXJkLmlkbDoKKwogMjAxMC0wNS0xNCAgRXJpYyBTZWlkZWwgIDxlcmljQHdl YmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjU5NDg5LgpJbmRl eDogV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0NsaXBib2FyZEN1c3RvbS5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0NsaXBib2FyZEN1c3RvbS5jcHAJKHJldmlzaW9uIDU5 NDkwKQorKysgV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0NsaXBib2FyZEN1c3RvbS5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTk3LDE3ICs5Nyw2IEBAIEpTVmFsdWUgSlNDbGlwYm9hcmQ6OmdldERhdGEo RXhlY1N0YXRlKiAKICAgICByZXR1cm4ganNTdHJpbmcoZXhlYywgcmVzdWx0KTsKIH0KIAotSlNW YWx1ZSBKU0NsaXBib2FyZDo6c2V0RGF0YShFeGVjU3RhdGUqIGV4ZWMsIGNvbnN0IEFyZ0xpc3Qm IGFyZ3MpCi17Ci0gICAgQ2xpcGJvYXJkKiBjbGlwYm9hcmQgPSBpbXBsKCk7Ci0KLSAgICAvLyBG SVhNRTogSXQgZG9lcyBub3QgbWF0Y2ggdGhlIHJlc3Qgb2YgdGhlIEpTIGJpbmRpbmdzIHRvIHRo cm93IG9uIGludmFsaWQgbnVtYmVyIG9mIGFyZ3VtZW50cy4gCi0gICAgaWYgKGFyZ3Muc2l6ZSgp ICE9IDIpCi0gICAgICAgIHJldHVybiB0aHJvd0Vycm9yKGV4ZWMsIFN5bnRheEVycm9yLCAic2V0 RGF0YTogSW52YWxpZCBudW1iZXIgb2YgYXJndW1lbnRzIik7Ci0KLSAgICByZXR1cm4ganNCb29s ZWFuKGNsaXBib2FyZC0+c2V0RGF0YSh1c3RyaW5nVG9TdHJpbmcoYXJncy5hdCgwKS50b1N0cmlu ZyhleGVjKSksIHVzdHJpbmdUb1N0cmluZyhhcmdzLmF0KDEpLnRvU3RyaW5nKGV4ZWMpKSkpOwot fQotCiBKU1ZhbHVlIEpTQ2xpcGJvYXJkOjpzZXREcmFnSW1hZ2UoRXhlY1N0YXRlKiBleGVjLCBj b25zdCBBcmdMaXN0JiBhcmdzKQogewogICAgIENsaXBib2FyZCogY2xpcGJvYXJkID0gaW1wbCgp OwpJbmRleDogV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhDbGlwYm9hcmRDdXN0b20uY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4Q2xpcGJvYXJkQ3Vz dG9tLmNwcAkocmV2aXNpb24gNTk0OTApCisrKyBXZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9W OENsaXBib2FyZEN1c3RvbS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTk2LDE5ICs5Niw2IEBAIHY4 OjpIYW5kbGU8djg6OlZhbHVlPiBWOENsaXBib2FyZDo6Z2V0RGEKICAgICByZXR1cm4gdjg6OlVu ZGVmaW5lZCgpOwogfQogCi12ODo6SGFuZGxlPHY4OjpWYWx1ZT4gVjhDbGlwYm9hcmQ6OnNldERh dGFDYWxsYmFjayhjb25zdCB2ODo6QXJndW1lbnRzJiBhcmdzKQotewotICAgIElOQ19TVEFUUygi RE9NLkNsaXBib2FyZC5zZXREYXRhKCkiKTsKLSAgICBDbGlwYm9hcmQqIGNsaXBib2FyZCA9IFY4 Q2xpcGJvYXJkOjp0b05hdGl2ZShhcmdzLkhvbGRlcigpKTsKLQotICAgIGlmIChhcmdzLkxlbmd0 aCgpICE9IDIpCi0gICAgICAgIHJldHVybiB0aHJvd0Vycm9yKCJzZXREYXRhOiBJbnZhbGlkIG51 bWJlciBvZiBhcmd1bWVudHMiLCBWOFByb3h5OjpTeW50YXhFcnJvcik7Ci0KLSAgICBTdHJpbmcg dHlwZSA9IHRvV2ViQ29yZVN0cmluZyhhcmdzWzBdKTsKLSAgICBTdHJpbmcgZGF0YSA9IHRvV2Vi Q29yZVN0cmluZyhhcmdzWzFdKTsKLSAgICByZXR1cm4gdjhCb29sZWFuKGNsaXBib2FyZC0+c2V0 RGF0YSh0eXBlLCBkYXRhKSk7Ci19Ci0KIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBWOENsaXBib2Fy ZDo6c2V0RHJhZ0ltYWdlQ2FsbGJhY2soY29uc3Qgdjg6OkFyZ3VtZW50cyYgYXJncykKIHsKICAg ICBJTkNfU1RBVFMoIkRPTS5DbGlwYm9hcmQuc2V0RHJhZ0ltYWdlKCkiKTsKSW5kZXg6IFdlYkNv cmUvZG9tL0NsaXBib2FyZC5pZGwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9kb20vQ2xpcGJvYXJk LmlkbAkocmV2aXNpb24gNTk0OTApCisrKyBXZWJDb3JlL2RvbS9DbGlwYm9hcmQuaWRsCSh3b3Jr aW5nIGNvcHkpCkBAIC0zOCw4ICszOCw4IEBAIG1vZHVsZSBjb3JlIHsKICAgICAgICAgICAgIHJh aXNlcyhET01FeGNlcHRpb24pOwogICAgICAgICBbQ3VzdG9tXSB2b2lkIGdldERhdGEoaW4gRE9N U3RyaW5nIHR5cGUpCiAgICAgICAgICAgICByYWlzZXMoRE9NRXhjZXB0aW9uKTsKLSAgICAgICAg W0N1c3RvbV0gdm9pZCBzZXREYXRhKGluIERPTVN0cmluZyB0eXBlLCBpbiBET01TdHJpbmcgZGF0 YSkKLSAgICAgICAgICAgIHJhaXNlcyhET01FeGNlcHRpb24pOworICAgICAgICAvLyBGSVhNRTog UmVxdWlyZXNBbGxBcmd1bWVudHMgaXMgcHJvYmFibHkgYm9ndXMgaGVyZS4KKyAgICAgICAgW1Jl cXVpcmVzQWxsQXJndW1lbnRzXSBib29sZWFuIHNldERhdGEoaW4gRE9NU3RyaW5nIHR5cGUsIGlu IERPTVN0cmluZyBkYXRhKTsKICAgICAgICAgW0N1c3RvbV0gdm9pZCBzZXREcmFnSW1hZ2UoaW4g SFRNTEltYWdlRWxlbWVudCBpbWFnZSwgaW4gbG9uZyB4LCBpbiBsb25nIHkpCiAgICAgICAgICAg ICByYWlzZXMoRE9NRXhjZXB0aW9uKTsKICAgICB9Owo=