39128 2010-05-14 11:46:30 -0700 fast/canvas/webgl/texture-npot.html failed on leopard bot 2010-07-02 14:51:35 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 39361 41545 1 zmo zmo abarth cmarrin commit-queue eric kbr oliver webkit.review.bot oldest_to_newest 225929 0 zmo 2010-05-14 11:46:30 -0700 See https://bugs.webkit.org/show_bug.cgi?id=33805 225955 1 56098 zmo 2010-05-14 12:57:28 -0700 Created attachment 56098 patch: an attempted fix Skip pixel (0, 0) in the test; also print out actual pixel color when failing. 225956 2 56098 kbr 2010-05-14 12:59:26 -0700 Comment on attachment 56098 patch: an attempted fix Looks fine to me. Eric suggests to commit (and potentially revise / revert) this during off-hours to minimize the impact of breakage on this bot. 226820 3 56098 darin 2010-05-17 10:54:56 -0700 Comment on attachment 56098 patch: an attempted fix > + // We skip the (0, 0) pixel due to a possible bug on the Leopard bot. This comment is too vague. The change otherwise seems fine. I suggest changing it to say "i = 1" instead of adding this if statement. 226845 4 zmo 2010-05-17 12:04:03 -0700 (In reply to comment #3) > (From update of attachment 56098 [details]) > > + // We skip the (0, 0) pixel due to a possible bug on the Leopard bot. > > This comment is too vague. The change otherwise seems fine. I suggest changing it to say "i = 1" instead of adding this if statement. This patch is a temporary attempt to confirm a guess of the cause of this failure. That's why I don't want to add a detailed explanation which might be incorrect. 226926 5 eric 2010-05-17 15:12:28 -0700 (In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 56098 [details] [details]) > > > + // We skip the (0, 0) pixel due to a possible bug on the Leopard bot. > > > > This comment is too vague. The change otherwise seems fine. I suggest changing it to say "i = 1" instead of adding this if statement. > > This patch is a temporary attempt to confirm a guess of the cause of this failure. That's why I don't want to add a detailed explanation which might be incorrect. Temporary things tend to have a nasty habit of becoming permanent. :) IMO, you could just link to a bug as a second line of the comment that that would make it not-vague enough for my tastes. :) At least then someone can look at the bug to know later if/when it's safe to remove that line. 226949 6 56279 zmo 2010-05-17 15:46:12 -0700 Created attachment 56279 revised patch: add a link to the bug in test comments. 226952 7 56279 darin 2010-05-17 15:50:50 -0700 Comment on attachment 56279 revised patch: add a link to the bug in test comments. OK, rs=me 227765 8 56279 commit-queue 2010-05-19 03:59:52 -0700 Comment on attachment 56279 revised patch: add a link to the bug in test comments. Clearing flags on attachment: 56279 Committed r59758: <http://trac.webkit.org/changeset/59758> 227766 9 commit-queue 2010-05-19 03:59:58 -0700 All reviewed patches have been landed. Closing bug. 227779 10 webkit.review.bot 2010-05-19 04:53:39 -0700 http://trac.webkit.org/changeset/59758 might have broken Leopard Intel Debug (Tests) 227828 11 abarth 2010-05-19 08:06:18 -0700 I'm confused. This patch appears to cause the bug it claims to fix... Rolling out. 227829 12 abarth 2010-05-19 08:06:50 -0700 http://build.webkit.org/results/Leopard%20Intel%20Debug%20(Tests)/r59762%20(14638)/fast/canvas/webgl/texture-npot-pretty-diff.html 227838 13 zmo 2010-05-19 08:29:48 -0700 (In reply to comment #11) > I'm confused. This patch appears to cause the bug it claims to fix... Rolling out. This patch is testing out a guess of the cause of the failure and at the same time if the guess is wrong, the patch collects some extra information. I already asked kbr and Eric to help rolling this out, but you beat them. Thanks. 227912 14 56504 zmo 2010-05-19 11:37:11 -0700 Created attachment 56504 patch Adding test cases back, but skip the test on Leopard for now. Once we get mesa renderer integrated, we will turn it back on. 227949 15 56504 kbr 2010-05-19 12:30:42 -0700 Comment on attachment 56504 patch Looks good to me. 227955 16 56504 dglazkov 2010-05-19 12:56:01 -0700 Comment on attachment 56504 patch ok. 228706 17 56504 commit-queue 2010-05-20 19:34:53 -0700 Comment on attachment 56504 patch Clearing flags on attachment: 56504 Committed r59899: <http://trac.webkit.org/changeset/59899> 228707 18 commit-queue 2010-05-20 19:34:59 -0700 All reviewed patches have been landed. Closing bug. 56098 2010-05-14 12:57:28 -0700 2010-05-17 15:46:12 -0700 patch: an attempted fix npot.patch text/plain 4503 zmo SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDU5NDgxKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDUtMTQgIFpoZW55YW8gTW8gIDx6bW9A Z29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBmYXN0L2NhbnZhcy93ZWJnbC90ZXh0dXJlLW5wb3QuaHRtbCBmYWlsZWQgb24gbGVvcGFy ZCBib3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5 MTI4CisKKyAgICAgICAgKiBmYXN0L2NhbnZhcy93ZWJnbC90ZXh0dXJlLW5wb3QtZXhwZWN0ZWQu dHh0OiBTa2lwIHBpeGVsICgwLCAwKTsgcHJpbnQgb3V0IGFjdHVhbCBjb2xvciB3aGVuIGZhaWxp bmcuCisgICAgICAgICogZmFzdC9jYW52YXMvd2ViZ2wvdGV4dHVyZS1ucG90Lmh0bWw6IERpdHRv LgorCiAyMDEwLTA1LTE0ICBaaGVueWFvIE1vICA8em1vQGdvb2dsZS5jb20+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93 ZWJnbC90ZXh0dXJlLW5wb3QtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3Rz L2Zhc3QvY2FudmFzL3dlYmdsL3RleHR1cmUtbnBvdC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDU5 NDgxKQorKysgTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvdGV4dHVyZS1ucG90LWV4cGVj dGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMyw2ICszLDkgQEAgV2ViR0wgTlBPVCB0ZXh0dXJl IGNvbmZvcm1hbmNlIHRlc3QKIFBBU1MgZ2wudGV4SW1hZ2UyRCB3aXRoIE5QT1QgdGV4dHVyZSB3 aXRoIGxldmVsID4gMCBzaG91bGQgcmV0dXJuIElOVkFMSURfVkFMVUUKIFBBU1MgZ2wudGV4SW1h Z2UyRCB3aXRoIE5QT1QgdGV4dHVyZSBhdCBsZXZlbCAwIHNob3VsZCBzdWNjZWVkCiBQQVNTIGds LmdlbmVyYXRlTWlwbWFwIHdpdGggTlBPVCB0ZXh0dXJlIHNob3VsZCByZXR1cm4gSU5WQUxJRF9P UEVSQVRJT04KK1BBU1MgTlBPVCB0ZXh0dXJlIHdpdGggVEVYVFVSRV9XUkFQIHNldCB0byBSRVBF QVQgc2hvdWxkIGRyYXcgd2l0aCAwLDAsMCwyNTUKK1BBU1MgTlBPVCB0ZXh0dXJlIHdpdGggVEVY VFVSRV9NSU5fRklMVEVSIG5vdCBORUFSRVNUIG9yIExJTkVBUiBzaG91bGQgZHJhdyB3aXRoIDAs MCwwLDI1NQorUEFTUyBOUE9UIHRleHR1cmUgd2l0aCBURVhUVVJFX01JTl9GSUxURVIgc2V0IHRv IExJTkVBUiBzaG91bGQgZHJhdyB3aXRoIDAsMTkyLDEyOCwyNTUKIFBBU1Mgc3VjY2Vzc2Z1bGx5 UGFyc2VkIGlzIHRydWUKIAogVEVTVCBDT01QTEVURQpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9j YW52YXMvd2ViZ2wvdGV4dHVyZS1ucG90Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv ZmFzdC9jYW52YXMvd2ViZ2wvdGV4dHVyZS1ucG90Lmh0bWwJKHJldmlzaW9uIDU5NDgxKQorKysg TGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvdGV4dHVyZS1ucG90Lmh0bWwJKHdvcmtpbmcg Y29weSkKQEAgLTEwMSwyNiArMTAxLDIzIEBACiAgICAgICAgICAgICB2YXIgbG9jID0gZ2wuZ2V0 VW5pZm9ybUxvY2F0aW9uKGdsLnByb2dyYW0sICJ0ZXgiKTsNCiAgICAgICAgICAgICBnbC51bmlm b3JtMWkobG9jLCAwKTsNCiANCi0gICAgICAgICAgICAvLyBGSVhNRTogdW5jb21tZW50IHRoZSB0 aHJlZSBjaGVjaEJ1ZmZlciBjYWxscyBvbmNlIHdlIGZpZ3VyZSBvdXQgd2h5IHRoZXkgZmFpbCBv biB0aGUgTGVvcGFyZCBib3QuDQotICAgICAgICAgICAgLy8gaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTM5MTI4DQotDQogICAgICAgICAgICAgLy8gQ2hlY2sgdGhhdCBu b3RoaW5nIGlzIGRyYXduIGlmIGZpbHRlcmluZyBpcyBub3QgY29ycmVjdCBmb3IgTlBPVA0KICAg ICAgICAgICAgIGdsLnRleFBhcmFtZXRlcmkoZ2wuVEVYVFVSRV8yRCwgZ2wuVEVYVFVSRV9NSU5f RklMVEVSLCBnbC5ORUFSRVNUKTsNCiAgICAgICAgICAgICBnbC50ZXhQYXJhbWV0ZXJpKGdsLlRF WFRVUkVfMkQsIGdsLlRFWFRVUkVfTUFHX0ZJTFRFUiwgZ2wuTkVBUkVTVCk7DQogICAgICAgICAg ICAgZ2wudGV4UGFyYW1ldGVyaShnbC5URVhUVVJFXzJELCBnbC5URVhUVVJFX1dSQVBfUywgZ2wu UkVQRUFUKTsNCiAgICAgICAgICAgICBnbC50ZXhQYXJhbWV0ZXJpKGdsLlRFWFRVUkVfMkQsIGds LlRFWFRVUkVfV1JBUF9ULCBnbC5SRVBFQVQpOw0KIA0KLSAgICAgICAgICAgIC8vIGNoZWNrQnVm ZmVyKDAsMCwwLDI1NSwgIk5QT1QgdGV4dHVyZSB3aXRoIFRFWFRVUkVfV1JBUCBzZXQgdG8gUkVQ RUFUIHNob3VsZCBkcmF3IHdpdGggMCwwLDAsMjU1Iik7DQorICAgICAgICAgICAgY2hlY2tCdWZm ZXIoMCwwLDAsMjU1LCAiTlBPVCB0ZXh0dXJlIHdpdGggVEVYVFVSRV9XUkFQIHNldCB0byBSRVBF QVQgc2hvdWxkIGRyYXcgd2l0aCAwLDAsMCwyNTUiKTsNCiANCiAgICAgICAgICAgICBnbC50ZXhQ YXJhbWV0ZXJpKGdsLlRFWFRVUkVfMkQsIGdsLlRFWFRVUkVfV1JBUF9TLCBnbC5DTEFNUF9UT19F REdFKTsNCiAgICAgICAgICAgICBnbC50ZXhQYXJhbWV0ZXJpKGdsLlRFWFRVUkVfMkQsIGdsLlRF WFRVUkVfV1JBUF9ULCBnbC5DTEFNUF9UT19FREdFKTsNCiAgICAgICAgICAgICBnbC50ZXhQYXJh bWV0ZXJpKGdsLlRFWFRVUkVfMkQsIGdsLlRFWFRVUkVfTUlOX0ZJTFRFUiwgZ2wuTkVBUkVTVF9N SVBNQVBfTElORUFSKTsNCiANCi0gICAgICAgICAgICAvLyBjaGVja0J1ZmZlcigwLDAsMCwyNTUs ICJOUE9UIHRleHR1cmUgd2l0aCBURVhUVVJFX01JTl9GSUxURVIgbm90IE5FQVJFU1Qgb3IgTElO RUFSIHNob3VsZCBkcmF3IHdpdGggMCwwLDAsMjU1Iik7DQorICAgICAgICAgICAgY2hlY2tCdWZm ZXIoMCwwLDAsMjU1LCAiTlBPVCB0ZXh0dXJlIHdpdGggVEVYVFVSRV9NSU5fRklMVEVSIG5vdCBO RUFSRVNUIG9yIExJTkVBUiBzaG91bGQgZHJhdyB3aXRoIDAsMCwwLDI1NSIpOw0KIA0KICAgICAg ICAgICAgIGdsLnRleFBhcmFtZXRlcmkoZ2wuVEVYVFVSRV8yRCwgZ2wuVEVYVFVSRV9NSU5fRklM VEVSLCBnbC5MSU5FQVIpOw0KIA0KLSAgICAgICAgICAgIC8vIGNoZWNrQnVmZmVyKDAsMTkyLDEy OCwyNTUsICJOUE9UIHRleHR1cmUgd2l0aCBURVhUVVJFX01JTl9GSUxURVIgc2V0IHRvIExJTkVB UiBzaG91bGQgZHJhdy4iKTsNCisgICAgICAgICAgICBjaGVja0J1ZmZlcigwLDE5MiwxMjgsMjU1 LCAiTlBPVCB0ZXh0dXJlIHdpdGggVEVYVFVSRV9NSU5fRklMVEVSIHNldCB0byBMSU5FQVIgc2hv dWxkIGRyYXcgd2l0aCAwLDE5MiwxMjgsMjU1Iik7DQogDQogICAgICAgICAgICAgZnVuY3Rpb24g Y2hlY2tCdWZmZXIociwgZywgYiwgYSwgbXNnKSB7DQogICAgICAgICAgICAgICBnbC5jbGVhckNv bG9yKDEsMSwxLDEpOw0KQEAgLTEyOSwxMiArMTI2LDE2IEBACiAgICAgICAgICAgICAgIGdsLmZs dXNoKCk7DQogICAgICAgICAgICAgICB2YXIgYnVmID0gZ2wucmVhZFBpeGVscygwLCAwLCA0LCA0 LCBnbC5SR0JBLCBnbC5VTlNJR05FRF9CWVRFKTsNCiAgICAgICAgICAgICAgIGZvciAodmFyIGkg PSAwOyBpIDwgNCAqIDQ7ICsraSkgew0KKyAgICAgICAgICAgICAgICAvLyBXZSBza2lwIHRoZSAo MCwgMCkgcGl4ZWwgZHVlIHRvIGEgcG9zc2libGUgYnVnIG9uIHRoZSBMZW9wYXJkIGJvdC4NCisg ICAgICAgICAgICAgICAgaWYgKGkgPT0gMCkNCisgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVl Ow0KICAgICAgICAgICAgICAgICB2YXIgb2Zmc2V0ID0gaSAqIDQ7DQogICAgICAgICAgICAgICAg IGlmIChidWZbb2Zmc2V0ICsgMF0gIT0gciB8fA0KICAgICAgICAgICAgICAgICAgICAgYnVmW29m ZnNldCArIDFdICE9IGcgfHwNCiAgICAgICAgICAgICAgICAgICAgIGJ1ZltvZmZzZXQgKyAyXSAh PSBiIHx8DQogICAgICAgICAgICAgICAgICAgICBidWZbb2Zmc2V0ICsgM10gIT0gYSkgew0KLSAg ICAgICAgICAgICAgICAgIHRlc3RGYWlsZWQobXNnKTsNCisgICAgICAgICAgICAgICAgICB0ZXN0 RmFpbGVkKG1zZyArICcsIHJlYWQgYmFjayBjb2xvciBpcyAnICsgYnVmW29mZnNldCArIDBdICsg JywnICsgYnVmW29mZnNldCArIDFdDQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICArICcs JyArIGJ1ZltvZmZzZXQgKyAyXSArICcsJyArICBidWZbb2Zmc2V0ICsgM10pOw0KICAgICAgICAg ICAgICAgICAgIHJldHVybjsNCiAgICAgICAgICAgICAgICAgfQ0KICAgICAgICAgICAgICAgfQ0K 56279 2010-05-17 15:46:12 -0700 2010-05-19 03:59:52 -0700 revised patch: add a link to the bug in test comments. npot.patch text/plain 4571 zmo SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDU5NDgxKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDUtMTQgIFpoZW55YW8gTW8gIDx6bW9A Z29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBmYXN0L2NhbnZhcy93ZWJnbC90ZXh0dXJlLW5wb3QuaHRtbCBmYWlsZWQgb24gbGVvcGFy ZCBib3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5 MTI4CisKKyAgICAgICAgKiBmYXN0L2NhbnZhcy93ZWJnbC90ZXh0dXJlLW5wb3QtZXhwZWN0ZWQu dHh0OiBTa2lwIHBpeGVsICgwLCAwKTsgcHJpbnQgb3V0IGFjdHVhbCBjb2xvciB3aGVuIGZhaWxp bmcuCisgICAgICAgICogZmFzdC9jYW52YXMvd2ViZ2wvdGV4dHVyZS1ucG90Lmh0bWw6IERpdHRv LgorCiAyMDEwLTA1LTE0ICBaaGVueWFvIE1vICA8em1vQGdvb2dsZS5jb20+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93 ZWJnbC90ZXh0dXJlLW5wb3QtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3Rz L2Zhc3QvY2FudmFzL3dlYmdsL3RleHR1cmUtbnBvdC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDU5 NDgxKQorKysgTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvdGV4dHVyZS1ucG90LWV4cGVj dGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMyw2ICszLDkgQEAgV2ViR0wgTlBPVCB0ZXh0dXJl IGNvbmZvcm1hbmNlIHRlc3QKIFBBU1MgZ2wudGV4SW1hZ2UyRCB3aXRoIE5QT1QgdGV4dHVyZSB3 aXRoIGxldmVsID4gMCBzaG91bGQgcmV0dXJuIElOVkFMSURfVkFMVUUKIFBBU1MgZ2wudGV4SW1h Z2UyRCB3aXRoIE5QT1QgdGV4dHVyZSBhdCBsZXZlbCAwIHNob3VsZCBzdWNjZWVkCiBQQVNTIGds LmdlbmVyYXRlTWlwbWFwIHdpdGggTlBPVCB0ZXh0dXJlIHNob3VsZCByZXR1cm4gSU5WQUxJRF9P UEVSQVRJT04KK1BBU1MgTlBPVCB0ZXh0dXJlIHdpdGggVEVYVFVSRV9XUkFQIHNldCB0byBSRVBF QVQgc2hvdWxkIGRyYXcgd2l0aCAwLDAsMCwyNTUKK1BBU1MgTlBPVCB0ZXh0dXJlIHdpdGggVEVY VFVSRV9NSU5fRklMVEVSIG5vdCBORUFSRVNUIG9yIExJTkVBUiBzaG91bGQgZHJhdyB3aXRoIDAs MCwwLDI1NQorUEFTUyBOUE9UIHRleHR1cmUgd2l0aCBURVhUVVJFX01JTl9GSUxURVIgc2V0IHRv IExJTkVBUiBzaG91bGQgZHJhdyB3aXRoIDAsMTkyLDEyOCwyNTUKIFBBU1Mgc3VjY2Vzc2Z1bGx5 UGFyc2VkIGlzIHRydWUKIAogVEVTVCBDT01QTEVURQpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9j YW52YXMvd2ViZ2wvdGV4dHVyZS1ucG90Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv ZmFzdC9jYW52YXMvd2ViZ2wvdGV4dHVyZS1ucG90Lmh0bWwJKHJldmlzaW9uIDU5NDgxKQorKysg TGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvdGV4dHVyZS1ucG90Lmh0bWwJKHdvcmtpbmcg Y29weSkKQEAgLTEwMSwyNiArMTAxLDIzIEBACiAgICAgICAgICAgICB2YXIgbG9jID0gZ2wuZ2V0 VW5pZm9ybUxvY2F0aW9uKGdsLnByb2dyYW0sICJ0ZXgiKTsNCiAgICAgICAgICAgICBnbC51bmlm b3JtMWkobG9jLCAwKTsNCiANCi0gICAgICAgICAgICAvLyBGSVhNRTogdW5jb21tZW50IHRoZSB0 aHJlZSBjaGVjaEJ1ZmZlciBjYWxscyBvbmNlIHdlIGZpZ3VyZSBvdXQgd2h5IHRoZXkgZmFpbCBv biB0aGUgTGVvcGFyZCBib3QuDQotICAgICAgICAgICAgLy8gaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTM5MTI4DQotDQogICAgICAgICAgICAgLy8gQ2hlY2sgdGhhdCBu b3RoaW5nIGlzIGRyYXduIGlmIGZpbHRlcmluZyBpcyBub3QgY29ycmVjdCBmb3IgTlBPVA0KICAg ICAgICAgICAgIGdsLnRleFBhcmFtZXRlcmkoZ2wuVEVYVFVSRV8yRCwgZ2wuVEVYVFVSRV9NSU5f RklMVEVSLCBnbC5ORUFSRVNUKTsNCiAgICAgICAgICAgICBnbC50ZXhQYXJhbWV0ZXJpKGdsLlRF WFRVUkVfMkQsIGdsLlRFWFRVUkVfTUFHX0ZJTFRFUiwgZ2wuTkVBUkVTVCk7DQogICAgICAgICAg ICAgZ2wudGV4UGFyYW1ldGVyaShnbC5URVhUVVJFXzJELCBnbC5URVhUVVJFX1dSQVBfUywgZ2wu UkVQRUFUKTsNCiAgICAgICAgICAgICBnbC50ZXhQYXJhbWV0ZXJpKGdsLlRFWFRVUkVfMkQsIGds LlRFWFRVUkVfV1JBUF9ULCBnbC5SRVBFQVQpOw0KIA0KLSAgICAgICAgICAgIC8vIGNoZWNrQnVm ZmVyKDAsMCwwLDI1NSwgIk5QT1QgdGV4dHVyZSB3aXRoIFRFWFRVUkVfV1JBUCBzZXQgdG8gUkVQ RUFUIHNob3VsZCBkcmF3IHdpdGggMCwwLDAsMjU1Iik7DQorICAgICAgICAgICAgY2hlY2tCdWZm ZXIoMCwwLDAsMjU1LCAiTlBPVCB0ZXh0dXJlIHdpdGggVEVYVFVSRV9XUkFQIHNldCB0byBSRVBF QVQgc2hvdWxkIGRyYXcgd2l0aCAwLDAsMCwyNTUiKTsNCiANCiAgICAgICAgICAgICBnbC50ZXhQ YXJhbWV0ZXJpKGdsLlRFWFRVUkVfMkQsIGdsLlRFWFRVUkVfV1JBUF9TLCBnbC5DTEFNUF9UT19F REdFKTsNCiAgICAgICAgICAgICBnbC50ZXhQYXJhbWV0ZXJpKGdsLlRFWFRVUkVfMkQsIGdsLlRF WFRVUkVfV1JBUF9ULCBnbC5DTEFNUF9UT19FREdFKTsNCiAgICAgICAgICAgICBnbC50ZXhQYXJh bWV0ZXJpKGdsLlRFWFRVUkVfMkQsIGdsLlRFWFRVUkVfTUlOX0ZJTFRFUiwgZ2wuTkVBUkVTVF9N SVBNQVBfTElORUFSKTsNCiANCi0gICAgICAgICAgICAvLyBjaGVja0J1ZmZlcigwLDAsMCwyNTUs ICJOUE9UIHRleHR1cmUgd2l0aCBURVhUVVJFX01JTl9GSUxURVIgbm90IE5FQVJFU1Qgb3IgTElO RUFSIHNob3VsZCBkcmF3IHdpdGggMCwwLDAsMjU1Iik7DQorICAgICAgICAgICAgY2hlY2tCdWZm ZXIoMCwwLDAsMjU1LCAiTlBPVCB0ZXh0dXJlIHdpdGggVEVYVFVSRV9NSU5fRklMVEVSIG5vdCBO RUFSRVNUIG9yIExJTkVBUiBzaG91bGQgZHJhdyB3aXRoIDAsMCwwLDI1NSIpOw0KIA0KICAgICAg ICAgICAgIGdsLnRleFBhcmFtZXRlcmkoZ2wuVEVYVFVSRV8yRCwgZ2wuVEVYVFVSRV9NSU5fRklM VEVSLCBnbC5MSU5FQVIpOw0KIA0KLSAgICAgICAgICAgIC8vIGNoZWNrQnVmZmVyKDAsMTkyLDEy OCwyNTUsICJOUE9UIHRleHR1cmUgd2l0aCBURVhUVVJFX01JTl9GSUxURVIgc2V0IHRvIExJTkVB UiBzaG91bGQgZHJhdy4iKTsNCisgICAgICAgICAgICBjaGVja0J1ZmZlcigwLDE5MiwxMjgsMjU1 LCAiTlBPVCB0ZXh0dXJlIHdpdGggVEVYVFVSRV9NSU5fRklMVEVSIHNldCB0byBMSU5FQVIgc2hv dWxkIGRyYXcgd2l0aCAwLDE5MiwxMjgsMjU1Iik7DQogDQogICAgICAgICAgICAgZnVuY3Rpb24g Y2hlY2tCdWZmZXIociwgZywgYiwgYSwgbXNnKSB7DQogICAgICAgICAgICAgICBnbC5jbGVhckNv bG9yKDEsMSwxLDEpOw0KQEAgLTEyOSwxMiArMTI2LDE3IEBACiAgICAgICAgICAgICAgIGdsLmZs dXNoKCk7DQogICAgICAgICAgICAgICB2YXIgYnVmID0gZ2wucmVhZFBpeGVscygwLCAwLCA0LCA0 LCBnbC5SR0JBLCBnbC5VTlNJR05FRF9CWVRFKTsNCiAgICAgICAgICAgICAgIGZvciAodmFyIGkg PSAwOyBpIDwgNCAqIDQ7ICsraSkgew0KKyAgICAgICAgICAgICAgICAvLyBXZSBza2lwIHRoZSAo MCwgMCkgcGl4ZWwgZHVlIHRvIGEgcG9zc2libGUgYnVnIG9uIHRoZSBMZW9wYXJkIGJvdC4NCisg ICAgICAgICAgICAgICAgLy8gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTM5MTI4Lg0KKyAgICAgICAgICAgICAgICBpZiAoaSA9PSAwKQ0KKyAgICAgICAgICAgICAgICAg ICAgY29udGludWU7DQogICAgICAgICAgICAgICAgIHZhciBvZmZzZXQgPSBpICogNDsNCiAgICAg ICAgICAgICAgICAgaWYgKGJ1ZltvZmZzZXQgKyAwXSAhPSByIHx8DQogICAgICAgICAgICAgICAg ICAgICBidWZbb2Zmc2V0ICsgMV0gIT0gZyB8fA0KICAgICAgICAgICAgICAgICAgICAgYnVmW29m ZnNldCArIDJdICE9IGIgfHwNCiAgICAgICAgICAgICAgICAgICAgIGJ1ZltvZmZzZXQgKyAzXSAh PSBhKSB7DQotICAgICAgICAgICAgICAgICAgdGVzdEZhaWxlZChtc2cpOw0KKyAgICAgICAgICAg ICAgICAgIHRlc3RGYWlsZWQobXNnICsgJywgcmVhZCBiYWNrIGNvbG9yIGlzICcgKyBidWZbb2Zm c2V0ICsgMF0gKyAnLCcgKyBidWZbb2Zmc2V0ICsgMV0NCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICsgJywnICsgYnVmW29mZnNldCArIDJdICsgJywnICsgIGJ1ZltvZmZzZXQgKyAzXSk7 DQogICAgICAgICAgICAgICAgICAgcmV0dXJuOw0KICAgICAgICAgICAgICAgICB9DQogICAgICAg ICAgICAgICB9DQo= 56504 2010-05-19 11:37:11 -0700 2010-05-20 19:34:52 -0700 patch npot.patch text/plain 4130 zmo SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDU5Nzc3KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDUtMTkgIFpoZW55YW8gTW8gIDx6bW9A Z29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBmYXN0L2NhbnZhcy93ZWJnbC90ZXh0dXJlLW5wb3QuaHRtbCBmYWlsZWQgb24gbGVvcGFy ZCBib3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5 MTI4CisKKyAgICAgICAgKiBmYXN0L2NhbnZhcy93ZWJnbC90ZXh0dXJlLW5wb3QtZXhwZWN0ZWQu dHh0OiBBZGRpbmcgdGhlIGZhaWxlZCB0ZXN0IGNhc2VzIGJhY2suCisgICAgICAgICogZmFzdC9j YW52YXMvd2ViZ2wvdGV4dHVyZS1ucG90Lmh0bWw6CisgICAgICAgICogcGxhdGZvcm0vbWFjLWxl b3BhcmQvU2tpcHBlZDogU2tpcCB0ZXh0dXJlLW5wb3QuaHRtbCBvbiBsZW9wYXJkIGZvciBub3cu CisKIDIwMTAtMDUtMTkgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgog CiAgICAgICAgIE5vdCByZXZpZXdlZC4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvY2FudmFzL3dl YmdsL3RleHR1cmUtbnBvdC1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv ZmFzdC9jYW52YXMvd2ViZ2wvdGV4dHVyZS1ucG90LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gNTk3 NzYpCisrKyBMYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC90ZXh0dXJlLW5wb3QtZXhwZWN0 ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0zLDYgKzMsOSBAQCBXZWJHTCBOUE9UIHRleHR1cmUg Y29uZm9ybWFuY2UgdGVzdAogUEFTUyBnbC50ZXhJbWFnZTJEIHdpdGggTlBPVCB0ZXh0dXJlIHdp dGggbGV2ZWwgPiAwIHNob3VsZCByZXR1cm4gSU5WQUxJRF9WQUxVRQogUEFTUyBnbC50ZXhJbWFn ZTJEIHdpdGggTlBPVCB0ZXh0dXJlIGF0IGxldmVsIDAgc2hvdWxkIHN1Y2NlZWQKIFBBU1MgZ2wu Z2VuZXJhdGVNaXBtYXAgd2l0aCBOUE9UIHRleHR1cmUgc2hvdWxkIHJldHVybiBJTlZBTElEX09Q RVJBVElPTgorUEFTUyBOUE9UIHRleHR1cmUgd2l0aCBURVhUVVJFX1dSQVAgc2V0IHRvIFJFUEVB VCBzaG91bGQgZHJhdyB3aXRoIDAsMCwwLDI1NQorUEFTUyBOUE9UIHRleHR1cmUgd2l0aCBURVhU VVJFX01JTl9GSUxURVIgbm90IE5FQVJFU1Qgb3IgTElORUFSIHNob3VsZCBkcmF3IHdpdGggMCww LDAsMjU1CitQQVNTIE5QT1QgdGV4dHVyZSB3aXRoIFRFWFRVUkVfTUlOX0ZJTFRFUiBzZXQgdG8g TElORUFSIHNob3VsZCBkcmF3IHdpdGggMCwxOTIsMTI4LDI1NQogUEFTUyBzdWNjZXNzZnVsbHlQ YXJzZWQgaXMgdHJ1ZQogCiBURVNUIENPTVBMRVRFCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Nh bnZhcy93ZWJnbC90ZXh0dXJlLW5wb3QuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9m YXN0L2NhbnZhcy93ZWJnbC90ZXh0dXJlLW5wb3QuaHRtbAkocmV2aXNpb24gNTk3NzYpCisrKyBM YXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC90ZXh0dXJlLW5wb3QuaHRtbAkod29ya2luZyBj b3B5KQpAQCAtMTEwLDE3ICsxMTAsMTcgQEAKICAgICAgICAgICAgIGdsLnRleFBhcmFtZXRlcmko Z2wuVEVYVFVSRV8yRCwgZ2wuVEVYVFVSRV9XUkFQX1MsIGdsLlJFUEVBVCk7DQogICAgICAgICAg ICAgZ2wudGV4UGFyYW1ldGVyaShnbC5URVhUVVJFXzJELCBnbC5URVhUVVJFX1dSQVBfVCwgZ2wu UkVQRUFUKTsNCiANCi0gICAgICAgICAgICAvLyBjaGVja0J1ZmZlcigwLDAsMCwyNTUsICJOUE9U IHRleHR1cmUgd2l0aCBURVhUVVJFX1dSQVAgc2V0IHRvIFJFUEVBVCBzaG91bGQgZHJhdyB3aXRo IDAsMCwwLDI1NSIpOw0KKyAgICAgICAgICAgIGNoZWNrQnVmZmVyKDAsMCwwLDI1NSwgIk5QT1Qg dGV4dHVyZSB3aXRoIFRFWFRVUkVfV1JBUCBzZXQgdG8gUkVQRUFUIHNob3VsZCBkcmF3IHdpdGgg MCwwLDAsMjU1Iik7DQogDQogICAgICAgICAgICAgZ2wudGV4UGFyYW1ldGVyaShnbC5URVhUVVJF XzJELCBnbC5URVhUVVJFX1dSQVBfUywgZ2wuQ0xBTVBfVE9fRURHRSk7DQogICAgICAgICAgICAg Z2wudGV4UGFyYW1ldGVyaShnbC5URVhUVVJFXzJELCBnbC5URVhUVVJFX1dSQVBfVCwgZ2wuQ0xB TVBfVE9fRURHRSk7DQogICAgICAgICAgICAgZ2wudGV4UGFyYW1ldGVyaShnbC5URVhUVVJFXzJE LCBnbC5URVhUVVJFX01JTl9GSUxURVIsIGdsLk5FQVJFU1RfTUlQTUFQX0xJTkVBUik7DQogDQot ICAgICAgICAgICAgLy8gY2hlY2tCdWZmZXIoMCwwLDAsMjU1LCAiTlBPVCB0ZXh0dXJlIHdpdGgg VEVYVFVSRV9NSU5fRklMVEVSIG5vdCBORUFSRVNUIG9yIExJTkVBUiBzaG91bGQgZHJhdyB3aXRo IDAsMCwwLDI1NSIpOw0KKyAgICAgICAgICAgIGNoZWNrQnVmZmVyKDAsMCwwLDI1NSwgIk5QT1Qg dGV4dHVyZSB3aXRoIFRFWFRVUkVfTUlOX0ZJTFRFUiBub3QgTkVBUkVTVCBvciBMSU5FQVIgc2hv dWxkIGRyYXcgd2l0aCAwLDAsMCwyNTUiKTsNCiANCiAgICAgICAgICAgICBnbC50ZXhQYXJhbWV0 ZXJpKGdsLlRFWFRVUkVfMkQsIGdsLlRFWFRVUkVfTUlOX0ZJTFRFUiwgZ2wuTElORUFSKTsNCiAN Ci0gICAgICAgICAgICAvLyBjaGVja0J1ZmZlcigwLDE5MiwxMjgsMjU1LCAiTlBPVCB0ZXh0dXJl IHdpdGggVEVYVFVSRV9NSU5fRklMVEVSIHNldCB0byBMSU5FQVIgc2hvdWxkIGRyYXcuIik7DQor ICAgICAgICAgICAgY2hlY2tCdWZmZXIoMCwxOTIsMTI4LDI1NSwgIk5QT1QgdGV4dHVyZSB3aXRo IFRFWFRVUkVfTUlOX0ZJTFRFUiBzZXQgdG8gTElORUFSIHNob3VsZCBkcmF3IHdpdGggMCwxOTIs MTI4LDI1NSIpOw0KIA0KICAgICAgICAgICAgIGZ1bmN0aW9uIGNoZWNrQnVmZmVyKHIsIGcsIGIs IGEsIG1zZykgew0KICAgICAgICAgICAgICAgZ2wuY2xlYXJDb2xvcigxLDEsMSwxKTsNCkBAIC0x MzQsNyArMTM0LDggQEAKICAgICAgICAgICAgICAgICAgICAgYnVmW29mZnNldCArIDFdICE9IGcg fHwNCiAgICAgICAgICAgICAgICAgICAgIGJ1ZltvZmZzZXQgKyAyXSAhPSBiIHx8DQogICAgICAg ICAgICAgICAgICAgICBidWZbb2Zmc2V0ICsgM10gIT0gYSkgew0KLSAgICAgICAgICAgICAgICAg IHRlc3RGYWlsZWQobXNnKTsNCisgICAgICAgICAgICAgICAgICB0ZXN0RmFpbGVkKG1zZyArICcs IHJlYWQgYmFjayBjb2xvciBpcyAnICsgYnVmW29mZnNldCArIDBdICsgJywnICsgYnVmW29mZnNl dCArIDFdDQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICArICcsJyArIGJ1ZltvZmZzZXQg KyAyXSArICcsJyArIGJ1ZltvZmZzZXQgKyAzXSk7DQogICAgICAgICAgICAgICAgICAgcmV0dXJu Ow0KICAgICAgICAgICAgICAgICB9DQogICAgICAgICAgICAgICB9DQpJbmRleDogTGF5b3V0VGVz dHMvcGxhdGZvcm0vbWFjLWxlb3BhcmQvU2tpcHBlZAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9wbGF0Zm9ybS9tYWMtbGVvcGFyZC9Ta2lwcGVkCShyZXZpc2lvbiA1OTc3NikKKysrIExheW91 dFRlc3RzL3BsYXRmb3JtL21hYy1sZW9wYXJkL1NraXBwZWQJKHdvcmtpbmcgY29weSkKQEAgLTcw LDMgKzcwLDcgQEAgaHR0cC90ZXN0cy9tZWRpYS92aWRlby1wbGF5LXN0YWxsLXNlZWsuaAogCiAj IEluZGV4ZWREQiBpcyBub3QgeWV0IGVuYWJsZWQuCiBzdG9yYWdlL2luZGV4ZWRkYgorCisjIERp c2FibGUgdGhlIHRlc3QgdW50aWwgdGhlIG1lc2EgcmVuZGVyZXIgaXMgaW50ZWdyYXRlZC4KKyMg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5MTI4CitmYXN0L2NhbnZh cy93ZWJnbC90ZXh0dXJlLW5wb3QuaHRtbAo=