39126 2010-05-14 11:26:13 -0700 Update notifications test results 2010-05-15 05:00:08 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 yael webkit-unassigned abarth commit-queue eric webkit.review.bot oldest_to_newest 225917 0 yael 2010-05-14 11:26:13 -0700 Some of the notifications test results have extra or missing line endings. new-run-webkit-tests does not check for line endings and since these test run only in test-shell in Chromium, this has not been a problem until now. Please see https://bugs.webkit.org/show_bug.cgi?id=36983 for more info. 225922 1 56089 yael 2010-05-14 11:34:46 -0700 Created attachment 56089 Patch. 226203 2 56089 commit-queue 2010-05-15 02:33:14 -0700 Comment on attachment 56089 Patch. Clearing flags on attachment: 56089 Committed r59530: <http://trac.webkit.org/changeset/59530> 226204 3 commit-queue 2010-05-15 02:33:19 -0700 All reviewed patches have been landed. Closing bug. 226219 4 webkit.review.bot 2010-05-15 04:09:17 -0700 http://trac.webkit.org/changeset/59530 might have broken GTK Linux 32-bit Release The following changes are on the blame list: http://trac.webkit.org/changeset/59530 http://trac.webkit.org/changeset/59531 http://trac.webkit.org/changeset/59532 http://trac.webkit.org/changeset/59533 226227 5 yael 2010-05-15 05:00:08 -0700 (In reply to comment #4) > http://trac.webkit.org/changeset/59530 might have broken GTK Linux 32-bit Release > The following changes are on the blame list: > http://trac.webkit.org/changeset/59530 > http://trac.webkit.org/changeset/59531 > http://trac.webkit.org/changeset/59532 > http://trac.webkit.org/changeset/59533 This patch added missing line endings to notifications tests, which are skipped on GTK, I doubt it is the cause of the accessibility test failure. 56089 2010-05-14 11:34:46 -0700 2010-05-15 02:33:14 -0700 Patch. 39126.patch text/plain 2148 yael SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDU5NDc3KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDUtMTQgIFlhZWwgQWhhcm9uICA8eWFl bC5haGFyb25Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFVwZGF0ZSBub3RpZmljYXRpb25zIHRlc3QgcmVzdWx0cworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzkxMjYKKyAgICAgICAgQWRk IG1pc3NpbmcgbGluZSBlbmRpbmdzLgorCisgICAgICAgICogZmFzdC9ub3RpZmljYXRpb25zL25v dGlmaWNhdGlvbnMtcmVwbGFjZS1leHBlY3RlZC50eHQ6CisgICAgICAgICogZmFzdC9ub3RpZmlj YXRpb25zL25vdGlmaWNhdGlvbnMtcmVxdWVzdC1wZXJtaXNzaW9uLWV4cGVjdGVkLnR4dDoKKyAg ICAgICAgKiBmYXN0L25vdGlmaWNhdGlvbnMvbm90aWZpY2F0aW9ucy1ydGwtZXhwZWN0ZWQudHh0 OgorCiAyMDEwLTA1LTE0ICBKZXJlbXkgT3Jsb3cgIDxqb3Jsb3dAY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KSW5kZXg6IExheW91dFRlc3RzL2Zh c3Qvbm90aWZpY2F0aW9ucy9ub3RpZmljYXRpb25zLXJlcGxhY2UtZXhwZWN0ZWQudHh0Cj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3Qvbm90aWZpY2F0aW9ucy9ub3RpZmljYXRpb25zLXJl cGxhY2UtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiA1OTQ3NykKKysrIExheW91dFRlc3RzL2Zhc3Qv bm90aWZpY2F0aW9ucy9ub3RpZmljYXRpb25zLXJlcGxhY2UtZXhwZWN0ZWQudHh0CSh3b3JraW5n IGNvcHkpCkBAIC0zLDMgKzMsNSBAQCBERVNLVE9QIE5PVElGSUNBVElPTjogaWNvbiBmaWxlOi8v L2FsYXJtCiBSRVBMQUNJTkcgTk9USUZJQ0FUSU9OIE5ldyBFLW1haWwKIERFU0tUT1AgTk9USUZJ Q0FUSU9OOiBpY29uIGZpbGU6Ly8vZW1haWwucG5nLCB0aXRsZSBOZXcgcmVwbHksIHRleHQgQ29y cmVjdGlvbiwgODoxNQogU2hvd2luZyBub3RpZmljYXRpb25zIHdpdGggcmVwbGFjZSBJRC4uLgor CisKSW5kZXg6IExheW91dFRlc3RzL2Zhc3Qvbm90aWZpY2F0aW9ucy9ub3RpZmljYXRpb25zLXJl cXVlc3QtcGVybWlzc2lvbi1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv ZmFzdC9ub3RpZmljYXRpb25zL25vdGlmaWNhdGlvbnMtcmVxdWVzdC1wZXJtaXNzaW9uLWV4cGVj dGVkLnR4dAkocmV2aXNpb24gNTk0NzcpCisrKyBMYXlvdXRUZXN0cy9mYXN0L25vdGlmaWNhdGlv bnMvbm90aWZpY2F0aW9ucy1yZXF1ZXN0LXBlcm1pc3Npb24tZXhwZWN0ZWQudHh0CSh3b3JraW5n IGNvcHkpCkBAIC0zLDQgKzMsMyBAQCBSZXF1ZXN0aW5nIG5vdGlmaWNhdGlvbiBwZXJtaXNzaW9u Li4uCiAKIFBBU1M6IFBlcm1pc3Npb24gY2FsbGJhY2sgaW52b2tlZC4KIAotCkluZGV4OiBMYXlv dXRUZXN0cy9mYXN0L25vdGlmaWNhdGlvbnMvbm90aWZpY2F0aW9ucy1ydGwtZXhwZWN0ZWQudHh0 Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3Qvbm90aWZpY2F0aW9ucy9ub3RpZmljYXRp b25zLXJ0bC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDU5NDc3KQorKysgTGF5b3V0VGVzdHMvZmFz dC9ub3RpZmljYXRpb25zL25vdGlmaWNhdGlvbnMtcnRsLWV4cGVjdGVkLnR4dAkod29ya2luZyBj b3B5KQpAQCAtMSwyICsxLDQgQEAKIERFU0tUT1AgTk9USUZJQ0FUSU9OOihSVEwpIGljb24gLCB0 aXRsZSBOZXcgRS1tYWlsLCB0ZXh0IE1lZXQgbWUgdG9uaWdodCBhdCA4IQogU2hvd2luZyBhIG5v dGlmaWNhdGlvbiB3aXRoIGRpcmVjdGlvbiAicnRsIi4uLgorCisK