39125 2010-05-14 11:21:44 -0700 XMLHttpRequest.getResponseHeader doesn't need to be custom 2010-05-15 18:44:15 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth webkit-unassigned ap commit-queue mjs sam oldest_to_newest 225914 0 abarth 2010-05-14 11:21:44 -0700 XMLHttpRequest.getResponseHeader doesn't need to be custom 225916 1 56087 abarth 2010-05-14 11:23:56 -0700 Created attachment 56087 Patch 225924 2 56087 abarth 2010-05-14 11:35:27 -0700 Comment on attachment 56087 Patch Thanks. 226072 3 ap 2010-05-14 17:14:45 -0700 + // FIXME: RequiresAllArguments is probably bogus here. I don't know what to do with this FIXME when I see it. On what grounds can the FIXME be removed, if it's not bogus? I think that a FIXME should contain a specific claim that can be addressed or rejected, but "bogus" is open ended. 226126 4 abarth 2010-05-14 21:19:37 -0700 We should make a project-wide decision about whether our bindings require all arguments by default. In making that decision, we should consider the specs, other browsers, and that vast majority of our bindings do not require all arguments. I added these comments to ensure that future developers don't think that I put the attribute there for a reason other than inertia. 226131 5 ap 2010-05-14 21:28:22 -0700 I'd say it's enough to mention that in ChangeLog - there is very little in JS bindings that's never supposed to be reconsidered. Generally, if not passing an argument makes no sense (like here), and we could get away with detecting that and reporting a useful error for all those years, then it's probably best to keep this developer-friendly behavior. 226133 6 abarth 2010-05-14 21:34:02 -0700 If that's the case, then we should enforce a minimum number of arguments on all the functions in the bindings. Having some enforce it and some not is a bunch of entropy for no reason. The last time I discussed this with mjs, my impression was that he favored not requiring all the arguments because that's how JavaScript works natively. Honestly, I don't much care. I just care that we're consistent. 226135 7 ap 2010-05-14 21:57:43 -0700 I don't really see this as an "all or none" case. We should be compatible above all, and helpful to developers when possible. 226136 8 abarth 2010-05-14 22:03:24 -0700 (In reply to comment #7) > I don't really see this as an "all or none" case. We should be compatible above all, and helpful to developers when possible. Is our current behavior a product of compatibility considerations or just whatever someone happened to copy/paste? In any case, it's something I'd like to worry about in the future, hence the FIXME. 226139 9 ap 2010-05-14 22:26:49 -0700 Firefox and IE behave differently, so compatibility isn't a product of consideration, but a product of testing and adjustment. We've had this behavior since 2006, so it's vetted pretty well. The arguments against detecting and reporting errors seem to be purely aesthetic, while the argument for detecting them is about making the platform easier to develop for. Calling getResponseHeader() without arguments makes no sense, and pretty much the only conceivable case when this could happen is a wrong copy/paste for getAllResponseHeaders(). Why make that harder to debug? 226140 10 abarth 2010-05-14 22:33:29 -0700 I feel like you're not listening to what I'm saying. Please re-read the above comments for the answer to your question. 226142 11 ap 2010-05-14 22:45:56 -0700 I re-read your comments, and don't see an answer. 226145 12 abarth 2010-05-14 22:55:36 -0700 (In reply to comment #9) > Why make that harder to debug? (In reply to comment #6) > Honestly, I don't much care. I just care that we're consistent. 226146 13 ap 2010-05-14 23:03:13 -0700 Oh, that's what I called "purely aesthetic" in the same paragraph you quoted. I don't see it as an important counter-argument, web developers' convenience trumps our convenience and our aesthetic feelings. 226147 14 abarth 2010-05-14 23:06:00 -0700 (In reply to comment #13) > Oh, that's what I called "purely aesthetic" in the same paragraph you quoted. I don't see it as an important counter-argument, web developers' convenience trumps our convenience and our aesthetic feelings. In that case, we should enforce minimum argument lengths everywhere that compatibility doesn't force our hand to do something else. 226148 15 abarth 2010-05-14 23:08:10 -0700 (In reply to comment #4) > We should make a project-wide decision about whether our bindings require all arguments by default. In making that decision, we should consider the specs, other browsers, and that vast majority of our bindings do not require all arguments. It seems your saying that we should add "developer convenience" to that list. In any case, we should make a project-wide decision for what our default stance should be, especially for new code that doesn't have any compat baggage. Currently, our practice is to randomly enforce minimum arguments depending on what code is used as a template. That's clearly lame. 226301 16 ap 2010-05-15 12:24:49 -0700 I agree that having a default stance would be good, but I'm not sure if it's achievable at this point. The arguments are all known, and it seems that we basically deferred this decision to WebIDL. 226340 17 56087 commit-queue 2010-05-15 15:42:13 -0700 Comment on attachment 56087 Patch Rejecting patch 56087 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Darin Adler', u'--force']" exit_code: 1 Last 500 characters of output: (s). patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/bindings/js/JSXMLHttpRequestCustom.cpp Hunk #1 FAILED at 133. 1 out of 1 hunk FAILED -- saving rejects to file WebCore/bindings/js/JSXMLHttpRequestCustom.cpp.rej patching file WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp Hunk #1 FAILED at 157. 1 out of 1 hunk FAILED -- saving rejects to file WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp.rej patching file WebCore/xml/XMLHttpRequest.idl Full output: http://webkit-commit-queue.appspot.com/results/2313120 226363 18 56165 abarth 2010-05-15 17:49:44 -0700 Created attachment 56165 Patch for landing 226378 19 56165 commit-queue 2010-05-15 18:44:09 -0700 Comment on attachment 56165 Patch for landing Clearing flags on attachment: 56165 Committed r59559: <http://trac.webkit.org/changeset/59559> 226379 20 commit-queue 2010-05-15 18:44:15 -0700 All reviewed patches have been landed. Closing bug. 56087 2010-05-14 11:23:56 -0700 2010-05-15 17:49:37 -0700 Patch bug-39125-20100514112355.patch text/plain 3582 abarth SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1OTQ3NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDUtMTQgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBYTUxI dHRwUmVxdWVzdC5nZXRSZXNwb25zZUhlYWRlciBkb2Vzbid0IG5lZWQgdG8gYmUgY3VzdG9tCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zOTEyNQorCisg ICAgICAgIEkgZG9uJ3Qgc2VlIGFueSByZWFzb24gdGhpcyBtZXRob2QgbmVlZHMgdG8gYmUgY3Vz dG9tLiAgTm8gbmV3IHRlc3RzCisgICAgICAgIGJlY2F1c2UgdGhlcmUncyBubyBiZWhhdmlvciBj aGFuZ2UuCisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU1hNTEh0dHBSZXF1ZXN0Q3VzdG9tLmNw cDoKKyAgICAgICAgKiBiaW5kaW5ncy92OC9jdXN0b20vVjhYTUxIdHRwUmVxdWVzdEN1c3RvbS5j cHA6CisgICAgICAgICogeG1sL1hNTEh0dHBSZXF1ZXN0LmlkbDoKKwogMjAxMC0wNS0xNCAgU2hp bmljaGlybyBIYW1hamkgIDxoYW1hamlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3 ZWQuICBBdHRlbXB0IHRvIGZpeCBjaHJvbWl1bSdzIG1lbW9yeSBib3QgZXJyb3IuCkluZGV4OiBX ZWJDb3JlL2JpbmRpbmdzL2pzL0pTWE1MSHR0cFJlcXVlc3RDdXN0b20uY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYkNvcmUvYmluZGluZ3MvanMvSlNYTUxIdHRwUmVxdWVzdEN1c3RvbS5jcHAJKHJldmlz aW9uIDU5MzgzKQorKysgV2ViQ29yZS9iaW5kaW5ncy9qcy9KU1hNTEh0dHBSZXF1ZXN0Q3VzdG9t LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTMzLDE3ICsxMzMsNiBAQCBKU1ZhbHVlIEpTWE1MSHR0 cFJlcXVlc3Q6OnNlbmQoRXhlY1N0YXRlCiAgICAgcmV0dXJuIGpzVW5kZWZpbmVkKCk7CiB9CiAK LUpTVmFsdWUgSlNYTUxIdHRwUmVxdWVzdDo6Z2V0UmVzcG9uc2VIZWFkZXIoRXhlY1N0YXRlKiBl eGVjLCBjb25zdCBBcmdMaXN0JiBhcmdzKQotewotICAgIGlmIChhcmdzLnNpemUoKSA8IDEpCi0g ICAgICAgIHJldHVybiB0aHJvd0Vycm9yKGV4ZWMsIFN5bnRheEVycm9yLCAiTm90IGVub3VnaCBh cmd1bWVudHMiKTsKLQotICAgIEV4Y2VwdGlvbkNvZGUgZWMgPSAwOwotICAgIEpTVmFsdWUgaGVh ZGVyID0ganNTdHJpbmdPck51bGwoZXhlYywgaW1wbCgpLT5nZXRSZXNwb25zZUhlYWRlcih1c3Ry aW5nVG9BdG9taWNTdHJpbmcoYXJncy5hdCgwKS50b1N0cmluZyhleGVjKSksIGVjKSk7Ci0gICAg c2V0RE9NRXhjZXB0aW9uKGV4ZWMsIGVjKTsKLSAgICByZXR1cm4gaGVhZGVyOwotfQotCiBKU1Zh bHVlIEpTWE1MSHR0cFJlcXVlc3Q6Om92ZXJyaWRlTWltZVR5cGUoRXhlY1N0YXRlKiBleGVjLCBj b25zdCBBcmdMaXN0JiBhcmdzKQogewogICAgIGlmIChhcmdzLnNpemUoKSA8IDEpCkluZGV4OiBX ZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOFhNTEh0dHBSZXF1ZXN0Q3VzdG9tLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOFhNTEh0dHBSZXF1ZXN0Q3Vz dG9tLmNwcAkocmV2aXNpb24gNTkzODMpCisrKyBXZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9W OFhNTEh0dHBSZXF1ZXN0Q3VzdG9tLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTU3LDIxICsxNTcs NiBAQCB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gVjhYTUxIdHRwUmVxdWVzdDo6CiAgICAgcmV0dXJu IHY4OjpVbmRlZmluZWQoKTsKIH0KIAotdjg6OkhhbmRsZTx2ODo6VmFsdWU+IFY4WE1MSHR0cFJl cXVlc3Q6OmdldFJlc3BvbnNlSGVhZGVyQ2FsbGJhY2soY29uc3Qgdjg6OkFyZ3VtZW50cyYgYXJn cykKLXsKLSAgICBJTkNfU1RBVFMoIkRPTS5YTUxIdHRwUmVxdWVzdC5nZXRSZXNwb25zZUhlYWRl cigpIik7Ci0gICAgaWYgKGFyZ3MuTGVuZ3RoKCkgPCAxKQotICAgICAgICByZXR1cm4gdGhyb3dF cnJvcigiTm90IGVub3VnaCBhcmd1bWVudHMiLCBWOFByb3h5OjpTeW50YXhFcnJvcik7Ci0KLSAg ICBYTUxIdHRwUmVxdWVzdCogeG1sSHR0cFJlcXVlc3QgPSBWOFhNTEh0dHBSZXF1ZXN0Ojp0b05h dGl2ZShhcmdzLkhvbGRlcigpKTsKLSAgICBFeGNlcHRpb25Db2RlIGVjID0gMDsKLSAgICBTdHJp bmcgaGVhZGVyID0gdG9XZWJDb3JlU3RyaW5nKGFyZ3NbMF0pOwotICAgIFN0cmluZyByZXN1bHQg PSB4bWxIdHRwUmVxdWVzdC0+Z2V0UmVzcG9uc2VIZWFkZXIoaGVhZGVyLCBlYyk7Ci0gICAgaWYg KGVjKQotICAgICAgICByZXR1cm4gdGhyb3dFcnJvcihlYyk7Ci0gICAgcmV0dXJuIHY4U3RyaW5n T3JOdWxsKHJlc3VsdCk7Ci19Ci0KIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBWOFhNTEh0dHBSZXF1 ZXN0OjpvdmVycmlkZU1pbWVUeXBlQ2FsbGJhY2soY29uc3Qgdjg6OkFyZ3VtZW50cyYgYXJncykK IHsKICAgICBJTkNfU1RBVFMoIkRPTS5YTUxIdHRwUmVxdWVzdC5vdmVycmlkZU1pbWVUeXBlKCki KTsKSW5kZXg6IFdlYkNvcmUveG1sL1hNTEh0dHBSZXF1ZXN0LmlkbAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVzdC5pZGwJKHJldmlzaW9uIDU5MzgzKQorKysgV2ViQ29y ZS94bWwvWE1MSHR0cFJlcXVlc3QuaWRsCSh3b3JraW5nIGNvcHkpCkBAIC03OCw3ICs3OCw4IEBA IG1vZHVsZSB4bWwgewogICAgICAgICAvLyByZXNwb25zZQogICAgICAgICBbQ29udmVydE51bGxT dHJpbmdUbz1VbmRlZmluZWRdIERPTVN0cmluZyBnZXRBbGxSZXNwb25zZUhlYWRlcnMoKQogICAg ICAgICAgICAgcmFpc2VzKERPTUV4Y2VwdGlvbik7Ci0gICAgICAgIFtDdXN0b20sIENvbnZlcnRO dWxsU3RyaW5nVG89TnVsbF0gRE9NU3RyaW5nIGdldFJlc3BvbnNlSGVhZGVyKGluIERPTVN0cmlu ZyBoZWFkZXIpCisgICAgICAgIC8vIEZJWE1FOiBSZXF1aXJlc0FsbEFyZ3VtZW50cyBpcyBwcm9i YWJseSBib2d1cyBoZXJlLgorICAgICAgICBbUmVxdWlyZXNBbGxBcmd1bWVudHMsIENvbnZlcnRO dWxsU3RyaW5nVG89TnVsbF0gRE9NU3RyaW5nIGdldFJlc3BvbnNlSGVhZGVyKGluIERPTVN0cmlu ZyBoZWFkZXIpCiAgICAgICAgICAgICByYWlzZXMoRE9NRXhjZXB0aW9uKTsKICAgICAgICAgcmVh ZG9ubHkgYXR0cmlidXRlIFtDdXN0b21HZXR0ZXJdIERPTVN0cmluZyByZXNwb25zZVRleHQ7IC8v IFRoZSBjdXN0b20gZ2V0dGVyIGltcGxlbWVudHMgQ29udmVydE51bGxTdHJpbmdUbz1OdWxsCiAg ICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBEb2N1bWVudCByZXNwb25zZVhNTDsK 56165 2010-05-15 17:49:44 -0700 2010-05-15 18:44:09 -0700 Patch for landing bug-39125-20100515174943.patch text/plain 3693 abarth ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MjUwYzA3YTk3MzU3MWI3MTAxNTljYWM5MDI4MDBhZGUwY2MyZDgyYy4uYWE2NTEwODE1NDRmMDU0 NjA5MjgyZWZiNzU0MmYwOGM0ZDljMDAzZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTIsNiArMiwyMCBAQAogCiAgICAgICAgIFJldmll d2VkIGJ5IERhcmluIEFkbGVyLgogCisgICAgICAgIFhNTEh0dHBSZXF1ZXN0LmdldFJlc3BvbnNl SGVhZGVyIGRvZXNuJ3QgbmVlZCB0byBiZSBjdXN0b20KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5MTI1CisKKyAgICAgICAgSSBkb24ndCBzZWUgYW55 IHJlYXNvbiB0aGlzIG1ldGhvZCBuZWVkcyB0byBiZSBjdXN0b20uICBObyBuZXcgdGVzdHMKKyAg ICAgICAgYmVjYXVzZSB0aGVyZSdzIG5vIGJlaGF2aW9yIGNoYW5nZS4KKworICAgICAgICAqIGJp bmRpbmdzL2pzL0pTWE1MSHR0cFJlcXVlc3RDdXN0b20uY3BwOgorICAgICAgICAqIGJpbmRpbmdz L3Y4L2N1c3RvbS9WOFhNTEh0dHBSZXF1ZXN0Q3VzdG9tLmNwcDoKKyAgICAgICAgKiB4bWwvWE1M SHR0cFJlcXVlc3QuaWRsOgorCisyMDEwLTA1LTE1ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtp dC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCisKICAgICAgICAgWE1M SHR0cFJlcXVlc3Quc2V0UmVxdWVzdEhlYWRlciBzaG91bGRuJ3QgYmUgY3VzdG9tCiAgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zOTEyNAogCmRpZmYgLS1n aXQgYS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTWE1MSHR0cFJlcXVlc3RDdXN0b20uY3BwIGIvV2Vi Q29yZS9iaW5kaW5ncy9qcy9KU1hNTEh0dHBSZXF1ZXN0Q3VzdG9tLmNwcAppbmRleCBkMmM4NmMy ZmQ2NDVhYWMyMDRjMmVlMDNiMDU4ZTA3ZTc1ZTczNmJlLi4wODZiODlkOTg3N2JjZTM1YzE2ZWJh NDIyYTU0N2YwNzUxNzY0OThmIDEwMDY0NAotLS0gYS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTWE1M SHR0cFJlcXVlc3RDdXN0b20uY3BwCisrKyBiL1dlYkNvcmUvYmluZGluZ3MvanMvSlNYTUxIdHRw UmVxdWVzdEN1c3RvbS5jcHAKQEAgLTEyMiwxNyArMTIyLDYgQEAgSlNWYWx1ZSBKU1hNTEh0dHBS ZXF1ZXN0OjpzZW5kKEV4ZWNTdGF0ZSogZXhlYywgY29uc3QgQXJnTGlzdCYgYXJncykKICAgICBy ZXR1cm4ganNVbmRlZmluZWQoKTsKIH0KIAotSlNWYWx1ZSBKU1hNTEh0dHBSZXF1ZXN0OjpnZXRS ZXNwb25zZUhlYWRlcihFeGVjU3RhdGUqIGV4ZWMsIGNvbnN0IEFyZ0xpc3QmIGFyZ3MpCi17Ci0g ICAgaWYgKGFyZ3Muc2l6ZSgpIDwgMSkKLSAgICAgICAgcmV0dXJuIHRocm93RXJyb3IoZXhlYywg U3ludGF4RXJyb3IsICJOb3QgZW5vdWdoIGFyZ3VtZW50cyIpOwotCi0gICAgRXhjZXB0aW9uQ29k ZSBlYyA9IDA7Ci0gICAgSlNWYWx1ZSBoZWFkZXIgPSBqc1N0cmluZ09yTnVsbChleGVjLCBpbXBs KCktPmdldFJlc3BvbnNlSGVhZGVyKHVzdHJpbmdUb0F0b21pY1N0cmluZyhhcmdzLmF0KDApLnRv U3RyaW5nKGV4ZWMpKSwgZWMpKTsKLSAgICBzZXRET01FeGNlcHRpb24oZXhlYywgZWMpOwotICAg IHJldHVybiBoZWFkZXI7Ci19Ci0KIEpTVmFsdWUgSlNYTUxIdHRwUmVxdWVzdDo6cmVzcG9uc2VU ZXh0KEV4ZWNTdGF0ZSogZXhlYykgY29uc3QKIHsKICAgICByZXR1cm4ganNPd25lZFN0cmluZ09y TnVsbChleGVjLCBpbXBsKCktPnJlc3BvbnNlVGV4dCgpKTsKZGlmZiAtLWdpdCBhL1dlYkNvcmUv YmluZGluZ3MvdjgvY3VzdG9tL1Y4WE1MSHR0cFJlcXVlc3RDdXN0b20uY3BwIGIvV2ViQ29yZS9i aW5kaW5ncy92OC9jdXN0b20vVjhYTUxIdHRwUmVxdWVzdEN1c3RvbS5jcHAKaW5kZXggOWUzMWZh NWY5NGJkZjIwZWRiN2VkNmVjMGU1YWE1NWM1ZTE1ODg4NC4uM2RhNjY0ZmY0NDVlMDE2NTRhMGU2 NTZhNzZhNzY5NzgzYjM2ZTU4OCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0 b20vVjhYTUxIdHRwUmVxdWVzdEN1c3RvbS5jcHAKKysrIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9j dXN0b20vVjhYTUxIdHRwUmVxdWVzdEN1c3RvbS5jcHAKQEAgLTE0MSwxOSArMTQxLDQgQEAgdjg6 OkhhbmRsZTx2ODo6VmFsdWU+IFY4WE1MSHR0cFJlcXVlc3Q6OnNlbmRDYWxsYmFjayhjb25zdCB2 ODo6QXJndW1lbnRzJiBhcmdzKQogICAgIHJldHVybiB2ODo6VW5kZWZpbmVkKCk7CiB9CiAKLXY4 OjpIYW5kbGU8djg6OlZhbHVlPiBWOFhNTEh0dHBSZXF1ZXN0OjpnZXRSZXNwb25zZUhlYWRlckNh bGxiYWNrKGNvbnN0IHY4OjpBcmd1bWVudHMmIGFyZ3MpCi17Ci0gICAgSU5DX1NUQVRTKCJET00u WE1MSHR0cFJlcXVlc3QuZ2V0UmVzcG9uc2VIZWFkZXIoKSIpOwotICAgIGlmIChhcmdzLkxlbmd0 aCgpIDwgMSkKLSAgICAgICAgcmV0dXJuIHRocm93RXJyb3IoIk5vdCBlbm91Z2ggYXJndW1lbnRz IiwgVjhQcm94eTo6U3ludGF4RXJyb3IpOwotCi0gICAgWE1MSHR0cFJlcXVlc3QqIHhtbEh0dHBS ZXF1ZXN0ID0gVjhYTUxIdHRwUmVxdWVzdDo6dG9OYXRpdmUoYXJncy5Ib2xkZXIoKSk7Ci0gICAg RXhjZXB0aW9uQ29kZSBlYyA9IDA7Ci0gICAgU3RyaW5nIGhlYWRlciA9IHRvV2ViQ29yZVN0cmlu ZyhhcmdzWzBdKTsKLSAgICBTdHJpbmcgcmVzdWx0ID0geG1sSHR0cFJlcXVlc3QtPmdldFJlc3Bv bnNlSGVhZGVyKGhlYWRlciwgZWMpOwotICAgIGlmIChlYykKLSAgICAgICAgcmV0dXJuIHRocm93 RXJyb3IoZWMpOwotICAgIHJldHVybiB2OFN0cmluZ09yTnVsbChyZXN1bHQpOwotfQotCiB9IC8v IG5hbWVzcGFjZSBXZWJDb3JlCmRpZmYgLS1naXQgYS9XZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVz dC5pZGwgYi9XZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVzdC5pZGwKaW5kZXggZjk1MjljYTkzM2Vk YjZjZDRiOGFkM2EyZGMxZDU5YjA4YmNkNTc0Zi4uMzU3NDc2NjNkYzYyMWRhZjZjZGY4N2I4ZjZk NmZiNjA3OWUyYzFlNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS94bWwvWE1MSHR0cFJlcXVlc3QuaWRs CisrKyBiL1dlYkNvcmUveG1sL1hNTEh0dHBSZXF1ZXN0LmlkbApAQCAtNzgsNyArNzgsNyBAQCBt b2R1bGUgeG1sIHsKICAgICAgICAgLy8gcmVzcG9uc2UKICAgICAgICAgW0NvbnZlcnROdWxsU3Ry aW5nVG89VW5kZWZpbmVkXSBET01TdHJpbmcgZ2V0QWxsUmVzcG9uc2VIZWFkZXJzKCkKICAgICAg ICAgICAgIHJhaXNlcyhET01FeGNlcHRpb24pOwotICAgICAgICBbQ3VzdG9tLCBDb252ZXJ0TnVs bFN0cmluZ1RvPU51bGxdIERPTVN0cmluZyBnZXRSZXNwb25zZUhlYWRlcihpbiBET01TdHJpbmcg aGVhZGVyKQorICAgICAgICBbUmVxdWlyZXNBbGxBcmd1bWVudHM9UmFpc2UsIENvbnZlcnROdWxs U3RyaW5nVG89TnVsbF0gRE9NU3RyaW5nIGdldFJlc3BvbnNlSGVhZGVyKGluIERPTVN0cmluZyBo ZWFkZXIpCiAgICAgICAgICAgICByYWlzZXMoRE9NRXhjZXB0aW9uKTsKICAgICAgICAgcmVhZG9u bHkgYXR0cmlidXRlIFtDdXN0b21HZXR0ZXJdIERPTVN0cmluZyByZXNwb25zZVRleHQ7IC8vIFRo ZSBjdXN0b20gZ2V0dGVyIGltcGxlbWVudHMgQ29udmVydE51bGxTdHJpbmdUbz1OdWxsCiAgICAg ICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBEb2N1bWVudCByZXNwb25zZVhNTDsK