39090 2010-05-13 15:28:42 -0700 Don't send mail if the only change is to the in-rietveld flag. 2010-05-14 15:55:34 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jparent jparent abarth eric ojan tony oldest_to_newest 225536 0 jparent 2010-05-13 15:28:42 -0700 Only used by tools, don't want to spam the world. 225544 1 56029 jparent 2010-05-13 15:34:10 -0700 Created attachment 56029 Patch 225576 2 56029 abarth 2010-05-13 17:04:35 -0700 Comment on attachment 56029 Patch Crazy. Looks hacky, but the whole file looks hacky... I'll give others a chance to look, but it seems reasonable to me. 225583 3 tony 2010-05-13 17:36:09 -0700 Can we do something similar for commit-queue? Maybe just setting commit-queue? . Normally I run webkit-patch upload and manually set the commit-queue flag because I forgot to add --request-commit. 225628 4 abarth 2010-05-13 19:37:14 -0700 That's an interesting idea. I'd still like email for commit-queue+ though. 225636 5 tony 2010-05-13 20:18:05 -0700 (In reply to comment #4) > That's an interesting idea. I'd still like email for commit-queue+ though. I agree, I still want email for commit-queue+. 225989 6 jparent 2010-05-14 13:56:44 -0700 I've separated the commit-queue request into another bug: https://bugs.webkit.org/show_bug.cgi?id=39134 226034 7 56029 ddkilzer 2010-05-14 15:43:37 -0700 Comment on attachment 56029 Patch r=me 226040 8 jparent 2010-05-14 15:55:34 -0700 Committed: http://trac.webkit.org/changeset/59500 56029 2010-05-13 15:34:10 -0700 2010-05-14 15:43:37 -0700 Patch sendmail.txt text/plain 1380 jparent SW5kZXg6IEJ1Z3NTaXRlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBCdWdzU2l0ZS9DaGFuZ2VM b2cJKHJldmlzaW9uIDU5Mzg5KQorKysgQnVnc1NpdGUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkp CkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDUtMTMgIEp1bGllIFBhcmVudCAgPGpwYXJlbnRAY2hy b21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEJ1Z3ppbGxhOiBEb24ndCBzZW5kIG1haWwgaWYgdGhlIG9ubHkgY2hhbmdlIGlzIHRvIHRo ZSBpbi1yaWV0dmVsZCBmbGFnLgorICAgICAgICAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTM5MDkwCisKKyAgICAgICAgKiBCdWd6aWxsYS9CdWdNYWls LnBtOgorCiAyMDEwLTA1LTEyICBKdWxpZSBQYXJlbnQgIDxqcGFyZW50QGNocm9taXVtLm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBPamFuIFZhZmFpLgpJbmRleDogQnVnc1NpdGUvQnVnemls bGEvQnVnTWFpbC5wbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBCdWdzU2l0ZS9CdWd6aWxsYS9CdWdNYWlsLnBt CShyZXZpc2lvbiA1OTM4OSkKKysrIEJ1Z3NTaXRlL0J1Z3ppbGxhL0J1Z01haWwucG0JKHdvcmtp bmcgY29weSkKQEAgLTU3NCw2ICs1NzQsMTQgQEAgc3ViIHNlbmRNYWlsIHsKICAgICAgICAgICAg ICAgICAgJiYgISgkdXNlci0+Z3JvdXBzLT57QnVnemlsbGEtPnBhcmFtcy0+eydpbnNpZGVyZ3Jv dXAnfX0pCiAgICAgICAgICAgICAgICAgKSB7CiAgICAgICAgICAgICAkYWRkX2RpZmYgPSAwOwor I2lmIFdFQktJVF9DSEFOR0VTCisgICAgICAgICMgSWYgdGhlIG9ubHkgdGhpbmcgd2UgYXJlIG1v ZGlmeWluZyBpcyB0aGUgaW4tcmlldHZlbGQgZmxhZywgZG9uJ3QKKyAgICAgICAgIyBpbmNsdWRl IHRoaXMgZGlmZi4gIElmIG11bHRpcGxlIGZsYWdzIGFyZSBiZWluZyBtb2RpZmllZCwKKyAgICAg ICAgIyB0aGUgZGlmZiB0ZXh0IHdpbGwgaGF2ZSBhIGNvbW1hIHNlcGVyYXRpbmcgaXQuCisgICAg ICAgICMgVGhpcyB3aWxsIHByZXZlbnQgbWFpbCBmcm9tIGJlaW5nIHNlbnQuCisgICAgICAgIH0g ZWxzaWYgKCRkaWZmLT57J3RleHQnfSA9fiAvaW4tcmlldHZlbGQvICYmICEoJGRpZmYtPnsndGV4 dCd9ID1+IC8sLykpIHsKKyAgICAgICAgICAgICRhZGRfZGlmZiA9IDA7CisjZW5kaWYgLy8gV0VC S0lUX0NIQU5HRVMKICAgICAgICAgfSBlbHNlIHsKICAgICAgICAgICAgICRhZGRfZGlmZiA9IDE7 CiAgICAgICAgIH0K