39089 2010-05-13 14:45:34 -0700 Domain names in Russian '.рф' domain are displayed as punycode 2010-05-13 15:43:10 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Mac All RESOLVED FIXED InRadar P2 Normal --- 1 ap ap oldest_to_newest 225515 0 ap 2010-05-13 14:45:34 -0700 Steps to reproduce: 1. Open http://президент.рф Expected results: address bar shows just this. Actual results: it's converted to punycode. There is no security risk in allowing Cyrillic characters in this TLD - to the contrary, Latin ones aren't allowed per registrar rules. <rdar://problem/7974044> 225518 1 56027 ap 2010-05-13 14:48:50 -0700 Created attachment 56027 proposed fix 225524 2 56027 darin 2010-05-13 15:03:09 -0700 Comment on attachment 56027 proposed fix r=me I'd like to see more use of early-return so the nesting could be a bit more shallow. Also, we should find a way to make regression tests for this. 225543 3 ap 2010-05-13 15:33:56 -0700 Some examples of what needs to be tested: shouldBe("presentDomainName('президент.рф')", "'президент.рф'"); shouldBe("presentDomainName('президент.рф.')", "'президент.рф.'"); shouldBe("presentDomainName('www.президент.рф')", "'www.президент.рф'"); shouldBe("presentDomainName('почта.президент.рф')", "'почта.президент.рф'"); shouldBe("presentDomainName('0ж9.рф')", "'0ж9.рф'"); shouldBe("presentDomainName('туда-сюда.рф')", "'туда-сюда.рф'"); shouldBe("presentDomainName('прeзидент.рф')", "'punycode'"); // spoof: Roman "e" shouldBe("presentDomainName('caxap.рф')", "'punycode'"); // spoof: all characters in "caxap" are Roman 225547 4 ap 2010-05-13 15:43:10 -0700 Committed <http://trac.webkit.org/changeset/59391>. 56027 2010-05-13 14:48:50 -0700 2010-05-13 15:03:08 -0700 proposed fix RFMac.txt text/plain 3260 ap SW5kZXg6IFdlYktpdC9tYWMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9tYWMvQ2hh bmdlTG9nCShyZXZpc2lvbiA1OTM4NikKKysrIFdlYktpdC9tYWMvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMDUtMTMgIEFsZXhleSBQcm9za3VyeWFrb3Yg IDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5MDg5Cisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS83OTc0MDQ0PiBEb21haW4gbmFtZXMgaW4gUnVzc2lhbiAn LtGA0YQnIGRvbWFpbiBhcmUgZGlzcGxheWVkIGFzIHB1bnljb2RlCisKKyAgICAgICAgQWRkIGEg Y3VzdG9tIGNoZWNrIGZvciB0aGlzIGRvbWFpbi4gQ3VycmVudGx5LCB0aGlzIGlzIHRoZSBvbmx5 IG5vbi1BU0NJSSBUTEQsIHdlJ2xsCisgICAgICAgIGludmVzdGlnYXRlIGEgbW9yZSBleHRlbnNp YmxlIHNvbHV0aW9uIHdoZW4gdGhlcmUgYXJlIG1vcmUsIGFuZCB3ZSBrbm93IHdoYXQgdGhlCisg ICAgICAgIHR5cGljYWwgcmVzdGljdGlvbnMgYXJlLgorCisgICAgICAgICogTWlzYy9XZWJOU1VS TEV4dHJhcy5tbToKKyAgICAgICAgKGFsbENoYXJhY3RlcnNBbGxvd2VkQnlUTERSdWxlcyk6Cisg ICAgICAgICgtW05TU3RyaW5nIF93ZWJfbWFwSG9zdE5hbWVXaXRoUmFuZ2U6ZW5jb2RlOm1ha2VT dHJpbmc6XSk6CisKIDIwMTAtMDUtMTIgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBs ZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgSHlhdHQuCkluZGV4OiBXZWJLaXQv bWFjL01pc2MvV2ViTlNVUkxFeHRyYXMubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L21hYy9NaXNj L1dlYk5TVVJMRXh0cmFzLm1tCShyZXZpc2lvbiA1OTIzNykKKysrIFdlYktpdC9tYWMvTWlzYy9X ZWJOU1VSTEV4dHJhcy5tbQkod29ya2luZyBjb3B5KQpAQCAtMTA1MCw2ICsxMDUwLDQxIEBAIHN0 YXRpYyBCT09MIGFsbENoYXJhY3RlcnNJbklETlNjcmlwdFdoaXQKICAgICByZXR1cm4gWUVTOwog fQogCitzdGF0aWMgQk9PTCBhbGxDaGFyYWN0ZXJzQWxsb3dlZEJ5VExEUnVsZXMoY29uc3QgVUNo YXIqIGJ1ZmZlciwgaW50MzJfdCBsZW5ndGgpCit7CisgICAgLy8gU2tpcCB0cmFpbGluZyBkb3Qg Zm9yIHJvb3QgZG9tYWluLgorICAgIGlmIChidWZmZXJbbGVuZ3RoIC0gMV0gPT0gJy4nKQorICAg ICAgICAtLWxlbmd0aDsKKworICAgIGlmIChsZW5ndGggPiAzCisgICAgICAgICYmIGJ1ZmZlclts ZW5ndGggLSAzXSA9PSAnLicKKyAgICAgICAgJiYgYnVmZmVyW2xlbmd0aCAtIDJdID09IDB4MDQ0 MCAvLyBDWVJJTExJQyBTTUFMTCBMRVRURVIgRVIKKyAgICAgICAgJiYgYnVmZmVyW2xlbmd0aCAt IDFdID09IDB4MDQ0NCkgLy8gQ1lSSUxMSUMgU01BTEwgTEVUVEVSIEVGCisgICAgeworICAgICAg ICAvLyBSdWxlcyBkZWZpbmVkIGJ5IDxodHRwOi8vd3d3LmNjdGxkLnJ1L3J1L2RvY3MvcnVsZXNy Zi5waHA+LiBUaGlzIGNvZGUgb25seSBjaGVja3MgcmVxdWlyZW1lbnRzIHRoYXQgbWF0dGVyIGZv ciBwcmVzZW50YXRpb24gcHVycG9zZXMuCisgICAgICAgIGZvciAoaW50MzJfdCBpID0gbGVuZ3Ro IC0gNDsgaTsgLS1pKSB7CisgICAgICAgICAgICBVQ2hhciBjaCA9IGJ1ZmZlcltpXTsKKworICAg ICAgICAgICAgLy8gT25seSBtb2Rlcm4gUnVzc2lhbiBsZXR0ZXJzLCBkaWdpdHMgYW5kIGRhc2hl cyBhcmUgYWxsb3dlZC4KKyAgICAgICAgICAgIGlmICgoY2ggPj0gMHgwNDMwICYmIGNoIDw9IDB4 MDQ0ZikKKyAgICAgICAgICAgICAgICB8fCBjaCA9PSAweDA0NTEKKyAgICAgICAgICAgICAgICB8 fCAoY2ggPj0gJzAnICYmIGNoIDw9ICc5JykKKyAgICAgICAgICAgICAgICB8fCBjaCA9PSAnLScp CisgICAgICAgICAgICAgICAgY29udGludWU7CisKKyAgICAgICAgICAgIC8vIE9ubHkgY2hlY2sg dG9wIGxldmVsIGRvbWFpbi4gTG93ZXIgbGV2ZWwgcmVnaXN0cmFycyBtYXkgaGF2ZSBkaWZmZXJl bnQgcnVsZXMuCisgICAgICAgICAgICBpZiAoY2ggPT0gJy4nKQorICAgICAgICAgICAgICAgIGJy ZWFrOworCisgICAgICAgICAgICByZXR1cm4gTk87CisgICAgICAgIH0KKyAgICAgICAgcmV0dXJu IFlFUzsKKyAgICB9CisKKyAgICAvLyBOb3QgYSBrbm93biB0b3AgbGV2ZWwgZG9tYWluIHdpdGgg c3BlY2lhbCBydWxlcy4KKyAgICByZXR1cm4gTk87Cit9CisKIC8vIFJldHVybiB2YWx1ZSBvZiBu aWwgbWVhbnMgbm8gbWFwcGluZyBpcyBuZWNlc3NhcnkuCiAvLyBJZiBtYWtlU3RyaW5nIGlzIE5P LCB0aGVuIHJldHVybiB2YWx1ZSBpcyBlaXRoZXIgbmlsIG9yIHNlbGYgdG8gaW5kaWNhdGUgbWFw cGluZyBpcyBuZWNlc3NhcnkuCiAvLyBJZiBtYWtlU3RyaW5nIGlzIFlFUywgdGhlbiByZXR1cm4g dmFsdWUgaXMgZWl0aGVyIG5pbCBvciB0aGUgbWFwcGVkIHN0cmluZy4KQEAgLTEwODcsNyArMTEy Miw3IEBAIC0gKE5TU3RyaW5nICopX3dlYl9tYXBIb3N0TmFtZVdpdGhSYW5nZToKICAgICBpZiAo bnVtQ2hhcmFjdGVyc0NvbnZlcnRlZCA9PSBsZW5ndGggJiYgbWVtY21wKHNvdXJjZUJ1ZmZlciwg ZGVzdGluYXRpb25CdWZmZXIsIGxlbmd0aCAqIHNpemVvZihVQ2hhcikpID09IDApIHsKICAgICAg ICAgcmV0dXJuIG5pbDsKICAgICB9Ci0gICAgaWYgKCFlbmNvZGUgJiYgIWFsbENoYXJhY3RlcnNJ bklETlNjcmlwdFdoaXRlTGlzdChkZXN0aW5hdGlvbkJ1ZmZlciwgbnVtQ2hhcmFjdGVyc0NvbnZl cnRlZCkpIHsKKyAgICBpZiAoIWVuY29kZSAmJiAhYWxsQ2hhcmFjdGVyc0luSUROU2NyaXB0V2hp dGVMaXN0KGRlc3RpbmF0aW9uQnVmZmVyLCBudW1DaGFyYWN0ZXJzQ29udmVydGVkKSAmJiAhYWxs Q2hhcmFjdGVyc0FsbG93ZWRCeVRMRFJ1bGVzKGRlc3RpbmF0aW9uQnVmZmVyLCBudW1DaGFyYWN0 ZXJzQ29udmVydGVkKSkgewogICAgICAgICByZXR1cm4gbmlsOwogICAgIH0KICAgICByZXR1cm4g bWFrZVN0cmluZyA/IChOU1N0cmluZyAqKVtOU1N0cmluZyBzdHJpbmdXaXRoQ2hhcmFjdGVyczpk ZXN0aW5hdGlvbkJ1ZmZlciBsZW5ndGg6bnVtQ2hhcmFjdGVyc0NvbnZlcnRlZF0gOiAoTlNTdHJp bmcgKilzZWxmOwo=