39086 2010-05-13 13:41:41 -0700 Scalar types allocated on the heap due to misuse of DEFINE_STATIC_LOCAL 2010-05-16 01:10:26 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 mitz mitz abarth commit-queue oldest_to_newest 225480 0 mitz 2010-05-13 13:41:41 -0700 Patch forthcoming 225490 1 56019 mitz 2010-05-13 13:50:43 -0700 Created attachment 56019 Use global variables directly 226161 2 abarth 2010-05-14 23:31:45 -0700 Attachment 56019 was posted by a committer and has review+, assigning to Dan Bernstein for commit. 226374 3 56019 abarth 2010-05-15 18:24:56 -0700 Comment on attachment 56019 Use global variables directly Mitz, I'm tossing this on the commit-queue for you because it looks pretty trivial. Hopefully that's ok with you. 226448 4 56019 commit-queue 2010-05-16 01:10:20 -0700 Comment on attachment 56019 Use global variables directly Clearing flags on attachment: 56019 Committed r59570: <http://trac.webkit.org/changeset/59570> 226449 5 commit-queue 2010-05-16 01:10:26 -0700 All reviewed patches have been landed. Closing bug. 56019 2010-05-13 13:50:43 -0700 2010-05-16 01:10:19 -0700 Use global variables directly 39086_r1.diff text/plain 3424 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1OTM4NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMDUtMTMgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTY2Fs YXIgdHlwZXMgYWxsb2NhdGVkIG9uIHRoZSBoZWFwIGR1ZSB0byBtaXN1c2Ugb2YgREVGSU5FX1NU QVRJQ19MT0NBTAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MzkwODYKKworICAgICAgICBVc2UgZ2xvYmFsIHZhcmlhYmxlcyBkaXJlY3RseS4KKworICAg ICAgICAqIGJpbmRpbmdzL3Y4L1NjcmlwdENhbGxTdGFjay5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpTY3JpcHRDYWxsU3RhY2s6OmNyZWF0ZVV0aWxpdHlDb250ZXh0KToKKyAgICAgICAgKiBwbGF0 Zm9ybS9TY3JvbGxWaWV3LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbFZpZXc6OndoZWVs RXZlbnQpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL21hYy9Db21wbGV4VGV4dENvbnRy b2xsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6c2hvdWxkVXNlQVRTVUlBUEkpOgorCiAyMDEw LTA1LTEzICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZp ZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0Q2Fs bFN0YWNrLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdENhbGxT dGFjay5jcHAJKHJldmlzaW9uIDU5MjYwKQorKysgV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRD YWxsU3RhY2suY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNyw3ICszNyw2IEBACiAKICNpbmNsdWRl IDx2OC1kZWJ1Zy5oPgogI2luY2x1ZGUgPHY4Lmg+Ci0jaW5jbHVkZSA8d3RmL1N0ZExpYkV4dHJh cy5oPiAvLyBGb3IgREVGSU5FX1NUQVRJQ19MT0NBTAogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAK QEAgLTkxLDggKzkwLDggQEAgdm9pZCBTY3JpcHRDYWxsU3RhY2s6OmNyZWF0ZVV0aWxpdHlDb250 ZQogCiAgICAgLy8gQ29tcGlsZSBKYXZhU2NyaXB0IGZ1bmN0aW9uIGZvciByZXRyaWV2aW5nIHRo ZSBzb3VyY2UgbGluZSwgdGhlIHNvdXJjZQogICAgIC8vIG5hbWUgYW5kIHRoZSBzeW1ib2wgbmFt ZSBmb3IgdGhlIHRvcCBKYXZhU2NyaXB0IHN0YWNrIGZyYW1lLgotICAgIERFRklORV9TVEFUSUNf TE9DQUwoY29uc3QgY2hhciosIHRvcFN0YWNrRnJhbWUsCi0gICAgICAgICgiZnVuY3Rpb24gdG9w U3RhY2tGcmFtZShleGVjX3N0YXRlKSB7IgorICAgIGNvbnN0IGNoYXIqIHRvcFN0YWNrRnJhbWUg PQorICAgICAgICAiZnVuY3Rpb24gdG9wU3RhY2tGcmFtZShleGVjX3N0YXRlKSB7IgogICAgICAg ICAiICBpZiAoIWV4ZWNfc3RhdGUuZnJhbWVDb3VudCgpKSIKICAgICAgICAgIiAgICAgIHJldHVy biB1bmRlZmluZWQ7IgogICAgICAgICAiICB2YXIgZnJhbWUgPSBleGVjX3N0YXRlLmZyYW1lKDAp OyIKQEAgLTEwMSw3ICsxMDAsNyBAQCB2b2lkIFNjcmlwdENhbGxTdGFjazo6Y3JlYXRlVXRpbGl0 eUNvbnRlCiAgICAgICAgICIgIGlmIChmdW5jLnJlc29sdmVkKCkgJiYgZnVuYy5zY3JpcHQoKSki CiAgICAgICAgICIgICAgICBzY3JpcHROYW1lID0gZnVuYy5zY3JpcHQoKS5uYW1lKCk7IgogICAg ICAgICAiICByZXR1cm4gW3NjcmlwdE5hbWUsIGZyYW1lLnNvdXJjZUxpbmUoKSwgKGZ1bmMubmFt ZSgpIHx8IGZ1bmMuaW5mZXJyZWROYW1lKCkpXTsiCi0gICAgICAgICJ9IikpOworICAgICAgICAi fSI7CiAgICAgdjg6OlNjcmlwdDo6Q29tcGlsZSh2ODo6U3RyaW5nOjpOZXcodG9wU3RhY2tGcmFt ZSkpLT5SdW4oKTsKIH0KIApJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxWaWV3LmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuY3BwCShyZXZpc2lvbiA1 OTI2MCkKKysrIFdlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsVmlldy5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTc1OSw3ICs3NTksNyBAQCB2b2lkIFNjcm9sbFZpZXc6OnBhaW50U2Nyb2xsYmFycyhHcmFw aGljCiAKIHZvaWQgU2Nyb2xsVmlldzo6cGFpbnRQYW5TY3JvbGxJY29uKEdyYXBoaWNzQ29udGV4 dCogY29udGV4dCkKIHsKLSAgICBERUZJTkVfU1RBVElDX0xPQ0FMKEltYWdlKiwgcGFuU2Nyb2xs SWNvbiwgKEltYWdlOjpsb2FkUGxhdGZvcm1SZXNvdXJjZSgicGFuSWNvbiIpLnJlbGVhc2VSZWYo KSkpOworICAgIHN0YXRpYyBJbWFnZSogcGFuU2Nyb2xsSWNvbiA9IEltYWdlOjpsb2FkUGxhdGZv cm1SZXNvdXJjZSgicGFuSWNvbiIpLnJlbGVhc2VSZWYoKTsKICAgICBjb250ZXh0LT5kcmF3SW1h Z2UocGFuU2Nyb2xsSWNvbiwgRGV2aWNlQ29sb3JTcGFjZSwgbV9wYW5TY3JvbGxJY29uUG9pbnQp OwogfQogCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21hYy9Db21wbGV4VGV4dENv bnRyb2xsZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFj L0NvbXBsZXhUZXh0Q29udHJvbGxlci5jcHAJKHJldmlzaW9uIDU5MjYwKQorKysgV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9tYWMvQ29tcGxleFRleHRDb250cm9sbGVyLmNwcAkod29ya2luZyBj b3B5KQpAQCAtMjgwLDcgKzI4MCw3IEBAIHZvaWQgQ29tcGxleFRleHRDb250cm9sbGVyOjpjb2xs ZWN0Q29tcGwKIHN0YXRpYyBpbmxpbmUgYm9vbCBzaG91bGRVc2VBVFNVSUFQSSgpCiB7CiAgICAg ZW51bSBUeXBlUmVuZGVyaW5nQVBJVG9Vc2UgeyBVbkluaXRpYWxpemVkLCBVc2VBVFNVSSwgVXNl Q29yZVRleHQgfTsKLSAgICBERUZJTkVfU1RBVElDX0xPQ0FMKFR5cGVSZW5kZXJpbmdBUElUb1Vz ZSwgYXBpVG9Vc2UsIChVbkluaXRpYWxpemVkKSk7CisgICAgc3RhdGljIFR5cGVSZW5kZXJpbmdB UElUb1VzZSBhcGlUb1VzZSA9IFVuSW5pdGlhbGl6ZWQ7CiAKICAgICBpZiAoVU5MSUtFTFkoYXBp VG9Vc2UgPT0gVW5Jbml0aWFsaXplZCkpIHsKICAgICAgICAgaWYgKCZDVEdldENvcmVUZXh0VmVy c2lvbiAhPSAwICYmIENUR2V0Q29yZVRleHRWZXJzaW9uKCkgPj0ga0NUVmVyc2lvbk51bWJlcjEw XzYpCg==