39085 2010-05-13 13:40:22 -0700 Resized Images are not cached in Chromium (Skia) 2010-05-14 13:37:03 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 sergeyu sergeyu brettw dimich webkit.review.bot oldest_to_newest 225479 0 sergeyu 2010-05-13 13:40:22 -0700 Skia version of Image::drawPattern() resizes images using bicubic scaling and doesn't cache results. This causes very poor performance when playing HTML5 video on YouTube when zoom factor is different from 1.0. Problem is that the video controls are refreshed after each frame and this requires resizing background image for the controls. 225511 1 56025 sergeyu 2010-05-13 14:30:28 -0700 Created attachment 56025 Fix for this bug. 225512 2 webkit.review.bot 2010-05-13 14:32:05 -0700 Attachment 56025 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/platform/graphics/skia/ImageSkia.cpp:350: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] WebCore/platform/graphics/skia/ImageSkia.cpp:350: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] WebCore/platform/graphics/skia/ImageSkia.cpp:351: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] WebCore/platform/graphics/skia/ImageSkia.cpp:352: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Total errors found: 4 in 1 files If any of these errors are false positives, please file a bug against check-webkit-style. 225580 3 56035 sergeyu 2010-05-13 17:19:54 -0700 Created attachment 56035 Fix for this bug. 225612 4 brettw 2010-05-13 18:30:23 -0700 This patch looks good to me (note that I'm not a real WebKit reviewer). 225624 5 56035 dimich 2010-05-13 19:32:06 -0700 Comment on attachment 56035 Fix for this bug. I can't check the functional validity. If Brett thinks it's ok and layout tests with pixel compare don't fail it could be ok. Some style issues: The change needs a ChangeLog (hence r-) > + || bitmap->shouldCacheResampling(static_cast<int>(destBitmapWidth), static_cast<int>(destBitmapHeight), > + static_cast<int>(destBitmapWidth), static_cast<int>(destBitmapHeight))) ) { I don't think the space before the closing ')' is needed. Could I suggest all those casts to be moved to the top, initializing some local 'destWidth' and 'destHeight', so we don't have a dozen of them repeated everywhere? > + // resize() caches resized images. > + resampled = bitmap->resizedBitmap(static_cast<int>(destBitmapWidth), > + static_cast<int>(destBitmapHeight)); Once the casts are gone, this line can be un-wrapped. 225646 6 56052 sergeyu 2010-05-13 20:41:02 -0700 Created attachment 56052 Patch, addressed review comments. 225650 7 56053 sergeyu 2010-05-13 20:43:16 -0700 Created attachment 56053 Patch. 225651 8 56054 sergeyu 2010-05-13 20:48:40 -0700 Created attachment 56054 Patch Added link to the bug in the ChangeLog. 225659 9 56055 sergeyu 2010-05-13 21:30:57 -0700 Created attachment 56055 Patch. 225660 10 56055 dimich 2010-05-13 21:32:59 -0700 Comment on attachment 56055 Patch. r=me 225970 11 56055 dimich 2010-05-14 13:20:15 -0700 Comment on attachment 56055 Patch. Going to land this manually for Sergey. removing cq+. 225978 12 dimich 2010-05-14 13:37:03 -0700 Landed: http://trac.webkit.org/changeset/59487 56025 2010-05-13 14:30:28 -0700 2010-05-13 17:19:54 -0700 Fix for this bug. WebKit-resize-caching.patch text/plain 1768 sergeyu ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9JbWFnZVNraWEuY3Bw IGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlU2tpYS5jcHAKaW5kZXggYjFi ZmJkZC4uZjMxNDU2ZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lh L0ltYWdlU2tpYS5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdl U2tpYS5jcHAKQEAgLTM0NiwxMCArMzQ2LDIxIEBAIHZvaWQgSW1hZ2U6OmRyYXdQYXR0ZXJuKEdy YXBoaWNzQ29udGV4dCogY29udGV4dCwKIAogICAgIGlmIChyZXNhbXBsaW5nID09IFJFU0FNUExF X0FXRVNPTUUpIHsKICAgICAgICAgLy8gRG8gbmljZSByZXNhbXBsaW5nLgotICAgICAgICBTa0Jp dG1hcCByZXNhbXBsZWQgPSBza2lhOjpJbWFnZU9wZXJhdGlvbnM6OlJlc2l6ZShzcmNTdWJzZXQs Ci0gICAgICAgICAgICBza2lhOjpJbWFnZU9wZXJhdGlvbnM6OlJFU0laRV9MQU5DWk9TMywKLSAg ICAgICAgICAgIHN0YXRpY19jYXN0PGludD4oZGVzdEJpdG1hcFdpZHRoKSwKLSAgICAgICAgICAg IHN0YXRpY19jYXN0PGludD4oZGVzdEJpdG1hcEhlaWdodCkpOworICAgICAgICBTa0JpdG1hcCBy ZXNhbXBsZWQ7CisgICAgICAgIGlmIChzcmNSZWN0LmZMZWZ0ID09IDAgJiYgc3JjUmVjdC5mVG9w ID09IDAgJiYKKyAgICAgICAgICAgIHNyY1JlY3QuZlJpZ2h0ID09IGJpdG1hcC0+d2lkdGgoKSAm JiBzcmNSZWN0LmZCb3R0b20gPT0gYml0bWFwLT5oZWlnaHQoKSAmJgorICAgICAgICAgICAgKGJp dG1hcC0+aGFzUmVzaXplZEJpdG1hcChzdGF0aWNfY2FzdDxpbnQ+KGRlc3RCaXRtYXBXaWR0aCks IHN0YXRpY19jYXN0PGludD4oZGVzdEJpdG1hcEhlaWdodCkpIHx8CisgICAgICAgICAgICAgYml0 bWFwLT5zaG91bGRDYWNoZVJlc2FtcGxpbmcoc3RhdGljX2Nhc3Q8aW50PihkZXN0Qml0bWFwV2lk dGgpLCBzdGF0aWNfY2FzdDxpbnQ+KGRlc3RCaXRtYXBIZWlnaHQpLAorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0YXRpY19jYXN0PGludD4oZGVzdEJpdG1hcFdp ZHRoKSwgc3RhdGljX2Nhc3Q8aW50PihkZXN0Qml0bWFwSGVpZ2h0KSkpICkgeworICAgICAgICAg ICAgLy8gcmVzaXplKCkgY2FjaGVzIHJlc2l6ZWQgaW1hZ2VzLgorICAgICAgICAgICAgcmVzYW1w bGVkID0gYml0bWFwLT5yZXNpemVkQml0bWFwKHN0YXRpY19jYXN0PGludD4oZGVzdEJpdG1hcFdp ZHRoKSwKKyAgICAgICAgICAgICAgICBzdGF0aWNfY2FzdDxpbnQ+KGRlc3RCaXRtYXBIZWlnaHQp KTsKKyAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgIHJlc2FtcGxlZCA9IHNraWE6OkltYWdl T3BlcmF0aW9uczo6UmVzaXplKHNyY1N1YnNldCwKKyAgICAgICAgICAgICAgICBza2lhOjpJbWFn ZU9wZXJhdGlvbnM6OlJFU0laRV9MQU5DWk9TMywKKyAgICAgICAgICAgICAgICBzdGF0aWNfY2Fz dDxpbnQ+KGRlc3RCaXRtYXBXaWR0aCksCisgICAgICAgICAgICAgICAgc3RhdGljX2Nhc3Q8aW50 PihkZXN0Qml0bWFwSGVpZ2h0KSk7CisgICAgICAgIH0KICAgICAgICAgc2hhZGVyID0gU2tTaGFk ZXI6OkNyZWF0ZUJpdG1hcFNoYWRlcihyZXNhbXBsZWQsIFNrU2hhZGVyOjprUmVwZWF0X1RpbGVN b2RlLCBTa1NoYWRlcjo6a1JlcGVhdF9UaWxlTW9kZSk7CiAKICAgICAgICAgLy8gU2luY2Ugd2Ug anVzdCByZXNpemVkIHRoZSBiaXRtYXAsIHdlIG5lZWQgdG8gdW5kbyB0aGUgc2NhbGUgc2V0IGlu Cg== 56035 2010-05-13 17:19:54 -0700 2010-05-13 20:41:02 -0700 Fix for this bug. WebKit-resize-caching.patch text/plain 1769 sergeyu ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9JbWFnZVNraWEuY3Bw IGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlU2tpYS5jcHAKaW5kZXggYjFi ZmJkZC4uMzdmNjJkYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lh L0ltYWdlU2tpYS5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdl U2tpYS5jcHAKQEAgLTM0NiwxMCArMzQ2LDIxIEBAIHZvaWQgSW1hZ2U6OmRyYXdQYXR0ZXJuKEdy YXBoaWNzQ29udGV4dCogY29udGV4dCwKIAogICAgIGlmIChyZXNhbXBsaW5nID09IFJFU0FNUExF X0FXRVNPTUUpIHsKICAgICAgICAgLy8gRG8gbmljZSByZXNhbXBsaW5nLgotICAgICAgICBTa0Jp dG1hcCByZXNhbXBsZWQgPSBza2lhOjpJbWFnZU9wZXJhdGlvbnM6OlJlc2l6ZShzcmNTdWJzZXQs Ci0gICAgICAgICAgICBza2lhOjpJbWFnZU9wZXJhdGlvbnM6OlJFU0laRV9MQU5DWk9TMywKLSAg ICAgICAgICAgIHN0YXRpY19jYXN0PGludD4oZGVzdEJpdG1hcFdpZHRoKSwKLSAgICAgICAgICAg IHN0YXRpY19jYXN0PGludD4oZGVzdEJpdG1hcEhlaWdodCkpOworICAgICAgICBTa0JpdG1hcCBy ZXNhbXBsZWQ7CisgICAgICAgIGlmICghc3JjUmVjdC5mTGVmdCAmJiAhc3JjUmVjdC5mVG9wCisg ICAgICAgICAgICAmJiBzcmNSZWN0LmZSaWdodCA9PSBiaXRtYXAtPndpZHRoKCkgJiYgc3JjUmVj dC5mQm90dG9tID09IGJpdG1hcC0+aGVpZ2h0KCkKKyAgICAgICAgICAgICYmIChiaXRtYXAtPmhh c1Jlc2l6ZWRCaXRtYXAoc3RhdGljX2Nhc3Q8aW50PihkZXN0Qml0bWFwV2lkdGgpLCBzdGF0aWNf Y2FzdDxpbnQ+KGRlc3RCaXRtYXBIZWlnaHQpKQorICAgICAgICAgICAgICAgIHx8IGJpdG1hcC0+ c2hvdWxkQ2FjaGVSZXNhbXBsaW5nKHN0YXRpY19jYXN0PGludD4oZGVzdEJpdG1hcFdpZHRoKSwg c3RhdGljX2Nhc3Q8aW50PihkZXN0Qml0bWFwSGVpZ2h0KSwKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdGF0aWNfY2FzdDxpbnQ+KGRlc3RCaXRtYXBX aWR0aCksIHN0YXRpY19jYXN0PGludD4oZGVzdEJpdG1hcEhlaWdodCkpKSApIHsKKyAgICAgICAg ICAgIC8vIHJlc2l6ZSgpIGNhY2hlcyByZXNpemVkIGltYWdlcy4KKyAgICAgICAgICAgIHJlc2Ft cGxlZCA9IGJpdG1hcC0+cmVzaXplZEJpdG1hcChzdGF0aWNfY2FzdDxpbnQ+KGRlc3RCaXRtYXBX aWR0aCksCisgICAgICAgICAgICAgICAgc3RhdGljX2Nhc3Q8aW50PihkZXN0Qml0bWFwSGVpZ2h0 KSk7CisgICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICByZXNhbXBsZWQgPSBza2lhOjpJbWFn ZU9wZXJhdGlvbnM6OlJlc2l6ZShzcmNTdWJzZXQsCisgICAgICAgICAgICAgICAgc2tpYTo6SW1h Z2VPcGVyYXRpb25zOjpSRVNJWkVfTEFOQ1pPUzMsCisgICAgICAgICAgICAgICAgc3RhdGljX2Nh c3Q8aW50PihkZXN0Qml0bWFwV2lkdGgpLAorICAgICAgICAgICAgICAgIHN0YXRpY19jYXN0PGlu dD4oZGVzdEJpdG1hcEhlaWdodCkpOworICAgICAgICB9CiAgICAgICAgIHNoYWRlciA9IFNrU2hh ZGVyOjpDcmVhdGVCaXRtYXBTaGFkZXIocmVzYW1wbGVkLCBTa1NoYWRlcjo6a1JlcGVhdF9UaWxl TW9kZSwgU2tTaGFkZXI6OmtSZXBlYXRfVGlsZU1vZGUpOwogCiAgICAgICAgIC8vIFNpbmNlIHdl IGp1c3QgcmVzaXplZCB0aGUgYml0bWFwLCB3ZSBuZWVkIHRvIHVuZG8gdGhlIHNjYWxlIHNldCBp bgo= 56052 2010-05-13 20:41:02 -0700 2010-05-13 20:43:59 -0700 Patch, addressed review comments. WebKit-resize-caching.patch text/plain 2322 sergeyu ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZWFiMjRjYy4uNDVhODVhZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wNS0xMyAgU2VyZ2V5IFVsYW5v diAgPHNlcmdleXVAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEFkZGluZyByZXNpemVkIGltYWdlIGNhY2hpbmcgZm9yIFNraWEu CisKKyAgICAgICAgVGVzdHM6IEhUTUw1IHZpZGVvIG9uIFlvdVR1YmUuCisKKyAgICAgICAgKiBw bGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlU2tpYS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJ bWFnZTo6ZHJhd1BhdHRlcm4pOiBVc2UgYml0bWFwLnJlc2l6ZSgpIHRvIGNhY2hlIHJlc2l6ZWQg aW1hZ2Ugd2hlbiBwb3NzaWJsZS4KKwogMjAxMC0wNS0xMSAgTmlrb2xhcyBaaW1tZXJtYW5uICA8 bnppbW1lcm1hbm5AcmltLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEaXJrIFNjaHVsemUu CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvSW1hZ2VTa2lhLmNw cCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9JbWFnZVNraWEuY3BwCmluZGV4IGIx YmZiZGQuLjIxODFmY2EgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tp YS9JbWFnZVNraWEuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9JbWFn ZVNraWEuY3BwCkBAIC0zNDYsMTAgKzM0NiwyMiBAQCB2b2lkIEltYWdlOjpkcmF3UGF0dGVybihH cmFwaGljc0NvbnRleHQqIGNvbnRleHQsCiAKICAgICBpZiAocmVzYW1wbGluZyA9PSBSRVNBTVBM RV9BV0VTT01FKSB7CiAgICAgICAgIC8vIERvIG5pY2UgcmVzYW1wbGluZy4KLSAgICAgICAgU2tC aXRtYXAgcmVzYW1wbGVkID0gc2tpYTo6SW1hZ2VPcGVyYXRpb25zOjpSZXNpemUoc3JjU3Vic2V0 LAotICAgICAgICAgICAgc2tpYTo6SW1hZ2VPcGVyYXRpb25zOjpSRVNJWkVfTEFOQ1pPUzMsCi0g ICAgICAgICAgICBzdGF0aWNfY2FzdDxpbnQ+KGRlc3RCaXRtYXBXaWR0aCksCi0gICAgICAgICAg ICBzdGF0aWNfY2FzdDxpbnQ+KGRlc3RCaXRtYXBIZWlnaHQpKTsKKyAgICAgICAgU2tCaXRtYXAg cmVzYW1wbGVkOworICAgICAgICBpbnQgZGVzdElCaXRtYXBXaWR0aCA9IHN0YXRpY19jYXN0PGlu dD4oZGVzdEJpdG1hcFdpZHRoKTsKKyAgICAgICAgaW50IGRlc3RJQml0bWFwSGVpZ2h0ID0gc3Rh dGljX2Nhc3Q8aW50PihkZXN0Qml0bWFwSGVpZ2h0KTsKKyAgICAgICAgaWYgKCFzcmNSZWN0LmZM ZWZ0ICYmICFzcmNSZWN0LmZUb3AKKyAgICAgICAgICAgICYmIHNyY1JlY3QuZlJpZ2h0ID09IGJp dG1hcC0+d2lkdGgoKSAmJiBzcmNSZWN0LmZCb3R0b20gPT0gYml0bWFwLT5oZWlnaHQoKQorICAg ICAgICAgICAgJiYgKGJpdG1hcC0+aGFzUmVzaXplZEJpdG1hcChkZXN0SUJpdG1hcFdpZHRoLCBk ZXN0SUJpdG1hcEhlaWdodCkKKyAgICAgICAgICAgICAgICB8fCBiaXRtYXAtPnNob3VsZENhY2hl UmVzYW1wbGluZyhkZXN0Qml0bWFwV2lkdGgsIGRlc3RCaXRtYXBIZWlnaHQsCisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZGVzdEJpdG1hcFdpZHRoLCBk ZXN0Qml0bWFwSGVpZ2h0KSkpIHsKKyAgICAgICAgICAgIC8vIHJlc2l6ZWRCaXRtYXAoKSBjYWNo ZXMgcmVzaXplZCBpbWFnZS4KKyAgICAgICAgICAgIHJlc2FtcGxlZCA9IGJpdG1hcC0+cmVzaXpl ZEJpdG1hcChkZXN0Qml0bWFwV2lkdGgsIGRlc3RCaXRtYXBIZWlnaHQpOworICAgICAgICB9IGVs c2UgeworICAgICAgICAgICAgcmVzYW1wbGVkID0gc2tpYTo6SW1hZ2VPcGVyYXRpb25zOjpSZXNp emUoc3JjU3Vic2V0LAorICAgICAgICAgICAgICAgIHNraWE6OkltYWdlT3BlcmF0aW9uczo6UkVT SVpFX0xBTkNaT1MzLAorICAgICAgICAgICAgICAgIHN0YXRpY19jYXN0PGludD4oZGVzdEJpdG1h cFdpZHRoKSwKKyAgICAgICAgICAgICAgICBzdGF0aWNfY2FzdDxpbnQ+KGRlc3RCaXRtYXBIZWln aHQpKTsKKyAgICAgICAgfQogICAgICAgICBzaGFkZXIgPSBTa1NoYWRlcjo6Q3JlYXRlQml0bWFw U2hhZGVyKHJlc2FtcGxlZCwgU2tTaGFkZXI6OmtSZXBlYXRfVGlsZU1vZGUsIFNrU2hhZGVyOjpr UmVwZWF0X1RpbGVNb2RlKTsKIAogICAgICAgICAvLyBTaW5jZSB3ZSBqdXN0IHJlc2l6ZWQgdGhl IGJpdG1hcCwgd2UgbmVlZCB0byB1bmRvIHRoZSBzY2FsZSBzZXQgaW4K 56053 2010-05-13 20:43:16 -0700 2010-05-13 20:48:40 -0700 Patch. WebKit-resize-caching.patch text/plain 2330 sergeyu ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZWFiMjRjYy4uNzU1NjY4NCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wNS0xMyAgU2VyZ2V5IFVsYW5v diAgPHNlcmdleXVAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEFkZGluZyByZXNpemVkIGltYWdlIGNhY2hpbmcgZm9yIFNraWEu CisKKyAgICAgICAgVGVzdHM6IEhUTUw1IHZpZGVvIG9uIFlvdVR1YmUuCisKKyAgICAgICAgKiBw bGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlU2tpYS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJ bWFnZTo6ZHJhd1BhdHRlcm4pOiBVc2UgYml0bWFwLT5yZXNpemVkQml0bWFwKCkgdG8gY2FjaGUg cmVzaXplZCBpbWFnZSB3aGVuIHBvc3NpYmxlLgorCiAyMDEwLTA1LTExICBOaWtvbGFzIFppbW1l cm1hbm4gIDxuemltbWVybWFubkByaW0uY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpcmsg U2NodWx6ZS4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9JbWFn ZVNraWEuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlU2tpYS5jcHAK aW5kZXggYjFiZmJkZC4uMjE4MWZjYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9za2lhL0ltYWdlU2tpYS5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9z a2lhL0ltYWdlU2tpYS5jcHAKQEAgLTM0NiwxMCArMzQ2LDIyIEBAIHZvaWQgSW1hZ2U6OmRyYXdQ YXR0ZXJuKEdyYXBoaWNzQ29udGV4dCogY29udGV4dCwKIAogICAgIGlmIChyZXNhbXBsaW5nID09 IFJFU0FNUExFX0FXRVNPTUUpIHsKICAgICAgICAgLy8gRG8gbmljZSByZXNhbXBsaW5nLgotICAg ICAgICBTa0JpdG1hcCByZXNhbXBsZWQgPSBza2lhOjpJbWFnZU9wZXJhdGlvbnM6OlJlc2l6ZShz cmNTdWJzZXQsCi0gICAgICAgICAgICBza2lhOjpJbWFnZU9wZXJhdGlvbnM6OlJFU0laRV9MQU5D Wk9TMywKLSAgICAgICAgICAgIHN0YXRpY19jYXN0PGludD4oZGVzdEJpdG1hcFdpZHRoKSwKLSAg ICAgICAgICAgIHN0YXRpY19jYXN0PGludD4oZGVzdEJpdG1hcEhlaWdodCkpOworICAgICAgICBT a0JpdG1hcCByZXNhbXBsZWQ7CisgICAgICAgIGludCBkZXN0SUJpdG1hcFdpZHRoID0gc3RhdGlj X2Nhc3Q8aW50PihkZXN0Qml0bWFwV2lkdGgpOworICAgICAgICBpbnQgZGVzdElCaXRtYXBIZWln aHQgPSBzdGF0aWNfY2FzdDxpbnQ+KGRlc3RCaXRtYXBIZWlnaHQpOworICAgICAgICBpZiAoIXNy Y1JlY3QuZkxlZnQgJiYgIXNyY1JlY3QuZlRvcAorICAgICAgICAgICAgJiYgc3JjUmVjdC5mUmln aHQgPT0gYml0bWFwLT53aWR0aCgpICYmIHNyY1JlY3QuZkJvdHRvbSA9PSBiaXRtYXAtPmhlaWdo dCgpCisgICAgICAgICAgICAmJiAoYml0bWFwLT5oYXNSZXNpemVkQml0bWFwKGRlc3RJQml0bWFw V2lkdGgsIGRlc3RJQml0bWFwSGVpZ2h0KQorICAgICAgICAgICAgICAgIHx8IGJpdG1hcC0+c2hv dWxkQ2FjaGVSZXNhbXBsaW5nKGRlc3RCaXRtYXBXaWR0aCwgZGVzdEJpdG1hcEhlaWdodCwKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkZXN0Qml0bWFw V2lkdGgsIGRlc3RCaXRtYXBIZWlnaHQpKSkgeworICAgICAgICAgICAgLy8gcmVzaXplZEJpdG1h cCgpIGNhY2hlcyByZXNpemVkIGltYWdlLgorICAgICAgICAgICAgcmVzYW1wbGVkID0gYml0bWFw LT5yZXNpemVkQml0bWFwKGRlc3RCaXRtYXBXaWR0aCwgZGVzdEJpdG1hcEhlaWdodCk7CisgICAg ICAgIH0gZWxzZSB7CisgICAgICAgICAgICByZXNhbXBsZWQgPSBza2lhOjpJbWFnZU9wZXJhdGlv bnM6OlJlc2l6ZShzcmNTdWJzZXQsCisgICAgICAgICAgICAgICAgc2tpYTo6SW1hZ2VPcGVyYXRp b25zOjpSRVNJWkVfTEFOQ1pPUzMsCisgICAgICAgICAgICAgICAgc3RhdGljX2Nhc3Q8aW50Pihk ZXN0Qml0bWFwV2lkdGgpLAorICAgICAgICAgICAgICAgIHN0YXRpY19jYXN0PGludD4oZGVzdEJp dG1hcEhlaWdodCkpOworICAgICAgICB9CiAgICAgICAgIHNoYWRlciA9IFNrU2hhZGVyOjpDcmVh dGVCaXRtYXBTaGFkZXIocmVzYW1wbGVkLCBTa1NoYWRlcjo6a1JlcGVhdF9UaWxlTW9kZSwgU2tT aGFkZXI6OmtSZXBlYXRfVGlsZU1vZGUpOwogCiAgICAgICAgIC8vIFNpbmNlIHdlIGp1c3QgcmVz aXplZCB0aGUgYml0bWFwLCB3ZSBuZWVkIHRvIHVuZG8gdGhlIHNjYWxlIHNldCBpbgo= 56054 2010-05-13 20:48:40 -0700 2010-05-13 21:30:57 -0700 Patch WebKit-resize-caching.patch text/plain 2385 sergeyu ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZWFiMjRjYy4uMWIwN2RhNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNS0xMyAgU2VyZ2V5IFVsYW5v diAgPHNlcmdleXVAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEFkZGluZyByZXNpemVkIGltYWdlIGNhY2hpbmcgZm9yIFNraWEu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zOTA4NQor CisgICAgICAgIFRlc3RzOiBIVE1MNSB2aWRlbyBvbiBZb3VUdWJlLgorCisgICAgICAgICogcGxh dGZvcm0vZ3JhcGhpY3Mvc2tpYS9JbWFnZVNraWEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW1h Z2U6OmRyYXdQYXR0ZXJuKTogVXNlIGJpdG1hcC0+cmVzaXplZEJpdG1hcCgpIHRvIGNhY2hlIHJl c2l6ZWQgaW1hZ2Ugd2hlbiBwb3NzaWJsZS4KKwogMjAxMC0wNS0xMSAgTmlrb2xhcyBaaW1tZXJt YW5uICA8bnppbW1lcm1hbm5AcmltLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEaXJrIFNj aHVsemUuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvSW1hZ2VT a2lhLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9JbWFnZVNraWEuY3BwCmlu ZGV4IGIxYmZiZGQuLjIxODFmY2EgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3Mvc2tpYS9JbWFnZVNraWEuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tp YS9JbWFnZVNraWEuY3BwCkBAIC0zNDYsMTAgKzM0NiwyMiBAQCB2b2lkIEltYWdlOjpkcmF3UGF0 dGVybihHcmFwaGljc0NvbnRleHQqIGNvbnRleHQsCiAKICAgICBpZiAocmVzYW1wbGluZyA9PSBS RVNBTVBMRV9BV0VTT01FKSB7CiAgICAgICAgIC8vIERvIG5pY2UgcmVzYW1wbGluZy4KLSAgICAg ICAgU2tCaXRtYXAgcmVzYW1wbGVkID0gc2tpYTo6SW1hZ2VPcGVyYXRpb25zOjpSZXNpemUoc3Jj U3Vic2V0LAotICAgICAgICAgICAgc2tpYTo6SW1hZ2VPcGVyYXRpb25zOjpSRVNJWkVfTEFOQ1pP UzMsCi0gICAgICAgICAgICBzdGF0aWNfY2FzdDxpbnQ+KGRlc3RCaXRtYXBXaWR0aCksCi0gICAg ICAgICAgICBzdGF0aWNfY2FzdDxpbnQ+KGRlc3RCaXRtYXBIZWlnaHQpKTsKKyAgICAgICAgU2tC aXRtYXAgcmVzYW1wbGVkOworICAgICAgICBpbnQgZGVzdElCaXRtYXBXaWR0aCA9IHN0YXRpY19j YXN0PGludD4oZGVzdEJpdG1hcFdpZHRoKTsKKyAgICAgICAgaW50IGRlc3RJQml0bWFwSGVpZ2h0 ID0gc3RhdGljX2Nhc3Q8aW50PihkZXN0Qml0bWFwSGVpZ2h0KTsKKyAgICAgICAgaWYgKCFzcmNS ZWN0LmZMZWZ0ICYmICFzcmNSZWN0LmZUb3AKKyAgICAgICAgICAgICYmIHNyY1JlY3QuZlJpZ2h0 ID09IGJpdG1hcC0+d2lkdGgoKSAmJiBzcmNSZWN0LmZCb3R0b20gPT0gYml0bWFwLT5oZWlnaHQo KQorICAgICAgICAgICAgJiYgKGJpdG1hcC0+aGFzUmVzaXplZEJpdG1hcChkZXN0SUJpdG1hcFdp ZHRoLCBkZXN0SUJpdG1hcEhlaWdodCkKKyAgICAgICAgICAgICAgICB8fCBiaXRtYXAtPnNob3Vs ZENhY2hlUmVzYW1wbGluZyhkZXN0Qml0bWFwV2lkdGgsIGRlc3RCaXRtYXBIZWlnaHQsCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZGVzdEJpdG1hcFdp ZHRoLCBkZXN0Qml0bWFwSGVpZ2h0KSkpIHsKKyAgICAgICAgICAgIC8vIHJlc2l6ZWRCaXRtYXAo KSBjYWNoZXMgcmVzaXplZCBpbWFnZS4KKyAgICAgICAgICAgIHJlc2FtcGxlZCA9IGJpdG1hcC0+ cmVzaXplZEJpdG1hcChkZXN0Qml0bWFwV2lkdGgsIGRlc3RCaXRtYXBIZWlnaHQpOworICAgICAg ICB9IGVsc2UgeworICAgICAgICAgICAgcmVzYW1wbGVkID0gc2tpYTo6SW1hZ2VPcGVyYXRpb25z OjpSZXNpemUoc3JjU3Vic2V0LAorICAgICAgICAgICAgICAgIHNraWE6OkltYWdlT3BlcmF0aW9u czo6UkVTSVpFX0xBTkNaT1MzLAorICAgICAgICAgICAgICAgIHN0YXRpY19jYXN0PGludD4oZGVz dEJpdG1hcFdpZHRoKSwKKyAgICAgICAgICAgICAgICBzdGF0aWNfY2FzdDxpbnQ+KGRlc3RCaXRt YXBIZWlnaHQpKTsKKyAgICAgICAgfQogICAgICAgICBzaGFkZXIgPSBTa1NoYWRlcjo6Q3JlYXRl Qml0bWFwU2hhZGVyKHJlc2FtcGxlZCwgU2tTaGFkZXI6OmtSZXBlYXRfVGlsZU1vZGUsIFNrU2hh ZGVyOjprUmVwZWF0X1RpbGVNb2RlKTsKIAogICAgICAgICAvLyBTaW5jZSB3ZSBqdXN0IHJlc2l6 ZWQgdGhlIGJpdG1hcCwgd2UgbmVlZCB0byB1bmRvIHRoZSBzY2FsZSBzZXQgaW4K 56055 2010-05-13 21:30:57 -0700 2010-05-14 13:20:15 -0700 Patch. WebKit-resize-caching.patch text/plain 2141 sergeyu ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZWFiMjRjYy4uMWIwN2RhNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNS0xMyAgU2VyZ2V5IFVsYW5v diAgPHNlcmdleXVAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEFkZGluZyByZXNpemVkIGltYWdlIGNhY2hpbmcgZm9yIFNraWEu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zOTA4NQor CisgICAgICAgIFRlc3RzOiBIVE1MNSB2aWRlbyBvbiBZb3VUdWJlLgorCisgICAgICAgICogcGxh dGZvcm0vZ3JhcGhpY3Mvc2tpYS9JbWFnZVNraWEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW1h Z2U6OmRyYXdQYXR0ZXJuKTogVXNlIGJpdG1hcC0+cmVzaXplZEJpdG1hcCgpIHRvIGNhY2hlIHJl c2l6ZWQgaW1hZ2Ugd2hlbiBwb3NzaWJsZS4KKwogMjAxMC0wNS0xMSAgTmlrb2xhcyBaaW1tZXJt YW5uICA8bnppbW1lcm1hbm5AcmltLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEaXJrIFNj aHVsemUuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvSW1hZ2VT a2lhLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9JbWFnZVNraWEuY3BwCmlu ZGV4IGIxYmZiZGQuLjIxYmE5MzQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3Mvc2tpYS9JbWFnZVNraWEuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tp YS9JbWFnZVNraWEuY3BwCkBAIC0zNDYsMTAgKzM0NiwxOSBAQCB2b2lkIEltYWdlOjpkcmF3UGF0 dGVybihHcmFwaGljc0NvbnRleHQqIGNvbnRleHQsCiAKICAgICBpZiAocmVzYW1wbGluZyA9PSBS RVNBTVBMRV9BV0VTT01FKSB7CiAgICAgICAgIC8vIERvIG5pY2UgcmVzYW1wbGluZy4KLSAgICAg ICAgU2tCaXRtYXAgcmVzYW1wbGVkID0gc2tpYTo6SW1hZ2VPcGVyYXRpb25zOjpSZXNpemUoc3Jj U3Vic2V0LAotICAgICAgICAgICAgc2tpYTo6SW1hZ2VPcGVyYXRpb25zOjpSRVNJWkVfTEFOQ1pP UzMsCi0gICAgICAgICAgICBzdGF0aWNfY2FzdDxpbnQ+KGRlc3RCaXRtYXBXaWR0aCksCi0gICAg ICAgICAgICBzdGF0aWNfY2FzdDxpbnQ+KGRlc3RCaXRtYXBIZWlnaHQpKTsKKyAgICAgICAgU2tC aXRtYXAgcmVzYW1wbGVkOworICAgICAgICBpbnQgd2lkdGggPSBzdGF0aWNfY2FzdDxpbnQ+KGRl c3RCaXRtYXBXaWR0aCk7CisgICAgICAgIGludCBoZWlnaHQgPSBzdGF0aWNfY2FzdDxpbnQ+KGRl c3RCaXRtYXBIZWlnaHQpOworICAgICAgICBpZiAoIXNyY1JlY3QuZkxlZnQgJiYgIXNyY1JlY3Qu ZlRvcAorICAgICAgICAgICAgJiYgc3JjUmVjdC5mUmlnaHQgPT0gYml0bWFwLT53aWR0aCgpICYm IHNyY1JlY3QuZkJvdHRvbSA9PSBiaXRtYXAtPmhlaWdodCgpCisgICAgICAgICAgICAmJiAoYml0 bWFwLT5oYXNSZXNpemVkQml0bWFwKHdpZHRoLCBoZWlnaHQpCisgICAgICAgICAgICAgICAgfHwg Yml0bWFwLT5zaG91bGRDYWNoZVJlc2FtcGxpbmcod2lkdGgsIGhlaWdodCwgd2lkdGgsIGhlaWdo dCkpKSB7CisgICAgICAgICAgICAvLyByZXNpemVkQml0bWFwKCkgY2FjaGVzIHJlc2l6ZWQgaW1h Z2UuCisgICAgICAgICAgICByZXNhbXBsZWQgPSBiaXRtYXAtPnJlc2l6ZWRCaXRtYXAod2lkdGgs IGhlaWdodCk7CisgICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICByZXNhbXBsZWQgPSBza2lh OjpJbWFnZU9wZXJhdGlvbnM6OlJlc2l6ZShzcmNTdWJzZXQsCisgICAgICAgICAgICAgICAgc2tp YTo6SW1hZ2VPcGVyYXRpb25zOjpSRVNJWkVfTEFOQ1pPUzMsIHdpZHRoLCBoZWlnaHQpOworICAg ICAgICB9CiAgICAgICAgIHNoYWRlciA9IFNrU2hhZGVyOjpDcmVhdGVCaXRtYXBTaGFkZXIocmVz YW1wbGVkLCBTa1NoYWRlcjo6a1JlcGVhdF9UaWxlTW9kZSwgU2tTaGFkZXI6OmtSZXBlYXRfVGls ZU1vZGUpOwogCiAgICAgICAgIC8vIFNpbmNlIHdlIGp1c3QgcmVzaXplZCB0aGUgYml0bWFwLCB3 ZSBuZWVkIHRvIHVuZG8gdGhlIHNjYWxlIHNldCBpbgo=