39077 2010-05-13 11:05:13 -0700 Map RGBA4/RGB5_A1 to RGBA and RGB565 to RGB in RenderbufferStorage 2010-05-20 18:06:51 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 zmo zmo cmarrin commit-queue kbr oliver oldest_to_newest 225383 0 zmo 2010-05-13 11:05:13 -0700 The three supported internal color formats RGBA4/RGB5_A1/RGB565 may not be supported by Desktop OpenGL. We need to map them to general RGBA and RGB. 225499 1 56021 zmo 2010-05-13 14:16:00 -0700 Created attachment 56021 patch The same mapping is also added to command buffer implementation in Google Chrome. 225614 2 56021 kbr 2010-05-13 18:46:24 -0700 Comment on attachment 56021 patch Should we do a similar reverse mapping for getRenderbufferParameter(RENDERBUFFER_INTERNAL_FORMAT) so we don't return enums that are undefined or illegal in the WebGL spec? 226039 3 zmo 2010-05-14 15:55:06 -0700 (In reply to comment #2) > (From update of attachment 56021 [details]) > Should we do a similar reverse mapping for getRenderbufferParameter(RENDERBUFFER_INTERNAL_FORMAT) so we don't return enums that are undefined or illegal in the WebGL spec? I just checked and realized the code for reverse mapping is already in place (see WebGLRenderingContext::getRenderbufferParameter and WebGLRenderingContext::renderbufferStorage). It's added through this patch: https://bugs.webkit.org/show_bug.cgi?id=35611 226084 4 kbr 2010-05-14 18:02:53 -0700 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 56021 [details] [details]) > > Should we do a similar reverse mapping for getRenderbufferParameter(RENDERBUFFER_INTERNAL_FORMAT) so we don't return enums that are undefined or illegal in the WebGL spec? > > I just checked and realized the code for reverse mapping is already in place (see WebGLRenderingContext::getRenderbufferParameter and WebGLRenderingContext::renderbufferStorage). > > It's added through this patch: https://bugs.webkit.org/show_bug.cgi?id=35611 Right, I'd forgotten all about that. Looks good to me. 226951 5 56021 eric 2010-05-17 15:49:24 -0700 Comment on attachment 56021 patch Why so much copy/paste code in the layout test? 227027 6 56298 zmo 2010-05-17 18:01:19 -0700 Created attachment 56298 revised patch Reduced the code duplication in the test (responding to Eric Seidel's comment). 227044 7 56298 dglazkov 2010-05-17 18:42:20 -0700 Comment on attachment 56298 revised patch rs=me. 228666 8 56298 commit-queue 2010-05-20 18:06:46 -0700 Comment on attachment 56298 revised patch Clearing flags on attachment: 56298 Committed r59888: <http://trac.webkit.org/changeset/59888> 228667 9 commit-queue 2010-05-20 18:06:51 -0700 All reviewed patches have been landed. Closing bug. 56021 2010-05-13 14:16:00 -0700 2010-05-17 18:01:19 -0700 patch renderbuffer.patch text/plain 7143 zmo SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1OTM4NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMDUtMTMgIFpoZW55YW8gTW8gIDx6bW9AZ29vZ2xlLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYXAgUkdC QTQvUkdCNV9BMSB0byBSR0JBIGFuZCBSR0I1NjUgdG8gUkdCIGluIFJlbmRlcmJ1ZmZlclN0b3Jh Z2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5MDc3 CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9tYWMvR3JhcGhpY3NDb250ZXh0M0RNYWMu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0M0Q6OnJlbmRlcmJ1ZmZlclN0 b3JhZ2UpOiBNYXBwaW5nIHRoZSBlbnVtcy4KKwogMjAxMC0wNS0xMyAgRW5yaWNhIENhc3VjY2kg IDxlbnJpY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhdmUgSHlhdHQuCklu ZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21hYy9HcmFwaGljc0NvbnRleHQzRE1hYy5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMvR3JhcGhpY3ND b250ZXh0M0RNYWMuY3BwCShyZXZpc2lvbiA1OTM3MykKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvbWFjL0dyYXBoaWNzQ29udGV4dDNETWFjLmNwcAkod29ya2luZyBjb3B5KQpAQCAtODQw LDEwICs4NDAsMjEgQEAgdm9pZCBHcmFwaGljc0NvbnRleHQzRDo6cmVsZWFzZVNoYWRlckNvbQog dm9pZCBHcmFwaGljc0NvbnRleHQzRDo6cmVuZGVyYnVmZmVyU3RvcmFnZSh1bnNpZ25lZCBsb25n IHRhcmdldCwgdW5zaWduZWQgbG9uZyBpbnRlcm5hbGZvcm1hdCwgdW5zaWduZWQgbG9uZyB3aWR0 aCwgdW5zaWduZWQgbG9uZyBoZWlnaHQpCiB7CiAgICAgZW5zdXJlQ29udGV4dChtX2NvbnRleHRP YmopOwotICAgIGlmIChpbnRlcm5hbGZvcm1hdCA9PSBERVBUSF9TVEVOQ0lMKQorICAgIHN3aXRj aCAoaW50ZXJuYWxmb3JtYXQpIHsKKyAgICBjYXNlIERFUFRIX1NURU5DSUw6CiAgICAgICAgIGlu dGVybmFsZm9ybWF0ID0gR0xfREVQVEgyNF9TVEVOQ0lMOF9FWFQ7Ci0gICAgZWxzZSBpZiAoaW50 ZXJuYWxmb3JtYXQgPT0gREVQVEhfQ09NUE9ORU5UMTYpCisgICAgICAgIGJyZWFrOworICAgIGNh c2UgREVQVEhfQ09NUE9ORU5UMTY6CiAgICAgICAgIGludGVybmFsZm9ybWF0ID0gR0xfREVQVEhf Q09NUE9ORU5UOworICAgICAgICBicmVhazsKKyAgICBjYXNlIFJHQkE0OgorICAgIGNhc2UgUkdC NV9BMToKKyAgICAgICAgaW50ZXJuYWxmb3JtYXQgPSBHTF9SR0JBOworICAgICAgICBicmVhazsK KyAgICBjYXNlIFJHQjU2NToKKyAgICAgICAgaW50ZXJuYWxmb3JtYXQgPSBHTF9SR0I7CisgICAg ICAgIGJyZWFrOworICAgIH0KICAgICA6OmdsUmVuZGVyYnVmZmVyU3RvcmFnZUVYVCh0YXJnZXQs IGludGVybmFsZm9ybWF0LCB3aWR0aCwgaGVpZ2h0KTsKIH0KIApJbmRleDogV2ViS2l0L2Nocm9t aXVtL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShy ZXZpc2lvbiA1OTM4NSkKKysrIFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29w eSkKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wNS0xMyAgWmhlbnlhbyBNbyAgPHptb0Bnb29nbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1h cCBSR0JBNC9SR0I1X0ExIHRvIFJHQkEgYW5kIFJHQjU2NSB0byBSR0IgaW4gUmVuZGVyYnVmZmVy U3RvcmFnZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MzkwNzcKKworICAgICAgICAqIHNyYy9XZWJHcmFwaGljc0NvbnRleHQzRERlZmF1bHRJbXBsLmNw cDoKKyAgICAgICAgKFdlYktpdDo6V2ViR3JhcGhpY3NDb250ZXh0M0REZWZhdWx0SW1wbDo6cmVu ZGVyYnVmZmVyU3RvcmFnZSk6IE1hcHBpbmcgdGhlIGVudW1zLgorCiAyMDEwLTA1LTEzICBQYXZl bCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IFl1cnkgU2VtaWtoYXRza3kuCkluZGV4OiBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYkdyYXBoaWNz Q29udGV4dDNERGVmYXVsdEltcGwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9z cmMvV2ViR3JhcGhpY3NDb250ZXh0M0REZWZhdWx0SW1wbC5jcHAJKHJldmlzaW9uIDU5MzczKQor KysgV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJHcmFwaGljc0NvbnRleHQzRERlZmF1bHRJbXBsLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMTIxNSwxMCArMTIxNSwyMSBAQCB2b2lkIFdlYkdyYXBoaWNz Q29udGV4dDNERGVmYXVsdEltcGw6OnJlCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgbG9uZyBoZWlnaHQpCiB7CiAgICAg bWFrZUNvbnRleHRDdXJyZW50KCk7Ci0gICAgaWYgKGludGVybmFsZm9ybWF0ID09IEdMX0RFUFRI X1NURU5DSUwpCisgICAgc3dpdGNoIChpbnRlcm5hbGZvcm1hdCkgeworICAgIGNhc2UgR0xfREVQ VEhfU1RFTkNJTDoKICAgICAgICAgaW50ZXJuYWxmb3JtYXQgPSBHTF9ERVBUSDI0X1NURU5DSUw4 X0VYVDsKLSAgICBlbHNlIGlmIChpbnRlcm5hbGZvcm1hdCA9PSBHTF9ERVBUSF9DT01QT05FTlQx NikKKyAgICAgICAgYnJlYWs7CisgICAgY2FzZSBHTF9ERVBUSF9DT01QT05FTlQxNjoKICAgICAg ICAgaW50ZXJuYWxmb3JtYXQgPSBHTF9ERVBUSF9DT01QT05FTlQ7CisgICAgICAgIGJyZWFrOwor ICAgIGNhc2UgR0xfUkdCQTQ6CisgICAgY2FzZSBHTF9SR0I1X0ExOgorICAgICAgICBpbnRlcm5h bGZvcm1hdCA9IEdMX1JHQkE7CisgICAgICAgIGJyZWFrOworICAgIGNhc2UgMHg4RDYyOiAvLyBH TF9SR0I1NjUKKyAgICAgICAgaW50ZXJuYWxmb3JtYXQgPSBHTF9SR0I7CisgICAgICAgIGJyZWFr OworICAgIH0KICAgICBnbFJlbmRlcmJ1ZmZlclN0b3JhZ2VFWFQodGFyZ2V0LCBpbnRlcm5hbGZv cm1hdCwgd2lkdGgsIGhlaWdodCk7CiB9CiAKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDU5Mzg1KQorKysg TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIw MTAtMDUtMTMgIFpoZW55YW8gTW8gIDx6bW9AZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYXAgUkdCQTQvUkdCNV9BMSB0byBSR0JB IGFuZCBSR0I1NjUgdG8gUkdCIGluIFJlbmRlcmJ1ZmZlclN0b3JhZ2UKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5MDc3CisKKyAgICAgICAgKiBmYXN0 L2NhbnZhcy93ZWJnbC9mcmFtZWJ1ZmZlci1vYmplY3QtYXR0YWNobWVudC1leHBlY3RlZC50eHQ6 IEFkZCB0aGUgdGVzdCBjYXNlcyBmb3IgY29sb3IgcmVuZGVyYnVmZmVyIGNyZWF0aW9uIGFuZCBh dHRhY2htZW50IHRvIGZyYW1lYnVmZmVyLgorICAgICAgICAqIGZhc3QvY2FudmFzL3dlYmdsL2Zy YW1lYnVmZmVyLW9iamVjdC1hdHRhY2htZW50Lmh0bWw6IERpdHRvLgorCiAyMDEwLTA1LTEzICBF bnJpY2EgQ2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg RGF2ZSBIeWF0dC4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL2ZyYW1lYnVm ZmVyLW9iamVjdC1hdHRhY2htZW50LWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC9mcmFtZWJ1ZmZlci1vYmplY3QtYXR0YWNobWVudC1leHBl Y3RlZC50eHQJKHJldmlzaW9uIDU5MzczKQorKysgTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2Vi Z2wvZnJhbWVidWZmZXItb2JqZWN0LWF0dGFjaG1lbnQtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNv cHkpCkBAIC03Myw2ICs3MywyMSBAQCBQQVNTIGdsLmdldEVycm9yKCkgaXMgZ2wuTk9fRVJST1IK IFBBU1MgZ2wuZ2V0RXJyb3IoKSBpcyBnbC5JTlZBTElEX09QRVJBVElPTgogUEFTUyBnbC5nZXRF cnJvcigpIGlzIGdsLk5PX0VSUk9SCiBQQVNTIGdsLmdldEVycm9yKCkgaXMgZ2wuTk9fRVJST1IK K0F0dGFjaCBjb2xvciByZW5kZXJidWZmZXIgd2l0aCBpbnRlcm5hbGZvcm1hdCA9PSBSR0JBNAor UEFTUyBjb2xvckJ1ZmZlciA9IGdsLmNyZWF0ZVJlbmRlcmJ1ZmZlcigpIGlzIG5vbi1udWxsLgor UEFTUyBnbC5nZXRFcnJvcigpIGlzIGdsLk5PX0VSUk9SCitQQVNTIGZibyA9IGdsLmNyZWF0ZUZy YW1lYnVmZmVyKCkgaXMgbm9uLW51bGwuCitQQVNTIGdsLmdldEVycm9yKCkgaXMgZ2wuTk9fRVJS T1IKK0F0dGFjaCBjb2xvciByZW5kZXJidWZmZXIgd2l0aCBpbnRlcm5hbGZvcm1hdCA9PSBSR0I1 X0ExCitQQVNTIGNvbG9yQnVmZmVyID0gZ2wuY3JlYXRlUmVuZGVyYnVmZmVyKCkgaXMgbm9uLW51 bGwuCitQQVNTIGdsLmdldEVycm9yKCkgaXMgZ2wuTk9fRVJST1IKK1BBU1MgZmJvID0gZ2wuY3Jl YXRlRnJhbWVidWZmZXIoKSBpcyBub24tbnVsbC4KK1BBU1MgZ2wuZ2V0RXJyb3IoKSBpcyBnbC5O T19FUlJPUgorQXR0YWNoIGNvbG9yIHJlbmRlcmJ1ZmZlciB3aXRoIGludGVybmFsZm9ybWF0ID09 IFJHQjU2NQorUEFTUyBjb2xvckJ1ZmZlciA9IGdsLmNyZWF0ZVJlbmRlcmJ1ZmZlcigpIGlzIG5v bi1udWxsLgorUEFTUyBnbC5nZXRFcnJvcigpIGlzIGdsLk5PX0VSUk9SCitQQVNTIGZibyA9IGds LmNyZWF0ZUZyYW1lYnVmZmVyKCkgaXMgbm9uLW51bGwuCitQQVNTIGdsLmdldEVycm9yKCkgaXMg Z2wuTk9fRVJST1IKIFBBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKIAogVEVTVCBDT01Q TEVURQpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvZnJhbWVidWZmZXItb2Jq ZWN0LWF0dGFjaG1lbnQuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2NhbnZh cy93ZWJnbC9mcmFtZWJ1ZmZlci1vYmplY3QtYXR0YWNobWVudC5odG1sCShyZXZpc2lvbiA1OTM3 MykKKysrIExheW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL2ZyYW1lYnVmZmVyLW9iamVjdC1h dHRhY2htZW50Lmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTE1LDYgKzE1LDcgQEAgdmFyIGZibzsK IHZhciBkZXB0aEJ1ZmZlcjsKIHZhciBzdGVuY2lsQnVmZmVyOwogdmFyIGRlcHRoU3RlbmNpbEJ1 ZmZlcjsKK3ZhciBjb2xvckJ1ZmZlcjsKIHZhciB3aWR0aCA9IDI7CiB2YXIgaGVpZ2h0ID0gMjsK IApAQCAtOTIsNiArOTMsMjcgQEAgdGVzdEF0dGFjaG1lbnRzKGdsLkRFUFRIX0FUVEFDSE1FTlQs IGRlcAogZGVidWcoIkF0dGFjaCBkZXB0aFN0ZW5jaWwsIHRoZW4gc3RlbmNpbCwgY2F1c2luZyBj b25mbGljdCIpOwogdGVzdEF0dGFjaG1lbnRzKGdsLkRFUFRIX1NURU5DSUxfQVRUQUNITUVOVCwg ZGVwdGhTdGVuY2lsQnVmZmVyLCBnbC5TVEVOQ0lMX0FUVEFDSE1FTlQsIHN0ZW5jaWxCdWZmZXIs IHRydWUpOwogCitkZWJ1ZygiQXR0YWNoIGNvbG9yIHJlbmRlcmJ1ZmZlciB3aXRoIGludGVybmFs Zm9ybWF0ID09IFJHQkE0Iik7CitzaG91bGRCZU5vbk51bGwoImNvbG9yQnVmZmVyID0gZ2wuY3Jl YXRlUmVuZGVyYnVmZmVyKCkiKTsKK2dsLmJpbmRSZW5kZXJidWZmZXIoZ2wuUkVOREVSQlVGRkVS LCBjb2xvckJ1ZmZlcik7CitnbC5yZW5kZXJidWZmZXJTdG9yYWdlKGdsLlJFTkRFUkJVRkZFUiwg Z2wuUkdCQTQsIHdpZHRoLCBoZWlnaHQpOworc2hvdWxkQmUoImdsLmdldEVycm9yKCkiLCAiZ2wu Tk9fRVJST1IiKTsKK3Rlc3RBdHRhY2htZW50KGdsLkNPTE9SX0FUVEFDSE1FTlQwLCBjb2xvckJ1 ZmZlciwgZmFsc2UpOworCitkZWJ1ZygiQXR0YWNoIGNvbG9yIHJlbmRlcmJ1ZmZlciB3aXRoIGlu dGVybmFsZm9ybWF0ID09IFJHQjVfQTEiKTsKK3Nob3VsZEJlTm9uTnVsbCgiY29sb3JCdWZmZXIg PSBnbC5jcmVhdGVSZW5kZXJidWZmZXIoKSIpOworZ2wuYmluZFJlbmRlcmJ1ZmZlcihnbC5SRU5E RVJCVUZGRVIsIGNvbG9yQnVmZmVyKTsKK2dsLnJlbmRlcmJ1ZmZlclN0b3JhZ2UoZ2wuUkVOREVS QlVGRkVSLCBnbC5SR0I1X0ExLCB3aWR0aCwgaGVpZ2h0KTsKK3Nob3VsZEJlKCJnbC5nZXRFcnJv cigpIiwgImdsLk5PX0VSUk9SIik7Cit0ZXN0QXR0YWNobWVudChnbC5DT0xPUl9BVFRBQ0hNRU5U MCwgY29sb3JCdWZmZXIsIGZhbHNlKTsKKworZGVidWcoIkF0dGFjaCBjb2xvciByZW5kZXJidWZm ZXIgd2l0aCBpbnRlcm5hbGZvcm1hdCA9PSBSR0I1NjUiKTsKK3Nob3VsZEJlTm9uTnVsbCgiY29s b3JCdWZmZXIgPSBnbC5jcmVhdGVSZW5kZXJidWZmZXIoKSIpOworZ2wuYmluZFJlbmRlcmJ1ZmZl cihnbC5SRU5ERVJCVUZGRVIsIGNvbG9yQnVmZmVyKTsKK2dsLnJlbmRlcmJ1ZmZlclN0b3JhZ2Uo Z2wuUkVOREVSQlVGRkVSLCBnbC5SR0I1NjUsIHdpZHRoLCBoZWlnaHQpOworc2hvdWxkQmUoImds LmdldEVycm9yKCkiLCAiZ2wuTk9fRVJST1IiKTsKK3Rlc3RBdHRhY2htZW50KGdsLkNPTE9SX0FU VEFDSE1FTlQwLCBjb2xvckJ1ZmZlciwgZmFsc2UpOworCiBzdWNjZXNzZnVsbHlQYXJzZWQgPSB0 cnVlOwogPC9zY3JpcHQ+CiAK 56298 2010-05-17 18:01:19 -0700 2010-05-20 18:06:45 -0700 revised patch renderbuffer.patch text/plain 6936 zmo SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1OTM4NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMDUtMTMgIFpoZW55YW8gTW8gIDx6bW9AZ29vZ2xlLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYXAgUkdC QTQvUkdCNV9BMSB0byBSR0JBIGFuZCBSR0I1NjUgdG8gUkdCIGluIFJlbmRlcmJ1ZmZlclN0b3Jh Z2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5MDc3 CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9tYWMvR3JhcGhpY3NDb250ZXh0M0RNYWMu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0M0Q6OnJlbmRlcmJ1ZmZlclN0 b3JhZ2UpOiBNYXBwaW5nIHRoZSBlbnVtcy4KKwogMjAxMC0wNS0xMyAgRW5yaWNhIENhc3VjY2kg IDxlbnJpY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhdmUgSHlhdHQuCklu ZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21hYy9HcmFwaGljc0NvbnRleHQzRE1hYy5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMvR3JhcGhpY3ND b250ZXh0M0RNYWMuY3BwCShyZXZpc2lvbiA1OTM3MykKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvbWFjL0dyYXBoaWNzQ29udGV4dDNETWFjLmNwcAkod29ya2luZyBjb3B5KQpAQCAtODQw LDEwICs4NDAsMjEgQEAgdm9pZCBHcmFwaGljc0NvbnRleHQzRDo6cmVsZWFzZVNoYWRlckNvbQog dm9pZCBHcmFwaGljc0NvbnRleHQzRDo6cmVuZGVyYnVmZmVyU3RvcmFnZSh1bnNpZ25lZCBsb25n IHRhcmdldCwgdW5zaWduZWQgbG9uZyBpbnRlcm5hbGZvcm1hdCwgdW5zaWduZWQgbG9uZyB3aWR0 aCwgdW5zaWduZWQgbG9uZyBoZWlnaHQpCiB7CiAgICAgZW5zdXJlQ29udGV4dChtX2NvbnRleHRP YmopOwotICAgIGlmIChpbnRlcm5hbGZvcm1hdCA9PSBERVBUSF9TVEVOQ0lMKQorICAgIHN3aXRj aCAoaW50ZXJuYWxmb3JtYXQpIHsKKyAgICBjYXNlIERFUFRIX1NURU5DSUw6CiAgICAgICAgIGlu dGVybmFsZm9ybWF0ID0gR0xfREVQVEgyNF9TVEVOQ0lMOF9FWFQ7Ci0gICAgZWxzZSBpZiAoaW50 ZXJuYWxmb3JtYXQgPT0gREVQVEhfQ09NUE9ORU5UMTYpCisgICAgICAgIGJyZWFrOworICAgIGNh c2UgREVQVEhfQ09NUE9ORU5UMTY6CiAgICAgICAgIGludGVybmFsZm9ybWF0ID0gR0xfREVQVEhf Q09NUE9ORU5UOworICAgICAgICBicmVhazsKKyAgICBjYXNlIFJHQkE0OgorICAgIGNhc2UgUkdC NV9BMToKKyAgICAgICAgaW50ZXJuYWxmb3JtYXQgPSBHTF9SR0JBOworICAgICAgICBicmVhazsK KyAgICBjYXNlIFJHQjU2NToKKyAgICAgICAgaW50ZXJuYWxmb3JtYXQgPSBHTF9SR0I7CisgICAg ICAgIGJyZWFrOworICAgIH0KICAgICA6OmdsUmVuZGVyYnVmZmVyU3RvcmFnZUVYVCh0YXJnZXQs IGludGVybmFsZm9ybWF0LCB3aWR0aCwgaGVpZ2h0KTsKIH0KIApJbmRleDogV2ViS2l0L2Nocm9t aXVtL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShy ZXZpc2lvbiA1OTM4NSkKKysrIFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29w eSkKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wNS0xMyAgWmhlbnlhbyBNbyAgPHptb0Bnb29nbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1h cCBSR0JBNC9SR0I1X0ExIHRvIFJHQkEgYW5kIFJHQjU2NSB0byBSR0IgaW4gUmVuZGVyYnVmZmVy U3RvcmFnZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MzkwNzcKKworICAgICAgICAqIHNyYy9XZWJHcmFwaGljc0NvbnRleHQzRERlZmF1bHRJbXBsLmNw cDoKKyAgICAgICAgKFdlYktpdDo6V2ViR3JhcGhpY3NDb250ZXh0M0REZWZhdWx0SW1wbDo6cmVu ZGVyYnVmZmVyU3RvcmFnZSk6IE1hcHBpbmcgdGhlIGVudW1zLgorCiAyMDEwLTA1LTEzICBQYXZl bCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IFl1cnkgU2VtaWtoYXRza3kuCkluZGV4OiBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYkdyYXBoaWNz Q29udGV4dDNERGVmYXVsdEltcGwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9z cmMvV2ViR3JhcGhpY3NDb250ZXh0M0REZWZhdWx0SW1wbC5jcHAJKHJldmlzaW9uIDU5MzczKQor KysgV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJHcmFwaGljc0NvbnRleHQzRERlZmF1bHRJbXBsLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMTIxNSwxMCArMTIxNSwyMSBAQCB2b2lkIFdlYkdyYXBoaWNz Q29udGV4dDNERGVmYXVsdEltcGw6OnJlCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgbG9uZyBoZWlnaHQpCiB7CiAgICAg bWFrZUNvbnRleHRDdXJyZW50KCk7Ci0gICAgaWYgKGludGVybmFsZm9ybWF0ID09IEdMX0RFUFRI X1NURU5DSUwpCisgICAgc3dpdGNoIChpbnRlcm5hbGZvcm1hdCkgeworICAgIGNhc2UgR0xfREVQ VEhfU1RFTkNJTDoKICAgICAgICAgaW50ZXJuYWxmb3JtYXQgPSBHTF9ERVBUSDI0X1NURU5DSUw4 X0VYVDsKLSAgICBlbHNlIGlmIChpbnRlcm5hbGZvcm1hdCA9PSBHTF9ERVBUSF9DT01QT05FTlQx NikKKyAgICAgICAgYnJlYWs7CisgICAgY2FzZSBHTF9ERVBUSF9DT01QT05FTlQxNjoKICAgICAg ICAgaW50ZXJuYWxmb3JtYXQgPSBHTF9ERVBUSF9DT01QT05FTlQ7CisgICAgICAgIGJyZWFrOwor ICAgIGNhc2UgR0xfUkdCQTQ6CisgICAgY2FzZSBHTF9SR0I1X0ExOgorICAgICAgICBpbnRlcm5h bGZvcm1hdCA9IEdMX1JHQkE7CisgICAgICAgIGJyZWFrOworICAgIGNhc2UgMHg4RDYyOiAvLyBH TF9SR0I1NjUKKyAgICAgICAgaW50ZXJuYWxmb3JtYXQgPSBHTF9SR0I7CisgICAgICAgIGJyZWFr OworICAgIH0KICAgICBnbFJlbmRlcmJ1ZmZlclN0b3JhZ2VFWFQodGFyZ2V0LCBpbnRlcm5hbGZv cm1hdCwgd2lkdGgsIGhlaWdodCk7CiB9CiAKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDU5Mzg1KQorKysg TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIw MTAtMDUtMTMgIFpoZW55YW8gTW8gIDx6bW9AZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYXAgUkdCQTQvUkdCNV9BMSB0byBSR0JB IGFuZCBSR0I1NjUgdG8gUkdCIGluIFJlbmRlcmJ1ZmZlclN0b3JhZ2UKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5MDc3CisKKyAgICAgICAgKiBmYXN0 L2NhbnZhcy93ZWJnbC9mcmFtZWJ1ZmZlci1vYmplY3QtYXR0YWNobWVudC1leHBlY3RlZC50eHQ6 IEFkZCB0aGUgdGVzdCBjYXNlcyBmb3IgY29sb3IgcmVuZGVyYnVmZmVyIGNyZWF0aW9uIGFuZCBh dHRhY2htZW50IHRvIGZyYW1lYnVmZmVyLgorICAgICAgICAqIGZhc3QvY2FudmFzL3dlYmdsL2Zy YW1lYnVmZmVyLW9iamVjdC1hdHRhY2htZW50Lmh0bWw6IERpdHRvLgorCiAyMDEwLTA1LTEzICBF bnJpY2EgQ2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg RGF2ZSBIeWF0dC4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL2ZyYW1lYnVm ZmVyLW9iamVjdC1hdHRhY2htZW50LWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC9mcmFtZWJ1ZmZlci1vYmplY3QtYXR0YWNobWVudC1leHBl Y3RlZC50eHQJKHJldmlzaW9uIDU5MzczKQorKysgTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2Vi Z2wvZnJhbWVidWZmZXItb2JqZWN0LWF0dGFjaG1lbnQtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNv cHkpCkBAIC03Myw2ICs3MywyMSBAQCBQQVNTIGdsLmdldEVycm9yKCkgaXMgZ2wuTk9fRVJST1IK IFBBU1MgZ2wuZ2V0RXJyb3IoKSBpcyBnbC5JTlZBTElEX09QRVJBVElPTgogUEFTUyBnbC5nZXRF cnJvcigpIGlzIGdsLk5PX0VSUk9SCiBQQVNTIGdsLmdldEVycm9yKCkgaXMgZ2wuTk9fRVJST1IK K0F0dGFjaCBjb2xvciByZW5kZXJidWZmZXIgd2l0aCBpbnRlcm5hbGZvcm1hdCA9PSBSR0JBNAor UEFTUyBjb2xvckJ1ZmZlciA9IGdsLmNyZWF0ZVJlbmRlcmJ1ZmZlcigpIGlzIG5vbi1udWxsLgor UEFTUyBnbC5nZXRFcnJvcigpIGlzIGdsLk5PX0VSUk9SCitQQVNTIGZibyA9IGdsLmNyZWF0ZUZy YW1lYnVmZmVyKCkgaXMgbm9uLW51bGwuCitQQVNTIGdsLmdldEVycm9yKCkgaXMgZ2wuTk9fRVJS T1IKK0F0dGFjaCBjb2xvciByZW5kZXJidWZmZXIgd2l0aCBpbnRlcm5hbGZvcm1hdCA9PSBSR0I1 X0ExCitQQVNTIGNvbG9yQnVmZmVyID0gZ2wuY3JlYXRlUmVuZGVyYnVmZmVyKCkgaXMgbm9uLW51 bGwuCitQQVNTIGdsLmdldEVycm9yKCkgaXMgZ2wuTk9fRVJST1IKK1BBU1MgZmJvID0gZ2wuY3Jl YXRlRnJhbWVidWZmZXIoKSBpcyBub24tbnVsbC4KK1BBU1MgZ2wuZ2V0RXJyb3IoKSBpcyBnbC5O T19FUlJPUgorQXR0YWNoIGNvbG9yIHJlbmRlcmJ1ZmZlciB3aXRoIGludGVybmFsZm9ybWF0ID09 IFJHQjU2NQorUEFTUyBjb2xvckJ1ZmZlciA9IGdsLmNyZWF0ZVJlbmRlcmJ1ZmZlcigpIGlzIG5v bi1udWxsLgorUEFTUyBnbC5nZXRFcnJvcigpIGlzIGdsLk5PX0VSUk9SCitQQVNTIGZibyA9IGds LmNyZWF0ZUZyYW1lYnVmZmVyKCkgaXMgbm9uLW51bGwuCitQQVNTIGdsLmdldEVycm9yKCkgaXMg Z2wuTk9fRVJST1IKIFBBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKIAogVEVTVCBDT01Q TEVURQpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvZnJhbWVidWZmZXItb2Jq ZWN0LWF0dGFjaG1lbnQuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2NhbnZh cy93ZWJnbC9mcmFtZWJ1ZmZlci1vYmplY3QtYXR0YWNobWVudC5odG1sCShyZXZpc2lvbiA1OTM3 MykKKysrIExheW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL2ZyYW1lYnVmZmVyLW9iamVjdC1h dHRhY2htZW50Lmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTE1LDYgKzE1LDcgQEAgdmFyIGZibzsK IHZhciBkZXB0aEJ1ZmZlcjsKIHZhciBzdGVuY2lsQnVmZmVyOwogdmFyIGRlcHRoU3RlbmNpbEJ1 ZmZlcjsKK3ZhciBjb2xvckJ1ZmZlcjsKIHZhciB3aWR0aCA9IDI7CiB2YXIgaGVpZ2h0ID0gMjsK IApAQCAtNDMsNiArNDQsMTUgQEAgZnVuY3Rpb24gdGVzdEF0dGFjaG1lbnRzKGF0dGFjaG1lbnQw LCBidQogICAgIH0KIH0KIAorZnVuY3Rpb24gdGVzdENvbG9yUmVuZGVyYnVmZmVyKGludGVybmFs Zm9ybWF0KQoreworICAgIHNob3VsZEJlTm9uTnVsbCgiY29sb3JCdWZmZXIgPSBnbC5jcmVhdGVS ZW5kZXJidWZmZXIoKSIpOworICAgIGdsLmJpbmRSZW5kZXJidWZmZXIoZ2wuUkVOREVSQlVGRkVS LCBjb2xvckJ1ZmZlcik7CisgICAgZ2wucmVuZGVyYnVmZmVyU3RvcmFnZShnbC5SRU5ERVJCVUZG RVIsIGludGVybmFsZm9ybWF0LCB3aWR0aCwgaGVpZ2h0KTsKKyAgICBzaG91bGRCZSgiZ2wuZ2V0 RXJyb3IoKSIsICJnbC5OT19FUlJPUiIpOworICAgIHRlc3RBdHRhY2htZW50KGdsLkNPTE9SX0FU VEFDSE1FTlQwLCBjb2xvckJ1ZmZlciwgZmFsc2UpOworfQorCiBkZXNjcmlwdGlvbigiVGVzdCBm cmFtZWJ1ZmZlciBvYmplY3QgYXR0YWNobWVudCBiZWhhdmlvcnMiKTsKIAogZGVidWcoIkNyZWF0 ZSByZW5kZXJidWZmZXJzIik7CkBAIC05Miw2ICsxMDIsMTUgQEAgdGVzdEF0dGFjaG1lbnRzKGds LkRFUFRIX0FUVEFDSE1FTlQsIGRlcAogZGVidWcoIkF0dGFjaCBkZXB0aFN0ZW5jaWwsIHRoZW4g c3RlbmNpbCwgY2F1c2luZyBjb25mbGljdCIpOwogdGVzdEF0dGFjaG1lbnRzKGdsLkRFUFRIX1NU RU5DSUxfQVRUQUNITUVOVCwgZGVwdGhTdGVuY2lsQnVmZmVyLCBnbC5TVEVOQ0lMX0FUVEFDSE1F TlQsIHN0ZW5jaWxCdWZmZXIsIHRydWUpOwogCitkZWJ1ZygiQXR0YWNoIGNvbG9yIHJlbmRlcmJ1 ZmZlciB3aXRoIGludGVybmFsZm9ybWF0ID09IFJHQkE0Iik7Cit0ZXN0Q29sb3JSZW5kZXJidWZm ZXIoZ2wuUkdCQTQpOworCitkZWJ1ZygiQXR0YWNoIGNvbG9yIHJlbmRlcmJ1ZmZlciB3aXRoIGlu dGVybmFsZm9ybWF0ID09IFJHQjVfQTEiKTsKK3Rlc3RDb2xvclJlbmRlcmJ1ZmZlcihnbC5SR0I1 X0ExKTsKKworZGVidWcoIkF0dGFjaCBjb2xvciByZW5kZXJidWZmZXIgd2l0aCBpbnRlcm5hbGZv cm1hdCA9PSBSR0I1NjUiKTsKK3Rlc3RDb2xvclJlbmRlcmJ1ZmZlcihnbC5SR0I1NjUpOworCiBz dWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOwogPC9zY3JpcHQ+CiAK