39074 2010-05-13 10:00:49 -0700 Web Inspector: Event Markers should be hidden in Resource's "Size" Graph 2010-05-13 10:28:36 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 joepeck joepeck bweinstein joepeck keishi pfeldman pmuellr rik timothy yurys oldest_to_newest 225354 0 joepeck 2010-05-13 10:00:49 -0700 Event markers make no sense in the Size graph. Patch to follow. 225355 1 55992 joepeck 2010-05-13 10:06:45 -0700 Created attachment 55992 [PATCH] Add Show/Hide functionality to Event Dividers in Timeline Graph These were already designed very nicely to be contained in a <div>. Great forethought! 225358 2 55992 pfeldman 2010-05-13 10:10:48 -0700 Comment on attachment 55992 [PATCH] Add Show/Hide functionality to Event Dividers in Timeline Graph r+ with nits. WebCore/inspector/front-end/TimelineGrid.js:153 + this._eventDividersElement.style.display = "none"; Timothy likes add/removeStyleClass("hidden"). You don't need dedicated methods for it too... 225368 3 joepeck 2010-05-13 10:28:36 -0700 > WebCore/inspector/front-end/TimelineGrid.js:153 > > + this._eventDividersElement.style.display = "none"; > Timothy likes add/removeStyleClass("hidden"). Done. Committed r59372 M WebCore/ChangeLog M WebCore/inspector/front-end/TimelineGrid.js M WebCore/inspector/front-end/ResourcesPanel.js M WebCore/inspector/front-end/AbstractTimelinePanel.js r59372 = 6c5ad77bbc072a3a315726f172304fd7cde898d4 (refs/remotes/trunk) http://trac.webkit.org/changeset/59372 55992 2010-05-13 10:06:45 -0700 2010-05-13 10:10:48 -0700 [PATCH] Add Show/Hide functionality to Event Dividers in Timeline Graph markers.patch text/plain 5276 joepeck ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YzFmYmU3Zi4uNDAyZmNhMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMyBAQAorMjAxMC0wNS0xMyAgSm9zZXBoIFBlY29y YXJvICA8am9lcGVja0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IEV2ZW50IE1hcmtlcnMgc2hvdWxkIGJl IGhpZGRlbiBpbiBSZXNvdXJjZSdzICJTaXplIiBHcmFwaAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzkwNzQKKworICAgICAgICBBZGRlZCBTaG93IC8g SGlkZSBldmVudCBkaXZpZGVycyBmdW5jdGlvbmFsaXR5IHRvIHRoZSB0aW1lbGluZSBncmlkLAor ICAgICAgICBhbmQgaW5jbHVkZWQgZGVsZWdhdGlvbiBmdW5jdGlvbnMgaW4gQWJzdHJhY3RUaW1l bGluZVBhbmVsLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9BYnN0cmFjdFRpbWVs aW5lUGFuZWwuanM6IGRlbGVnYXRlIHRvIHRoZSBpbm5lciBncmlkCisgICAgICAgIChXZWJJbnNw ZWN0b3IuQWJzdHJhY3RUaW1lbGluZVBhbmVsLnByb3RvdHlwZS5oaWRlRXZlbnREaXZpZGVycyk6 CisgICAgICAgIChXZWJJbnNwZWN0b3IuQWJzdHJhY3RUaW1lbGluZVBhbmVsLnByb3RvdHlwZS5z aG93RXZlbnREaXZpZGVycyk6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9SZXNvdXJj ZXNQYW5lbC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5SZXNvdXJjZXNQYW5lbC5wcm90b3R5 cGUucG9wdWxhdGVTaWRlYmFyKTogc2F2ZSBhIHJlZmVyZW5jZSB0byB0aGUgc2l6ZSBncmFwaCBp dGVtIHRvIGtub3cgd2hlbiBpdHMgc2VsZWN0ZWQKKyAgICAgICAgKFdlYkluc3BlY3Rvci5SZXNv dXJjZXNQYW5lbC5wcm90b3R5cGUuX2dyYXBoU2VsZWN0ZWQpOiBpZiB0aGUgc2l6ZSBncmFwaCBp cyBzZWxlY3RlZCBoaWRlIHRoZSBkaXZpZGVycywgb3RoZXJ3aXNlIHNob3cgdGhlbQorICAgICAg ICAqIGluc3BlY3Rvci9mcm9udC1lbmQvVGltZWxpbmVHcmlkLmpzOgorICAgICAgICAoV2ViSW5z cGVjdG9yLlRpbWVsaW5lR3JpZC5wcm90b3R5cGUuaGlkZUV2ZW50RGl2aWRlcnMpOiBzZXQgdGhl IGNvbnRhaW5lciB0byBkaXNwbGF5OiBub25lCisgICAgICAgIChXZWJJbnNwZWN0b3IuVGltZWxp bmVHcmlkLnByb3RvdHlwZS5zaG93RXZlbnREaXZpZGVycyk6IHNldCB0aGUgY29udGFpbmVyIHRv IGRpc3BsYXk6IGJsb2NrCisKIDIwMTAtMDUtMTEgIEpvc2VwaCBQZWNvcmFybyAgPGpvZXBlY2tA d2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBUaW1vdGh5IEhhdGNoZXIuCmRpZmYg LS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQWJzdHJhY3RUaW1lbGluZVBhbmVs LmpzIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0Fic3RyYWN0VGltZWxpbmVQYW5lbC5q cwppbmRleCBjZmVjOWRhLi5lYjllYTg4IDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvQWJzdHJhY3RUaW1lbGluZVBhbmVsLmpzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9y L2Zyb250LWVuZC9BYnN0cmFjdFRpbWVsaW5lUGFuZWwuanMKQEAgLTQyNCw2ICs0MjQsMTYgQEAg V2ViSW5zcGVjdG9yLkFic3RyYWN0VGltZWxpbmVQYW5lbC5wcm90b3R5cGUgPSB7CiAgICAgYWRk RXZlbnREaXZpZGVyOiBmdW5jdGlvbihkaXZpZGVyKQogICAgIHsKICAgICAgICAgdGhpcy5fdGlt ZWxpbmVHcmlkLmFkZEV2ZW50RGl2aWRlcihkaXZpZGVyKTsKKyAgICB9LAorCisgICAgaGlkZUV2 ZW50RGl2aWRlcnM6IGZ1bmN0aW9uKCkKKyAgICB7CisgICAgICAgIHRoaXMuX3RpbWVsaW5lR3Jp ZC5oaWRlRXZlbnREaXZpZGVycygpOworICAgIH0sCisKKyAgICBzaG93RXZlbnREaXZpZGVyczog ZnVuY3Rpb24oKQorICAgIHsKKyAgICAgICAgdGhpcy5fdGltZWxpbmVHcmlkLnNob3dFdmVudERp dmlkZXJzKCk7CiAgICAgfQogfQogCmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvUmVzb3VyY2VzUGFuZWwuanMgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvUmVz b3VyY2VzUGFuZWwuanMKaW5kZXggYTYyOTk0ZS4uN2ExNTk1OSAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Jlc291cmNlc1BhbmVsLmpzCisrKyBiL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9SZXNvdXJjZXNQYW5lbC5qcwpAQCAtMTAyLDIzICsxMDIsMjMgQEAg V2ViSW5zcGVjdG9yLlJlc291cmNlc1BhbmVsLnByb3RvdHlwZSA9IHsKICAgICAgICAgdGltZUdy YXBoSXRlbS5pc0Jhck9wYXF1ZUF0TGVmdCA9IGZhbHNlOwogICAgICAgICB0aW1lR3JhcGhJdGVt LnNlbGVjdGVkU29ydGluZ09wdGlvbkluZGV4ID0gMTsKIAotICAgICAgICB2YXIgc2l6ZUdyYXBo SXRlbSA9IG5ldyBXZWJJbnNwZWN0b3IuU2lkZWJhclRyZWVFbGVtZW50KCJyZXNvdXJjZXMtc2l6 ZS1ncmFwaC1zaWRlYmFyLWl0ZW0iLCBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIlNpemUiKSk7Ci0g ICAgICAgIHNpemVHcmFwaEl0ZW0ub25zZWxlY3QgPSB0aGlzLl9ncmFwaFNlbGVjdGVkLmJpbmQo dGhpcyk7CisgICAgICAgIHRoaXMuc2l6ZUdyYXBoSXRlbSA9IG5ldyBXZWJJbnNwZWN0b3IuU2lk ZWJhclRyZWVFbGVtZW50KCJyZXNvdXJjZXMtc2l6ZS1ncmFwaC1zaWRlYmFyLWl0ZW0iLCBXZWJJ bnNwZWN0b3IuVUlTdHJpbmcoIlNpemUiKSk7CisgICAgICAgIHRoaXMuc2l6ZUdyYXBoSXRlbS5v bnNlbGVjdCA9IHRoaXMuX2dyYXBoU2VsZWN0ZWQuYmluZCh0aGlzKTsKIAogICAgICAgICB2YXIg dHJhbnNmZXJTaXplQ2FsY3VsYXRvciA9IG5ldyBXZWJJbnNwZWN0b3IuUmVzb3VyY2VUcmFuc2Zl clNpemVDYWxjdWxhdG9yKCk7Ci0gICAgICAgIHNpemVHcmFwaEl0ZW0uc29ydGluZ09wdGlvbnMg PSBbCisgICAgICAgIHRoaXMuc2l6ZUdyYXBoSXRlbS5zb3J0aW5nT3B0aW9ucyA9IFsKICAgICAg ICAgICAgIHsgbmFtZTogV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJTb3J0IGJ5IFRyYW5zZmVyIFNp emUiKSwgc29ydGluZ0Z1bmN0aW9uOiBXZWJJbnNwZWN0b3IuUmVzb3VyY2VTaWRlYmFyVHJlZUVs ZW1lbnQuQ29tcGFyZUJ5RGVzY2VuZGluZ1RyYW5zZmVyU2l6ZSwgY2FsY3VsYXRvcjogdHJhbnNm ZXJTaXplQ2FsY3VsYXRvciB9LAogICAgICAgICAgICAgeyBuYW1lOiBXZWJJbnNwZWN0b3IuVUlT dHJpbmcoIlNvcnQgYnkgU2l6ZSIpLCBzb3J0aW5nRnVuY3Rpb246IFdlYkluc3BlY3Rvci5SZXNv dXJjZVNpZGViYXJUcmVlRWxlbWVudC5Db21wYXJlQnlEZXNjZW5kaW5nU2l6ZSwgY2FsY3VsYXRv cjogdHJhbnNmZXJTaXplQ2FsY3VsYXRvciB9LAogICAgICAgICBdOwogCi0gICAgICAgIHNpemVH cmFwaEl0ZW0uaXNCYXJPcGFxdWVBdExlZnQgPSB0cnVlOwotICAgICAgICBzaXplR3JhcGhJdGVt LnNlbGVjdGVkU29ydGluZ09wdGlvbkluZGV4ID0gMDsKKyAgICAgICAgdGhpcy5zaXplR3JhcGhJ dGVtLmlzQmFyT3BhcXVlQXRMZWZ0ID0gdHJ1ZTsKKyAgICAgICAgdGhpcy5zaXplR3JhcGhJdGVt LnNlbGVjdGVkU29ydGluZ09wdGlvbkluZGV4ID0gMDsKIAogICAgICAgICB0aGlzLmdyYXBoc1Ry ZWVFbGVtZW50ID0gbmV3IFdlYkluc3BlY3Rvci5TaWRlYmFyU2VjdGlvblRyZWVFbGVtZW50KFdl Ykluc3BlY3Rvci5VSVN0cmluZygiR1JBUEhTIiksIHt9LCB0cnVlKTsKICAgICAgICAgdGhpcy5z aWRlYmFyVHJlZS5hcHBlbmRDaGlsZCh0aGlzLmdyYXBoc1RyZWVFbGVtZW50KTsKIAogICAgICAg ICB0aGlzLmdyYXBoc1RyZWVFbGVtZW50LmFwcGVuZENoaWxkKHRpbWVHcmFwaEl0ZW0pOwotICAg ICAgICB0aGlzLmdyYXBoc1RyZWVFbGVtZW50LmFwcGVuZENoaWxkKHNpemVHcmFwaEl0ZW0pOwor ICAgICAgICB0aGlzLmdyYXBoc1RyZWVFbGVtZW50LmFwcGVuZENoaWxkKHRoaXMuc2l6ZUdyYXBo SXRlbSk7CiAgICAgICAgIHRoaXMuZ3JhcGhzVHJlZUVsZW1lbnQuZXhwYW5kKCk7CiAKICAgICAg ICAgdGhpcy5pdGVtc1RyZWVFbGVtZW50ID0gbmV3IFdlYkluc3BlY3Rvci5TaWRlYmFyU2VjdGlv blRyZWVFbGVtZW50KFdlYkluc3BlY3Rvci5VSVN0cmluZygiUkVTT1VSQ0VTIiksIHt9LCB0cnVl KTsKQEAgLTYyNSw2ICs2MjUsMTEgQEAgV2ViSW5zcGVjdG9yLlJlc291cmNlc1BhbmVsLnByb3Rv dHlwZSA9IHsKIAogICAgICAgICB0aGlzLmNsb3NlVmlzaWJsZVJlc291cmNlKCk7CiAgICAgICAg IHRoaXMuY29udGFpbmVyRWxlbWVudC5zY3JvbGxUb3AgPSAwOworCisgICAgICAgIGlmICh0cmVl RWxlbWVudCA9PT0gdGhpcy5zaXplR3JhcGhJdGVtKQorICAgICAgICAgICAgdGhpcy5oaWRlRXZl bnREaXZpZGVycygpOworICAgICAgICBlbHNlCisgICAgICAgICAgICB0aGlzLnNob3dFdmVudERp dmlkZXJzKCk7CiAgICAgfSwKIAogICAgIF90b2dnbGVMYXJnZXJSZXNvdXJjZXM6IGZ1bmN0aW9u KCkKZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UaW1lbGluZUdyaWQu anMgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGltZWxpbmVHcmlkLmpzCmluZGV4IDMy ODZlNjUuLjg1MmNiYjggMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9U aW1lbGluZUdyaWQuanMKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RpbWVsaW5l R3JpZC5qcwpAQCAtMTQ4LDYgKzE0OCwxNiBAQCBXZWJJbnNwZWN0b3IuVGltZWxpbmVHcmlkLnBy b3RvdHlwZSA9IHsKICAgICAgICAgdGhpcy5fZXZlbnREaXZpZGVyc0VsZW1lbnQucmVtb3ZlQ2hp bGRyZW4oKTsKICAgICB9LAogCisgICAgaGlkZUV2ZW50RGl2aWRlcnM6IGZ1bmN0aW9uKCkKKyAg ICB7CisgICAgICAgIHRoaXMuX2V2ZW50RGl2aWRlcnNFbGVtZW50LnN0eWxlLmRpc3BsYXkgPSAi bm9uZSI7CisgICAgfSwKKworICAgIHNob3dFdmVudERpdmlkZXJzOiBmdW5jdGlvbigpCisgICAg eworICAgICAgICB0aGlzLl9ldmVudERpdmlkZXJzRWxlbWVudC5zdHlsZS5kaXNwbGF5ID0gImJs b2NrIjsKKyAgICB9LAorCiAgICAgc2V0U2Nyb2xsQW5kRGl2aWRlclRvcDogZnVuY3Rpb24oc2Ny b2xsVG9wLCBkaXZpZGVyc1RvcCkKICAgICB7CiAgICAgICAgIHRoaXMuX2RpdmlkZXJzRWxlbWVu dC5zdHlsZS50b3AgPSBzY3JvbGxUb3AgKyAicHgiOwo=