39051 2010-05-13 01:13:33 -0700 Various JavaScript string optimizations 2010-05-13 06:06:56 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 mjs webkit-unassigned eric jorlow oldest_to_newest 225199 0 mjs 2010-05-13 01:13:33 -0700 Various JavaScript string optimizations 225204 1 55956 mjs 2010-05-13 01:44:54 -0700 Created attachment 55956 Patch 225206 2 55956 mrowe 2010-05-13 01:51:52 -0700 Comment on attachment 55956 Patch JavaScriptCore/ChangeLog:15 + (JSC::RegExp::match): resize overctor to 0 instead of clearing to avoid “overctor” should be “ovector”. JavaScriptCore/runtime/StringPrototype.cpp:762 + if (!(end >= 0)) // check for nevative values or NaN “nevative” should be “negative”. r=me 225211 3 mjs 2010-05-13 02:37:15 -0700 Committed r59355: <http://trac.webkit.org/changeset/59355> 225228 4 jorlow 2010-05-13 04:45:59 -0700 This is causing the build to fail on the tiger bot. I'm considering reverting it as I don't really know this code. Either of you guys still up? 225241 5 eric 2010-05-13 05:52:15 -0700 /Volumes/Data/WebKit-BuildSlave/tiger-intel-release/build/JavaScriptCore/runtime/StringPrototype.cpp: In function 'JSC::JSValue JSC::stringProtoFuncReplace(JSC::ExecState*, JSC::JSObject*, JSC::JSValue, const JSC::ArgList&)': /Volumes/Data/WebKit-BuildSlave/tiger-intel-release/build/JavaScriptCore/runtime/StringPrototype.cpp:269: warning: 'buffer' may be used uninitialized in this function 225243 6 eric 2010-05-13 06:01:25 -0700 Tiger appears to not understand: http://trac.webkit.org/browser/trunk/JavaScriptCore/runtime/StringPrototype.cpp#L269 225244 7 eric 2010-05-13 06:04:57 -0700 One possible fix would be to initialize buffer = 0. I'm not sure if that's right though, so it seems safer to roll out and let Maciej re-land a corrected fix in the morning. Maciej, webkit-patch apply-attachment 55956 should set up your tree for easy re-landing of this patch after modifications. 225245 8 eric 2010-05-13 06:06:56 -0700 Nevermind. maciej fixed in r59358. 55956 2010-05-13 01:44:54 -0700 2010-05-13 01:51:52 -0700 Patch bug-39051-20100513014453.patch text/plain 6669 mjs SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDU5MzUxKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjcgQEAKKzIwMTAtMDUtMTMgIE1hY2llaiBT dGFjaG93aWFrICA8bWpzQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBWYXJpb3VzIEphdmFTY3JpcHQgc3RyaW5nIG9wdGltaXphdGlv bnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5MDUx CisKKyAgICAgICAgQXBwcm94aW1hdGVseSAxJSBTdW5TcGlkZXIgc3BlZWR1cC4KKyAgICAgICAg CisgICAgICAgICogcnVudGltZS9BcnJheVByb3RvdHlwZS5jcHA6CisgICAgICAgIChKU0M6OmFy cmF5UHJvdG9GdW5jSm9pbik6IFJlbW92ZSBicmFuY2hlcyBmcm9tIHRoZSBob3QgY29kZSBwYXRo CisgICAgICAgIGJ5IG1vdmluZyB0aGUgZmlyc3QgcGFzcyBvdXRzaWRlIHRoZSBsb29wLCBhbmQg ZHVwbGljYXRpbmcgdGhlIGhvdCBsb29wCisgICAgICAgIHRvIGV4dHJhY3QgdGhlIGxvb3AtaW52 YXJpYW50IGJyYW5jaC4KKyAgICAgICAgKiBydW50aW1lL1JlZ0V4cC5jcHA6CisgICAgICAgIChK U0M6OlJlZ0V4cDo6bWF0Y2gpOiByZXNpemUgb3ZlcmN0b3IgdG8gMCBpbnN0ZWFkIG9mIGNsZWFy aW5nIHRvIGF2b2lkCisgICAgICAgIHRocmFzaCBpbiBjYXNlIG9mIGxhcmdlIG1hdGNoZXMuCisg ICAgICAgICogcnVudGltZS9SZWdFeHBDb25zdHJ1Y3Rvci5oOgorICAgICAgICAoSlNDOjpSZWdF eHBDb25zdHJ1Y3Rvcjo6cGVyZm9ybU1hdGNoKTogTWFyayBBTFdBWVNfSU5MSU5FIHRvIG1ha2Ug dGhlCisgICAgICAgIGNvbXBpbGVyIHJlc3BlY3Qgb3VyIGF1dGhvcml0eS4KKyAgICAgICAgKiBy dW50aW1lL1N0cmluZ1Byb3RvdHlwZS5jcHA6CisgICAgICAgIChKU0M6OmpzU3BsaWNlU3Vic3Ry aW5nc1dpdGhTZXBhcmF0b3JzKTogSW5saW5lLgorICAgICAgICAoSlNDOjpzdHJpbmdQcm90b0Z1 bmNTdWJzdHJpbmcpOiBSZXdyaXRlIGJvdW5kYXJ5IGNvbmRpdGlvbiBjaGVja3MgdG8KKyAgICAg ICAgcmVkdWNlIHRoZSBudW1iZXIgb2YgZmxvYXRpbmcgcG9pbnQgY29tcGFyaXNvbnMgYW5kIGJy YW5jaGVzLgorCiAyMDEwLTA1LTEyICBHYXZpbiBCYXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFw cGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBPbGl2ZXIgSHVudC4KSW5kZXg6IEphdmFT Y3JpcHRDb3JlL3J1bnRpbWUvQXJyYXlQcm90b3R5cGUuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFT Y3JpcHRDb3JlL3J1bnRpbWUvQXJyYXlQcm90b3R5cGUuY3BwCShyZXZpc2lvbiA1OTIxMSkKKysr IEphdmFTY3JpcHRDb3JlL3J1bnRpbWUvQXJyYXlQcm90b3R5cGUuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0yNzEsMjAgKzI3MSwzNyBAQCBKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgYXJyYXlQcm90b0Z1 bmNKb2luCiAgICAgdW5zaWduZWQgayA9IDA7CiAgICAgaWYgKGlzSlNBcnJheSgmZXhlYy0+Z2xv YmFsRGF0YSgpLCB0aGlzT2JqKSkgewogICAgICAgICBKU0FycmF5KiBhcnJheSA9IGFzQXJyYXko dGhpc09iaik7Ci0gICAgICAgIGZvciAoOyBrIDwgbGVuZ3RoOyBrKyspIHsKLSAgICAgICAgICAg IGlmICghYXJyYXktPmNhbkdldEluZGV4KGspKQotICAgICAgICAgICAgICAgIGJyZWFrOwotICAg ICAgICAgICAgaWYgKGsgPj0gMSkgewotICAgICAgICAgICAgICAgIGlmIChzZXBhcmF0b3IuaXNO dWxsKCkpCi0gICAgICAgICAgICAgICAgICAgIHN0ckJ1ZmZlci5hcHBlbmQoJywnKTsKLSAgICAg ICAgICAgICAgICBlbHNlCi0gICAgICAgICAgICAgICAgICAgIHN0ckJ1ZmZlci5hcHBlbmQoc2Vw YXJhdG9yKTsKLSAgICAgICAgICAgIH0KKworICAgICAgICBpZiAobGVuZ3RoKSB7CisgICAgICAg ICAgICBpZiAoIWFycmF5LT5jYW5HZXRJbmRleChrKSkgCisgICAgICAgICAgICAgICAgZ290byBz a2lwRmlyc3RMb29wOwogICAgICAgICAgICAgSlNWYWx1ZSBlbGVtZW50ID0gYXJyYXktPmdldElu ZGV4KGspOwogICAgICAgICAgICAgaWYgKCFlbGVtZW50LmlzVW5kZWZpbmVkT3JOdWxsKCkpCiAg ICAgICAgICAgICAgICAgc3RyQnVmZmVyLmFwcGVuZChlbGVtZW50LnRvU3RyaW5nKGV4ZWMpKTsK KyAgICAgICAgICAgIGsrKzsKKyAgICAgICAgfQorCisgICAgICAgIGlmIChzZXBhcmF0b3IuaXNO dWxsKCkpIHsKKyAgICAgICAgICAgIGZvciAoOyBrIDwgbGVuZ3RoOyBrKyspIHsKKyAgICAgICAg ICAgICAgICBpZiAoIWFycmF5LT5jYW5HZXRJbmRleChrKSkKKyAgICAgICAgICAgICAgICAgICAg YnJlYWs7CisgICAgICAgICAgICAgICAgc3RyQnVmZmVyLmFwcGVuZCgnLCcpOworICAgICAgICAg ICAgICAgIEpTVmFsdWUgZWxlbWVudCA9IGFycmF5LT5nZXRJbmRleChrKTsKKyAgICAgICAgICAg ICAgICBpZiAoIWVsZW1lbnQuaXNVbmRlZmluZWRPck51bGwoKSkKKyAgICAgICAgICAgICAgICAg ICAgc3RyQnVmZmVyLmFwcGVuZChlbGVtZW50LnRvU3RyaW5nKGV4ZWMpKTsKKyAgICAgICAgICAg IH0KKyAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgIGZvciAoOyBrIDwgbGVuZ3RoOyBrKysp IHsKKyAgICAgICAgICAgICAgICBpZiAoIWFycmF5LT5jYW5HZXRJbmRleChrKSkKKyAgICAgICAg ICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAgICAgICAgc3RyQnVmZmVyLmFwcGVuZChzZXBh cmF0b3IpOworICAgICAgICAgICAgICAgIEpTVmFsdWUgZWxlbWVudCA9IGFycmF5LT5nZXRJbmRl eChrKTsKKyAgICAgICAgICAgICAgICBpZiAoIWVsZW1lbnQuaXNVbmRlZmluZWRPck51bGwoKSkK KyAgICAgICAgICAgICAgICAgICAgc3RyQnVmZmVyLmFwcGVuZChlbGVtZW50LnRvU3RyaW5nKGV4 ZWMpKTsKKyAgICAgICAgICAgIH0KICAgICAgICAgfQogICAgIH0KKyBza2lwRmlyc3RMb29wOgog ICAgIGZvciAoOyBrIDwgbGVuZ3RoOyBrKyspIHsKICAgICAgICAgaWYgKGsgPj0gMSkgewogICAg ICAgICAgICAgaWYgKHNlcGFyYXRvci5pc051bGwoKSkKSW5kZXg6IEphdmFTY3JpcHRDb3JlL3J1 bnRpbWUvUmVnRXhwLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL1Jl Z0V4cC5jcHAJKHJldmlzaW9uIDU5MjExKQorKysgSmF2YVNjcmlwdENvcmUvcnVudGltZS9SZWdF eHAuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDcsNyArMTA3LDcgQEAgaW50IFJlZ0V4cDo6bWF0 Y2goY29uc3QgVVN0cmluZyYgcywgaW50IAogICAgIGlmIChzdGFydE9mZnNldCA8IDApCiAgICAg ICAgIHN0YXJ0T2Zmc2V0ID0gMDsKICAgICBpZiAob3ZlY3RvcikKLSAgICAgICAgb3ZlY3Rvci0+ Y2xlYXIoKTsKKyAgICAgICAgb3ZlY3Rvci0+cmVzaXplKDApOwogCiAgICAgaWYgKHN0YXRpY19j YXN0PHVuc2lnbmVkPihzdGFydE9mZnNldCkgPiBzLnNpemUoKSB8fCBzLmlzTnVsbCgpKQogICAg ICAgICByZXR1cm4gLTE7CkBAIC0xMzIsNyArMTMyLDYgQEAgaW50IFJlZ0V4cDo6bWF0Y2goY29u c3QgVVN0cmluZyYgcywgaW50IAogICAgICAgICBmb3IgKGludCBqID0gMDsgaiA8IG9mZnNldFZl Y3RvclNpemU7ICsraikKICAgICAgICAgICAgIG9mZnNldFZlY3RvcltqXSA9IC0xOwogCi0KICNp ZiBFTkFCTEUoWUFSUl9KSVQpCiAgICAgICAgIGludCByZXN1bHQgPSBZYXJyOjpleGVjdXRlUmVn ZXgobV9yZWdFeHBKSVRDb2RlLCBzLmRhdGEoKSwgc3RhcnRPZmZzZXQsIHMuc2l6ZSgpLCBvZmZz ZXRWZWN0b3IsIG9mZnNldFZlY3RvclNpemUpOwogI2Vsc2UKSW5kZXg6IEphdmFTY3JpcHRDb3Jl L3J1bnRpbWUvUmVnRXhwQ29uc3RydWN0b3IuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29y ZS9ydW50aW1lL1JlZ0V4cENvbnN0cnVjdG9yLmgJKHJldmlzaW9uIDU5MjExKQorKysgSmF2YVNj cmlwdENvcmUvcnVudGltZS9SZWdFeHBDb25zdHJ1Y3Rvci5oCSh3b3JraW5nIGNvcHkpCkBAIC0x MDksNyArMTA5LDcgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICBleHByZXNzaW9uIG1hdGNoaW5n IHRocm91Z2ggdGhlIHBlcmZvcm1NYXRjaCBmdW5jdGlvbi4gV2UgdXNlIGNhY2hlZCByZXN1bHRz IHRvIGNhbGN1bGF0ZSwgCiAgICAgICBlLmcuLCBSZWdFeHAubGFzdE1hdGNoIGFuZCBSZWdFeHAu bGVmdFBhcmVuLgogICAgICovCi0gICAgaW5saW5lIHZvaWQgUmVnRXhwQ29uc3RydWN0b3I6OnBl cmZvcm1NYXRjaChSZWdFeHAqIHIsIGNvbnN0IFVTdHJpbmcmIHMsIGludCBzdGFydE9mZnNldCwg aW50JiBwb3NpdGlvbiwgaW50JiBsZW5ndGgsIGludCoqIG92ZWN0b3IpCisgICAgQUxXQVlTX0lO TElORSB2b2lkIFJlZ0V4cENvbnN0cnVjdG9yOjpwZXJmb3JtTWF0Y2goUmVnRXhwKiByLCBjb25z dCBVU3RyaW5nJiBzLCBpbnQgc3RhcnRPZmZzZXQsIGludCYgcG9zaXRpb24sIGludCYgbGVuZ3Ro LCBpbnQqKiBvdmVjdG9yKQogICAgIHsKICAgICAgICAgcG9zaXRpb24gPSByLT5tYXRjaChzLCBz dGFydE9mZnNldCwgJmQtPnRlbXBPdmVjdG9yKCkpOwogCkluZGV4OiBKYXZhU2NyaXB0Q29yZS9y dW50aW1lL1N0cmluZ1Byb3RvdHlwZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUv cnVudGltZS9TdHJpbmdQcm90b3R5cGUuY3BwCShyZXZpc2lvbiA1OTIxMSkKKysrIEphdmFTY3Jp cHRDb3JlL3J1bnRpbWUvU3RyaW5nUHJvdG90eXBlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjQ1 LDggKzI0NSw3IEBAIHB1YmxpYzoKICAgICBpbnQgbGVuZ3RoOwogfTsKIAotSlNWYWx1ZSBqc1Nw bGljZVN1YnN0cmluZ3NXaXRoU2VwYXJhdG9ycyhFeGVjU3RhdGUqIGV4ZWMsIEpTU3RyaW5nKiBz b3VyY2VWYWwsIGNvbnN0IFVTdHJpbmcmIHNvdXJjZSwgY29uc3QgU3RyaW5nUmFuZ2UqIHN1YnN0 cmluZ1JhbmdlcywgaW50IHJhbmdlQ291bnQsIGNvbnN0IFVTdHJpbmcqIHNlcGFyYXRvcnMsIGlu dCBzZXBhcmF0b3JDb3VudCk7Ci1KU1ZhbHVlIGpzU3BsaWNlU3Vic3RyaW5nc1dpdGhTZXBhcmF0 b3JzKEV4ZWNTdGF0ZSogZXhlYywgSlNTdHJpbmcqIHNvdXJjZVZhbCwgY29uc3QgVVN0cmluZyYg c291cmNlLCBjb25zdCBTdHJpbmdSYW5nZSogc3Vic3RyaW5nUmFuZ2VzLCBpbnQgcmFuZ2VDb3Vu dCwgY29uc3QgVVN0cmluZyogc2VwYXJhdG9ycywgaW50IHNlcGFyYXRvckNvdW50KQorc3RhdGlj IEFMV0FZU19JTkxJTkUgSlNWYWx1ZSBqc1NwbGljZVN1YnN0cmluZ3NXaXRoU2VwYXJhdG9ycyhF eGVjU3RhdGUqIGV4ZWMsIEpTU3RyaW5nKiBzb3VyY2VWYWwsIGNvbnN0IFVTdHJpbmcmIHNvdXJj ZSwgY29uc3QgU3RyaW5nUmFuZ2UqIHN1YnN0cmluZ1JhbmdlcywgaW50IHJhbmdlQ291bnQsIGNv bnN0IFVTdHJpbmcqIHNlcGFyYXRvcnMsIGludCBzZXBhcmF0b3JDb3VudCkKIHsKICAgICBpZiAo cmFuZ2VDb3VudCA9PSAxICYmIHNlcGFyYXRvckNvdW50ID09IDApIHsKICAgICAgICAgaW50IHNv dXJjZVNpemUgPSBzb3VyY2Uuc2l6ZSgpOwpAQCAtNzUxLDIxICs3NTAsMjAgQEAgSlNWYWx1ZSBK U0NfSE9TVF9DQUxMIHN0cmluZ1Byb3RvRnVuY1N1YgogICAgIEpTVmFsdWUgYTEgPSBhcmdzLmF0 KDEpOwogCiAgICAgZG91YmxlIHN0YXJ0ID0gYTAudG9OdW1iZXIoZXhlYyk7Ci0gICAgZG91Ymxl IGVuZCA9IGExLnRvTnVtYmVyKGV4ZWMpOwotICAgIGlmIChpc25hbihzdGFydCkpCisgICAgZG91 YmxlIGVuZDsKKyAgICBpZiAoIShzdGFydCA+PSAwKSkgLy8gY2hlY2sgZm9yIG5lZ2F0aXZlIHZh bHVlcyBvciBOYU4KICAgICAgICAgc3RhcnQgPSAwOwotICAgIGlmIChpc25hbihlbmQpKQotICAg ICAgICBlbmQgPSAwOwotICAgIGlmIChzdGFydCA8IDApCi0gICAgICAgIHN0YXJ0ID0gMDsKLSAg ICBpZiAoZW5kIDwgMCkKLSAgICAgICAgZW5kID0gMDsKLSAgICBpZiAoc3RhcnQgPiBsZW4pCisg ICAgZWxzZSBpZiAoc3RhcnQgPiBsZW4pCiAgICAgICAgIHN0YXJ0ID0gbGVuOwotICAgIGlmIChl bmQgPiBsZW4pCi0gICAgICAgIGVuZCA9IGxlbjsKICAgICBpZiAoYTEuaXNVbmRlZmluZWQoKSkK ICAgICAgICAgZW5kID0gbGVuOworICAgIGVsc2UgeyAKKyAgICAgICAgZW5kID0gYTEudG9OdW1i ZXIoZXhlYyk7CisgICAgICAgIGlmICghKGVuZCA+PSAwKSkgLy8gY2hlY2sgZm9yIG5ldmF0aXZl IHZhbHVlcyBvciBOYU4KKyAgICAgICAgICAgIGVuZCA9IDA7CisgICAgICAgIGVsc2UgaWYgKGVu ZCA+IGxlbikKKyAgICAgICAgICAgIGVuZCA9IGxlbjsKKyAgICB9CiAgICAgaWYgKHN0YXJ0ID4g ZW5kKSB7CiAgICAgICAgIGRvdWJsZSB0ZW1wID0gZW5kOwogICAgICAgICBlbmQgPSBzdGFydDsK