39043 2010-05-12 21:37:20 -0700 Don't include RetainPtr.h unless PLATFORM(CF) is set 2010-05-14 12:49:50 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 joybro201 webkit-unassigned commit-queue skyul oldest_to_newest 225098 0 joybro201 2010-05-12 21:37:20 -0700 The RetainPtr is only used for CF platform in this class. 225109 1 55941 joybro201 2010-05-12 21:49:05 -0700 Created attachment 55941 patch 225141 2 55941 darin 2010-05-12 23:07:52 -0700 Comment on attachment 55941 patch > #include <errno.h> > #include <stdio.h> > +#if PLATFORM(CF) > #include <wtf/RetainPtr.h> > +#endif > #include <wtf/Threading.h> > #include <wtf/Vector.h> > #include <wtf/text/CString.h> Includes inside #if go in their own paragraph, not sorted in the middle of the main include paragraph. We also normally put #if in headers so we don't have to make includes everywhere conditional. For example, see the #if ENABLE(SVG) in SVGElement.h. Despite those minor problems it seems OK to land this as-is. 225951 3 55941 commit-queue 2010-05-14 12:49:45 -0700 Comment on attachment 55941 patch Clearing flags on attachment: 55941 Committed r59482: <http://trac.webkit.org/changeset/59482> 225952 4 commit-queue 2010-05-14 12:49:50 -0700 All reviewed patches have been landed. Closing bug. 55941 2010-05-12 21:49:05 -0700 2010-05-14 12:49:45 -0700 patch patch_39043 text/plain 1154 joybro201 SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1OTE0NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDUtMTIgIFlvdW5nIEhhbiBMZWUgIDxqb3licm9AY29tcGFu eTEwMC5uZXQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgRG9uJ3QgaW5jbHVkZSBSZXRhaW5QdHIuaCB1bmxlc3MgUExBVEZPUk0oQ0YpIGlzIHNldC4K KyAgICAgICAgVGhlIFJldGFpblB0ciBpcyBvbmx5IHVzZWQgZm9yIENGIHBsYXRmb3JtIGluIHRo aXMgY2xhc3MuIAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MzkwNDMKKworICAgICAgICBObyBuZXcgdGVzdHMsIHRoZXJlIGlzIG5vIG5ldyBmdW5jdGlv bmFsaXR5LgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9jdXJsL1Jlc291cmNlSGFuZGxl TWFuYWdlci5jcHA6CisKIDIwMTAtMDUtMTEgIFpvbHRhbiBIZXJjemVnICA8emhlcmN6ZWdAd2Vi a2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEaXJrIFNjaHVsemUuCkluZGV4OiBXZWJD b3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9SZXNvdXJjZUhhbmRsZU1hbmFnZXIuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL1Jlc291cmNlSGFuZGxlTWFu YWdlci5jcHAJKHJldmlzaW9uIDU5MTQ3KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1 cmwvUmVzb3VyY2VIYW5kbGVNYW5hZ2VyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDUsNyArNDUs OSBAQAogCiAjaW5jbHVkZSA8ZXJybm8uaD4KICNpbmNsdWRlIDxzdGRpby5oPgorI2lmIFBMQVRG T1JNKENGKQogI2luY2x1ZGUgPHd0Zi9SZXRhaW5QdHIuaD4KKyNlbmRpZgogI2luY2x1ZGUgPHd0 Zi9UaHJlYWRpbmcuaD4KICNpbmNsdWRlIDx3dGYvVmVjdG9yLmg+CiAjaW5jbHVkZSA8d3RmL3Rl eHQvQ1N0cmluZy5oPgo=