39032 2010-05-12 15:59:09 -0700 Don't clear yellow autofill highlight until user edits value 2010-05-14 07:17:06 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) All All RESOLVED FIXED P3 Minor --- 1 jens jens commit-queue sullivan oldest_to_newest 224965 0 jens 2010-05-12 15:59:09 -0700 The 'autofilled' flag (and yellow background highlight) on a text field gets cleared when the field is focused. This can have weird results — for example, if there's an onload handler on the page that focuses a particular field, then that field won't appear autofilled even though it was. Also, if password fields get autofilled (as Chrome does), then a form's fields turn yellow again as soon as you tab out, since the browser applies the autofill again. This got reported against Chrome as: http://code.google.com/p/chromium/issues/detail?id=38386 The specific behaviors called out there apply to Chrome, but the autofill highlight is part of WebKit. I propose that HTMLInputField be changed slightly so that the autofill flag isn't cleared until the field is actually changed by the user, not just tabbed through. This seems more consistent in that the highlight then applies to the _contents_ of the field, showing that it's still a value supplied automatically by the browser and not hand-typed. 224979 1 55912 jens 2010-05-12 16:52:43 -0700 Created attachment 55912 patch FYI, I asked about this change on webkit-dev, and John Sullivan was OK with it: "It seems reasonable to me that the autofilled property is only cleared when the text is modified by the user. Since it is a visible change in the behavior, there's always a chance that it will not sit well with everyone and we might eventually have to allow for both behaviors somehow. But it seems like a small enough behavior change that it's unlikely that anyone will care strongly about it." 224995 2 sullivan 2010-05-12 17:23:39 -0700 I think we could implement the old behavior on top of the new code by having the client notice the focus event and explicitly call setAutofilled(false), so that makes the new code seem even safer than I previously thought. 224999 3 55912 sullivan 2010-05-12 17:25:09 -0700 Comment on attachment 55912 patch This seems safe enough. 225795 4 55912 commit-queue 2010-05-14 07:17:01 -0700 Comment on attachment 55912 patch Clearing flags on attachment: 55912 Committed r59472: <http://trac.webkit.org/changeset/59472> 225796 5 commit-queue 2010-05-14 07:17:06 -0700 All reviewed patches have been landed. Closing bug. 55912 2010-05-12 16:52:43 -0700 2010-05-14 07:17:01 -0700 patch textmate stdin cZcdP1.txt text/plain 1660 jens ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZWFiMjRjYy4uMThmNGE2NCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNS0xMiAgSmVucyBBbGZrZSAg PHNuZWpAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIERvbid0IGNsZWFyIHllbGxvdyBhdXRvZmlsbCBoaWdobGlnaHQgZnJvbSB0 ZXh0IGZpZWxkcyB1bnRpbCB0aGUgdXNlciBlZGl0cyB0aGVtLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzkwMzIKKyAgICAgICAgTm8gbmV3IHRlc3Rz IChDb3VsZG4ndCBmaW5kIGFueSBhdXRvZmlsbCB0ZXN0cy4gVGhlIGZsYWcgZG9lc24ndCBzZWVt IHRvIGJlIGV4cG9zZWQgdG8gSlMuKQorCisgICAgICAgICogaHRtbC9IVE1MSW5wdXRFbGVtZW50 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxJbnB1dEVsZW1lbnQ6OmhhbmRsZUZvY3VzRXZl bnQpOiAgRG9uJ3QgY2xlYXIgdGhlIGF1dG9maWxsZWQgZmxhZy4KKyAgICAgICAgKFdlYkNvcmU6 OkhUTUxJbnB1dEVsZW1lbnQ6OnNldFZhbHVlRnJvbVJlbmRlcmVyKTogIENsZWFyIHRoZSBhdXRv ZmlsbGVkIGZsYWcuCisKIDIwMTAtMDUtMTEgIE5pa29sYXMgWmltbWVybWFubiAgPG56aW1tZXJt YW5uQHJpbS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGlyayBTY2h1bHplLgpkaWZmIC0t Z2l0IGEvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwIGIvV2ViQ29yZS9odG1sL0hU TUxJbnB1dEVsZW1lbnQuY3BwCmluZGV4IGU0OTljYWEuLjU4ZTdmODcgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcAorKysgYi9XZWJDb3JlL2h0bWwvSFRNTElu cHV0RWxlbWVudC5jcHAKQEAgLTc0OCw5ICs3NDgsNiBAQCBib29sIEhUTUxJbnB1dEVsZW1lbnQ6 OnNob3VsZFVzZUlucHV0TWV0aG9kKCkgY29uc3QKIHZvaWQgSFRNTElucHV0RWxlbWVudDo6aGFu ZGxlRm9jdXNFdmVudCgpCiB7CiAgICAgSW5wdXRFbGVtZW50OjpkaXNwYXRjaEZvY3VzRXZlbnQo dGhpcywgdGhpcyk7Ci0KLSAgICBpZiAoaXNUZXh0RmllbGQoKSkKLSAgICAgICAgbV9hdXRvZmls bGVkID0gZmFsc2U7CiB9CiAKIHZvaWQgSFRNTElucHV0RWxlbWVudDo6aGFuZGxlQmx1ckV2ZW50 KCkKQEAgLTE5MzksNiArMTkzNiw5IEBAIHZvaWQgSFRNTElucHV0RWxlbWVudDo6c2V0VmFsdWVG cm9tUmVuZGVyZXIoY29uc3QgU3RyaW5nJiB2YWx1ZSkKICAgICB1cGRhdGVQbGFjZWhvbGRlclZp c2liaWxpdHkoZmFsc2UpOwogICAgIElucHV0RWxlbWVudDo6c2V0VmFsdWVGcm9tUmVuZGVyZXIo bV9kYXRhLCB0aGlzLCB0aGlzLCB2YWx1ZSk7CiAgICAgc2V0TmVlZHNWYWxpZGl0eUNoZWNrKCk7 CisKKyAgICAvLyBDbGVhciBhdXRvZmlsbCBmbGFnIChhbmQgeWVsbG93IGJhY2tncm91bmQpIG9u IHVzZXIgZWRpdC4KKyAgICBzZXRBdXRvZmlsbGVkKGZhbHNlKTsKIH0KIAogdm9pZCBIVE1MSW5w dXRFbGVtZW50OjpzZXRGaWxlTGlzdEZyb21SZW5kZXJlcihjb25zdCBWZWN0b3I8U3RyaW5nPiYg cGF0aHMpCg==