39031 2010-05-12 15:54:14 -0700 CSSParser::parseColor() shouldn't alter 'color' unless passed a valid color string. 2010-05-14 08:40:41 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All All CLOSED FIXED P2 Normal --- 35784 1 kling webkit-unassigned benjamin commit-queue darin hausmann laszlo.gombos oldest_to_newest 224963 0 kling 2010-05-12 15:54:14 -0700 So says the comment above the function: // color will only be changed when string contains a valid css color, making it // possible to set up a default color. 224966 1 55910 kling 2010-05-12 16:03:22 -0700 Created attachment 55910 Proposed patch 224974 2 kling 2010-05-12 16:26:16 -0700 I can't think of a good way to LayoutTest this, but it doesn't break any existing tests and is obviously correct (famous last words..) 225027 3 55910 darin 2010-05-12 18:21:59 -0700 Comment on attachment 55910 Proposed patch How did you check all the call sites to make sure that none were depending on the old behavior? 225042 4 55927 kling 2010-05-12 18:45:37 -0700 Created attachment 55927 Proposed patch v2 By insufficient grepping, apparently. :( Updated patch to remove dependency on old behavior. 225125 5 55927 darin 2010-05-12 22:33:14 -0700 Comment on attachment 55927 Proposed patch v2 Looks OK. r=me 225813 6 55927 commit-queue 2010-05-14 07:47:22 -0700 Comment on attachment 55927 Proposed patch v2 Clearing flags on attachment: 55927 Committed r59473: <http://trac.webkit.org/changeset/59473> 225814 7 commit-queue 2010-05-14 07:47:28 -0700 All reviewed patches have been landed. Closing bug. 225844 8 hausmann 2010-05-14 08:40:04 -0700 Revision r59473 cherry-picked into qtwebkit-2.0 with commit 2b20c8dabe7670fe4c99b83156cdd5f4544c8c30 55910 2010-05-12 16:03:22 -0700 2010-05-12 18:45:37 -0700 Proposed patch bug-39091.diff text/plain 1053 kling ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Mjk4ZGEwOS4uZDc2YjNmNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wNS0xMiAgQW5kcmVhcyBLbGlu ZyAgPGFuZHJlYXMua2xpbmdAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIENTU1BhcnNlcjo6cGFyc2VDb2xvcigpIHNob3VsZG4ndCBh bHRlciAnY29sb3InIHVubGVzcyBwYXNzZWQgYSB2YWxpZCBjb2xvciBzdHJpbmcuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zOTAzMQorCisgICAgICAg ICogY3NzL0NTU1BhcnNlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NQYXJzZXI6OnBhcnNl Q29sb3IpOgorCiAyMDEwLTA1LTEyICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvV2ViQ29y ZS9jc3MvQ1NTUGFyc2VyLmNwcCBiL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKaW5kZXggNmY3 Y2YxMi4uYWMxNjhkYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcAorKysg Yi9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCkBAIC0yODQsNyArMjg0LDYgQEAgYm9vbCBDU1NQ YXJzZXI6OnBhcnNlVmFsdWUoQ1NTTXV0YWJsZVN0eWxlRGVjbGFyYXRpb24qIGRlY2xhcmF0aW9u LCBpbnQgaWQsIGNvbnMKIC8vIHBvc3NpYmxlIHRvIHNldCB1cCBhIGRlZmF1bHQgY29sb3IuCiBi b29sIENTU1BhcnNlcjo6cGFyc2VDb2xvcihSR0JBMzImIGNvbG9yLCBjb25zdCBTdHJpbmcmIHN0 cmluZywgYm9vbCBzdHJpY3QpCiB7Ci0gICAgY29sb3IgPSAwOwogICAgIENTU1BhcnNlciBwYXJz ZXIodHJ1ZSk7CiAKICAgICAvLyBGaXJzdCB0cnkgY3JlYXRpbmcgYSBjb2xvciBzcGVjaWZpZWQg YnkgbmFtZSBvciB0aGUgIiMiIHN5bnRheC4K 55927 2010-05-12 18:45:37 -0700 2010-05-14 07:47:22 -0700 Proposed patch v2 bug-39091-2.diff text/plain 2772 kling ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZGMwYTEyNS4uNWY3MGVmMCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0wNS0xMiAgQW5kcmVhcyBLbGlu ZyAgPGFuZHJlYXMua2xpbmdAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIENTU1BhcnNlcjo6cGFyc2VDb2xvcigpIHNob3VsZG4ndCBh bHRlciAnY29sb3InIHVubGVzcyBwYXNzZWQgYSB2YWxpZCBjb2xvciBzdHJpbmcuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zOTAzMQorCisgICAgICAg ICogY3NzL0NTU1BhcnNlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NQYXJzZXI6OnBhcnNl Q29sb3IpOgorICAgICAgICAqIGVkaXRpbmcvQXBwbHlTdHlsZUNvbW1hbmQuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6U3R5bGVDaGFuZ2U6OmV4dHJhY3RUZXh0U3R5bGVzKTogRG9uJ3QgZGVwZW5k IG9uIG9sZCBiZWhhdmlvci4KKyAgICAgICAgKiBodG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdD b250ZXh0MkQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q2FudmFzUmVuZGVyaW5nQ29udGV4dDJE OjpzZXRTaGFkb3cpOiBSZW1vdmUgZGVhZCBjb2RlLgorCiAyMDEwLTA1LTEyICBBbmRlcnMgQ2Fy bHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24g RnJhc2VyLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcCBiL1dlYkNvcmUv Y3NzL0NTU1BhcnNlci5jcHAKaW5kZXggNmY3Y2YxMi4uYWMxNjhkYyAxMDA2NDQKLS0tIGEvV2Vi Q29yZS9jc3MvQ1NTUGFyc2VyLmNwcAorKysgYi9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCkBA IC0yODQsNyArMjg0LDYgQEAgYm9vbCBDU1NQYXJzZXI6OnBhcnNlVmFsdWUoQ1NTTXV0YWJsZVN0 eWxlRGVjbGFyYXRpb24qIGRlY2xhcmF0aW9uLCBpbnQgaWQsIGNvbnMKIC8vIHBvc3NpYmxlIHRv IHNldCB1cCBhIGRlZmF1bHQgY29sb3IuCiBib29sIENTU1BhcnNlcjo6cGFyc2VDb2xvcihSR0JB MzImIGNvbG9yLCBjb25zdCBTdHJpbmcmIHN0cmluZywgYm9vbCBzdHJpY3QpCiB7Ci0gICAgY29s b3IgPSAwOwogICAgIENTU1BhcnNlciBwYXJzZXIodHJ1ZSk7CiAKICAgICAvLyBGaXJzdCB0cnkg Y3JlYXRpbmcgYSBjb2xvciBzcGVjaWZpZWQgYnkgbmFtZSBvciB0aGUgIiMiIHN5bnRheC4KZGlm ZiAtLWdpdCBhL1dlYkNvcmUvZWRpdGluZy9BcHBseVN0eWxlQ29tbWFuZC5jcHAgYi9XZWJDb3Jl L2VkaXRpbmcvQXBwbHlTdHlsZUNvbW1hbmQuY3BwCmluZGV4IDFjNzM5ZWMuLjUyOWQ5ZDMgMTAw NjQ0Ci0tLSBhL1dlYkNvcmUvZWRpdGluZy9BcHBseVN0eWxlQ29tbWFuZC5jcHAKKysrIGIvV2Vi Q29yZS9lZGl0aW5nL0FwcGx5U3R5bGVDb21tYW5kLmNwcApAQCAtMjEyLDcgKzIxMiw3IEBAIHZv aWQgU3R5bGVDaGFuZ2U6OmV4dHJhY3RUZXh0U3R5bGVzKENTU011dGFibGVTdHlsZURlY2xhcmF0 aW9uKiBzdHlsZSkKICAgICBpZiAoUmVmUHRyPENTU1ZhbHVlPiBjb2xvclZhbHVlID0gc3R5bGUt PmdldFByb3BlcnR5Q1NTVmFsdWUoQ1NTUHJvcGVydHlDb2xvcikpIHsKICAgICAgICAgQVNTRVJU KGNvbG9yVmFsdWUtPmlzUHJpbWl0aXZlVmFsdWUoKSk7CiAgICAgICAgIENTU1ByaW1pdGl2ZVZh bHVlKiBwcmltaXRpdmVDb2xvciA9IHN0YXRpY19jYXN0PENTU1ByaW1pdGl2ZVZhbHVlKj4oY29s b3JWYWx1ZS5nZXQoKSk7Ci0gICAgICAgIFJHQkEzMiByZ2JhOworICAgICAgICBSR0JBMzIgcmdi YSA9IDA7CiAgICAgICAgIGlmIChwcmltaXRpdmVDb2xvci0+cHJpbWl0aXZlVHlwZSgpICE9IENT U1ByaW1pdGl2ZVZhbHVlOjpDU1NfUkdCQ09MT1IpIHsKICAgICAgICAgICAgIENTU1BhcnNlcjo6 cGFyc2VDb2xvcihyZ2JhLCBjb2xvclZhbHVlLT5jc3NUZXh0KCkpOwogICAgICAgICAgICAgLy8g TmVlZCB0byB0YWtlIGNhcmUgb2YgbmFtZWQgY29sb3Igc3VjaCBhcyBncmVlbiBhbmQgYmxhY2sK ZGlmZiAtLWdpdCBhL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJE LmNwcCBiL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcApp bmRleCA2MTViNDVkLi42MWU0OWY5IDEwMDY0NAotLS0gYS9XZWJDb3JlL2h0bWwvY2FudmFzL0Nh bnZhc1JlbmRlcmluZ0NvbnRleHQyRC5jcHAKKysrIGIvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52 YXNSZW5kZXJpbmdDb250ZXh0MkQuY3BwCkBAIC04NzQsOCArODc0LDYgQEAgdm9pZCBDYW52YXNS ZW5kZXJpbmdDb250ZXh0MkQ6OnNldFNoYWRvdyhmbG9hdCB3aWR0aCwgZmxvYXQgaGVpZ2h0LCBm bG9hdCBibHVyLAogICAgICAgICByZXR1cm47CiAKICAgICBSR0JBMzIgcmdiYSA9IG1ha2VSR0JB MzJGcm9tRmxvYXRzKHIsIGcsIGIsIGEpOyAvLyBkZWZhdWx0IGlzIHRyYW5zcGFyZW50IGJsYWNr Ci0gICAgaWYgKCFzdGF0ZSgpLm1fc2hhZG93Q29sb3IuaXNFbXB0eSgpKQotICAgICAgICBDU1NQ YXJzZXI6OnBhcnNlQ29sb3IocmdiYSwgc3RhdGUoKS5tX3NoYWRvd0NvbG9yKTsKICAgICBjLT5z ZXRTaGFkb3coSW50U2l6ZSh3aWR0aCwgLWhlaWdodCksIHN0YXRlKCkubV9zaGFkb3dCbHVyLCBD b2xvcihyZ2JhKSwgRGV2aWNlQ29sb3JTcGFjZSk7CiB9CiAK