39018 2010-05-12 12:58:23 -0700 [chromium] "Check spelling in this field" context menu item always checked 2010-05-15 02:22:02 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 estade estade commit-queue dglazkov evan webkit.review.bot oldest_to_newest 224826 0 estade 2010-05-12 12:58:23 -0700 http://code.google.com/p/chromium/issues/detail?id=42981 Note that the functionality is not broken, just the state of the check. This affects all chromium platforms. 224889 1 55899 estade 2010-05-12 14:19:37 -0700 Created attachment 55899 try1 225173 2 evan 2010-05-13 00:13:15 -0700 Is "data" here some struct? Maybe it'd make more sense to just memset it to zero when it's created? 225377 3 estade 2010-05-13 10:49:18 -0700 yes, data is a struct. Memsetting doesn't seem like it would produce the most intuitive code. 225432 4 55899 jianli 2010-05-13 12:17:42 -0700 Comment on attachment 55899 try1 I think we should either introduce default constructor or memset the struct instance in order to avoid future mistake when we add new members. 225444 5 56007 estade 2010-05-13 12:40:50 -0700 Created attachment 56007 do initing in default constructor 225450 6 webkit.review.bot 2010-05-13 12:59:47 -0700 Attachment 56007 did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/2253037 225452 7 56009 estade 2010-05-13 13:02:06 -0700 Created attachment 56009 syntax 225471 8 56009 abarth 2010-05-13 13:30:07 -0700 Comment on attachment 56009 syntax We usually put constructors at the top of the declaration. It's a bit odd to have a struct with a constructor, but I think we do that in other places too. 225505 9 estade 2010-05-13 14:23:42 -0700 all the structs I checked in WebKit/chromium/public/ (WebRect, WebSize, WebFindOptions, WebScriptSource, etc.) put the constructor(s) after the data members. 225921 10 56009 abarth 2010-05-14 11:33:43 -0700 Comment on attachment 56009 syntax Ok. We might want to change all of those in the future. Thanks for being consistent with nearby existing code. 226200 11 56009 commit-queue 2010-05-15 02:21:56 -0700 Comment on attachment 56009 syntax Clearing flags on attachment: 56009 Committed r59529: <http://trac.webkit.org/changeset/59529> 226201 12 commit-queue 2010-05-15 02:22:02 -0700 All reviewed patches have been landed. Closing bug. 55899 2010-05-12 14:19:37 -0700 2010-05-13 12:40:50 -0700 try1 spellch.diff text/plain 1520 estade ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IGYxODgyZmEuLmJhOWIxNmUgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE5IEBACisyMDEwLTA1LTEyICBFdmFuIFN0YWRlICA8ZXN0YWRlQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbY2hyb21pdW1d ICJDaGVjayBzcGVsbGluZyBpbiB0aGlzIGZpZWxkIiBjb250ZXh0IG1lbnUgaXRlbSBhbHdheXMg Y2hlY2tlZCAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTM5MDE4CisKKyAgICAgICAgSW5pdGlhbGl6ZSB0aGUgdmFsdWUgaW4gdGhlIHN0cnVjdCB0byBm YWxzZS4KKworICAgICAgICBObyB0ZXN0cyBiZWNhdXNlIHRoaXMgY29kZSB3b3VsZCBuZWVkIHNv bWUgbWFqb3IgcmVmYWN0b3JpbmcgdG8gdW5pdAorICAgICAgICB0ZXN0LCBhbmQgQUZBSUNUIGl0 J3Mgbm90IHRlc3RhYmxlIHZpYSBsYXlvdXQgdGVzdHMuIFNlZSBub3RlIGF0IHRvcAorICAgICAg ICBvZiBnZXRDdXN0b21NZW51RnJvbURlZmF1bHRJdGVtcy4KKworICAgICAgICAqIHNyYy9Db250 ZXh0TWVudUNsaWVudEltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpDb250ZXh0TWVudUNsaWVu dEltcGw6OmdldEN1c3RvbU1lbnVGcm9tRGVmYXVsdEl0ZW1zKToKKwogMjAxMC0wNS0xMiAgSmVy ZW15IE9ybG93ICA8am9ybG93QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBT dGV2ZSBCbG9jay4KZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9zcmMvQ29udGV4dE1lbnVD bGllbnRJbXBsLmNwcCBiL1dlYktpdC9jaHJvbWl1bS9zcmMvQ29udGV4dE1lbnVDbGllbnRJbXBs LmNwcAppbmRleCBiZWU0MzEwLi44NTViN2VhIDEwMDY0NAotLS0gYS9XZWJLaXQvY2hyb21pdW0v c3JjL0NvbnRleHRNZW51Q2xpZW50SW1wbC5jcHAKKysrIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9D b250ZXh0TWVudUNsaWVudEltcGwuY3BwCkBAIC0yMDMsNiArMjAzLDcgQEAgUGxhdGZvcm1NZW51 RGVzY3JpcHRpb24gQ29udGV4dE1lbnVDbGllbnRJbXBsOjpnZXRDdXN0b21NZW51RnJvbURlZmF1 bHRJdGVtcygKICAgICAgICAgZGF0YS5zZWxlY3RlZFRleHQgPSBzZWxlY3RlZEZyYW1lLT5zZWxl Y3RlZFRleHQoKS5zdHJpcFdoaXRlU3BhY2UoKTsKIAogICAgIGRhdGEuaXNFZGl0YWJsZSA9IGZh bHNlOworICAgIGRhdGEuaXNTcGVsbENoZWNraW5nRW5hYmxlZCA9IGZhbHNlOwogICAgIGlmIChy LmlzQ29udGVudEVkaXRhYmxlKCkpIHsKICAgICAgICAgZGF0YS5pc0VkaXRhYmxlID0gdHJ1ZTsK ICAgICAgICAgaWYgKG1fd2ViVmlldy0+Zm9jdXNlZFdlYkNvcmVGcmFtZSgpLT5lZGl0b3IoKS0+ aXNDb250aW51b3VzU3BlbGxDaGVja2luZ0VuYWJsZWQoKSkgewo= 56007 2010-05-13 12:40:50 -0700 2010-05-13 13:02:06 -0700 do initing in default constructor try2.diff text/plain 3522 estade ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IGYxODgyZmEuLmZhNzEyYzEgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDIyIEBACisyMDEwLTA1LTEzICBFdmFuIFN0YWRlICA8ZXN0YWRlQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbY2hyb21pdW1d ICJDaGVjayBzcGVsbGluZyBpbiB0aGlzIGZpZWxkIiBjb250ZXh0IG1lbnUgaXRlbSBhbHdheXMg Y2hlY2tlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MzkwMTgKKworICAgICAgICBJbml0aWFsaXplIGFsbCBQT0QgbWVtYmVycyBvZiBXZWJDb250ZXh0 TWVudURhdGEgaW4gYSBkZWZhdWx0CisgICAgICAgIGNvbnN0cnVjdG9yLgorCisgICAgICAgIE5v IHRlc3RzIGJlY2F1c2UgdGhpcyBjb2RlIHdvdWxkIG5lZWQgc29tZSBtYWpvciByZWZhY3Rvcmlu ZyB0byB1bml0CisgICAgICAgIHRlc3QsIGFuZCBBRkFJQ1QgaXQncyBub3QgdGVzdGFibGUgdmlh IGxheW91dCB0ZXN0cy4gU2VlIG5vdGUgYXQgdG9wCisgICAgICAgIG9mIGdldEN1c3RvbU1lbnVG cm9tRGVmYXVsdEl0ZW1zLgorCisgICAgICAgICogcHVibGljL1dlYkNvbnRleHRNZW51RGF0YS5o OgorICAgICAgICAoV2ViS2l0OjpXZWJDb250ZXh0TWVudURhdGE6OldlYkNvbnRleHRNZW51RGF0 YSk6CisgICAgICAgICogc3JjL0NvbnRleHRNZW51Q2xpZW50SW1wbC5jcHA6CisgICAgICAgIChX ZWJLaXQ6OkNvbnRleHRNZW51Q2xpZW50SW1wbDo6Z2V0Q3VzdG9tTWVudUZyb21EZWZhdWx0SXRl bXMpOgorCiAyMDEwLTA1LTEyICBKZXJlbXkgT3Jsb3cgIDxqb3Jsb3dAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFJldmlld2VkIGJ5IFN0ZXZlIEJsb2NrLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2No cm9taXVtL3B1YmxpYy9XZWJDb250ZXh0TWVudURhdGEuaCBiL1dlYktpdC9jaHJvbWl1bS9wdWJs aWMvV2ViQ29udGV4dE1lbnVEYXRhLmgKaW5kZXggMjUwMzZkNC4uMWYwNDM1OSAxMDA2NDQKLS0t IGEvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJDb250ZXh0TWVudURhdGEuaAorKysgYi9XZWJL aXQvY2hyb21pdW0vcHVibGljL1dlYkNvbnRleHRNZW51RGF0YS5oCkBAIC0xMzQsNiArMTM0LDE3 IEBAIHN0cnVjdCBXZWJDb250ZXh0TWVudURhdGEgewogCiAgICAgLy8gQ3VzdG9tIGNvbnRleHQg bWVudSBpdGVtcyBwcm92aWRlZCBieSB0aGUgV2ViQ29yZSBpbnRlcm5hbHMuCiAgICAgV2ViVmVj dG9yPFdlYk1lbnVJdGVtSW5mbz4gY3VzdG9tSXRlbXM7CisKKyAgICBXZWJDb250ZXh0TWVudURh dGEoKQorICAgICAgICA6IG1lZGlhVHlwZShNZWRpYVR5cGVOb25lKQorICAgICAgICAsIGlzSW1h Z2VCbG9ja2VkKGZhbHNlKQorICAgICAgICAsIG1lZGlhRmxhZ3MoTWVkaWFOb25lKQorICAgICAg ICAsIGlzU3BlbGxDaGVja2luZ0VuYWJsZWQoZmFsc2UpLAorICAgICAgICAsIGlzRWRpdGFibGUo ZmFsc2UpLAorICAgICAgICAsIHdyaXRpbmdEaXJlY3Rpb25EZWZhdWx0KENoZWNrYWJsZU1lbnVJ dGVtRGlzYWJsZWQpCisgICAgICAgICwgd3JpdGluZ0RpcmVjdGlvbkxlZnRUb1JpZ2h0KENoZWNr YWJsZU1lbnVJdGVtRW5hYmxlZCkKKyAgICAgICAgLCB3cml0aW5nRGlyZWN0aW9uUmlnaHRUb0xl ZnQoQ2hlY2thYmxlTWVudUl0ZW1FbmFibGVkKQorICAgICAgICAsIGVkaXRGbGFncygwKSB7IH0K IH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYktpdApkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVt L3NyYy9Db250ZXh0TWVudUNsaWVudEltcGwuY3BwIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9Db250 ZXh0TWVudUNsaWVudEltcGwuY3BwCmluZGV4IGJlZTQzMTAuLmI2MDA1ZjkgMTAwNjQ0Ci0tLSBh L1dlYktpdC9jaHJvbWl1bS9zcmMvQ29udGV4dE1lbnVDbGllbnRJbXBsLmNwcAorKysgYi9XZWJL aXQvY2hyb21pdW0vc3JjL0NvbnRleHRNZW51Q2xpZW50SW1wbC5jcHAKQEAgLTE1MSw5ICsxNTEs NiBAQCBQbGF0Zm9ybU1lbnVEZXNjcmlwdGlvbiBDb250ZXh0TWVudUNsaWVudEltcGw6OmdldEN1 c3RvbU1lbnVGcm9tRGVmYXVsdEl0ZW1zKAogICAgIC8vIGFsbCBlbHNlLgogICAgIGRhdGEubGlu a1VSTCA9IHIuYWJzb2x1dGVMaW5rVVJMKCk7CiAKLSAgICBkYXRhLm1lZGlhVHlwZSA9IFdlYkNv bnRleHRNZW51RGF0YTo6TWVkaWFUeXBlTm9uZTsKLSAgICBkYXRhLm1lZGlhRmxhZ3MgPSBXZWJD b250ZXh0TWVudURhdGE6Ok1lZGlhTm9uZTsKLQogICAgIGlmICghci5hYnNvbHV0ZUltYWdlVVJM KCkuaXNFbXB0eSgpKSB7CiAgICAgICAgIGRhdGEuc3JjVVJMID0gci5hYnNvbHV0ZUltYWdlVVJM KCk7CiAgICAgICAgIGRhdGEubWVkaWFUeXBlID0gV2ViQ29udGV4dE1lbnVEYXRhOjpNZWRpYVR5 cGVJbWFnZTsKQEAgLTIwMiw3ICsxOTksNiBAQCBQbGF0Zm9ybU1lbnVEZXNjcmlwdGlvbiBDb250 ZXh0TWVudUNsaWVudEltcGw6OmdldEN1c3RvbU1lbnVGcm9tRGVmYXVsdEl0ZW1zKAogICAgIGlm IChyLmlzU2VsZWN0ZWQoKSkKICAgICAgICAgZGF0YS5zZWxlY3RlZFRleHQgPSBzZWxlY3RlZEZy YW1lLT5zZWxlY3RlZFRleHQoKS5zdHJpcFdoaXRlU3BhY2UoKTsKIAotICAgIGRhdGEuaXNFZGl0 YWJsZSA9IGZhbHNlOwogICAgIGlmIChyLmlzQ29udGVudEVkaXRhYmxlKCkpIHsKICAgICAgICAg ZGF0YS5pc0VkaXRhYmxlID0gdHJ1ZTsKICAgICAgICAgaWYgKG1fd2ViVmlldy0+Zm9jdXNlZFdl YkNvcmVGcmFtZSgpLT5lZGl0b3IoKS0+aXNDb250aW51b3VzU3BlbGxDaGVja2luZ0VuYWJsZWQo KSkgewpAQCAtMjEyLDExICsyMDgsNiBAQCBQbGF0Zm9ybU1lbnVEZXNjcmlwdGlvbiBDb250ZXh0 TWVudUNsaWVudEltcGw6OmdldEN1c3RvbU1lbnVGcm9tRGVmYXVsdEl0ZW1zKAogICAgIH0KIAog I2lmIE9TKERBUldJTikKLSAgICAvLyBXcml0aW5nIGRpcmVjdGlvbiBjb250ZXh0IG1lbnUuCi0g ICAgZGF0YS53cml0aW5nRGlyZWN0aW9uRGVmYXVsdCA9IFdlYkNvbnRleHRNZW51RGF0YTo6Q2hl Y2thYmxlTWVudUl0ZW1EaXNhYmxlZDsKLSAgICBkYXRhLndyaXRpbmdEaXJlY3Rpb25MZWZ0VG9S aWdodCA9IFdlYkNvbnRleHRNZW51RGF0YTo6Q2hlY2thYmxlTWVudUl0ZW1FbmFibGVkOwotICAg IGRhdGEud3JpdGluZ0RpcmVjdGlvblJpZ2h0VG9MZWZ0ID0gV2ViQ29udGV4dE1lbnVEYXRhOjpD aGVja2FibGVNZW51SXRlbUVuYWJsZWQ7Ci0KICAgICBFeGNlcHRpb25Db2RlIGVjID0gMDsKICAg ICBSZWZQdHI8Q1NTU3R5bGVEZWNsYXJhdGlvbj4gc3R5bGUgPSBzZWxlY3RlZEZyYW1lLT5kb2N1 bWVudCgpLT5jcmVhdGVDU1NTdHlsZURlY2xhcmF0aW9uKCk7CiAgICAgc3R5bGUtPnNldFByb3Bl cnR5KENTU1Byb3BlcnR5RGlyZWN0aW9uLCAibHRyIiwgZmFsc2UsIGVjKTsK 56009 2010-05-13 13:02:06 -0700 2010-05-15 02:21:55 -0700 syntax try2.diff text/plain 3520 estade ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IGYxODgyZmEuLmZhNzEyYzEgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDIyIEBACisyMDEwLTA1LTEzICBFdmFuIFN0YWRlICA8ZXN0YWRlQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbY2hyb21pdW1d ICJDaGVjayBzcGVsbGluZyBpbiB0aGlzIGZpZWxkIiBjb250ZXh0IG1lbnUgaXRlbSBhbHdheXMg Y2hlY2tlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MzkwMTgKKworICAgICAgICBJbml0aWFsaXplIGFsbCBQT0QgbWVtYmVycyBvZiBXZWJDb250ZXh0 TWVudURhdGEgaW4gYSBkZWZhdWx0CisgICAgICAgIGNvbnN0cnVjdG9yLgorCisgICAgICAgIE5v IHRlc3RzIGJlY2F1c2UgdGhpcyBjb2RlIHdvdWxkIG5lZWQgc29tZSBtYWpvciByZWZhY3Rvcmlu ZyB0byB1bml0CisgICAgICAgIHRlc3QsIGFuZCBBRkFJQ1QgaXQncyBub3QgdGVzdGFibGUgdmlh IGxheW91dCB0ZXN0cy4gU2VlIG5vdGUgYXQgdG9wCisgICAgICAgIG9mIGdldEN1c3RvbU1lbnVG cm9tRGVmYXVsdEl0ZW1zLgorCisgICAgICAgICogcHVibGljL1dlYkNvbnRleHRNZW51RGF0YS5o OgorICAgICAgICAoV2ViS2l0OjpXZWJDb250ZXh0TWVudURhdGE6OldlYkNvbnRleHRNZW51RGF0 YSk6CisgICAgICAgICogc3JjL0NvbnRleHRNZW51Q2xpZW50SW1wbC5jcHA6CisgICAgICAgIChX ZWJLaXQ6OkNvbnRleHRNZW51Q2xpZW50SW1wbDo6Z2V0Q3VzdG9tTWVudUZyb21EZWZhdWx0SXRl bXMpOgorCiAyMDEwLTA1LTEyICBKZXJlbXkgT3Jsb3cgIDxqb3Jsb3dAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFJldmlld2VkIGJ5IFN0ZXZlIEJsb2NrLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2No cm9taXVtL3B1YmxpYy9XZWJDb250ZXh0TWVudURhdGEuaCBiL1dlYktpdC9jaHJvbWl1bS9wdWJs aWMvV2ViQ29udGV4dE1lbnVEYXRhLmgKaW5kZXggMjUwMzZkNC4uMWYwNDM1OSAxMDA2NDQKLS0t IGEvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJDb250ZXh0TWVudURhdGEuaAorKysgYi9XZWJL aXQvY2hyb21pdW0vcHVibGljL1dlYkNvbnRleHRNZW51RGF0YS5oCkBAIC0xMzQsNiArMTM0LDE3 IEBAIHN0cnVjdCBXZWJDb250ZXh0TWVudURhdGEgewogCiAgICAgLy8gQ3VzdG9tIGNvbnRleHQg bWVudSBpdGVtcyBwcm92aWRlZCBieSB0aGUgV2ViQ29yZSBpbnRlcm5hbHMuCiAgICAgV2ViVmVj dG9yPFdlYk1lbnVJdGVtSW5mbz4gY3VzdG9tSXRlbXM7CisKKyAgICBXZWJDb250ZXh0TWVudURh dGEoKQorICAgICAgICA6IG1lZGlhVHlwZShNZWRpYVR5cGVOb25lKQorICAgICAgICAsIGlzSW1h Z2VCbG9ja2VkKGZhbHNlKQorICAgICAgICAsIG1lZGlhRmxhZ3MoTWVkaWFOb25lKQorICAgICAg ICAsIGlzU3BlbGxDaGVja2luZ0VuYWJsZWQoZmFsc2UpCisgICAgICAgICwgaXNFZGl0YWJsZShm YWxzZSkKKyAgICAgICAgLCB3cml0aW5nRGlyZWN0aW9uRGVmYXVsdChDaGVja2FibGVNZW51SXRl bURpc2FibGVkKQorICAgICAgICAsIHdyaXRpbmdEaXJlY3Rpb25MZWZ0VG9SaWdodChDaGVja2Fi bGVNZW51SXRlbUVuYWJsZWQpCisgICAgICAgICwgd3JpdGluZ0RpcmVjdGlvblJpZ2h0VG9MZWZ0 KENoZWNrYWJsZU1lbnVJdGVtRW5hYmxlZCkKKyAgICAgICAgLCBlZGl0RmxhZ3MoMCkgeyB9CiB9 OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQKZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9z cmMvQ29udGV4dE1lbnVDbGllbnRJbXBsLmNwcCBiL1dlYktpdC9jaHJvbWl1bS9zcmMvQ29udGV4 dE1lbnVDbGllbnRJbXBsLmNwcAppbmRleCBiZWU0MzEwLi5iNjAwNWY5IDEwMDY0NAotLS0gYS9X ZWJLaXQvY2hyb21pdW0vc3JjL0NvbnRleHRNZW51Q2xpZW50SW1wbC5jcHAKKysrIGIvV2ViS2l0 L2Nocm9taXVtL3NyYy9Db250ZXh0TWVudUNsaWVudEltcGwuY3BwCkBAIC0xNTEsOSArMTUxLDYg QEAgUGxhdGZvcm1NZW51RGVzY3JpcHRpb24gQ29udGV4dE1lbnVDbGllbnRJbXBsOjpnZXRDdXN0 b21NZW51RnJvbURlZmF1bHRJdGVtcygKICAgICAvLyBhbGwgZWxzZS4KICAgICBkYXRhLmxpbmtV UkwgPSByLmFic29sdXRlTGlua1VSTCgpOwogCi0gICAgZGF0YS5tZWRpYVR5cGUgPSBXZWJDb250 ZXh0TWVudURhdGE6Ok1lZGlhVHlwZU5vbmU7Ci0gICAgZGF0YS5tZWRpYUZsYWdzID0gV2ViQ29u dGV4dE1lbnVEYXRhOjpNZWRpYU5vbmU7Ci0KICAgICBpZiAoIXIuYWJzb2x1dGVJbWFnZVVSTCgp LmlzRW1wdHkoKSkgewogICAgICAgICBkYXRhLnNyY1VSTCA9IHIuYWJzb2x1dGVJbWFnZVVSTCgp OwogICAgICAgICBkYXRhLm1lZGlhVHlwZSA9IFdlYkNvbnRleHRNZW51RGF0YTo6TWVkaWFUeXBl SW1hZ2U7CkBAIC0yMDIsNyArMTk5LDYgQEAgUGxhdGZvcm1NZW51RGVzY3JpcHRpb24gQ29udGV4 dE1lbnVDbGllbnRJbXBsOjpnZXRDdXN0b21NZW51RnJvbURlZmF1bHRJdGVtcygKICAgICBpZiAo ci5pc1NlbGVjdGVkKCkpCiAgICAgICAgIGRhdGEuc2VsZWN0ZWRUZXh0ID0gc2VsZWN0ZWRGcmFt ZS0+c2VsZWN0ZWRUZXh0KCkuc3RyaXBXaGl0ZVNwYWNlKCk7CiAKLSAgICBkYXRhLmlzRWRpdGFi bGUgPSBmYWxzZTsKICAgICBpZiAoci5pc0NvbnRlbnRFZGl0YWJsZSgpKSB7CiAgICAgICAgIGRh dGEuaXNFZGl0YWJsZSA9IHRydWU7CiAgICAgICAgIGlmIChtX3dlYlZpZXctPmZvY3VzZWRXZWJD b3JlRnJhbWUoKS0+ZWRpdG9yKCktPmlzQ29udGludW91c1NwZWxsQ2hlY2tpbmdFbmFibGVkKCkp IHsKQEAgLTIxMiwxMSArMjA4LDYgQEAgUGxhdGZvcm1NZW51RGVzY3JpcHRpb24gQ29udGV4dE1l bnVDbGllbnRJbXBsOjpnZXRDdXN0b21NZW51RnJvbURlZmF1bHRJdGVtcygKICAgICB9CiAKICNp ZiBPUyhEQVJXSU4pCi0gICAgLy8gV3JpdGluZyBkaXJlY3Rpb24gY29udGV4dCBtZW51LgotICAg IGRhdGEud3JpdGluZ0RpcmVjdGlvbkRlZmF1bHQgPSBXZWJDb250ZXh0TWVudURhdGE6OkNoZWNr YWJsZU1lbnVJdGVtRGlzYWJsZWQ7Ci0gICAgZGF0YS53cml0aW5nRGlyZWN0aW9uTGVmdFRvUmln aHQgPSBXZWJDb250ZXh0TWVudURhdGE6OkNoZWNrYWJsZU1lbnVJdGVtRW5hYmxlZDsKLSAgICBk YXRhLndyaXRpbmdEaXJlY3Rpb25SaWdodFRvTGVmdCA9IFdlYkNvbnRleHRNZW51RGF0YTo6Q2hl Y2thYmxlTWVudUl0ZW1FbmFibGVkOwotCiAgICAgRXhjZXB0aW9uQ29kZSBlYyA9IDA7CiAgICAg UmVmUHRyPENTU1N0eWxlRGVjbGFyYXRpb24+IHN0eWxlID0gc2VsZWN0ZWRGcmFtZS0+ZG9jdW1l bnQoKS0+Y3JlYXRlQ1NTU3R5bGVEZWNsYXJhdGlvbigpOwogICAgIHN0eWxlLT5zZXRQcm9wZXJ0 eShDU1NQcm9wZXJ0eURpcmVjdGlvbiwgImx0ciIsIGZhbHNlLCBlYyk7Cg==