39016 2010-05-12 12:49:26 -0700 [Qt] Regression(r59152): QGraphicsPageClient is not forwarding scroll and update events to view 2010-05-13 11:57:44 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All RESOLVED FIXED Qt, QtTriaged P1 Normal --- 1 tonikitoo kenneth hausmann jesus tonikitoo oldest_to_newest 224816 0 tonikitoo 2010-05-12 12:49:26 -0700 methods below miss view->scroll() and view->update() calls, respectively. void PageClientQGraphicsWidget::scroll(int dx, int dy, const QRect& rectToScroll) { #if USE(ACCELERATED_COMPOSITING) updateCompositingScrollPosition(); #endif } void PageClientQGraphicsWidget::update(const QRect & dirtyRect) { if (overlay) overlay->update(QRectF(dirtyRect)); #if USE(ACCELERATED_COMPOSITING) syncLayers(); #endif } kenneth has a patch... 224848 1 55892 tonikitoo 2010-05-12 13:34:41 -0700 Created attachment 55892 patch v1 224850 2 tonikitoo 2010-05-12 13:36:39 -0700 (In reply to comment #1) > Created an attachment (id=55892) [details] > patch v1 just created the bug and uploaded the patch on behalf of kenneth. The fix is his. 224853 3 jesus 2010-05-12 13:39:45 -0700 (In reply to comment #0) > methods below miss view->scroll() and view->update() calls, respectively. Hmmm... my fault. =/ I had this on a previous version of that patch but something went wrong during all rounds of rebases and adding/removing APIs. =// Thanks for fixing this! The patch LGTM. 224972 4 55892 laszlo.gombos 2010-05-12 16:19:29 -0700 Comment on attachment 55892 patch v1 lgtm, r+. 225300 5 tonikitoo 2010-05-13 07:54:26 -0700 *** Bug 39066 has been marked as a duplicate of this bug. *** 225306 6 tonikitoo 2010-05-13 07:56:56 -0700 *** Bug 39069 has been marked as a duplicate of this bug. *** 225417 7 tonikitoo 2010-05-13 11:57:44 -0700 Committed r59377: <http://trac.webkit.org/changeset/59377> 55892 2010-05-12 13:34:41 -0700 2010-05-13 11:35:17 -0700 patch v1 0001-Qt-Regression-r59152-QGraphicsPageClient-is-not-forw.patch text/plain 2769 tonikitoo RnJvbSBkNmMzZjk1OTM4Nzk3NzE2ODYzOTA5ODNhMzJiZWExNDFmNmU2ZDAxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4K RGF0ZTogV2VkLCAxMiBNYXkgMjAxMCAxNjozMzozOSAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIFtR dF0gUmVncmVzc2lvbihyNTkxNTIpOiBRR3JhcGhpY3NQYWdlQ2xpZW50IGlzIG5vdCBmb3J3YXJk aW5nIHNjcm9sbCBhbmQgdXBkYXRlIGV2ZW50cyB0byB2aWV3CiBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzkwMTYKClBhdGNoIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0 aWFuc2VuIDxrZW5uZXRoQHdlYmtpdC5vcmc+IG9uIDIwMTAtMDUtMTIKUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCgpTb21lIGZvcndhcmQgY2FsbHMgZ290IGxvc3QgZHVyaW5nIHRoZSByZWZh dG9yeS4KCiogV2ViQ29yZVN1cHBvcnQvUGFnZUNsaWVudFF0LmNwcDoKKFdlYkNvcmU6OlBhZ2VD bGllbnRRR3JhcGhpY3NXaWRnZXQ6OnNjcm9sbCk6CihXZWJDb3JlOjpQYWdlQ2xpZW50UUdyYXBo aWNzV2lkZ2V0Ojp1cGRhdGUpOgotLS0KIFdlYktpdC9xdC9DaGFuZ2VMb2cgICAgICAgICAgICAg ICAgICAgICAgIHwgICAxMyArKysrKysrKysrKysrCiBXZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQv UGFnZUNsaWVudFF0LmNwcCB8ICAgIDYgKysrKystCiAyIGZpbGVzIGNoYW5nZWQsIDE4IGluc2Vy dGlvbnMoKyksIDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViS2l0L3F0L0NoYW5nZUxv ZyBiL1dlYktpdC9xdC9DaGFuZ2VMb2cKaW5kZXggMTUxNzhhMC4uMDA0NGNkNiAxMDA2NDQKLS0t IGEvV2ViS2l0L3F0L0NoYW5nZUxvZworKysgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDgg KzEsMjEgQEAKKzIwMTAtMDUtMTIgIEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuICA8a2VubmV0 aEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFtRdF0gUmVncmVzc2lvbihyNTkxNTIpOiBRR3JhcGhpY3NQYWdlQ2xpZW50IGlzIG5v dCBmb3J3YXJkaW5nIHNjcm9sbCBhbmQgdXBkYXRlIGV2ZW50cyB0byB2aWV3CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zOTAxNgorCisgICAgICAgIFNv bWUgZm9yd2FyZCBjYWxscyBnb3QgbG9zdCBkdXJpbmcgdGhlIHJlZmF0b3J5LgorCisgICAgICAg ICogV2ViQ29yZVN1cHBvcnQvUGFnZUNsaWVudFF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBh Z2VDbGllbnRRR3JhcGhpY3NXaWRnZXQ6OnNjcm9sbCk6CisgICAgICAgIChXZWJDb3JlOjpQYWdl Q2xpZW50UUdyYXBoaWNzV2lkZ2V0Ojp1cGRhdGUpOgorCiAyMDEwLTA1LTEyICBBbnRvbmlvIEdv bWVzICA8dG9uaWtpdG9vQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0 aCBDaHJpc3RpYW5zZW4uCiAKICAgICAgICAgW1F0XSBSZW1vdmUgdGhlIHVubmVlZGVkIGNoZWNr IGZvciBRV2lkZ2V0UGFnZUNsaWVudCBAUUdyYXBoaWNzV2ViVmlldzo6ZGV0YWNoQ3VycmVudFBh Z2UKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM4OTg5 CiAKICAgICAgICAgUmVhc29uczoKZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9y dC9QYWdlQ2xpZW50UXQuY3BwIGIvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L1BhZ2VDbGllbnRR dC5jcHAKaW5kZXggN2ZmMmQwMy4uZTE5ZjQ0ZiAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0L1dlYkNv cmVTdXBwb3J0L1BhZ2VDbGllbnRRdC5jcHAKKysrIGIvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0 L1BhZ2VDbGllbnRRdC5jcHAKQEAgLTExMSwyMyArMTExLDI3IEBAIFBhZ2VDbGllbnRRR3JhcGhp Y3NXaWRnZXQ6On5QYWdlQ2xpZW50UUdyYXBoaWNzV2lkZ2V0KCkKICAgICAvLyB3ZSBkb24ndCBu ZWVkIHRvIGRlbGV0ZSB0aGUgcm9vdCBncmFwaGljcyBsYXllci4gVGhlIGxpZmVjeWNsZSBpcyBt YW5hZ2VkIGluIEdyYXBoaWNzTGF5ZXJRdC5jcHAuCiAgICAgcm9vdEdyYXBoaWNzTGF5ZXIuZGF0 YSgpLT5zZXRQYXJlbnRJdGVtKDApOwogICAgIHZpZXctPnNjZW5lKCktPnJlbW92ZUl0ZW0ocm9v dEdyYXBoaWNzTGF5ZXIuZGF0YSgpKTsKICNlbmRpZgogfQogCiB2b2lkIFBhZ2VDbGllbnRRR3Jh cGhpY3NXaWRnZXQ6OnNjcm9sbChpbnQgZHgsIGludCBkeSwgY29uc3QgUVJlY3QmIHJlY3RUb1Nj cm9sbCkKIHsKKyAgICB2aWV3LT5zY3JvbGwocXJlYWwoZHgpLCBxcmVhbChkeSksIHJlY3RUb1Nj cm9sbCk7CisKICNpZiBVU0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcpCiAgICAgdXBkYXRlQ29t cG9zaXRpbmdTY3JvbGxQb3NpdGlvbigpOwogI2VuZGlmCiB9CiAKLXZvaWQgUGFnZUNsaWVudFFH cmFwaGljc1dpZGdldDo6dXBkYXRlKGNvbnN0IFFSZWN0ICYgZGlydHlSZWN0KQordm9pZCBQYWdl Q2xpZW50UUdyYXBoaWNzV2lkZ2V0Ojp1cGRhdGUoY29uc3QgUVJlY3QmIGRpcnR5UmVjdCkKIHsK KyAgICB2aWV3LT51cGRhdGUoZGlydHlSZWN0KTsKKwogICAgIGNyZWF0ZU9yRGVsZXRlT3Zlcmxh eSgpOwogICAgIGlmIChvdmVybGF5KQogICAgICAgICBvdmVybGF5LT51cGRhdGUoUVJlY3RGKGRp cnR5UmVjdCkpOwogI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKICAgICBzeW5jTGF5 ZXJzKCk7CiAjZW5kaWYKIH0KIAotLSAKMS42LjMuMwoK