39015 2010-05-12 12:45:59 -0700 [chromium] Avoid crash when msttcorefonts aren't provided 2010-05-24 14:25:39 -0700 1 1 1 Unclassified WebKit Text 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 agl webkit-unassigned webkit.review.bot oldest_to_newest 224812 0 agl 2010-05-12 12:45:59 -0700 http://code.google.com/p/chromium/issues/detail?id=43831 224815 1 55888 agl 2010-05-12 12:48:13 -0700 Created attachment 55888 patch 224819 2 webkit.review.bot 2010-05-12 12:51:05 -0700 Attachment 55888 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/platform/graphics/chromium/FontCacheLinux.cpp:133: One space before end of line comments [whitespace/comments] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 224821 3 55889 agl 2010-05-12 12:53:02 -0700 Created attachment 55889 patch 225172 4 evan 2010-05-13 00:12:15 -0700 LGTM. Might want to note what you're actually changing in the changelog. I'm not sure why this code used to work... 227923 5 levin 2010-05-19 11:53:53 -0700 Why is there no layout test? 227936 6 agl 2010-05-19 12:03:53 -0700 (In reply to comment #5) > Why is there no layout test? Our tests run with these fonts available (and they're critical to hundreds of other tests). 228013 7 levin 2010-05-19 15:16:20 -0700 One last attempt, would this trigger the code path? <html> <body> <span style="font-family: -webkit-family-will-not-be-found;">Foo</span> </body> </html> 228015 8 agl 2010-05-19 15:27:16 -0700 (In reply to comment #7) > One last attempt, would this trigger the code path? > <html> > <body> > <span style="font-family: -webkit-family-will-not-be-found;">Foo</span> > </body> > </html> Sadly yes. But the thought of burning hours away on another layout test has just sapped my will to live so I'm going to head home instead. 228039 9 agl 2010-05-19 16:06:48 -0700 > Sadly yes. But the thought of burning hours away on another layout test has just sapped my will to live so I'm going to head home instead. That was shitty of me to take WebKit frustrations out on you. Thanks for finding the test case. 228040 10 56529 agl 2010-05-19 16:07:11 -0700 Created attachment 56529 patch 229907 11 agl 2010-05-24 14:25:39 -0700 r59835 55888 2010-05-12 12:48:13 -0700 2010-05-12 12:53:02 -0700 patch patch text/plain 1332 agl ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZmEwYTI0NS4uYzhjMjJkNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNS0xMiAgQWRhbSBMYW5nbGV5 ICA8YWdsQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBbY2hyb21pdW1dIEF2b2lkIGNyYXNoIHdoZW4gbXN0dGNvcmVmb250cyBh cmVuJ3QgcHJvdmlkZWQKKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MzkwMTUKKyAgICAgICAgaHR0cDovL2NvZGUuZ29vZ2xlLmNvbS9wL2Nocm9taXVt L2lzc3Vlcy9kZXRhaWw/aWQ9NDM4MzEKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2No cm9taXVtL0ZvbnRDYWNoZUxpbnV4LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZvbnRDYWNoZTo6 Y3JlYXRlRm9udFBsYXRmb3JtRGF0YSk6CisKIDIwMTAtMDUtMTIgIHlhZWwgYWhhcm9uICA8eWFl bC5haGFyb25Abm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhbiBCZXJuc3RlaW4u CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ZvbnRDYWNo ZUxpbnV4LmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vRm9udENhY2hl TGludXguY3BwCmluZGV4IGVjZWNkMTMuLjUwNzkwYjAgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vRm9udENhY2hlTGludXguY3BwCisrKyBiL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vRm9udENhY2hlTGludXguY3BwCkBAIC0xMjgsOSAr MTI4LDkgQEAgRm9udFBsYXRmb3JtRGF0YSogRm9udENhY2hlOjpjcmVhdGVGb250UGxhdGZvcm1E YXRhKGNvbnN0IEZvbnREZXNjcmlwdGlvbiYgZm9udEQKICAgICAgICAgICAgICAgICBicmVhazsK ICAgICAgICAgICAgIH0KICAgICAgICAgfQotICAgICAgICAvLyBpZiB3ZSBmYWxsIG91dCBvZiB0 aGUgbG9vcCwgaXQncyBvayBmb3IgbmFtZSB0byBzdGlsbCBiZSAwCi0gICAgfQotICAgIGVsc2Ug eyAgICAvLyBjb252ZXJ0IHRoZSBuYW1lIHRvIHV0ZjgKKyAgICAgICAgaWYgKCFuYW1lKQorICAg ICAgICAgICAgbmFtZSA9ICIiOworICAgIH0gZWxzZSB7ICAgIC8vIGNvbnZlcnQgdGhlIG5hbWUg dG8gdXRmOAogICAgICAgICBzID0gZmFtaWx5LnN0cmluZygpLnV0ZjgoKTsKICAgICAgICAgbmFt ZSA9IHMuZGF0YSgpOwogICAgIH0K 55889 2010-05-12 12:53:02 -0700 2010-05-19 16:07:11 -0700 patch patch text/plain 1339 agl ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZmEwYTI0NS4uYzhjMjJkNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNS0xMiAgQWRhbSBMYW5nbGV5 ICA8YWdsQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBbY2hyb21pdW1dIEF2b2lkIGNyYXNoIHdoZW4gbXN0dGNvcmVmb250cyBh cmVuJ3QgcHJvdmlkZWQKKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MzkwMTUKKyAgICAgICAgaHR0cDovL2NvZGUuZ29vZ2xlLmNvbS9wL2Nocm9taXVt L2lzc3Vlcy9kZXRhaWw/aWQ9NDM4MzEKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2No cm9taXVtL0ZvbnRDYWNoZUxpbnV4LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZvbnRDYWNoZTo6 Y3JlYXRlRm9udFBsYXRmb3JtRGF0YSk6CisKIDIwMTAtMDUtMTIgIHlhZWwgYWhhcm9uICA8eWFl bC5haGFyb25Abm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhbiBCZXJuc3RlaW4u CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ZvbnRDYWNo ZUxpbnV4LmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vRm9udENhY2hl TGludXguY3BwCmluZGV4IGVjZWNkMTMuLjUzZjRhNTIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vRm9udENhY2hlTGludXguY3BwCisrKyBiL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vRm9udENhY2hlTGludXguY3BwCkBAIC0xMjgsOSAr MTI4LDEwIEBAIEZvbnRQbGF0Zm9ybURhdGEqIEZvbnRDYWNoZTo6Y3JlYXRlRm9udFBsYXRmb3Jt RGF0YShjb25zdCBGb250RGVzY3JpcHRpb24mIGZvbnRECiAgICAgICAgICAgICAgICAgYnJlYWs7 CiAgICAgICAgICAgICB9CiAgICAgICAgIH0KLSAgICAgICAgLy8gaWYgd2UgZmFsbCBvdXQgb2Yg dGhlIGxvb3AsIGl0J3Mgb2sgZm9yIG5hbWUgdG8gc3RpbGwgYmUgMAotICAgIH0KLSAgICBlbHNl IHsgICAgLy8gY29udmVydCB0aGUgbmFtZSB0byB1dGY4CisgICAgICAgIGlmICghbmFtZSkKKyAg ICAgICAgICAgIG5hbWUgPSAiIjsKKyAgICB9IGVsc2UgeworICAgICAgICAvLyBjb252ZXJ0IHRo ZSBuYW1lIHRvIHV0ZjgKICAgICAgICAgcyA9IGZhbWlseS5zdHJpbmcoKS51dGY4KCk7CiAgICAg ICAgIG5hbWUgPSBzLmRhdGEoKTsKICAgICB9Cg== 56529 2010-05-19 16:07:11 -0700 2010-05-19 16:10:57 -0700 patch patch text/plain 3029 agl ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA1OWI1YjA0Li4yOTU3NDBmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDUt MTkgIEFkYW0gTGFuZ2xleSAgPGFnbEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW2Nocm9taXVtXSBBZGQgdGVzdCB3aGljaCBw cmV2aW91c2x5IGNyYXNoZWQgb24gTGludXguCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTM5MDE1CisgICAgICAgIGh0dHA6Ly9jb2RlLmdvb2dsZS5j b20vcC9jaHJvbWl1bS9pc3N1ZXMvZGV0YWlsP2lkPTQzODMxCisKKyAgICAgICAgKiBmYXN0L3Rl eHQvY2hyb21pdW0tbGludXgtZmFsbGJhY2stY3Jhc2gtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAg ICAgICAgKiBmYXN0L3RleHQvY2hyb21pdW0tbGludXgtZmFsbGJhY2stY3Jhc2guaHRtbDogQWRk ZWQuCisKIDIwMTAtMDUtMTkgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgVHJ5IGFnYWluIHRvIHJvbGwgb3V0IHI1ODc2NQpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvZmFzdC90ZXh0L2Nocm9taXVtLWxpbnV4LWZhbGxiYWNrLWNyYXNoLWV4cGVjdGVkLnR4 dCBiL0xheW91dFRlc3RzL2Zhc3QvdGV4dC9jaHJvbWl1bS1saW51eC1mYWxsYmFjay1jcmFzaC1l eHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uMzM0MjM4Mgot LS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvdGV4dC9jaHJvbWl1bS1saW51eC1m YWxsYmFjay1jcmFzaC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwzIEBACitQcmV2aW91c2x5IHRo aXMgd291bGQgY3Jhc2ggQ2hyb21pdW0gTGludXggYnkgdHJpZ2dlcmluZyBhIE5VTEwgcG9pbnRl ciBkZXJlZmVyZW5jZSBpbiB0aGUgZm9udCBmYWxsYmFjayBjb2RlLgorCitGb28KZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL2Zhc3QvdGV4dC9jaHJvbWl1bS1saW51eC1mYWxsYmFjay1jcmFzaC5o dG1sIGIvTGF5b3V0VGVzdHMvZmFzdC90ZXh0L2Nocm9taXVtLWxpbnV4LWZhbGxiYWNrLWNyYXNo Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uNDg3YmYwYQotLS0gL2Rl di9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvdGV4dC9jaHJvbWl1bS1saW51eC1mYWxsYmFj ay1jcmFzaC5odG1sCkBAIC0wLDAgKzEsMTIgQEAKKzxodG1sPgorICA8c2NyaXB0PgorICAgIGlm ICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICBsYXlvdXRUZXN0Q29udHJvbGxl ci5kdW1wQXNUZXh0KCk7CisgIDwvc2NyaXB0PgorCisgIDxib2R5PgorICAgIDxwPlByZXZpb3Vz bHkgdGhpcyB3b3VsZCBjcmFzaCBDaHJvbWl1bSBMaW51eCBieSB0cmlnZ2VyaW5nIGEgTlVMTCBw b2ludGVyIGRlcmVmZXJlbmNlIGluIHRoZSBmb250IGZhbGxiYWNrIGNvZGUuPC9wPgorCisgICAg PHNwYW4gc3R5bGU9ImZvbnQtZmFtaWx5OiAtd2Via2l0LWZhbWlseS13aWxsLW5vdC1iZS1mb3Vu ZDsiPkZvbzwvc3Bhbj4KKyAgPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9D aGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA0YjgwZWE4Li4zYmQ4ZDQ3IDEwMDY0 NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE1IEBACisyMDEwLTA1LTEyICBBZGFtIExhbmdsZXkgIDxhZ2xAY2hyb21pdW0ub3JnPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1 bV0gQXZvaWQgY3Jhc2ggd2hlbiBtc3R0Y29yZWZvbnRzIGFyZW4ndCBwcm92aWRlZAorCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zOTAxNQorICAgICAg ICBodHRwOi8vY29kZS5nb29nbGUuY29tL3AvY2hyb21pdW0vaXNzdWVzL2RldGFpbD9pZD00Mzgz MQorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vRm9udENhY2hlTGludXgu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6Rm9udENhY2hlOjpjcmVhdGVGb250UGxhdGZvcm1EYXRh KToKKwogMjAxMC0wNS0xOSAgRGlyayBQcmFua2UgIDxkcHJhbmtlQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBUcnkgYWdhaW4gdG8gcm9sbCBvdXQgcjU4Njc1LgpkaWZmIC0tZ2l0IGEvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9Gb250Q2FjaGVMaW51eC5jcHAgYi9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ZvbnRDYWNoZUxpbnV4LmNwcAppbmRleCBlY2Vj ZDEzLi41M2Y0YTUyIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9t aXVtL0ZvbnRDYWNoZUxpbnV4LmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2No cm9taXVtL0ZvbnRDYWNoZUxpbnV4LmNwcApAQCAtMTI4LDkgKzEyOCwxMCBAQCBGb250UGxhdGZv cm1EYXRhKiBGb250Q2FjaGU6OmNyZWF0ZUZvbnRQbGF0Zm9ybURhdGEoY29uc3QgRm9udERlc2Ny aXB0aW9uJiBmb250RAogICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAgfQogICAg ICAgICB9Ci0gICAgICAgIC8vIGlmIHdlIGZhbGwgb3V0IG9mIHRoZSBsb29wLCBpdCdzIG9rIGZv ciBuYW1lIHRvIHN0aWxsIGJlIDAKLSAgICB9Ci0gICAgZWxzZSB7ICAgIC8vIGNvbnZlcnQgdGhl IG5hbWUgdG8gdXRmOAorICAgICAgICBpZiAoIW5hbWUpCisgICAgICAgICAgICBuYW1lID0gIiI7 CisgICAgfSBlbHNlIHsKKyAgICAgICAgLy8gY29udmVydCB0aGUgbmFtZSB0byB1dGY4CiAgICAg ICAgIHMgPSBmYW1pbHkuc3RyaW5nKCkudXRmOCgpOwogICAgICAgICBuYW1lID0gcy5kYXRhKCk7 CiAgICAgfQo=