3901 2005-07-07 20:30:29 -0700 REGRESSSION: back/forward broken at wsj.com, worked in v185 2007-05-19 00:38:03 -0700 1 1 1 Unclassified WebKit New Bugs 412 Mac OS X 10.4 RESOLVED FIXED http://www.wsj.com/ P2 Normal --- 1 trey mjs oldest_to_newest 14151 0 trey 2005-07-07 20:30:29 -0700 (This was originally reported in Radar #4109893) At some, but not all, pages at wsj.com an extra element is being added to the back/forward list. This causes the end user effect that clicking back does not take you back. I've noticed it on different pages. Currently it reproduces using the home page, but I suspect that might change since it is not consistent on all pages of the site. The steps: Open a new Safari window. Goto http://online.wsj.com/public/us. Press and hold the back button. Notice there is an item for "WSJ Home", but that should not be there since you are currently at that site. When there is an extra b/f item, it looks like: http://cmhtml.overture.com/d/search/p/wsj/html/jsads/? Partner=wsj_home_ctxt&adwd=620&adht=250&ctxtUrl=no_url&ctxtCat=home&css_url=http:// cmhtml.overture.com/partner/css/wsj4.css&tg=1&cb=1115325157576 I tried the same steps today on version 185 of Safari running on 10.3.5, and did not see the bug. 14152 1 2857 trey 2005-07-07 21:01:20 -0700 Created attachment 2857 proposed patch 14153 2 2857 mjs 2005-07-07 21:08:49 -0700 Comment on attachment 2857 proposed patch r=me great fix! 14212 3 joost 2005-07-08 10:58:36 -0700 I propose Trey for canconfirm, and i'll make this bug confirmed :). Maciej: next time when you review+ a patch, maybe it's easier to do this as well? :P 14215 4 vicki 2005-07-08 11:55:12 -0700 I committed this fix. 9624 5 mrowe 2007-05-19 00:38:03 -0700 Bug 13772 claims that this has been reintroduced. 2857 2005-07-07 21:01:20 -0700 2005-07-07 21:07:45 -0700 proposed patch 3901.patch text/plain 4154 trey SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvV2ViQ29yZS9D aGFuZ2VMb2csdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNDM4OApkaWZmIC1wIC11IC1yMS40Mzg4 IENoYW5nZUxvZwotLS0gQ2hhbmdlTG9nCTIwMDUvMDcvMDggMDA6MTk6NTgJMS40Mzg4CisrKyBD aGFuZ2VMb2cJMjAwNS8wNy8wOCAwMzo1OTo1OQpAQCAtMSwzICsxLDI3IEBACisyMDA1LTA3LTA3 ICBUcmV5IE1hdHRlc29uICA8dHJleUB1c2EubmV0PgorCisgICAgICAgIFJldmlld2VkIGJ5IG1q cworCisgICAgICAgIFRlc3QgY2FzZXMgYWRkZWQ6IChOT05FKQorICAgICAgICAKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzQxMDk4OTM+IFJFR1JFU1NTSU9OOiBiYWNrL2ZvcndhcmQgYnJva2Vu IGF0IHdzai5jb20sIHdvcmtlZCBpbiB2MTg1CisgICAgICAgIEFsc28gd3JpdHRlbiBhcyBodHRw Oi8vYnVnemlsbGEub3BlbmRhcndpbi5vcmcvc2hvd19idWcuY2dpP2lkPTM5MDEKKworICAgICAg ICBCcm9rZW4gYnkgc2VjdXJpdHkgZml4IGZvciA0MDA1NTc1OiBBcmJpdHJhcnkgZmlsZSBkaXNj bG9zdXJlIHZ1bG5lcmFiaWxpdHkgZHVlIHRvIGFiaWxpdHkgdG8gbG9hZCBsb2NhbCBodG1sIGZy b20gcmVtb3RlIGNvbnRlbnQKKworICAgICAgICBUaGUgcm9vdCBvZiB0aGlzIGJ1ZyBpcyB0aGF0 IFVSTHMgZm9yIHN1YmZyYW1lcyBvZiBhIHBhZ2UgYXJlIHNvbWV0aW1lcyBhZGRlZCB0byB0aGUg YmFjay9mb3J3YXJkIGxpc3QuICBUaGlzIGhhcHBlbnMgYSBsb3QgYXQKKyAgICAgICAgd3NqLmNv bSwgYW5kIEkgYmVsaWV2ZSBpdCB3b3VsZCBoYXBwZW4gZm9yIG1hbnkgb3IgYWxsIHNpdGVzIHRo YXQgdXNlIEpTIHRvIGNvbnMgdXAgYSBVUkwgZm9yIGFuIGlmcmFtZSBhbmQgdGhlbiBsb2FkIGl0 LgorCisgICAgICAgIFRoZSBzZWN1cml0eSBmaXggY2hhbmdlZCB0aGUgY29kZSBwYXRoIHRvIGdv IHRocm91Z2ggb3BlblVSTFJlcXVlc3QsIGJ1dCBvbmx5IG9wZW5VUkwgaGFkIHRoZSBsb2dpYyB0 byBndWVzcyBpZgorICAgICAgICB0aGUgY3VycmVudCBuYXZpZ2F0aW9uIHdhcyBkb25lIGluIHJl c3BvbnNlIHRvIGEgdXNlciBnZXN0dXJlLiAgb3BlblVSTFJlcXVlc3QgYWx3YXlzIGFzc3VtZWQg aXQgd2FzIGEgdXNlciBnZXN0dXJlLAorICAgICAgICBhbmQgdGh1cyBhbGwgdXNlcyBvZiB0aGlz IGNvZGUgcGF0aCB3b3VsZCBwbGFjZSBhbiBpdGVtIGluIHRoZSBiL2YgbGlzdC4KKworICAgICAg ICAqIGt3cS9LV1FLSFRNTFBhcnQuaDoKKyAgICAgICAgKiBrd3EvS1dRS0hUTUxQYXJ0Lm1tOgor ICAgICAgICAoS1dRS0hUTUxQYXJ0Ojp1c2VyR2VzdHVyZUhpbnQpOiAgRmFjdG9yZWQgY29kZSBm cm9tIG9wZW5VUkwuCisgICAgICAgIChLV1FLSFRNTFBhcnQ6Om9wZW5VUkwpOiAgQ2FsbCBuZXds eSBmYWN0b3JlZCBjb2RlLgorICAgICAgICAoS1dRS0hUTUxQYXJ0OjpvcGVuVVJMUmVxdWVzdCk6 ICBOZXdseSBjYWxsIG5ld2x5IGZhY3RvcmVkIGNvZGUuCisKIDIwMDUtMDctMDcgIEFkZWxlIFBl dGVyc29uICA8YWRlbGVAYXBwbGUuY29tPgogCiAgICAgICAgIGNoYW5nZSBieSBNYWNpZWosIHJl dmlld2VkIGJ5IG1lLgpJbmRleDogLi9rd3EvS1dRS0hUTUxQYXJ0LmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1Mg ZmlsZTogL2N2cy9yb290L1dlYkNvcmUva3dxL0tXUUtIVE1MUGFydC5oLHYKcmV0cmlldmluZyBy ZXZpc2lvbiAxLjIyMQpkaWZmIC1wIC11IC1yMS4yMjEgLi9rd3EvS1dRS0hUTUxQYXJ0LmgKLS0t IC4va3dxL0tXUUtIVE1MUGFydC5oCTIwMDUvMDUvMjYgMjA6MzA6MTIJMS4yMjEKKysrIC4va3dx L0tXUUtIVE1MUGFydC5oCTIwMDUvMDcvMDggMDQ6MDA6MTQKQEAgLTQwMCw2ICs0MDAsOCBAQCBw cml2YXRlOgogICAgIAogICAgIE5TVmlldyAqbW91c2VEb3duVmlld0lmU3RpbGxHb29kKCk7CiAK KyAgICBib29sIHVzZXJHZXN0dXJlSGludCgpOworCiAgICAgUVN0cmluZyBnZW5lcmF0ZUZyYW1l TmFtZSgpOwogCiAgICAgTlNWaWV3ICpuZXh0S2V5Vmlld0luRnJhbWUoRE9NOjpOb2RlSW1wbCAq c3RhcnRpbmdQb2ludCwgS1dRU2VsZWN0aW9uRGlyZWN0aW9uKTsKSW5kZXg6IC4va3dxL0tXUUtI VE1MUGFydC5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvV2ViQ29yZS9rd3EvS1dR S0hUTUxQYXJ0Lm1tLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjY0NApkaWZmIC1wIC11IC1yMS42 NDQgLi9rd3EvS1dRS0hUTUxQYXJ0Lm1tCi0tLSAuL2t3cS9LV1FLSFRNTFBhcnQubW0JMjAwNS8w Ny8wNyAwODowMzoyMgkxLjY0NAorKysgLi9rd3EvS1dRS0hUTUxQYXJ0Lm1tCTIwMDUvMDcvMDgg MDQ6MDA6MTgKQEAgLTI5NCwxOSArMjk0LDIyIEBAIHZvaWQgS1dRS0hUTUxQYXJ0Ojpwcm92aXNp b25hbExvYWRTdGFydGUKICAgICBjYW5jZWxSZWRpcmVjdGlvbih0cnVlKTsKIH0KIAotYm9vbCBL V1FLSFRNTFBhcnQ6Om9wZW5VUkwoY29uc3QgS1VSTCAmdXJsKQorYm9vbCBLV1FLSFRNTFBhcnQ6 OnVzZXJHZXN0dXJlSGludCgpCiB7Ci0gICAgS1dRX0JMT0NLX0VYQ0VQVElPTlM7Ci0KLSAgICBi b29sIHVzZXJHZXN0dXJlID0gdHJ1ZTsKLSAgICAKICAgICBpZiAoalNjcmlwdCgpICYmIGpTY3Jp cHQoKS0+aW50ZXJwcmV0ZXIoKSkgewogICAgICAgICBLSFRNTFBhcnQgKnJvb3RQYXJ0ID0gdGhp czsKICAgICAgICAgd2hpbGUgKHJvb3RQYXJ0LT5wYXJlbnRQYXJ0KCkgIT0gMCkKICAgICAgICAg ICAgIHJvb3RQYXJ0ID0gcm9vdFBhcnQtPnBhcmVudFBhcnQoKTsKICAgICAgICAgS0pTOjpTY3Jp cHRJbnRlcnByZXRlciAqaW50ZXJwcmV0ZXIgPSBzdGF0aWNfY2FzdDxLSlM6OlNjcmlwdEludGVy cHJldGVyICo+KEtKU1Byb3h5Ojpwcm94eShyb290UGFydCktPmludGVycHJldGVyKCkpOwotICAg ICAgICB1c2VyR2VzdHVyZSA9IGludGVycHJldGVyLT53YXNSdW5CeVVzZXJHZXN0dXJlKCk7Ci0g ICAgfQorICAgICAgICByZXR1cm4gaW50ZXJwcmV0ZXItPndhc1J1bkJ5VXNlckdlc3R1cmUoKTsK KyAgICB9IGVsc2UKKyAgICAgICAgLy8gaWYgbm8gSlMsIGFzc3VtZSB0aGUgdXNlciBpbml0aWF0 ZWQgdGhpcyBuYXYKKyAgICAgICAgcmV0dXJuIHRydWU7Cit9CisKK2Jvb2wgS1dRS0hUTUxQYXJ0 OjpvcGVuVVJMKGNvbnN0IEtVUkwgJnVybCkKK3sKKyAgICBLV1FfQkxPQ0tfRVhDRVBUSU9OUzsK IAogICAgIC8vIEZJWE1FOiBUaGUgbGFjayBvZiBhcmdzIGhlcmUgdG8gZ2V0IHRoZSByZWxvYWQg ZmxhZyBmcm9tCiAgICAgLy8gaW5kaWNhdGVzIGEgcHJvYmxlbSBpbiBob3cgd2UgdXNlIEtIVE1M UGFydDo6cHJvY2Vzc09iamVjdFJlcXVlc3QsCkBAIC0zMTQsNyArMzE3LDcgQEAgYm9vbCBLV1FL SFRNTFBhcnQ6Om9wZW5VUkwoY29uc3QgS1VSTCAmdQogICAgIFtfYnJpZGdlIGxvYWRVUkw6dXJs LmdldE5TVVJMKCkKICAgICAgICAgICAgIHJlZmVycmVyOltfYnJpZGdlIHJlZmVycmVyXQogICAg ICAgICAgICAgICByZWxvYWQ6Tk8KLSAgICAgICAgIHVzZXJHZXN0dXJlOnVzZXJHZXN0dXJlCisg ICAgICAgICB1c2VyR2VzdHVyZTp1c2VyR2VzdHVyZUhpbnQoKQogICAgICAgICAgICAgICB0YXJn ZXQ6bmlsCiAgICAgIHRyaWdnZXJpbmdFdmVudDpuaWwKICAgICAgICAgICAgICAgICBmb3JtOm5p bApAQCAtMzQwLDcgKzM0Myw3IEBAIHZvaWQgS1dRS0hUTUxQYXJ0OjpvcGVuVVJMUmVxdWVzdChj b25zdCAKICAgICBbX2JyaWRnZSBsb2FkVVJMOnVybC5nZXROU1VSTCgpCiAgICAgICAgICAgICBy ZWZlcnJlcjpyZWZlcnJlcgogICAgICAgICAgICAgICByZWxvYWQ6YXJncy5yZWxvYWQKLSAgICAg ICAgIHVzZXJHZXN0dXJlOnRydWUKKyAgICAgICAgIHVzZXJHZXN0dXJlOnVzZXJHZXN0dXJlSGlu dCgpCiAgICAgICAgICAgICAgIHRhcmdldDphcmdzLmZyYW1lTmFtZS5nZXROU1N0cmluZygpCiAg ICAgIHRyaWdnZXJpbmdFdmVudDpuaWwKICAgICAgICAgICAgICAgICBmb3JtOm5pbAo=