39006 2010-05-12 11:05:42 -0700 [Qt] Link error in debug mode without debug_and_release config 2010-05-12 14:10:12 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All Windows XP RESOLVED FIXED Qt, QtTriaged P3 Normal --- 1 ossy webkit-qt-unassigned hausmann jturcotte oldest_to_newest 224731 0 ossy 2010-05-12 11:05:42 -0700 I experimented with removing default debug_and_release config from win32-g++/qmake.conf . Now qmake runs twice unnecessarly and generate makefiles for release and debug mode too. After removing debug build broke because of a little bug. Fix is coming soon. 224732 1 55872 ossy 2010-05-12 11:11:00 -0700 Created attachment 55872 Patch 224739 2 ossy 2010-05-12 11:18:25 -0700 - CONFIG(debug, debug|release):build_pass: QTWEBKITLIBNAME = $${QTWEBKITLIBNAME}d + CONFIG(debug, debug|release):QTWEBKITLIBNAME = $${QTWEBKITLIBNAME}d The QtLauncher linking break caused in debug mode caused the line above, because if config doesn't contain debug_and_release, build_pass will always false and QTWEBKITLIBNAME won't have necessarily "d" suffix. Removing build_pass guard fix this bug and won't change anything. I know modifying mkspec isn't the good solution, but it was an experiment in first step. And I found it works. I'm going to remove debug_and_release config from the WebKit build scripts to decrease the runtime of building and avoid generating unnecessarily makefiles in an other bug. 224741 3 55872 ossy 2010-05-12 11:19:19 -0700 Comment on attachment 55872 Patch cq- -ed, because I would like to land it manually. 224856 4 55872 kenneth 2010-05-12 13:42:19 -0700 Comment on attachment 55872 Patch Be aware that this will conflict with Laszlo's patch on the cq. 224877 5 ossy 2010-05-12 14:10:12 -0700 Landed, conflict resolved manually: http://trac.webkit.org/changeset/59266 55872 2010-05-12 11:11:00 -0700 2010-05-12 13:42:18 -0700 Patch bug-39006-20100512111057.patch text/plain 1225 ossy SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDU5MjM1 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDUt MTIgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIExpbmsgZXJyb3IgaW4gZGVi dWcgbW9kZSB3aXRob3V0IGRlYnVnX2FuZF9yZWxlYXNlIGNvbmZpZworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzkwMDYKKworICAgICAgICAqIFdlYktp dC5wcmk6IFVubmVjZXNzYXJ5IGJ1aWxkX3Bhc3MgZ3VhcmQgcmVtb3ZlZC4KKwogMjAxMC0wNS0w OCAgTGFzemxvIEdvbWJvcyAgPGxhc3psby4xLmdvbWJvc0Bub2tpYS5jb20+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4uCkluZGV4OiBXZWJLaXQucHJp Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYktpdC5wcmkJKHJldmlzaW9uIDU5MjM1KQorKysgV2ViS2l0LnBy aQkod29ya2luZyBjb3B5KQpAQCAtMjIsNyArMjIsNyBAQCBidWlsZGluZy1saWJzIHsKICAgICAg ICAgICAgIFFNQUtFX0ZSQU1FV09SS1BBVEggPSAkJE9VVFBVVF9ESVIvbGliICQkUU1BS0VfRlJB TUVXT1JLUEFUSAogICAgICAgICB9IGVsc2UgewogICAgICAgICAgICAgd2luMzItKnx3aW5jZSog ewotICAgICAgICAgICAgICAgIENPTkZJRyhkZWJ1ZywgZGVidWd8cmVsZWFzZSk6YnVpbGRfcGFz czogUVRXRUJLSVRMSUJOQU1FID0gJCR7UVRXRUJLSVRMSUJOQU1FfWQKKyAgICAgICAgICAgICAg ICBDT05GSUcoZGVidWcsIGRlYnVnfHJlbGVhc2UpOlFUV0VCS0lUTElCTkFNRSA9ICQke1FUV0VC S0lUTElCTkFNRX1kCiAgICAgICAgICAgICAgICAgUVRXRUJLSVRMSUJOQU1FID0gJCR7UVRXRUJL SVRMSUJOQU1FfSQke1FUX01BSk9SX1ZFUlNJT059CiAgICAgICAgICAgICAgICAgd2luMzItZysr OiBMSUJTICs9IC1sJCRRVFdFQktJVExJQk5BTUUKICAgICAgICAgICAgICAgICBlbHNlOiBMSUJT ICs9ICQke1FUV0VCS0lUTElCTkFNRX0ubGliCg==