39001 2010-05-12 09:54:06 -0700 IDBRequest is not a proper ActiveDomObject 2010-05-17 06:34:05 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 39167 0 andreip webkit-unassigned abarth commit-queue eric japhet jorlow webkit.review.bot oldest_to_newest 224692 0 andreip 2010-05-12 09:54:06 -0700 1. IDBRequest interface is not mentioned in the IsActiveDomType routine of the CodeGeneratorV8.pm 2. IDBRequest class should rename its m_stopped member to m_suspended and this flag should be reset when resume() is called. Patch following. 224704 1 55865 andreip 2010-05-12 10:07:18 -0700 Created attachment 55865 Fix IDBRequest. 224707 2 55865 jorlow 2010-05-12 10:12:18 -0700 Comment on attachment 55865 Fix IDBRequest. r=me 226307 3 55865 commit-queue 2010-05-15 12:53:16 -0700 Comment on attachment 55865 Fix IDBRequest. Clearing flags on attachment: 55865 Committed r59549: <http://trac.webkit.org/changeset/59549> 226308 4 commit-queue 2010-05-15 12:53:21 -0700 All reviewed patches have been landed. Closing bug. 226312 5 webkit.review.bot 2010-05-15 13:06:19 -0700 http://trac.webkit.org/changeset/59549 might have broken Chromium Linux Release 226316 6 abarth 2010-05-15 13:19:08 -0700 Too bad the EWS didn't run on this patch. :( Rolling out. 226317 7 abarth 2010-05-15 13:19:56 -0700 Reopening. 226324 8 eric 2010-05-15 13:36:23 -0700 Thank you Adam. 226697 9 andreip 2010-05-17 01:51:23 -0700 Oops, sorry about this. Fixing. 226741 10 jorlow 2010-05-17 06:34:05 -0700 Landed http://trac.webkit.org/changeset/59605 55865 2010-05-12 10:07:18 -0700 2010-05-17 06:05:38 -0700 Fix IDBRequest. 39001.patch text/plain 2997 andreip SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1OTIzOSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjYgQEAKKzIwMTAtMDUtMTIgIEFuZHJlaSBQb3Blc2N1ICA8YW5kcmVpcEBnb29n bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IElEQlJlcXVlc3QgaXMgbm90IGEgcHJvcGVyIEFjdGl2ZURvbU9iamVjdAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzkwMDEKKworICAgICAgICBBZGQg SURCUmVxdWVzdCBpbnRlcmZhY2UgdG8gdGhlIElzQWN0aXZlRG9tVHlwZQorICAgICAgICByb3V0 aW5lIG9mIHRoZSBDb2RlR2VuZXJhdG9yVjgucG0uCisKKyAgICAgICAgUmVuYW1lIElEQlJlcXVl c3Q6Om1fc3RvcHBlZCB0byBtX3N1c3BlbmRlZCBhbmQgcmVzZXQKKyAgICAgICAgdGhlIGZsYWcg d2hlbiByZXN1bWUoKSBpcyBjYWxsZWQuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBJbmRleGVk IERhdGFiYXNlIGlzbid0IHlldCB0ZXN0YWJsZS4KKworICAgICAgICAqIGJpbmRpbmdzL3Njcmlw dHMvQ29kZUdlbmVyYXRvclY4LnBtOgorICAgICAgICAqIHN0b3JhZ2UvSURCUmVxdWVzdC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpJREJSZXF1ZXN0OjpzdXNwZW5kKToKKyAgICAgICAgKFdlYkNv cmU6OklEQlJlcXVlc3Q6OnJlc3VtZSk6CisgICAgICAgIChXZWJDb3JlOjpJREJSZXF1ZXN0Ojp0 aW1lckZpcmVkKToKKyAgICAgICAgKFdlYkNvcmU6OklEQlJlcXVlc3Q6Om9uRXZlbnRDb21tb24p OgorICAgICAgICAqIHN0b3JhZ2UvSURCUmVxdWVzdC5oOgorCiAyMDEwLTA1LTEyICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxl ci4KSW5kZXg6IFdlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQko cmV2aXNpb24gNTkyMzUpCisrKyBXZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRv clY4LnBtCSh3b3JraW5nIGNvcHkpCkBAIC0yNDYzLDYgKzI0NjMsNyBAQCBzdWIgSXNBY3RpdmVE b21UeXBlCiAgICAgcmV0dXJuIDEgaWYgJHR5cGUgZXEgIldlYlNvY2tldCI7CiAgICAgcmV0dXJu IDEgaWYgJHR5cGUgZXEgIldvcmtlciI7CiAgICAgcmV0dXJuIDEgaWYgJHR5cGUgZXEgIlNoYXJl ZFdvcmtlciI7CisgICAgcmV0dXJuIDEgaWYgJHR5cGUgZXEgIklEQlJlcXVlc3QiOwogICAgIHJl dHVybiAwOwogfQogCkluZGV4OiBXZWJDb3JlL3N0b3JhZ2UvSURCUmVxdWVzdC5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViQ29yZS9zdG9yYWdlL0lEQlJlcXVlc3QuY3BwCShyZXZpc2lvbiA1OTIzNSkK KysrIFdlYkNvcmUvc3RvcmFnZS9JREJSZXF1ZXN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTEy LDEwICsxMTIsMTIgQEAgdm9pZCBJREJSZXF1ZXN0OjpzdG9wKCkKIHZvaWQgSURCUmVxdWVzdDo6 c3VzcGVuZCgpCiB7CiAgICAgbV90aW1lci5zdG9wKCk7CisgICAgbV9zdXNwZW5kZWQgPSB0cnVl OwogfQogCiB2b2lkIElEQlJlcXVlc3Q6OnJlc3VtZSgpCiB7CisgICAgbV9zdXNwZW5kZWQgPSBm YWxzZTsKICAgICAvLyBXZSBvbmx5IGhvbGQgb3VyIHNlbGYgcmVmIHdoZW4gd2UncmUgd2FpdGlu ZyB0byBkaXNwYXRjaCBhbiBldmVudC4KICAgICBpZiAobV9zZWxmUmVmICYmICFtX2Fib3J0ZWQp CiAgICAgICAgIG1fdGltZXIuc3RhcnRPbmVTaG90KDApOwpAQCAtMTM1LDcgKzEzNyw3IEBAIHZv aWQgSURCUmVxdWVzdDo6dGltZXJGaXJlZChUaW1lcjxJREJSZXEKIHsKICAgICBBU1NFUlQobV9y ZWFkeVN0YXRlID09IERPTkUpOwogICAgIEFTU0VSVChtX3NlbGZSZWYpOwotICAgIEFTU0VSVCgh bV9zdG9wcGVkKTsKKyAgICBBU1NFUlQoIW1fc3VzcGVuZGVkKTsKICAgICBBU1NFUlQoIW1fYWJv cnRlZCk7CiAKICAgICAvLyBXZSBuZWVkIHRvIGtlZXAgc2VsZi1yZWZlcmVuY2luZyBvdXJzZWxm LCBvdGhlcndpc2UgaXQncyBwb3NzaWJsZSB3ZSdsbCBiZSBkZWxldGVkLgpAQCAtMTY1LDcgKzE2 Nyw3IEBAIHZvaWQgSURCUmVxdWVzdDo6b25FdmVudENvbW1vbigpCiAKICAgICBtX3JlYWR5U3Rh dGUgPSBET05FOwogICAgIG1fc2VsZlJlZiA9IHRoaXM7Ci0gICAgaWYgKCFtX3N0b3BwZWQpCisg ICAgaWYgKCFtX3N1c3BlbmRlZCkKICAgICAgICAgbV90aW1lci5zdGFydE9uZVNob3QoMCk7CiB9 CiAKSW5kZXg6IFdlYkNvcmUvc3RvcmFnZS9JREJSZXF1ZXN0LmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Q29yZS9zdG9yYWdlL0lEQlJlcXVlc3QuaAkocmV2aXNpb24gNTkyMzUpCisrKyBXZWJDb3JlL3N0 b3JhZ2UvSURCUmVxdWVzdC5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMTAsNyArMTEwLDcgQEAgcHJp dmF0ZToKICAgICBUaW1lcjxJREJSZXF1ZXN0PiBtX3RpbWVyOwogICAgIFJlZlB0cjxJREJSZXF1 ZXN0PiBtX3NlbGZSZWY7IC8vIFRoaXMgaXMgc2V0IHRvIHVzIGlmZiB0aGVyZSdzIGFuIGV2ZW50 IHBlbmRpbmcuCiAKLSAgICBib29sIG1fc3RvcHBlZDsKKyAgICBib29sIG1fc3VzcGVuZGVkOwog ICAgIGJvb2wgbV9hYm9ydGVkOwogICAgIFJlYWR5U3RhdGUgbV9yZWFkeVN0YXRlOwogICAgIEV2 ZW50VGFyZ2V0RGF0YSBtX2V2ZW50VGFyZ2V0RGF0YTsK