39000 2010-05-12 09:22:47 -0700 [chromium] Make ImageDiff depend on webkit (again). 2010-05-14 05:28:30 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 0 jochen webkit-unassigned commit-queue tkent tony oldest_to_newest 224670 0 jochen 2010-05-12 09:22:47 -0700 Make ImageDiff depend on webkit (again). 224671 1 55856 jochen 2010-05-12 09:24:26 -0700 Created attachment 55856 Patch 224673 2 jochen 2010-05-12 09:26:24 -0700 ImageDiff should depend on WebKit.WTF depends on symbols defined in WebKit/chromium: CurrentTime and callOnMainThread. I already fixed this in https://bugs.webkit.org/show_bug.cgi?id=38632 but this change was dropped when ImageDiff was moved to WebKit.gyp :( 224793 3 55856 eric 2010-05-12 12:19:47 -0700 Comment on attachment 55856 Patch OK. 225000 4 tony 2010-05-12 17:25:41 -0700 (In reply to comment #2) > ImageDiff should depend on WebKit.WTF depends on symbols defined in WebKit/chromium: CurrentTime and callOnMainThread. > > I already fixed this in https://bugs.webkit.org/show_bug.cgi?id=38632 but this change was dropped when ImageDiff was moved to WebKit.gyp :( Sorry about dropping this when moving the target! 225764 5 55856 commit-queue 2010-05-14 05:28:25 -0700 Comment on attachment 55856 Patch Clearing flags on attachment: 55856 Committed r59467: <http://trac.webkit.org/changeset/59467> 225765 6 commit-queue 2010-05-14 05:28:30 -0700 All reviewed patches have been landed. Closing bug. 55856 2010-05-12 09:24:26 -0700 2010-05-14 05:28:24 -0700 Patch bug-39000-20100512182424.patch text/plain 1095 jochen ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDkwNTA1NjRmMjI3YzBmNWYzZDQ2ODY3OTRkNDA5ODA0Zjk2NTUwYzku LjEzZDU2ZWJiNjgzNzUzY2YyY2U4N2I4ZmQwNzU0ZTRkY2VjN2U1MzAgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSwzICsxLDEyIEBACisyMDEwLTA1LTEyICBKb2NoZW4gRWlzaW5nZXIgIDxqb2NoZW5AY2hy b21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIE1ha2UgSW1hZ2VEaWZmIGRlcGVuZCBvbiB3ZWJraXQgKGFnYWluKS4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM5MDAwCisKKyAgICAgICAgKiBX ZWJLaXQuZ3lwOgorCiAyMDEwLTA1LTEwICB5YWVsIGFoYXJvbiAgPHlhZWwuYWhhcm9uQG5va2lh LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBhL1dl YktpdC9jaHJvbWl1bS9XZWJLaXQuZ3lwIGIvV2ViS2l0L2Nocm9taXVtL1dlYktpdC5neXAKaW5k ZXggMzJmNDg1Yjk5YTI3ZTE0YjExNTI0M2RhZjQxOTViOGY1MTQ4NmE1ZS4uMWViMDYzMThiMDQ2 N2Q3NDM2YzllNjM5ZDhhNGQyODc5MDA0N2FiZiAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVt L1dlYktpdC5neXAKKysrIGIvV2ViS2l0L2Nocm9taXVtL1dlYktpdC5neXAKQEAgLTYxOCw2ICs2 MTgsNyBAQAogICAgICAgICAgICAgJ3RhcmdldF9uYW1lJzogJ0ltYWdlRGlmZicsCiAgICAgICAg ICAgICAndHlwZSc6ICdleGVjdXRhYmxlJywKICAgICAgICAgICAgICdkZXBlbmRlbmNpZXMnOiBb CisgICAgICAgICAgICAgICAgJ3dlYmtpdCcsCiAgICAgICAgICAgICAgICAgJy4uLy4uL0phdmFT Y3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLmd5cC9KYXZhU2NyaXB0Q29yZS5neXA6d3RmJywKICAg ICAgICAgICAgICAgICAnPChjaHJvbWl1bV9zcmNfZGlyKS9nZngvZ2Z4Lmd5cDpnZngnLAogICAg ICAgICAgICAgXSwK