38997 2010-05-12 09:07:33 -0700 REGRESSION: webkit-patch commit-message throws exception 2010-05-14 03:55:50 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned abarth commit-queue ojan oldest_to_newest 224661 0 eric 2010-05-12 09:07:33 -0700 webkit-patch commit-message throws exception It's mostly used for testing. Seems it needs to have --squash and --git-commit added as options. % webkit-patch commit-message Traceback (most recent call last): File "/Projects/WebKit/WebKitTools/Scripts/webkit-patch", line 56, in <module> main() File "/Projects/WebKit/WebKitTools/Scripts/webkit-patch", line 51, in main WebKitPatch(__file__).main() File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/tool/multicommandtool.py", line 302, in main result = command.check_arguments_and_execute(options, args, self) File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/tool/multicommandtool.py", line 113, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/tool/commands/upload.py", line 56, in execute print "%s" % tool.checkout().commit_message_for_this_commit().message() TypeError: commit_message_for_this_commit() takes exactly 3 arguments (1 given) 224682 1 55861 eric 2010-05-12 09:35:17 -0700 Created attachment 55861 Patch 224685 2 55861 commit-queue 2010-05-12 09:49:08 -0700 Comment on attachment 55861 Patch Rejecting patch 55861 from review queue. ojan@chromium.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). Due to bug 30084 the commit-queue will require a restart after your change. Please contact eseidel@chromium.org to request a commit-queue restart. After restart the commit-queue will correctly respect your reviewer rights. 224690 3 55861 abarth 2010-05-12 09:53:06 -0700 Comment on attachment 55861 Patch Looks like ojan isn't registered as a proper reviewer yet. 225742 4 55861 commit-queue 2010-05-14 03:55:44 -0700 Comment on attachment 55861 Patch Clearing flags on attachment: 55861 Committed r59461: <http://trac.webkit.org/changeset/59461> 225743 5 commit-queue 2010-05-14 03:55:50 -0700 All reviewed patches have been landed. Closing bug. 55861 2010-05-12 09:35:17 -0700 2010-05-14 03:55:44 -0700 Patch bug-38997-20100512093514.patch text/plain 3441 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA1ODE1MmZiOGQ5MjljYmU3YWExOGEzYmUwYWIzOGMzNTBiMzFkNWNkLi4zNjVjMGRh ZGNkMTg3NGE3ZTg4N2UzZWI2MDUyZTE0MDI4YTZkMjFkIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTAtMDUtMTIgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJFR1JFU1NJT046IHdlYmtpdC1w YXRjaCBjb21taXQtbWVzc2FnZSB0aHJvd3MgZXhjZXB0aW9uCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODk5NworCisgICAgICAgICogU2NyaXB0cy93 ZWJraXRweS90b29sL2NvbW1hbmRzL3VwbG9hZC5weToKKyAgICAgICAgIC0gRml4IHRvIHJlc3Bl Y3QgYW5kIHBhc3MgdGhlIC0tc3F1YXNoIGFuZCAtLWdpdC1jb21taXQgb3B0aW9ucy4KKyAgICAg ICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvdXBsb2FkX3VuaXR0ZXN0LnB5Ogor ICAgICAgICAgLSBGaXggdGhlIHVuaXQgdGVzdCB0byB1c2UgdGhlIGNlbnRyYWwgTW9ja0NoZWNr b3V0IGluc3RlYWQgb2YKKyAgICAgICAgICAgaXRzIG93biBjdXN0b20gTW9jayB3aGljaCBkaWRu J3QgcmVxdWlyZSBlbm91Z2ggcGFyYW1ldGVycy4KKwogMjAxMC0wNS0xMCAgUm9kcmlnbyBCZWxl bSAgPHJvZHJpZ28uYmVsZW1Ab3BlbmJvc3NhLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBL ZW5uZXRoIENocmlzdGlhbnNlbiAsIFNpbW9uIEhhdXNtYW5uIGFuZCBHdXN0YXZvIE5vcm9uaGEu CmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMv dXBsb2FkLnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3Vw bG9hZC5weQppbmRleCA5OWQ0NWE2NmFiNjk4NzgzNTBkZjU3MGFmMTI4Zjk2NTkyY2ZkYjI5Li40 Nzk3ZWY2NDNkZWVkOGE5MzUwYTY3MmZhNzAwYTcxMGM1OWNiZGM1IDEwMDY0NAotLS0gYS9XZWJL aXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvdXBsb2FkLnB5CisrKyBiL1dl YktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy91cGxvYWQucHkKQEAgLTQ2 LDE0ICs0NiwyMyBAQCBmcm9tIHdlYmtpdHB5LnRvb2wuY29tbWVudHMgaW1wb3J0IGJ1Z19jb21t ZW50X2Zyb21fc3ZuX3JldmlzaW9uCiBmcm9tIHdlYmtpdHB5LnRvb2wubXVsdGljb21tYW5kdG9v bCBpbXBvcnQgQWJzdHJhY3REZWNsYXJhdGl2ZUNvbW1hbmQKIGZyb20gd2Via2l0cHkuY29tbW9u LnN5c3RlbS5kZXByZWNhdGVkX2xvZ2dpbmcgaW1wb3J0IGVycm9yLCBsb2cKIAorCiBjbGFzcyBD b21taXRNZXNzYWdlRm9yQ3VycmVudERpZmYoQWJzdHJhY3REZWNsYXJhdGl2ZUNvbW1hbmQpOgog ICAgIG5hbWUgPSAiY29tbWl0LW1lc3NhZ2UiCiAgICAgaGVscF90ZXh0ID0gIlByaW50IGEgY29t bWl0IG1lc3NhZ2Ugc3VpdGFibGUgZm9yIHRoZSB1bmNvbW1pdHRlZCBjaGFuZ2VzIgogCisgICAg ZGVmIF9faW5pdF9fKHNlbGYpOgorICAgICAgICBvcHRpb25zID0gWworICAgICAgICAgICAgc3Rl cHMuT3B0aW9ucy5zcXVhc2gsCisgICAgICAgICAgICBzdGVwcy5PcHRpb25zLmdpdF9jb21taXQs CisgICAgICAgIF0KKyAgICAgICAgQWJzdHJhY3REZWNsYXJhdGl2ZUNvbW1hbmQuX19pbml0X18o c2VsZiwgb3B0aW9ucz1vcHRpb25zKQorCiAgICAgZGVmIGV4ZWN1dGUoc2VsZiwgb3B0aW9ucywg YXJncywgdG9vbCk6CiAgICAgICAgICMgVGhpcyBjb21tYW5kIGlzIGEgdXNlZnVsIHRlc3QgdG8g bWFrZSBzdXJlIGNvbW1pdF9tZXNzYWdlX2Zvcl90aGlzX2NvbW1pdAogICAgICAgICAjIGFsd2F5 cyByZXR1cm5zIHRoZSByaWdodCB2YWx1ZSByZWdhcmRsZXNzIG9mIHRoZSBjdXJyZW50IHdvcmtp bmcgZGlyZWN0b3J5LgotICAgICAgICBwcmludCAiJXMiICUgdG9vbC5jaGVja291dCgpLmNvbW1p dF9tZXNzYWdlX2Zvcl90aGlzX2NvbW1pdCgpLm1lc3NhZ2UoKQorICAgICAgICBwcmludCAiJXMi ICUgdG9vbC5jaGVja291dCgpLmNvbW1pdF9tZXNzYWdlX2Zvcl90aGlzX2NvbW1pdChvcHRpb25z LmdpdF9jb21taXQsIG9wdGlvbnMuc3F1YXNoKS5tZXNzYWdlKCkKKwogCiBjbGFzcyBDbGVhblBl bmRpbmdDb21taXQoQWJzdHJhY3REZWNsYXJhdGl2ZUNvbW1hbmQpOgogICAgIG5hbWUgPSAiY2xl YW4tcGVuZGluZy1jb21taXQiCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtp dHB5L3Rvb2wvY29tbWFuZHMvdXBsb2FkX3VuaXR0ZXN0LnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0 cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3VwbG9hZF91bml0dGVzdC5weQppbmRleCBlZWMzNzUx Y2U1M2NjYzJmODdiOWYxYWVkYmNkZThhMjY0MDljZDFhLi44ZjY0ODNhYzdkYTEyZjRkOGU5ZDE1 OTQxMjQ0MmUyZWZjY2FiOWM5IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtp dHB5L3Rvb2wvY29tbWFuZHMvdXBsb2FkX3VuaXR0ZXN0LnB5CisrKyBiL1dlYktpdFRvb2xzL1Nj cmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy91cGxvYWRfdW5pdHRlc3QucHkKQEAgLTM0LDEw ICszNCw3IEBAIGZyb20gd2Via2l0cHkudG9vbC5tb2NrdG9vbCBpbXBvcnQgTW9ja1Rvb2wKIGNs YXNzIFVwbG9hZENvbW1hbmRzVGVzdChDb21tYW5kc1Rlc3QpOgogICAgIGRlZiB0ZXN0X2NvbW1p dF9tZXNzYWdlX2Zvcl9jdXJyZW50X2RpZmYoc2VsZik6CiAgICAgICAgIHRvb2wgPSBNb2NrVG9v bCgpCi0gICAgICAgIG1vY2tfY29tbWl0X21lc3NhZ2VfZm9yX3RoaXNfY29tbWl0ID0gTW9jaygp Ci0gICAgICAgIG1vY2tfY29tbWl0X21lc3NhZ2VfZm9yX3RoaXNfY29tbWl0Lm1lc3NhZ2UgPSBs YW1iZGE6ICJNb2NrIG1lc3NhZ2UiCi0gICAgICAgIHRvb2wuX2NoZWNrb3V0LmNvbW1pdF9tZXNz YWdlX2Zvcl90aGlzX2NvbW1pdCA9IGxhbWJkYTogbW9ja19jb21taXRfbWVzc2FnZV9mb3JfdGhp c19jb21taXQKLSAgICAgICAgZXhwZWN0ZWRfc3Rkb3V0ID0gIk1vY2sgbWVzc2FnZVxuIgorICAg ICAgICBleHBlY3RlZF9zdGRvdXQgPSAiVGhpcyBpcyBhIGZha2UgY29tbWl0IG1lc3NhZ2UgdGhh dCBpcyBhdCBsZWFzdCA1MCBjaGFyYWN0ZXJzLlxuIgogICAgICAgICBzZWxmLmFzc2VydF9leGVj dXRlX291dHB1dHMoQ29tbWl0TWVzc2FnZUZvckN1cnJlbnREaWZmKCksIFtdLCBleHBlY3RlZF9z dGRvdXQ9ZXhwZWN0ZWRfc3Rkb3V0LCB0b29sPXRvb2wpCiAKICAgICBkZWYgdGVzdF9jbGVhbl9w ZW5kaW5nX2NvbW1pdChzZWxmKToK